RE: [PATCH V1 2/4] net/mlx5: support FDB unified domain

[Dariusz Sosnowski <dsosnowski@nvidia.com>]

Nacked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>

Please see below:

> diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c
> index 091f288..9410211 100644
> --- a/drivers/net/mlx5/linux/mlx5_os.c
> +++ b/drivers/net/mlx5/linux/mlx5_os.c
> @@ -1707,6 +1707,17 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev,
>  	LIST_INIT(&priv->hw_ext_ctrl_flows);
>  	if (priv->sh->config.dv_flow_en == 2) {  #ifdef
> HAVE_MLX5_HWS_SUPPORT
> +		/*
> +		 * Unified FDB flag is only needed for the actions created on
> the transfer
> +		 * port. proxy port. It is not needed on the following ports:
> +		 *   1. NIC PF / VF / SF
> +		 *   2. in Verbs or DV/DR mode
> +		 *   3. with unsupported FW
> +		 *   4. all representors in HWS
> +		 */
> +		priv->unified_fdb_en = !!priv->master;

This should be also based on FW capability check introduced in previous commit.

> +		DRV_LOG(DEBUG, "port %u: unified FDB %s enabled.",
> +			eth_dev->data->port_id, priv->unified_fdb_en ? "is" :
> "isn't");
>  		if (priv->sh->config.dv_esw_en) {
>  			uint32_t usable_bits;
>  			uint32_t required_bits;