From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D423BA0540; Tue, 8 Nov 2022 10:26:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 66AA3410EA; Tue, 8 Nov 2022 10:26:48 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id B63DE400D7 for ; Tue, 8 Nov 2022 10:26:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667899606; x=1699435606; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=gqMYrBkRZaR2czv3I2ShWxwruzQ2Mh4bAJ7RL+SNzq4=; b=cC+LBguL0//Y9M1U1KUfFnZrI40ZUY4UhdcLzNj3Mnb7l/vYdymXHDUy cIwthApDpkOSVe79DmR+PFgXPMhoCjUh7aE9vnp8POI6Us4ZRhSE3hACN iJTSPSQMyBCQL1urVWnISaBa9y38BWt2Q30otMzvhRjlObPLzXQr6Ig7R hpG3smsIWmsw5MCprevKmfjZ4wQBqWwZUIPMy6i+RPrtVoQVVRhXATq94 SwETzUopACA4nwhIEEQo66naDo5LYYgY5pXxkHiP0EEl4tL1UzNL8GBx7 DpYNDpz0kFrd6vLfxghXdfgNMSFydxexE1K1HUSQz8uGkFGUGENKIeJdU Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10524"; a="291038115" X-IronPort-AV: E=Sophos;i="5.96,147,1665471600"; d="scan'208";a="291038115" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Nov 2022 01:26:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10524"; a="636273087" X-IronPort-AV: E=Sophos;i="5.96,147,1665471600"; d="scan'208";a="636273087" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga002.jf.intel.com with ESMTP; 08 Nov 2022 01:26:43 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 8 Nov 2022 01:26:43 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 8 Nov 2022 01:26:42 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 8 Nov 2022 01:26:42 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.107) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 8 Nov 2022 01:26:42 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IlGKF+F6qU/9AeU+d1EUNGWbXZ4kXyzWTrYeEmOu3H/YpvZtFRJ1QSAtNFP68YXRzwse5aghr2z8cfP+GsFaRv2TdwINeAc+Jtue6fPMTBJ3zSqbYaGTlMca+/rIoIAP6/7NIpsi+e490CVUUsDjDIVoKZIplR4ySlB3BG258+aBpyPzN2oqbCEyvMKI3k7rTF4mGSgcGXMGtnSGalZZt+90dQ02IqgHBRMX6jW0+BnJIbc7qD8K2qCRhdc026Q2JUIQb7gOce2wHUhUnYsPGNF3/wdwkeJDD6VQQRNxBik6Q3drztI6ojP6Wkab789d5tkFAwKCwuv1YfXsgWsakA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+BnQb0u5NsdwvJoYMpkR6emHgLzvNDHct/GB6y4hHCg=; b=EPh0w/RqPNs60pGZgs99Oaf7fS1/IZxzF7QoJqrSFT/WjtgDJcn3I3rB6BVWV7f5I64bIWPeqmBeTiHqAppvI8xVW+WrTQhG4iBmzSd0JvjwyPa6l0+bBkJrW9oBP9q3SqqnPbEXFMkRqZ0ZaOUXpl+MtKM4IJa4jIr+45eLSVZE+gtPxOk4p7ZvlLduQQvLIH/vpZ/fRl06HGrH+6MYsCcIUVQ/TopkNoHb00f7UHAqrF6uTLFM0UBy9YEgamlbpV9uJc6HWF1u065eJmHnWmw7HuzyDtMnB7ILTzd+i6cLy+q4tbPSG7UliK19GiTOf4E2T+PjVttK2ulpFEH0RQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM5PR1101MB2107.namprd11.prod.outlook.com (2603:10b6:4:5a::19) by SN7PR11MB6800.namprd11.prod.outlook.com (2603:10b6:806:260::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.25; Tue, 8 Nov 2022 09:26:36 +0000 Received: from DM5PR1101MB2107.namprd11.prod.outlook.com ([fe80::b961:c069:9d46:cf45]) by DM5PR1101MB2107.namprd11.prod.outlook.com ([fe80::b961:c069:9d46:cf45%9]) with mapi id 15.20.5791.026; Tue, 8 Nov 2022 09:26:36 +0000 From: "Zhou, YidingX" To: "dev@dpdk.org" CC: "ktraynor@redhat.com" , "Yang, Qiming" Subject: RE: [PATCH v3] net/iavf: revert fix VLAN insertion Thread-Topic: [PATCH v3] net/iavf: revert fix VLAN insertion Thread-Index: AQHY8BOlB1/uSdsPHkKQwEUrVlAlVa40yAqg Date: Tue, 8 Nov 2022 09:26:36 +0000 Message-ID: References: <20221018102602.217673-1-yidingx.zhou@intel.com> <20221104061000.1868113-1-yidingx.zhou@intel.com> In-Reply-To: <20221104061000.1868113-1-yidingx.zhou@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM5PR1101MB2107:EE_|SN7PR11MB6800:EE_ x-ms-office365-filtering-correlation-id: 08d99035-95f3-4d97-593e-08dac16b5528 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rZxwF18QumKI4PJH9cnaHU5cTkrYWPgJwpqVMkKBPr2IltvwOU0pHyPwRpHExMU9XBSQ7EfoPX43mErxTNS0UuqboF05rMFT4koIGGLYWqW+nTaGXOSVZ3/GsXIkrkJuHefYBOaSmqEiaLPY9WJz1rdRUirosQ3G0sFYs1JAFBN8ZtQqob1bnsytXdhCIOZZM7krFRsqoJkLidre4KtiVyQ5MIWKLiH7rkwPWbk2gJtUdvRKHAgrpE9EXxi7R9Bxkggx47RYFWSG1iu3uSZTgGQssTqDPuzgT/smBbMeIP7A7gxckDvoroKb1dCxXJkgtub2vwu1aLVk86fLylVLzO1+7ASSJ1+4Ixymine+Bd1WFxxuXbbGEjOGXJRJJ2SnzNRwsMHazenV20o8gKn4HBy/lNN3xMeu6eqgLUg7jyam1iaFpoF/vjzC9mHMY036Gouz9/khdRHvZQer7H1xlK0c8ioK+EprWSRdGBfw1ZwYzYZTunDRMklg7IB16DrlVlmw9ArTtcUvJRNUOjpLY6YbJ39z4nYpWIPr7MEDgKYzqb9gwQWKbHYGxMl7mFrDXHur7hpF2ykH37xn/OrQ/oSRBFx8eqbNNessJrpNsxxmBh/a9jj4dQZCTfgfsjrCfWYg61/sTVKmckxPBWtlILM6tQbJLX/XUqh50nflfDY9zQk+P9+SQTFvk1KCO9U8ie/LlQAjPkyDUMyVYNdPToXmMWKI8bHkxwcdfhN2wJmyRyDN0PwewTqWYPkMELZMxhtm6zCMX5pjbHCQHm9Pbg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR1101MB2107.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(396003)(376002)(39860400002)(136003)(346002)(451199015)(38070700005)(55016003)(83380400001)(186003)(122000001)(82960400001)(38100700002)(41300700001)(2906002)(8936002)(52536014)(86362001)(66446008)(54906003)(7696005)(6916009)(316002)(6506007)(53546011)(478600001)(5660300002)(33656002)(64756008)(4326008)(107886003)(71200400001)(66946007)(8676002)(66476007)(9686003)(26005)(66556008)(76116006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dlN/LpzxhKm4TmBO0tzsVkPtfFZvu79sxhpR9C8/dvxanq70ytmNDKrC/mYd?= =?us-ascii?Q?Q6gqIzTLCtOZkYzdQqG0RgKhLRkjcrbBdKQ65QG6TtLf1GVsU5018oPyNFpi?= =?us-ascii?Q?k9xTbEpEEsof1Ta2fLQYWuIr+VwCZKr61INNOwUnbBmuzLSg9tnWkBOwnREx?= =?us-ascii?Q?fnvint+vqDkCHTIO9bGR07hZa926CAx1Kf68WuCQ/yZZuZiAYRsZwzuDiTXk?= =?us-ascii?Q?/VQxnYT01NH+rUYFsSW3Jnm39iotLr0oPtfSOhwECIEXlAJ2OIbfZTOZSu3R?= =?us-ascii?Q?yn7I7mnO18evkfPfY1ZkXKpWWKD8PBqobX3//DqwfdfR9sZp1G4C+tKLlGsB?= =?us-ascii?Q?ZE5DCepWpljYq5gLoTEzaUEjac7wxfFIZ42CZB2P9SODM0vN7zhHZwjdnBTW?= =?us-ascii?Q?mRzzVQUJzXQADi8oRg7Z84DSbJgkewKtNLk3/lnMTf6Gc59CEAOceKUtXiis?= =?us-ascii?Q?crxEI2/0AFSzNIPMKgSdD/ZGRbHg2SoxQH5mDmvwhF6xywfMK24YB5asjZP+?= =?us-ascii?Q?rOTMNWGNfxhcmW504v6qowjysgLEIxfqPD/A24tI8rZ72HleZ36TC+XGEDYq?= =?us-ascii?Q?8EWBjlFsZa1+hBn2cQSwrsqPJmOBTXSCvzq5qnIlAwC63CEJZ+ZDqqv2pHFl?= =?us-ascii?Q?COOgeVPMKT+jqCLU4aWjXLvO+ak805S5kfl5QwJzOIfEdZBxwQnEGaz8v+zu?= =?us-ascii?Q?08Cdg9VO02iceXZmrctul5CJYUZOZsq7Gym78rSMGdVWQMg15gh3Nmj3pLYl?= =?us-ascii?Q?tJdRjm0y0XtIPgHCwCsXOXTJbzQ5bo8NpEjWd6bapJLAimnEkeGfzHauvKIZ?= =?us-ascii?Q?hHthkp3hK+M7i+Eb26D4oFKTrYy2071cymTpmd31liN9xeFg1a1g6E9dNGPK?= =?us-ascii?Q?WBwGUUfGactdmy09Wgm9jGfy9NziDrxLGQm90MbW2iB0WaIOIJuAmMOT9vvf?= =?us-ascii?Q?V+k+1GBhk0gXPu+MrEUeHOpFoAoUrNjFz/iyTZjr1PXoGrmr3MBP6lJkIkYT?= =?us-ascii?Q?E/AGxj0KehPLwHw9mrxRTSPb6ooiO2Yz0bEpvTWRvzGT4w4ZMMrqrz1eQnWY?= =?us-ascii?Q?zb30GUt5mB4L+AZ7WNVkpnzcMw1EjPqTQhRoJhRgsOZvYdV7ccpMSXQox6Ru?= =?us-ascii?Q?wlskukH8rFhOWZD52BwsVQ9wNYhCTlB6mVwK9aXoZcmAt4bDd3V4BNFoDowb?= =?us-ascii?Q?r3tr2kn2obswzMQHU8dU2HNK1JinNZPH4zPDJSL17P3xlv5OCjSEHBabgWNt?= =?us-ascii?Q?HtnYNgtb1+2dIMeV79MzRjutJAmfdleXl38gky2FTkZHkl483ZbEKc33Q23L?= =?us-ascii?Q?V+f0Oo8n9puyMl/XJBz+6KRjRMzdKYQhQlV+ytFc/zVAgJP5v+vxDc7onr9u?= =?us-ascii?Q?aaS1InHeZcYrdM9eNdUbAfTKafZOJvrQuZEelXnENBPIKfjThSjNYcl/lEJZ?= =?us-ascii?Q?mL61WqYXOGyPKo/j+A4d//HCN+uvv4GFlAU5rJms6QPMWhJunkTePutXHlHY?= =?us-ascii?Q?vRjm4rwbntAH5X+SWDRhI5DAL1iB5OlkwyzET8cwdpGreUBvyaaSfNUliC7T?= =?us-ascii?Q?bLPemhIZjXM0q4lMNpJ2MFSTx7LllEyBqajqGVVe?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR1101MB2107.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 08d99035-95f3-4d97-593e-08dac16b5528 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Nov 2022 09:26:36.0559 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oNrKMZkFL9FFu33VmyCjVoie10MFZfx6APqNbEuBTvquXWQoT5Vma071BBNgoqPabBitdMIWiRXFudEjD29c7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6800 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi=20 > -----Original Message----- > From: Zhou, YidingX > Sent: Friday, November 4, 2022 2:10 PM > To: dev@dpdk.org > Cc: ktraynor@redhat.com; Yang, Qiming ; Zhou, > YidingX > Subject: [PATCH v3] net/iavf: revert fix VLAN insertion >=20 > The vector Tx path does not support VLAN insertion via the L2TAG2 field, = but > the scalar path supports. The previous commit was to force to select scal= ar > path as soon as kernel driver requests to use L2TAG2. >=20 > That logic is incorrect. Because other case like VLAN offloading not requ= ired > but scalar path selected would have a significant performance drop . Ther= efore > the following commit needs to revert. >=20 > commit 0d58caa7d6d1 ("net/iavf: fix VLAN insertion") >=20 > After this commit reverted, the user can select scalar path with the para= meter > '--force-max-simd-bitwidth' if necessary. >=20 > Fixes: 0d58caa7d6d1 ("net/iavf: fix VLAN insertion") >=20 > Signed-off-by: Yiding Zhou > --- > v3: rebase and change commit log > --- > drivers/net/iavf/iavf_rxtx_vec_common.h | 3 --- > 1 file changed, 3 deletions(-) >=20 > diff --git a/drivers/net/iavf/iavf_rxtx_vec_common.h > b/drivers/net/iavf/iavf_rxtx_vec_common.h > index 4ab22c6b2b..a59cb2ceee 100644 > --- a/drivers/net/iavf/iavf_rxtx_vec_common.h > +++ b/drivers/net/iavf/iavf_rxtx_vec_common.h > @@ -253,9 +253,6 @@ iavf_tx_vec_queue_default(struct iavf_tx_queue *txq) > if (txq->offloads & IAVF_TX_NO_VECTOR_FLAGS) > return -1; >=20 > - if (txq->vlan_flag =3D=3D IAVF_TX_FLAGS_VLAN_TAG_LOC_L2TAG2) > - return -1; > - > if (txq->offloads & IAVF_TX_VECTOR_OFFLOAD) > return IAVF_VECTOR_OFFLOAD_PATH; >=20 > -- > 2.34.1