From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F15CA04FD; Thu, 10 Nov 2022 03:10:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1D46F400EF; Thu, 10 Nov 2022 03:10:13 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 754AD400D4 for ; Thu, 10 Nov 2022 03:10:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668046211; x=1699582211; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=GD96CTz22+BL1zUqn6Neyd3b2pc9zd0K/qVV+5z77G4=; b=ZH0Rf2KVaYwuBdqoQe+ujsgKcdio4rf4gGzkdmMcV6RWMaFt9Os4t+wd KKjUORe31ebBRSE4kesfZaezUChpoydNWAU7Xe6wmSZuJOPPFsKWif6rY lKgSs/JYIFrpzXLSmu2RN0qEU30X9qpwAxCCxaP9Wv2lI2LlzeCp670p3 5tLArID2dGcbR+z18iv2o9Xj6F39wxf6SRTT63y+ScfbJpQu/dO9cT1Rr b9VwFdIqheXdmAXGpl+nDVyhzvNbcJ7wfQd9LoMNmVUYYmTpnpmJwEJIm nr1K0wbDcb9KIdnjXUnXlfg1i5vHFMbYPJjEUwpCihxoBjk3nuCWji05G A==; X-IronPort-AV: E=McAfee;i="6500,9779,10526"; a="397479254" X-IronPort-AV: E=Sophos;i="5.96,152,1665471600"; d="scan'208";a="397479254" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2022 18:10:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10526"; a="762104917" X-IronPort-AV: E=Sophos;i="5.96,152,1665471600"; d="scan'208";a="762104917" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga004.jf.intel.com with ESMTP; 09 Nov 2022 18:10:10 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 9 Nov 2022 18:10:09 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 9 Nov 2022 18:10:09 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 9 Nov 2022 18:10:09 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R4cJcwvNBlmpu1+1VXQNpp/ohN2smOE87oL2IJbD1PNyCXuA/qflocr4yjrCvPc84HSmQ2Ua1arx1K6yA/ywPLK6r8DoqVFiIJIAOtUvwToJfEAHA5uv9UuCYGT904ErCZrSpFD6qBZngbW3KRG4So1PEXnEkCWkeAfK+F5ZaU1H4N3czAiCbWotnu2yWFdXbH1c16Xk24ptqYHAjzhOeji0vRkCxBZfV5rBBHj5eS3FLSkc7Xni9VyHlTIB17F/DFPuJrpT+IhmECzpK6NRyxCT5S2wg4fBDFt+EQ/2n6qvYvi5Z2zkqDNi7y9hbGAjxg/imbqZVCfIy+UMnJdw4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pAGpJ1smrCDPeZ85zY3UfF1B5oGTNwV5ojCPJcfQXeA=; b=BNFGqeb4arrH/XXPFckH2OvZfIOnsJus7JieaZZu1L+Uwr4T2qtiDCmwKEyctJGJ5SWsYjTO5vVGdGdlapXA3thO/GYmxamuD3Rm+HiVvNCYyd1RPVv6an+ILDwhRLY1mdmXWN4iZuY/NUi4kye1fd62/NsmdrHKM5wWBFi7YEE6XSKN6c3kVC8UB7Oq5z4KlPx3//0zTxARJVq1CRTkqq1N8DOo/OcamRXfvYHnVne2ddLQEDZRRECJce2l31EItlpclp7rl3mb2jYI6COb0WDSbBwHUQLw3jThUkN1Xv+QFtlCCp/INzTYydjb5SEYm1gLoV5RbB5DvYy2DUw06Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM5PR1101MB2107.namprd11.prod.outlook.com (2603:10b6:4:5a::19) by DS7PR11MB6269.namprd11.prod.outlook.com (2603:10b6:8:97::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Thu, 10 Nov 2022 02:10:08 +0000 Received: from DM5PR1101MB2107.namprd11.prod.outlook.com ([fe80::b961:c069:9d46:cf45]) by DM5PR1101MB2107.namprd11.prod.outlook.com ([fe80::b961:c069:9d46:cf45%9]) with mapi id 15.20.5791.027; Thu, 10 Nov 2022 02:10:08 +0000 From: "Zhou, YidingX" To: "Zhang, Qi Z" , "dev@dpdk.org" CC: "ktraynor@redhat.com" , "Yang, Qiming" Subject: RE: [PATCH v3] net/iavf: revert fix VLAN insertion Thread-Topic: [PATCH v3] net/iavf: revert fix VLAN insertion Thread-Index: AQHY8BOlB1/uSdsPHkKQwEUrVlAlVa41yQYAgAGiRqA= Date: Thu, 10 Nov 2022 02:10:08 +0000 Message-ID: References: <20221018102602.217673-1-yidingx.zhou@intel.com> <20221104061000.1868113-1-yidingx.zhou@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM5PR1101MB2107:EE_|DS7PR11MB6269:EE_ x-ms-office365-filtering-correlation-id: 666b003f-40f8-4b69-9ea9-08dac2c0b0c7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GhBD7Dx2a34OKC/UwIkh3nJ7zlgQPdVXMHDlqA/9Kh6HTRvl8GuLNCLifYC8FMnZ6Esskdy8EaB/zNFfeN5EU1tE4qBw8R7lsEyE/Yd3oFfUUv/ziEErXqqNUur61j5dbfYR3ALPzrd1n97az+QMVzIpU6PdlYEvXH8qq1iwaO17Kgag7IcKDx5uHlYcBDVUduMycdu6yLfZdJzuzpeYXbBTKKRK4bCiMcYgSDFwo2sEDPq9dz5zUcues4n/czOOvhkzbWxFusWYfDLp67NEyuFkj46qVue0Ufs+0vYlO+eHUcXSLKN/cSgd17ghgPD83H4Qc8zHKrIypNm7oRH5mZ4i0WNPsJH4TUOMcYHaFCzBoZjMqS22PBYyYJYGKQm0z6maYbunT3DKpacsVC5MsCMvVMNkB4Te5K5vT5ajM2fkJC9iJg2irOcMShsyI7BRGAte34bBTKFducyDo5tAkWMqVpQ6ftsowzANe47zYHWyLl4rd0lwpJFOqFpuHR/O0vgGwRAIwxgNLI8mWmyhSYkXdKQGx6JGLOKfuGei0Y4Jak5VoIDS+osQI6JBApeRVErQ0GkoYFy9ahH6ouLc5qwdQooaWdJ5WQAOboYphqZNaYr/9gJUawFlMOP4L1bxwRGMePynQ8kqBtphfVHxj0rTXnpnjJY5AiARAONg32BxivlAbGzDB7PTfoDOkX/UMFZRsAOO5Q11qjojTbku6oWpK3RPSsFJqkdFb4d6HTvRllPvp9KFB6Nm3zjWxEyh1YsL6YYgSuWXPjYGGOgBRw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR1101MB2107.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(39860400002)(136003)(396003)(366004)(346002)(376002)(451199015)(83380400001)(2906002)(38070700005)(33656002)(9686003)(66556008)(76116006)(5660300002)(66946007)(52536014)(86362001)(66476007)(8676002)(64756008)(41300700001)(66446008)(26005)(4326008)(8936002)(54906003)(71200400001)(478600001)(6506007)(107886003)(7696005)(186003)(110136005)(316002)(82960400001)(38100700002)(122000001)(55016003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gUFyMpLLkCn2XLovIDe3HaltHxZ88x3i7Kj9Gd7pz1f741aZTHWFPkGKUych?= =?us-ascii?Q?PkWYCmxeg1IaLDXNAPhRxyAJa2U6o/7Dmv+UvHEG1EY//mIcIlGYMdyQaIii?= =?us-ascii?Q?PXgP1lYRB6T0BCPgif4TwYpYHY6wN1ZO6lSXidlQWTY3huyMvx9Rm2qSTb3f?= =?us-ascii?Q?ubUQY/jWiWCf/PeTCmBVFPW0imq/RMterb59uzBPrQco6ebHpjSwwpU26wKg?= =?us-ascii?Q?bDFdTJ7x3oa7EtBLGuEw5mQz0jJK3cLwDvDTor3gQeStFJ8EucU08S9EbOO/?= =?us-ascii?Q?Bev92VkjUm9Rref4rH5NpgxtQ+RRyURM3kBrQUduxLPAYL+iUsjDj8SWqY1K?= =?us-ascii?Q?EYpDLaw6POjIeWT66AE8d9eQ4zhlb1Juc27zfQFP78VaUjGC2ONUzAt7vs11?= =?us-ascii?Q?pl/Ji3dN+VdMlBv5Q+aGL5sMWfVF67ooHk3myAuzRyskpQwUyPoCp6ZSTr2u?= =?us-ascii?Q?Bm+YjiGhtJvT9MbuxTDaXvl27U7Rm/0SY39/zkOkE3Uji4cTmzPZ7UkY10fV?= =?us-ascii?Q?7gd+05YR5pBMVU0Djx1qBUxSwYcRnbczFxbgst1QNHOqiUKfYZ3pZGpP6XYx?= =?us-ascii?Q?cQZS7/skDyzYRn32E+BTB9VX4FnX2g2l+2ma01D0ij3JjHVcrtF7oZuCfjHm?= =?us-ascii?Q?3yGIuP0LuaQFDDUXMprec5vPNtw8D6xCw+bSu4HTsJteXNd64Zsc45wTDsSg?= =?us-ascii?Q?JGHIjK7Mep4t7FhO8ZiL/NbTY1kB9lEcLI37hvnzBDf04Q5CICu63OLxp+kH?= =?us-ascii?Q?1JMEwcb7kFep8otRVFnKuRE3eNPoQMUb4DsuDvslFJRKqjaZfYzYJX7o775S?= =?us-ascii?Q?Qooq59XPtEC824HJhuvY0pbShgn0tx3LsdDryrdLLxtrXI5Ehqyn9W1BQJat?= =?us-ascii?Q?AF/BRmKDZt1j3VI20FDm21L8mxgK50syDtexiotelQqLGpy8Q6TvUIIPN4ej?= =?us-ascii?Q?DV/oEzpVdLRxRXHe9zOo1u5+hAHJxoFuyugH8/fcEpX0tAtYWgAvf7Q1ZqzZ?= =?us-ascii?Q?fp9AxlQp+mroBWnxbnYZwhwvjE3F3M205DI6RFemurJOzAZidowfr8Xo4zvY?= =?us-ascii?Q?5gvKkApHyOh8+HCCiqNSmj4viZeH1CGonK3YDzTuO4LcJ0zUbEO76J4Vh8on?= =?us-ascii?Q?XZOQlNWyJX21uTmy27tQd9yAtC7O7sjxYjpnRJ9UTENh3MqMLSCs63HDcsCi?= =?us-ascii?Q?CMg+m9Sia9rsF0i4gvBohs7awJ1EgvxOun/fmsTZIvXxLLbCSdDOX5TO10gU?= =?us-ascii?Q?ADf16kO50O1vC5foStWNTQ/tYaOWWMvsRCl8NkzXWpBdSofMgGYmbOWAFwA5?= =?us-ascii?Q?gZKGS+GDulj7FRehMRRlR0+iM9M8+qiP7W1UWO1DqGFOeFuh3m3BdFtN2Z9K?= =?us-ascii?Q?aCAeKnzycqUfgWkG9wqQG8uwjZ5xWPDFr3YSjRr3INJLTNQ1L6jIPXq2Z/jR?= =?us-ascii?Q?titH/FkWU4v/G0eplUYZewbdwV+jm18kgOQ/5Q2hlsEQTt9isuEwVUJaqIea?= =?us-ascii?Q?ZtcL6kMNNJXOTwHcdX90psYcvD88lcfCU/eOFdB9V05zY2b37+qi1x+V84uQ?= =?us-ascii?Q?UTG3ei8MJ7Bw1/d3Fv6RltosQvAEU4KemPg0b596?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR1101MB2107.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 666b003f-40f8-4b69-9ea9-08dac2c0b0c7 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Nov 2022 02:10:08.1098 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FP7f5hFXsp6RPP4Z9FLH/ATtQrIjOeox8ch1ig6yl2V9OsT+Tnh/6nIWyrXuLoh5qfiy7KxK3284n16VW5JuRg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6269 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > Subject: [PATCH v3] net/iavf: revert fix VLAN insertion > > > > The vector Tx path does not support VLAN insertion via the L2TAG2 > > field, but the scalar path supports. The previous commit was to force > > to select scalar path as soon as kernel driver requests to use L2TAG2. >=20 > In which situation, that kernel driver will request to use L2TAG2? According to my tests, this happens when the kernel driver version is newer= than 1.8.9 > > > > That logic is incorrect. Because other case like VLAN offloading not > > required but scalar path selected would have a significant performance = drop . > > Therefore the following commit needs to revert. >=20 > What will happen, if kernel driver request to use L2TAG2, but still vecto= r path is > selected? >=20 The VLAN tag will be inserted to wrong location (inner of QinQ), and this = behavior is inconsistent with PF (outer). > > > > commit 0d58caa7d6d1 ("net/iavf: fix VLAN insertion") > > > > After this commit reverted, the user can select scalar path with the > > parameter '--force-max-simd-bitwidth' if necessary. > > > > Fixes: 0d58caa7d6d1 ("net/iavf: fix VLAN insertion") > > > > Signed-off-by: Yiding Zhou > > --- > > v3: rebase and change commit log > > --- > > drivers/net/iavf/iavf_rxtx_vec_common.h | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/drivers/net/iavf/iavf_rxtx_vec_common.h > > b/drivers/net/iavf/iavf_rxtx_vec_common.h > > index 4ab22c6b2b..a59cb2ceee 100644 > > --- a/drivers/net/iavf/iavf_rxtx_vec_common.h > > +++ b/drivers/net/iavf/iavf_rxtx_vec_common.h > > @@ -253,9 +253,6 @@ iavf_tx_vec_queue_default(struct iavf_tx_queue *txq= ) > > if (txq->offloads & IAVF_TX_NO_VECTOR_FLAGS) > > return -1; > > > > - if (txq->vlan_flag =3D=3D IAVF_TX_FLAGS_VLAN_TAG_LOC_L2TAG2) > > - return -1; > > - > > if (txq->offloads & IAVF_TX_VECTOR_OFFLOAD) > > return IAVF_VECTOR_OFFLOAD_PATH; > > > > -- > > 2.34.1