From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48BC8A00C3; Mon, 1 Aug 2022 07:44:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4E00641101; Mon, 1 Aug 2022 07:44:43 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 86AF24067B for ; Mon, 1 Aug 2022 07:44:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659332681; x=1690868681; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=Q0uIkvXyDFHfgTpaEwcWrZr+VhJAC9Q4/2M0Oz98Ob4=; b=ACGij1bCoQAeGfyaEDleykr3nkDff1N+Pk+u1CeHMxaW9jOYGi64BLg9 g5VkOKVEycskddtz4/F6T3XVnOWwg+v46vgGMe3DKLvY0Rhrswh2PBSC2 kk8LJjeAaZ8RcYhD50NAH06HBkfA4Lt7Ed3AEaWIYexsFyhqC9Umfj8pN mhww8LZAr/g/ZSoXVZW71T3EvWjghdGiCu9uz4u8Lszh2DavVHvvbgdIc wqzqnsbprCQEhY1f3ZbIrhc6LUiHm3GJuMW4RcECpYKi53lwAu6ohLJrf EFW372EodkPqCff1TxIkAIsPFNxB90DOaPeb15zKWXAtTrhRnZ8486Abw Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10425"; a="272110614" X-IronPort-AV: E=Sophos;i="5.93,206,1654585200"; d="scan'208";a="272110614" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jul 2022 22:44:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,206,1654585200"; d="scan'208";a="669925379" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga004.fm.intel.com with ESMTP; 31 Jul 2022 22:44:40 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Sun, 31 Jul 2022 22:44:39 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Sun, 31 Jul 2022 22:44:39 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.172) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Sun, 31 Jul 2022 22:44:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RlrhfRqsDuovV5HFxCRBIAhlpo0WO3JsYVfOjJyIstd3ekGiDrsWV56GPyVeW5X4FDLPwpMVRy8k4OYu60RpfqK3LI8j/cYezwhjo6xLGiGrZxPEr1Vtf7O9kAO/+zTQMmUKg80+bA2spumT4ztWzYESTj5WxEgnFB/O6MZ6ZhCy/yANPmzvTxUx5K1g2X4Q4FRZyGzz7BbnJgQKzs56D1zv8PNRtmKUKD+edJgXkJdGejfk0TXjFnNziUIn4O/i64bbELOCq9Numg+c9h21yNbP4pvcyj3xj8kwCtsoOqOSRPMER4qqSrm3/Lib7G+Zh6nmFGYrCFjBH3z/V8WqOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+hyAkbOAI48ppZTJTrDvTxYR0BpjveDFy1KyfJrG+BA=; b=biLIM15OaYdrJbY0K/dNAet46mKkNBLVZdJDmw/4Tt2Qjr7f1OzGLH9sTpMCwOi6BkR2pxyc8+oBgxt2qYggpvZAK1To3e3XYm7bzkoxc8mYLnvFrZTiINHZBC/FrIqhQAsmHp7AXDsAvyAKfGmH2xiNekm8jombnhoeJd6/cgMTflnzraI9WIHHJoudWpibBOk6aAe+scGH56LnEgY7pIjO7Yz+7nIeesyGbI0CEVlP/n8LHrbjFk2v8YgpwXQnLnqpWh6PVXQrUzGNPGHNiSeMIiyIG48c/O/Vbw+KnCzjgX3D8kiOamgKXEypZ8jRgt8xh/4ooDz4tzKG8MG8UA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM5PR1101MB2107.namprd11.prod.outlook.com (2603:10b6:4:5a::19) by BN8PR11MB3700.namprd11.prod.outlook.com (2603:10b6:408:89::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.10; Mon, 1 Aug 2022 05:44:38 +0000 Received: from DM5PR1101MB2107.namprd11.prod.outlook.com ([fe80::24c4:4a7b:c8a:628a]) by DM5PR1101MB2107.namprd11.prod.outlook.com ([fe80::24c4:4a7b:c8a:628a%3]) with mapi id 15.20.5482.016; Mon, 1 Aug 2022 05:44:37 +0000 From: "Zhou, YidingX" To: "Zhang, Qi Z" , "Zhang, Peng1X" , "Yang, Qiming" , "dev@dpdk.org" Subject: RE: [PATCH v6] net/ice: add retry mechanism for DCF after failure Thread-Topic: [PATCH v6] net/ice: add retry mechanism for DCF after failure Thread-Index: AQHYkQFWadrmXgyll02tdvszrFga4a1yeyaAgCc08bA= Date: Mon, 1 Aug 2022 05:44:37 +0000 Message-ID: References: <20220706141709.7681-1-peng1x.zhang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: de19589b-06db-4ade-c5d4-08da7380ebfe x-ms-traffictypediagnostic: BN8PR11MB3700:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: G05OsPimaAVFd4elQgrTz6sh5V8wuPRht0CuLRnkJGgDPMcqAgTbfPvrz/n/LuHHtUCmaK4hwXDtbtd2d6sUGpV6CQnb+jiboB3DkND9CsRoO1w/n/p4JHUikyRbIOCUqz2jlMQewh87tw4Eot8ppTypRlur6nu2C7V7Ow0VbDnJyb1ENDUvRrN7GY0b4yBvVSp/80HPqgkKehJnxUXW+zCAjzyaTt1jWN9TphiqcmV9WVJGdIySa9bA8Sk7fcM+xetfSBGactoTu/J24vzKFETUsMmtnIiH6el+tUa7X996EkYhymYELcb0NdyxfELBR1UqVK9wyodGRqL0wRBl84bVUFXS+qvD3CqKBcZlwoiV2jA4ftNKjzMiLUWvvjzK1Kjh+2UWG8rp/J0kBvyRKJeKqDCJtJctp9rfbrIeWRlldmtDCP6jzm3kDPBbOnZcF71tOgByJYl9hrpZDFGin4LDwZo+d+00cShj4TCkopizOm2cyZ0XLC5OfPp2t/PH861vIIjFFk51AXzsmqVcbApWdeQ0KTzsuzmaVqOlsmYvMAA+wDtGrlMcl5Ae5TxjTof+lBRn+vCuVkgizwD3fqGn3uhJh0cP/8EaXZL8o9XNkk/av+dFc2NO4QDbBaHHh1BYFTrPQFqipVnaUMXyQt4QcaKsf+wFbZ8N99VvMsokzsrviBaUuiGe+UqtrngT2Be4xa+IzPgMApqLK0o7R84rDztr0ac7EqKr7ShsyF8VYt1mk8aQyR0Ejr2HsHi2P9gQ0xk0GAigE0ZoDQZ8e5gVu+I6t9nGTEjEYTU6tdhdisoizEqTmoip31gLkvTr x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR1101MB2107.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(39860400002)(396003)(376002)(346002)(136003)(366004)(6506007)(9686003)(8676002)(26005)(66946007)(38070700005)(66446008)(64756008)(66556008)(66476007)(2906002)(33656002)(7696005)(82960400001)(71200400001)(41300700001)(76116006)(53546011)(38100700002)(122000001)(83380400001)(5660300002)(52536014)(478600001)(86362001)(8936002)(316002)(55016003)(186003)(110136005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?cT4095Y8sm/mjq2R7h/iFMzXai0vm6mfMMdGRv8CpJ7fgY02sx7dA+Ur58Jx?= =?us-ascii?Q?TiNJgtFDMu3Fh89u5FliHRZ9sMnDmUAEqYXJa9h2XkhrGclhbfwbfAq5IU8S?= =?us-ascii?Q?C+yB9tz6SMmKVx/tGbcd6yqQx8i2i497SMzBL05RPyDnRncWVzEkdPOb53vb?= =?us-ascii?Q?9EjPsDdb2H1esPxMUkQgPVngO27QIDDhC+SNRvqBPLgMeoFRDod8r9YsiYhz?= =?us-ascii?Q?HsF6AXjZX7lj2Mb+JlZb7YsucSX0BOcF/vo+PSMgtbr+CCV2WXxppI2SsWuY?= =?us-ascii?Q?dmkWRX6khaSWtJxhRlob/Y/8biDdeZNTEBNd1AePkVuJGTcTh2Nz0z4PsiNN?= =?us-ascii?Q?VINRCeBjXFhmcp9bdgtNH5nOoxCN0E5GPm6eLe7PeqmG5TAOu5nnWvqEQC92?= =?us-ascii?Q?HNWAf2EbkhF2NKiyNZSj/pxEQ1GKgzGqJ48mJW7ERfbdzWApL1R2+gn9fl/m?= =?us-ascii?Q?iaOixOINjolvXzidlIKL9/HX+reTbLlPJUcDM4+MtKbxJde+GhX4bl4OXIlR?= =?us-ascii?Q?dhX6BtSZ3IVUM8QuzoO+x2qp5SeaMvfhARN+wBa+0aLAIBiLs8FSGTWLxjb/?= =?us-ascii?Q?5vDqz1xfGoYy6t8g4HX+if0tbo6zFa8t1qXEmt291NYYVYyVK0zG5lV0cxVu?= =?us-ascii?Q?OYcbBIfQxpzkHpbJgO5MO0JyhQKr2vdBbHIDHsNTeySJEDX0XQsoLlIhy7eq?= =?us-ascii?Q?e9b/r00d4Ods3CnmNeqiLHjR3DCifExt+7+BUiAufDg15Yb1HUiqY8YRY3V6?= =?us-ascii?Q?LhrAB1d0yg0rPpsxWTgDv52XP/fk0cILCJXgE17Slbj1dWzD6tlpduY1b2BZ?= =?us-ascii?Q?P7tvgMW49RqdqjK0QzI/VI7+trNtP4cCfD21V1faO9/htwEKW7fnoSx7RHgO?= =?us-ascii?Q?y4IO7oqn91ZVawZrRyTurBkBTnRPg3pLSYMlO1OXzSJ64x34cEjXJOr9oD4B?= =?us-ascii?Q?S9dJrelTwHdJ2q//ehk98xDXTR4OMhNhJbYA+WE5MymaXyrj9/8FyzfeTWaf?= =?us-ascii?Q?CuIvst2sx8QwQlbxFbT2gan2JMr13/TPm4j183BuG1iwj2vk0cbyxmM5aXnr?= =?us-ascii?Q?IMetyDc3p2gUWEOhF/j+I3snUYCnlEDWhfYs4dMhaAweMy1KD4nN1rHhyyu9?= =?us-ascii?Q?m21zwrppiGTTC9SDa0ijTg23n20PwbQ18FdifUjSpqCNs+tOEEO/ad3isuly?= =?us-ascii?Q?NW6niA8g893ukN6nisBKr+nxIVdg7o7NI3gFmadV/7eM5ei6DfF7yLbPFY3+?= =?us-ascii?Q?f89B7KGH04TrmfvjV1xOcNUc60rruTnUsVdJpgGVbp7Vxeses6v6DRWhxIVU?= =?us-ascii?Q?Qkr14SM8irNXo+o5kxpZKmg+DrBXS3LSmVZDMefnVM497P40L6+2jQtYtFri?= =?us-ascii?Q?aFcQMByo5nV0v23Z0TelwpixLoIwgD57BGiHTHqewi/hhC4RaFS6l2aW2MgD?= =?us-ascii?Q?gOe1m2Xd1zK/DGHfIfWQn8Qw21uwa+p2bY54PL6MMitOSz6CxK7HIXIR6n1a?= =?us-ascii?Q?XEA3YXw95LguneUKItvh8frOWWrX3gYASsHtAtW8n74mkpseBWOHZdaHqtrp?= =?us-ascii?Q?/1PU0Lxb3XuPZEPIX3WxjJVPVashCIDTbqfK5kqy?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR1101MB2107.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: de19589b-06db-4ade-c5d4-08da7380ebfe X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Aug 2022 05:44:37.8540 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ifgAh+jkrloxUE1tmMH9mFcldOUw/sajOySUAXKG2Z6Uze0kmYT77sDOSX+JPDnfx7Cn9tFmbIxmy5sbgXkrWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3700 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Zhang, Qi Z > Sent: Thursday, July 7, 2022 2:56 PM > To: Zhang, Peng1X ; Yang, Qiming > ; dev@dpdk.org > Subject: RE: [PATCH v6] net/ice: add retry mechanism for DCF after failur= e >=20 >=20 >=20 > > -----Original Message----- > > From: Zhang, Peng1X > > Sent: Wednesday, July 6, 2022 10:17 PM > > To: Yang, Qiming ; Zhang, Qi Z > > ; dev@dpdk.org > > Subject: [PATCH v6] net/ice: add retry mechanism for DCF after failure > > > > From: Peng Zhang > > > > The origin design is if error happen during the step 3 of given > > situation, it will return error directly without retry. While in > > current patch, it will retry at every interval time during certain > > time if receive designed error code 'VIRTCHNL_STATUS_ERR_RETRY' > > from kernel. If retry succeed, rule can be continuously created. > > > > The given situation as following steps show: > > step 1. Kernel PF and DPDK DCF are ready at the beginning. > > step 2. A VF reset happen, kernel send an event to DCF and set STATE to > pause. > > step 3. Before DCF receive the event, it is possible a rule creation > > is ongoing and virtual channel command from DCF to kernel PF is executi= ng. > > step 4. Then result of command is failure, it will lead to error code > > return to DCF. Error code will be set as EINVAL, not EAGAIN. > > > > Fixes: daa714d55c72 ("net/ice: handle AdminQ command by DCF") > > Cc: stable@dpdk.org > > > > Signed-off-by: Peng Zhang > > --- > > v6 changes: > > - Add retry mechanism for DCF if receive designed error code from kern= el. > > v5 changes: > > - Add retry mechanism for DCF if the result of sending virtual channel > > command is failure. > > v4 changes: > > - Add retry mechanism if the result of sending adminQ queue command is > > failure. > > v3 Changes: > > - Add the situation description, expected error code and incorrect > > error code in commit log. > > v2 Changes: > > - Modify DCF state checking mechanism. > > > > drivers/common/iavf/virtchnl.h | 1 + > > drivers/net/ice/ice_dcf.c | 32 ++++++++++++++++++++------------ > > 2 files changed, 21 insertions(+), 12 deletions(-) > > > > diff --git a/drivers/common/iavf/virtchnl.h > > b/drivers/common/iavf/virtchnl.h index f123daec8e..e15e3a4439 100644 > > --- a/drivers/common/iavf/virtchnl.h > > +++ b/drivers/common/iavf/virtchnl.h > > @@ -49,6 +49,7 @@ enum virtchnl_status_code { > > VIRTCHNL_STATUS_ERR_CQP_COMPL_ERROR =3D -39, > > VIRTCHNL_STATUS_ERR_INVALID_VF_ID =3D -40, > > VIRTCHNL_STATUS_ERR_ADMIN_QUEUE_ERROR =3D -53, > > + VIRTCHNL_STATUS_ERR_RETRY =3D -63, >=20 > Where this error code be used? This error code is not used in DPDK. It's unnecessary to add it in vritchn= l.h. DPDK use IAVF_ERR_NOT_READY which has the same value -63.