From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 30C3FA0527; Mon, 9 Nov 2020 18:37:49 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4A475697B; Mon, 9 Nov 2020 18:37:47 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 5374A6947 for ; Mon, 9 Nov 2020 18:37:43 +0100 (CET) IronPort-SDR: 1+0ph+IIVF4wOtLkfNlctpJjqLmXYMnEYFhpSriNaCODFOOeKPOuoWjgFhC4ZwfXP/SSpGD6Rh MYCMbxS/Tvgg== X-IronPort-AV: E=McAfee;i="6000,8403,9800"; a="234007173" X-IronPort-AV: E=Sophos;i="5.77,463,1596524400"; d="scan'208";a="234007173" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2020 09:37:37 -0800 IronPort-SDR: R/b8Ce3VoEc+v16fqQtY2A0nqZXK69bJ8bmiCoWI+zP6nqBu/ZjPzRyuF0Ag7hDP8GVY3E4Fnx k0e0grA8qvfw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,463,1596524400"; d="scan'208";a="530842995" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga005.fm.intel.com with ESMTP; 09 Nov 2020 09:37:37 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 9 Nov 2020 09:37:35 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 9 Nov 2020 09:37:35 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.175) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 9 Nov 2020 09:37:34 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UGpsbG6hYtxdsKWbYz/3jVlucgrmfTSqlZ1y/0OQ0pE9iaPjxMEEQtVe+reepFHl4k00TMS9pPjR2cnmZYQni5F6ED+ACE4xQTFXdjr23JVrTihN4SCGnDyXE2zh9gO24WkV52gFwDnPsx87c+Oa51X4MbcABe9oLXsbpZEUwNN5K6kS78MERlfxK0jDhFBIuNnKZWpzgy+e4EebQWTHbyPQxi7y6kIyZ4ga4P/Psf7QuP1RoOaYD9vnaTVypnxxW7axXdHRPLXQkIuRfaJ+rBu0IPb9+7mNyb3a0zj6HqIFX8u9PsYs3722B6OAAuymL8qn1zM6dlpN0lY9utvvYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GmddDeRhPfjrs+Lmh1pEKoArtjL38nkDJFPmrkjxISg=; b=e0Av8Hy/yzUXni1Xy3r5OySxymOBCkpScANYBu325A6QX9vrmTDJJolDIu0lH1ml3DUHKo+mIVuZPclC4WcAz2j88eFacLgf63LtVMRvZgTLitfD8d97Rspqw4JaUKXopbc67uHdQPE3/a8q427cPFpaf10L9tuZfgxiXLP1mdWhtonOQTePNs9cFK5s2wpntFMUjcdttDEVl8ITnxDcsIndEETUcejVSMukbdh/yD2QNm0lAfcd4WovFmngI2DyKJ5eRQyDVbSowC3r2ZtqonwIKTNEd1MwBlQLlBybHhJfXz3d52bUHbM23a1g5Vo0iy/dFNBCIUCFTBL7Spbmgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GmddDeRhPfjrs+Lmh1pEKoArtjL38nkDJFPmrkjxISg=; b=iBshbug9NcSFBfKRFwcQHhurHb/zxnh51mJfA6PNXz0L3P/FNH4v9XgaaE7v7DjgTnR4BgFsAc4ArYaOscRhzMQyPVyERKNhbKAmB7YtGBc/hcCMklFHNkkZfY7aSCJ7AvGm8oxFCOruIdoZFHgR+cXxOFlHCITU3p9Cocvzy60= Received: from DM5PR1101MB2121.namprd11.prod.outlook.com (2603:10b6:4:50::19) by DM5PR11MB1866.namprd11.prod.outlook.com (2603:10b6:3:10a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21; Mon, 9 Nov 2020 17:37:28 +0000 Received: from DM5PR1101MB2121.namprd11.prod.outlook.com ([fe80::283c:db65:84a4:b621]) by DM5PR1101MB2121.namprd11.prod.outlook.com ([fe80::283c:db65:84a4:b621%10]) with mapi id 15.20.3541.025; Mon, 9 Nov 2020 17:37:28 +0000 From: "Walsh, Conor" To: Honnappa Nagarahalli , "Ananyev, Konstantin" CC: "dev@dpdk.org" , "Chen, LingliX" , nd , nd Thread-Topic: [PATCH v1] app/test: zcd needs to be initialised to fix gcc compile error Thread-Index: AQHWssx7UeSjSO8VKEW0ixDwHHuez6m4UHwAgAevGSCAAAodgIAABIJQgAAGhACAAAB6wA== Date: Mon, 9 Nov 2020 17:37:27 +0000 Message-ID: References: <20201104170306.1688771-1-conor.walsh@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [51.37.110.131] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c1c7673b-badd-4f6e-cee9-08d884d620c9 x-ms-traffictypediagnostic: DM5PR11MB1866: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: RQGilt1PvUANvkp38eeHgErTeiRkpOSqN27lquZEBQfUaAdYIzHEnCVfSucCaTvYHJrgVVbWURSBLYmz+VAEL28ddj7RrfbRw62YjCjUPRt1zWkLxAT805xRICOtpbaTFiarLT0CgKaUuxaVusl45HQBChHqJOyLsj2IsDv9kMOM2EJe4L32cyWw2J1HHSSAqk9VGvaxHasKy/M272E9j0sG9bi3lzKMeam1GJjkiA11UPwL79GGpfhpfQkk1fGPln/QpWtwVupLNyVdTirjqvXbAC2aDwu13ajHJUoj66u+qBTijuHkjhkMz3oC/S22 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR1101MB2121.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(366004)(376002)(136003)(396003)(346002)(186003)(26005)(6506007)(4326008)(6636002)(71200400001)(110136005)(316002)(2906002)(55016002)(83380400001)(9686003)(7696005)(66556008)(66476007)(66446008)(64756008)(76116006)(66946007)(53546011)(33656002)(8676002)(8936002)(5660300002)(52536014)(54906003)(86362001)(478600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: bphCeJgLgA1fSY22+aoNfBO4FA32ootVhZSQQZMZiAPXsQKuV0Pwp92ZXBf8d5zpRhVIcytKIbvP4PYVju7IzOtxFUxLfAdtb++7sDg/jv27N6TTUr/tcIJ+NsddmHuQ0YL/mXEN7CE0hLczzUPge2ZsYvof2u2UNwNqr7AeoMTGDCshAhtNxwLb1j/pAoSXFXZG/TB5sNKCcMfFpzp2VGzw9TbFTUQfOsUQEU4HfFkuy9KBRyfe3IUUzS/0PH6Uw8XxQw5+rq1JUy3EF7nyOzkrqC3WbbBO4aT6nVseVJhh0BWU5hzqD60rKSWhgMVLgNMx7G+jZlGQdZTBKQbv9CscCJpBQTaMau+Arq6/TBckmxqsOVS8ie6KnV+/ulrHTSWErJyjjDQX+8/jbQfU+DiJ1SJ349Oy6h+22ou7nXU9iyzird3Dh51lk6o1ggPy1xTYtk1zwMnIO+GuYbtCYgkmVE9mhN2YKVW9m8R6TkKVtc3YThHg926vIHFfVLDVYMyNGm0nl+iC5D1UWHJ3Y1SO6i1ZoeED4sDxRzGzfY34pl4pvHOCKm0D8L2iNzF/k0yfm6S4YduiM67bR3bah7OD9Ex3Uf+y98GQ/FQZTSdPhiHskgzmPAJL5ip7MASEjhIskVnzlmlNyMu+lNN2U+qgJzbmuncKhvSFtEUN2fTkaemTAkSPCYEFrIgnrdquRaiOpS9edzi3kcMqvm4zJsJ1WPjInuE5ufvQPHVF7XJk6gQ8tNPC0FfudDjclSWKZA9qiR+hgsyk1UTyG3i/Z8zpKTTK2la8kH9+0ZN0mutwPYuBXhEMDPUIba0JkbFexP0vTkOtPBgZoPDPzfh1fifBtdttb3ghIbhwT9/scQGW+bq7P2NcwSuVA4ETnybUXtAsrUllC7Gc94aWioneAA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR1101MB2121.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c1c7673b-badd-4f6e-cee9-08d884d620c9 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2020 17:37:27.9780 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: J8MQXbt6kOJqCjO3IIFt09o683C2lD2NEnrY6Hsi+ogJodxTFBvx4PJ8wNiNwPD475Hz2KInhXgm/p0lHUPa/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1866 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v1] app/test: zcd needs to be initialised to fix gcc compile error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > From: Honnappa Nagarahalli > Sent: Monday 9 November 2020 17:24 > To: Walsh, Conor ; Ananyev, Konstantin > > Cc: dev@dpdk.org; Chen, LingliX ; nd > ; Honnappa Nagarahalli ; > nd > Subject: RE: [PATCH v1] app/test: zcd needs to be initialised to fix gcc = compile > error >=20 > >=20 > > > > > > > > Hi Honnappa, > > > > > > > > Sorry about the delayed reply. > > > No problem, thank you. > > > > > > > The build error trace is below, the build command used was: CC=3Dgc= c > > > > meson > > > -- > > > > optimization=3D1 --werror build1; ninja -C build1 I am not sure how= I > > > > could fix this issue without initialising zcd. > > > > >=20 > >=20 > > > > In file included from ../app/test/test_ring_mt_peek_stress_zc.c:5: > > > > ../app/test/test_ring_stress_impl.h: In function 'test_worker': > > > > ../app/test/test_ring.h:82:3: error: 'zcd.n1' may be used > > > > uninitialized in this function [-Werror=3Dmaybe-uninitialized] > > > > test_ring_mem_copy(zcd->ptr2, src, > > > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > > esize, num - zcd->n1); > > > > ~~~~~~~~~~~~~~~~~~~~~ > > > > ../app/test/test_ring_mt_peek_stress_zc.c:32:26: note: 'zcd.n1' was > > > declared > > > > here > > > > struct rte_ring_zc_data zcd; > > > > ^~~ > > > > In file included from ../app/test/test_ring_mt_peek_stress_zc.c:5: > > > > ../app/test/test_ring.h:67:2: error: '*((void *)&zcd+8)' may be use= d > > > > uninitialized in this function [-Werror=3Dmaybe-uninitialized] > > > > memcpy(dst, src, sz); > > > > ^~~~~~~~~~~~~~~~~~~~ > > > > ../app/test/test_ring_mt_peek_stress_zc.c:32:26: note: '*((void > > > *)&zcd+8)' > > > > was declared here > > > I remember seeing a similar error in test_ring_st_peek_stress_zc.c. > > > In the file test_ring_mt_peek_stress_zc.c, after the call to > > > enqueue/dequeue API calls, we have: > > > "n =3D (m =3D=3D n) ? n : 0;" > > > > > > This is present as the code was copied from existing code. I do not > > > see why this line is required. Can you please try to remove this line > > > and see if it works? > > > > I commented out all occurrences of that line in > test_ring_mt_peek_stess_zc.c > > and the build is still failing. > > Trace at end of email. > Thanks for checking the suggestion. Can you provide your setup details? O= S > and gcc version would be good. I would like to try it. Sure no problem, the error doesn't seem to affect gcc versions > 8. My setup is CentOS8.2 with kernel 4.18.0-193.28.1.el8_2.x86_64 and gcc 8.3.= 1. >=20 > >=20 > > > > [2339/2407] Compiling C object app/test/dpdk- > > test.p/test_ring_mt_peek_stress_zc.c.o > > FAILED: app/test/dpdk-test.p/test_ring_mt_peek_stress_zc.c.o > > gcc -Iapp/test/dpdk-test.p -Iapp/test -I../app/test -Ilib/librte_acl - > > I../lib/librte_acl -I. -I.. -Iconfig -I../config -Ilib/librte_eal/inclu= de - > > I../lib/librte_eal/include -Ilib/librte_eal/linux/include - > > I../lib/librte_eal/linux/include -Ilib/librte_eal/x86/include - > > I../lib/librte_eal/x86/include -Ilib/librte_eal/common - > > I../lib/librte_eal/common -Ilib/librte_eal -I../lib/librte_eal - > Ilib/librte_kvargs - > > I../lib/librte_kvargs -Ilib/librte_metrics -I../lib/librte_metrics - > > Ilib/librte_telemetry -I../lib/librte_telemetry -Idrivers/bus/pci - > > I../drivers/bus/pci -I../drivers/bus/pci/linux -Ilib/librte_pci -I../li= b/librte_pci > - > > Idrivers/bus/vdev -I../drivers/bus/vdev -Ilib/librte_bitratestats - > > I../lib/librte_bitratestats -Ilib/librte_ethdev -I../lib/librte_ethdev = - > > Ilib/librte_net -I../lib/librte_net -Ilib/librte_mbuf -I../lib/librte_m= buf - > > Ilib/librte_mempool -I../lib/librte_mempool -Ilib/librte_ring - > I../lib/librte_ring > > -Ilib/librte_meter -I../lib/librte_meter -Ilib/librte_bpf -I../lib/libr= te_bpf - > > Ilib/librte_cfgfile -I../lib/librte_cfgfile -Ilib/librte_cmdline - > I../lib/librte_cmdline > > -Ilib/librte_cryptodev -I../lib/librte_cryptodev -Ilib/librte_distribut= or - > > I../lib/librte_distributor -Ilib/librte_efd -I../lib/librte_efd -Ilib/l= ibrte_hash - > > I../lib/librte_hash -Ilib/librte_rcu -I../lib/librte_rcu -Ilib/librte_e= ventdev - > > I../lib/librte_eventdev -Ilib/librte_timer -I../lib/librte_timer -Ilib/= librte_fib - > > I../lib/librte_fib -Ilib/librte_rib -I../lib/librte_rib -Ilib/librte_fl= ow_classify - > > I../lib/librte_flow_classify -Ilib/librte_table -I../lib/librte_table - > Ilib/librte_port > > -I../lib/librte_port -Ilib/librte_sched -I../lib/librte_sched -Ilib/lib= rte_ip_frag > - > > I../lib/librte_ip_frag -Ilib/librte_kni -I../lib/librte_kni -Ilib/librt= e_lpm - > > I../lib/librte_lpm -Ilib/librte_graph -I../lib/librte_graph -Ilib/librt= e_ipsec - > > I../lib/librte_ipsec -Ilib/librte_security -I../lib/librte_security - > > Ilib/librte_latencystats -I../lib/librte_latencystats -Ilib/librte_memb= er - > > I../lib/librte_member -Ilib/librte_node -I../lib/librte_node - > Ilib/librte_pipeline > > -I../lib/librte_pipeline -Ilib/librte_rawdev -I../lib/librte_rawdev - > > Ilib/librte_reorder -I../lib/librte_reorder -Ilib/librte_stack - > I../lib/librte_stack - > > Idrivers/mempool/ring -I../drivers/mempool/ring -Idrivers/mempool/stack > - > > I../drivers/mempool/stack -Idrivers/event/skeleton - > > I../drivers/event/skeleton -Idrivers/net/bonding -I../drivers/net/bondi= ng - > > Idrivers/net/ring -I../drivers/net/ring -Ilib/librte_power - > I../lib/librte_power - > > Ilib/librte_pdump -I../lib/librte_pdump -Idrivers/crypto/scheduler - > > I../drivers/crypto/scheduler -fdiagnostics-color=3Dalways -pipe - > > D_FILE_OFFSET_BITS=3D64 -Wall -Winvalid-pch -Werror -O1 -include > > rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat-nonliteral - > > Wformat-security -Wmissing-declarations -Wmissing-prototypes - > Wnested- > > externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict- > > prototypes -Wundef -Wwrite-strings -Wno-packed-not-aligned -Wno- > missing- > > field-initializers -march=3Dnative -mno-avx512f - > DALLOW_EXPERIMENTAL_API - > > Wno-format-truncation -D_GNU_SOURCE -fno-strict-aliasing - > > DALLOW_INTERNAL_API -MD -MQ app/test/dpdk- > > test.p/test_ring_mt_peek_stress_zc.c.o -MF app/test/dpdk- > > test.p/test_ring_mt_peek_stress_zc.c.o.d -o app/test/dpdk- > > test.p/test_ring_mt_peek_stress_zc.c.o -c > > ../app/test/test_ring_mt_peek_stress_zc.c > > ../app/test/test_ring_mt_peek_stress_zc.c: In function > > '_st_ring_dequeue_bulk': > > ../app/test/test_ring_mt_peek_stress_zc.c:13:11: error: variable 'm' se= t > but > > not used [-Werror=3Dunused-but-set-variable] > > uint32_t m; > > ^ > > ../app/test/test_ring_mt_peek_stress_zc.c: In function > > '_st_ring_enqueue_bulk': > > ../app/test/test_ring_mt_peek_stress_zc.c:31:11: error: variable 'm' se= t > but > > not used [-Werror=3Dunused-but-set-variable] > > uint32_t m; > > ^ > I am not sure why you are seeing the above error. m is being set but is only being used in the line that I commented out, if = that line needs to be removed then m doesn't need to be set or declared. E.g. below. test_ring_mt_peek_stress_zc.c:9 static inline uint32_t _st_ring_dequeue_bulk(struct rte_ring *r, void **obj, uint32_t n, uint32_t *avail) { uint32_t m; struct rte_ring_zc_data zcd; m =3D rte_ring_dequeue_zc_bulk_start(r, n, &zcd, avail); //n =3D (m =3D=3D n) ? n : 0; if (n !=3D 0) { /* Copy the data from the ring */ test_ring_copy_from(&zcd, obj, -1, n); rte_ring_dequeue_zc_finish(r, n); } return n; } Thanks for looking into this. >=20 >