DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Walsh, Conor" <conor.walsh@intel.com>
To: Luca Boccassi <bluca@debian.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 0/2] build: add Wformat to fix gcc compile warnings and format fixes
Date: Thu, 19 Nov 2020 10:24:52 +0000
Message-ID: <DM5PR1101MB212181936CB358A6D839647CFFE00@DM5PR1101MB2121.namprd11.prod.outlook.com> (raw)
In-Reply-To: <3381c6393a6b77be78624f4401d6760c22ebdb3b.camel@debian.org>

Thank you for your feedback Luca,
I pushed a v3 that now has stable cc'ed.
/Conor

> From: Luca Boccassi <bluca@debian.org>
> Sent: Wednesday 18 November 2020 18:38
> To: Walsh, Conor <conor.walsh@intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; ajit.khaparde@broadcom.com;
> somnath.kotur@broadcom.com; stuart.schacher@broadcom.com;
> venkatkumar.duvvuru@broadcom.com; michael.wildt@broadcom.com
> Cc: dev@dpdk.org; Chen, LingliX <linglix.chen@intel.com>;
> thomas@monjalon.net
> Subject: Re: [dpdk-dev] [PATCH v2 0/2] build: add Wformat to fix gcc compile
> warnings and format fixes
> 
> On Wed, 2020-11-18 at 18:11 +0000, Conor Walsh wrote:
> > On some systems Wformat-nonliteral and Wformat-security could not be
> > checked without Wformat also being specified this causes a compile
> > warning on these systems. This patchset adds Wformat to
> > config/meson.build and fixes some format issues that this exposed.
> >
> > ---
> >
> > v2:
> > - expand explaination of patches
> > - suppress false postives in icc
> > - add fixes for format issues
> >
> > Conor Walsh (2):
> >   build: fix gcc compile warnings by adding wformat
> >   net/bnxt: fix format characters for unsigned values
> >
> >  config/meson.build                 | 3 ++-
> >  drivers/net/bnxt/tf_core/tf_core.c | 8 ++++----
> >  2 files changed, 6 insertions(+), 5 deletions(-)
> 
> Looks good to me, but it should be cc'ed to stable as well I think
> 
> --
> Kind regards,
> Luca Boccassi

  reply	other threads:[~2020-11-19 10:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-12 11:35 [dpdk-dev] [PATCH v1] build: add Wformat to fix gcc compile error Conor Walsh
2020-11-12 18:47 ` Thomas Monjalon
2020-11-13 13:54   ` Walsh, Conor
2020-11-13  3:39 ` Chen, LingliX
2020-11-18 18:11 ` [dpdk-dev] [PATCH v2 0/2] build: add Wformat to fix gcc compile warnings and format fixes Conor Walsh
2020-11-18 18:11   ` [dpdk-dev] [PATCH v2 1/2] build: fix gcc compile warnings by adding wformat Conor Walsh
2020-11-18 18:11   ` [dpdk-dev] [PATCH v2 2/2] net/bnxt: fix format characters for unsigned values Conor Walsh
2020-11-18 18:37   ` [dpdk-dev] [PATCH v2 0/2] build: add Wformat to fix gcc compile warnings and format fixes Luca Boccassi
2020-11-19 10:24     ` Walsh, Conor [this message]
2020-11-19 10:16   ` [dpdk-dev] [PATCH v3 " Conor Walsh
2020-11-19 10:16     ` [dpdk-dev] [PATCH v3 1/2] build: fix gcc compile warnings by adding wformat Conor Walsh
2020-11-20  7:23       ` Chen, LingliX
2020-11-19 10:17     ` [dpdk-dev] [PATCH v3 2/2] net/bnxt: fix format characters for unsigned values Conor Walsh
2020-11-19 23:12       ` Ajit Khaparde
2020-11-22 20:07     ` [dpdk-dev] [dpdk-stable] [PATCH v3 0/2] build: add Wformat to fix gcc compile warnings and format fixes Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM5PR1101MB212181936CB358A6D839647CFFE00@DM5PR1101MB2121.namprd11.prod.outlook.com \
    --to=conor.walsh@intel.com \
    --cc=bluca@debian.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git