From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5857CA052A; Thu, 26 Nov 2020 15:01:11 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 19B1EC940; Thu, 26 Nov 2020 15:01:09 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 7F7D8C93A; Thu, 26 Nov 2020 15:01:05 +0100 (CET) IronPort-SDR: E/WfHy2p6JqLvgmCFekWZclwT2M5RK3z2Cx7rTsKUdI8VOygoZ/esnzLX2+cl2u+nQJCXYSLbw UAaAU6lbzEKg== X-IronPort-AV: E=McAfee;i="6000,8403,9816"; a="160060834" X-IronPort-AV: E=Sophos;i="5.78,372,1599548400"; d="scan'208";a="160060834" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Nov 2020 06:01:02 -0800 IronPort-SDR: Oqd0stLVEtCVtTJMB58orIsLMYmlJPAx+PRcxv0WHCGxFKq78eaJS4A//+zXVQayD6rp9O89+D VWUYgDEPLvIA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,372,1599548400"; d="scan'208";a="362815564" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga004.fm.intel.com with ESMTP; 26 Nov 2020 06:01:02 -0800 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 26 Nov 2020 06:01:02 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 26 Nov 2020 06:01:02 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 26 Nov 2020 06:01:01 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ew27GPpkLq/uXTcIYNLI3d2ZfJzXfjaHZgL1SL8vjMhSKEgTb++1CDV57d+5vr60jHwhnJN5WDxWcMOcFJsitIkhenuZK4DhRZ2ajuLYJplFtSipvBo5A4WRLfzPc5SM5dFNoZipu6USm90T/7rMODL9LSTc+cktaF1QYdiz5/si8eyzPWMWPlUZvW2I1R8op4H3lTP4tI5b8HidtbP9x7r74+Uj8DSau+1CbNsshcDWiHNtX+YHduONasqtsjgSEgLLWdxr6aJyEU8fD6WYS84jNZIdoUN5tx0KiIt3z12csSKthXdItMTTC6jPNhjImYj/K9TrMzWqz3R6uvxE1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5/7TJF/NZqm+weRhj2Txamosn7Feg5XRvpQpsq1gziQ=; b=LV1AMsveOATWaTGgzXKEJdMsgGFEtMMzkIeptIlUFsTxmJQ9q+4B7dBiRuZRE1xMZjTSl5nOOvf3xkXp9jQeGn7ot0z0ouzurrjSV/5VD8pKPPhcVVWW5/c4lYOLHKdb272DNVJzCqQxDSJeJwJ8h1DlRXSMl5G4Cnt7ZYNRBLEXBMaESXV5EgVI+cPcWdaXZUy75xDT89XPsN3fdDNPBtKKPNa96E0lRTmMmmFPaduy4qrvmruEXLvsCo0Wt5a9F8B09+86FY9VUKojfpGbZjTNP7pDeVBQven9KnsoLrO3vcn0Y8PBy81v/hJPTo2cEIm6AQYbVowX+kbJiwBHdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5/7TJF/NZqm+weRhj2Txamosn7Feg5XRvpQpsq1gziQ=; b=LWlDAq7wQUWcWRg1hSir+VbhLLzIBfYrsubxVUw+wSmafuhRhegINbwTP41Ij5apdIJac4xkJJJkil6pIvJNg1xYwbOgP/aX3o/v8P0kpvGF4lw0O0XfFZYfgnj4ADYHXRhsDfYHyiv+P2NvjGh4DbcEJPElXeOiP1sAlDaeub0= Received: from DM5PR1101MB2121.namprd11.prod.outlook.com (2603:10b6:4:50::19) by DM6PR11MB3964.namprd11.prod.outlook.com (2603:10b6:5:19c::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3611.22; Thu, 26 Nov 2020 14:00:58 +0000 Received: from DM5PR1101MB2121.namprd11.prod.outlook.com ([fe80::283c:db65:84a4:b621]) by DM5PR1101MB2121.namprd11.prod.outlook.com ([fe80::283c:db65:84a4:b621%10]) with mapi id 15.20.3611.022; Thu, 26 Nov 2020 14:00:58 +0000 From: "Walsh, Conor" To: "Yigit, Ferruh" , Thomas Monjalon CC: "dev@dpdk.org" , "techboard@dpdk.org" , Stephen Hemminger , "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH 2/6] usertools/setup: remove inserting custom kernel modules Thread-Index: AQHWw2AOfL82Yj9fy06eSIu00xVJDqnacjYg Date: Thu, 26 Nov 2020 14:00:58 +0000 Message-ID: References: <20201125191908.1867106-1-ferruh.yigit@intel.com> <20201125191908.1867106-3-ferruh.yigit@intel.com> In-Reply-To: <20201125191908.1867106-3-ferruh.yigit@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [86.40.70.33] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fa891453-717b-4fe3-2033-08d89213b37c x-ms-traffictypediagnostic: DM6PR11MB3964: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HXFbXGWcXsBasGmHOf74Di3doBEwTiSELyn606+ku2eZBfb8EfRAcXQV3Kd7xpbZrCOEnLnBAxtAFPFwhHaHBqrP8y1KiyQqY9N/6D6mZwkH42b+yOraH1vg5c92ThQOmB46n8R8I5jev/YrTk1wj4KSj+XPYkNb3kbF5l35D87y04V5BjjKPjDIQ3f+Hg3ycVQsnDC5JJ03jdd3kFenG3yynmXO4UGXyoquHVZkPNi/Jvm0D6NmTURgtznqODmVnszfOUir9YrRC7bTzPea4c4xk6KoZ/GnzuVKy6PRXOKf6rn/RTHpchMwjEGVq0Q/wxYc9VzYlFoREgGeN9mKmaTWRjNrzK614cMroHq9WkNAz6npkNFvBhiOhHZQV1y7nZ5ga6qUqoasAxjVgCyh7Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR1101MB2121.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(346002)(376002)(39860400002)(366004)(136003)(316002)(71200400001)(52536014)(26005)(83380400001)(186003)(5660300002)(110136005)(54906003)(86362001)(66946007)(2906002)(33656002)(107886003)(66476007)(66446008)(64756008)(66556008)(4326008)(7696005)(76116006)(966005)(8936002)(6506007)(53546011)(55016002)(478600001)(9686003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?NC9PtjuNwQi0fqaLLfLC721F9H0ETB9Mz0Z+LeBMEhS0+Ei3b3rZuiDR6/yA?= =?us-ascii?Q?PG8em+u91rzRFIDlbtDbuzxp+dlKQy1Td6WUJyrhW213f+KYSHu3GLomppJ0?= =?us-ascii?Q?nB4blYcQF0cLeef5iYFx1UZAm4jlCLrRGpUoiGP4qNfG7PcMAkAk2PGR+bxX?= =?us-ascii?Q?iM2TSSpr86cLLj2PBsGLDt9dw86d1a3AlRKm/f9FQ4SGC6LGHPnTEQBAOtgO?= =?us-ascii?Q?FiUnLICwqRCadJuXGzHbdaTh8M17ZPReXxislPZBOt4tJ83shvXIdK0FOcKp?= =?us-ascii?Q?0TQd67z22K12EJRsh1YjjTTWufGjEISrUjhfuB39qK1bBP7XBm4n94dDmwkQ?= =?us-ascii?Q?hxwv3Zb9jjjSSGEyfpNou6/kei25zV24hkwncaPJ7NmuCZ0GmJu1HPj3B5aA?= =?us-ascii?Q?rv7Lm079uQesBw0F3sxm/nR6vHJrJznggugqPho+GlBue5gUqlOn0pAeEmEk?= =?us-ascii?Q?b72vQ6Dw7pArOC2kLCGA7OiS8bhMAqaPSTqXjTtW7CotkTL4Xgtrd4oFGPbr?= =?us-ascii?Q?nzQN8D4rpvT16nGSv3kdWEbJDphL9/yVfir5OVwxtvMYXHzfYA8W0ay+DNne?= =?us-ascii?Q?b+J/BR5N/rlKKttqxrUDHiscrVSBEYy8dBIeP2I/kri/HDvR4yYXH3CoCNvW?= =?us-ascii?Q?0fRwHTYZOmBGNU8ZMahBwV7c+ivxIlwOFdcnF3CNqjoXcV7e/YqQRMoAC+qo?= =?us-ascii?Q?TdCrTZDZnmtgODEdCSu4kCzrrDPOHApx28aoMtt2Bj4CPngB9iFwVlRcyLDM?= =?us-ascii?Q?Uxnmsr1jcl9dJtqV9BoGkdEQgbapbSfP7YU/BlNnQsIkFUk139lNoH0tjj0s?= =?us-ascii?Q?7VuROncOGP2ShXjBQcjnHI2wAFuI29eapHgoFALIa5k4ev2JihXYKcm4rLJu?= =?us-ascii?Q?jxr9+ea35G6/oh16igrmC/3YnytGvaTkO0l7f5Y9vP0NFPFdd+hBarooXG/c?= =?us-ascii?Q?xMOAs7F2/8O3fMGIGs7WO1yXiBzwby+On0gQI6kNwOA=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR1101MB2121.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fa891453-717b-4fe3-2033-08d89213b37c X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Nov 2020 14:00:58.5425 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Vv5+nt0CGm8HyZAt/wjwsy4MeTT5UvFEZEv2likIWYxmIZQCywsjY+ymgiE8bWUXsfsCYCHaCMl4mOROE8xI8Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3964 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 2/6] usertools/setup: remove inserting custom kernel modules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ferruh, Patch tested. Thanks, Conor. > -----Original Message----- > From: dev On Behalf Of Ferruh Yigit > Sent: Wednesday 25 November 2020 19:19 > To: Thomas Monjalon > Cc: Yigit, Ferruh ; dev@dpdk.org; > techboard@dpdk.org; Stephen Hemminger > ; Richardson, Bruce > > Subject: [dpdk-dev] [PATCH 2/6] usertools/setup: remove inserting custom > kernel modules >=20 > Custom DPDK kernel module insert support relies on make based build > variable 'RTE_TARGET' to find the location of the kernel modules, which > is not valid anymore. >=20 > Also 'igb_uio' kernel module moved to another git repository: > https://git.dpdk.org/dpdk-kmods/ >=20 > Signed-off-by: Ferruh Yigit Tested-by: Conor Walsh > --- > usertools/dpdk-setup.sh | 91 +++++++---------------------------------- > 1 file changed, 14 insertions(+), 77 deletions(-) >=20 > diff --git a/usertools/dpdk-setup.sh b/usertools/dpdk-setup.sh > index d1eb188692a6..bcf0c843678f 100755 > --- a/usertools/dpdk-setup.sh > +++ b/usertools/dpdk-setup.sh > @@ -78,39 +78,6 @@ remove_igb_uio_module() > fi > } >=20 > -# > -# Loads new igb_uio.ko (and uio module if needed). > -# > -load_igb_uio_module() > -{ > - if [ ! -f $RTE_SDK/$RTE_TARGET/kmod/igb_uio.ko ];then > - echo "## ERROR: Target does not have the DPDK UIO Kernel > Module." > - echo " To fix, please try to rebuild target." > - return > - fi > - > - remove_igb_uio_module > - > - /sbin/lsmod | grep -s uio > /dev/null > - if [ $? -ne 0 ] ; then > - modinfo uio > /dev/null > - if [ $? -eq 0 ]; then > - echo "Loading uio module" > - sudo /sbin/modprobe uio > - fi > - fi > - > - # UIO may be compiled into kernel, so it may not be an error if it can'= t > - # be loaded. > - > - echo "Loading DPDK UIO module" > - sudo /sbin/insmod $RTE_SDK/$RTE_TARGET/kmod/igb_uio.ko > - if [ $? -ne 0 ] ; then > - echo "## ERROR: Could not load kmod/igb_uio.ko." > - quit > - fi > -} > - > # > # Unloads VFIO modules. > # > @@ -171,30 +138,6 @@ remove_kni_module() > fi > } >=20 > -# > -# Loads the rte_kni.ko module. > -# > -load_kni_module() > -{ > - # Check that the KNI module is already built. > - if [ ! -f $RTE_SDK/$RTE_TARGET/kmod/rte_kni.ko ];then > - echo "## ERROR: Target does not have the DPDK KNI > Module." > - echo " To fix, please try to rebuild target." > - return > - fi > - > - # Unload existing version if present. > - remove_kni_module > - > - # Now try load the KNI module. > - echo "Loading DPDK KNI module" > - sudo /sbin/insmod $RTE_SDK/$RTE_TARGET/kmod/rte_kni.ko > - if [ $? -ne 0 ] ; then > - echo "## ERROR: Could not load kmod/rte_kni.ko." > - quit > - fi > -} > - > # > # Sets appropriate permissions on /dev/vfio/* files > # > @@ -416,32 +359,26 @@ step1_func() > { > TITLE=3D"Setup linux environment" >=20 > - TEXT[1]=3D"Insert IGB UIO module" > - FUNC[1]=3D"load_igb_uio_module" > - > - TEXT[2]=3D"Insert VFIO module" > - FUNC[2]=3D"load_vfio_module" > - > - TEXT[3]=3D"Insert KNI module" > - FUNC[3]=3D"load_kni_module" > + TEXT[1]=3D"Insert VFIO module" > + FUNC[1]=3D"load_vfio_module" >=20 > - TEXT[4]=3D"Setup hugepage mappings for non-NUMA systems" > - FUNC[4]=3D"set_non_numa_pages" > + TEXT[2]=3D"Setup hugepage mappings for non-NUMA systems" > + FUNC[2]=3D"set_non_numa_pages" >=20 > - TEXT[5]=3D"Setup hugepage mappings for NUMA systems" > - FUNC[5]=3D"set_numa_pages" > + TEXT[3]=3D"Setup hugepage mappings for NUMA systems" > + FUNC[3]=3D"set_numa_pages" >=20 > - TEXT[6]=3D"Display current Ethernet/Baseband/Crypto device settings" > - FUNC[6]=3D"show_devices" > + TEXT[4]=3D"Display current Ethernet/Baseband/Crypto device settings" > + FUNC[4]=3D"show_devices" >=20 > - TEXT[7]=3D"Bind Ethernet/Baseband/Crypto device to IGB UIO > module" > - FUNC[7]=3D"bind_devices_to_igb_uio" > + TEXT[5]=3D"Bind Ethernet/Baseband/Crypto device to IGB UIO > module" > + FUNC[5]=3D"bind_devices_to_igb_uio" >=20 > - TEXT[8]=3D"Bind Ethernet/Baseband/Crypto device to VFIO module" > - FUNC[8]=3D"bind_devices_to_vfio" > + TEXT[6]=3D"Bind Ethernet/Baseband/Crypto device to VFIO module" > + FUNC[6]=3D"bind_devices_to_vfio" >=20 > - TEXT[9]=3D"Setup VFIO permissions" > - FUNC[9]=3D"set_vfio_permissions" > + TEXT[7]=3D"Setup VFIO permissions" > + FUNC[7]=3D"set_vfio_permissions" > } >=20 > # > -- > 2.26.2