DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Walsh, Conor" <conor.walsh@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
	Thomas Monjalon <thomas@monjalon.net>
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"techboard@dpdk.org" <techboard@dpdk.org>,
	Stephen Hemminger <stephen@networkplumber.org>,
	"Richardson, Bruce" <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH 1/6] usertools/setup: remove make based build
Date: Thu, 26 Nov 2020 13:56:46 +0000
Message-ID: <DM5PR1101MB2121CF6F865398904286A94EFFF90@DM5PR1101MB2121.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20201125191908.1867106-2-ferruh.yigit@intel.com>

Hi Ferruh,

Patch tested.

Thanks,
Conor.

> From: dev <dev-bounces@dpdk.org> On Behalf Of Ferruh Yigit
> Sent: Wednesday 25 November 2020 19:19
> To: Thomas Monjalon <thomas@monjalon.net>
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; dev@dpdk.org;
> techboard@dpdk.org; Stephen Hemminger
> <stephen@networkplumber.org>; Richardson, Bruce
> <bruce.richardson@intel.com>
> Subject: [dpdk-dev] [PATCH 1/6] usertools/setup: remove make based build
> 
> DPDK build system is switched to 'meson' based build, please check the
> documentation for details: "doc/guides/linux_gsg/build_dpdk.rst"
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Tested-by: Conor Walsh <conor.walsh@intel.com>

> ---
>  usertools/dpdk-setup.sh | 74 +++--------------------------------------
>  1 file changed, 4 insertions(+), 70 deletions(-)
> 
> diff --git a/usertools/dpdk-setup.sh b/usertools/dpdk-setup.sh
> index 411bf2e07f5e..d1eb188692a6 100755
> --- a/usertools/dpdk-setup.sh
> +++ b/usertools/dpdk-setup.sh
> @@ -36,53 +36,6 @@ q()
>  	quit
>  }
> 
> -#
> -# Sets up environmental variables for ICC.
> -#
> -setup_icc()
> -{
> -	DEFAULT_PATH=/opt/intel/bin/iccvars.sh
> -	param=$1
> -	shpath=`which iccvars.sh 2> /dev/null`
> -	if [ $? -eq 0 ] ; then
> -		echo "Loading iccvars.sh from $shpath for $param"
> -		source $shpath $param
> -	elif [ -f $DEFAULT_PATH ] ; then
> -		echo "Loading iccvars.sh from $DEFAULT_PATH for $param"
> -		source $DEFAULT_PATH $param
> -	else
> -		echo "## ERROR: cannot find 'iccvars.sh' script to set up ICC."
> -		echo "##     To fix, please add the directory that contains"
> -		echo "##     iccvars.sh  to your 'PATH' environment variable."
> -		quit
> -	fi
> -}
> -
> -#
> -# Sets RTE_TARGET and does a "make install".
> -#
> -setup_target()
> -{
> -	option=$1
> -	export RTE_TARGET=${TARGETS[option]}
> -
> -	compiler=${RTE_TARGET##*-}
> -	if [ "$compiler" == "icc" ] ; then
> -		platform=${RTE_TARGET%%-*}
> -		if [ "$platform" == "x86_64" ] ; then
> -			setup_icc intel64
> -		else
> -			setup_icc ia32
> -		fi
> -	fi
> -	if [ "$QUIT" == "0" ] ; then
> -		make install T=${RTE_TARGET}
> -	fi
> -	echo "----------------------------------------------------------------------------
> --"
> -	echo " RTE_TARGET exported as $RTE_TARGET"
> -	echo "----------------------------------------------------------------------------
> --"
> -}
> -
>  #
>  # Creates hugepage filesystem.
>  #
> @@ -456,28 +409,10 @@ unbind_devices()
>  	sudo ${RTE_SDK}/usertools/dpdk-devbind.py -b $DRV $PCI_PATH
> && echo "OK"
>  }
> 
> -#
> -# Options for building a target. Note that this step MUST be first as it sets
> -# up TARGETS[] starting from 1, and this is accessed in setup_target using
> the
> -# user entered option.
> -#
> -step1_func()
> -{
> -	TITLE="Select the DPDK environment to build"
> -	CONFIG_NUM=1
> -	for cfg in config/defconfig_* ; do
> -		cfg=${cfg/config\/defconfig_/}
> -		TEXT[$CONFIG_NUM]="$cfg"
> -		TARGETS[$CONFIG_NUM]=$cfg
> -		FUNC[$CONFIG_NUM]="setup_target"
> -		let "CONFIG_NUM+=1"
> -	done
> -}
> -
>  #
>  # Options for setting up environment.
>  #
> -step2_func()
> +step1_func()
>  {
>  	TITLE="Setup linux environment"
> 
> @@ -512,7 +447,7 @@ step2_func()
>  #
>  # Options for running applications.
>  #
> -step3_func()
> +step2_func()
>  {
>  	TITLE="Run test application for linux environment"
> 
> @@ -526,7 +461,7 @@ step3_func()
>  #
>  # Other options
>  #
> -step4_func()
> +step3_func()
>  {
>  	TITLE="Other tools"
> 
> @@ -538,7 +473,7 @@ step4_func()
>  #
>  # Options for cleaning up the system
>  #
> -step5_func()
> +step4_func()
>  {
>  	TITLE="Uninstall and system cleanup"
> 
> @@ -562,7 +497,6 @@ STEPS[1]="step1_func"
>  STEPS[2]="step2_func"
>  STEPS[3]="step3_func"
>  STEPS[4]="step4_func"
> -STEPS[5]="step5_func"
> 
>  QUIT=0
> 
> --
> 2.26.2


  reply	other threads:[~2020-11-26 13:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-25 19:19 [dpdk-dev] [PATCH 0/6] update dpdk-setup.sh Ferruh Yigit
2020-11-25 19:19 ` [dpdk-dev] [PATCH 1/6] usertools/setup: remove make based build Ferruh Yigit
2020-11-26 13:56   ` Walsh, Conor [this message]
2020-11-25 19:19 ` [dpdk-dev] [PATCH 2/6] usertools/setup: remove inserting custom kernel modules Ferruh Yigit
2020-11-26 14:00   ` Walsh, Conor
2020-11-25 19:19 ` [dpdk-dev] [PATCH 3/6] usertools/setup: remove running built applications Ferruh Yigit
2020-11-26 14:02   ` Walsh, Conor
2020-11-26 14:04     ` Thomas Monjalon
2020-11-25 19:19 ` [dpdk-dev] [PATCH 4/6] usertools/setup: remove hugepage functions Ferruh Yigit
2020-11-26 14:10   ` Walsh, Conor
2020-11-25 19:19 ` [dpdk-dev] [PATCH 5/6] usertools/setup: fix loading vfio module Ferruh Yigit
2020-11-25 19:19 ` [dpdk-dev] [PATCH 6/6] usertools/setup: move removal target to 21.11 Ferruh Yigit
2020-11-27 13:57 ` [dpdk-dev] [PATCH 0/6] update dpdk-setup.sh Burakov, Anatoly
2020-11-27 14:12   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM5PR1101MB2121CF6F865398904286A94EFFF90@DM5PR1101MB2121.namprd11.prod.outlook.com \
    --to=conor.walsh@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=stephen@networkplumber.org \
    --cc=techboard@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git