Re: [dpdk-dev] [PATCH v1] vhost: fix async callback return type define

["Fu, Patrick" <patrick.fu@intel.com>]

Hi Maxime,

> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Tuesday, July 28, 2020 5:10 PM
> To: Fu, Patrick <patrick.fu@intel.com>; dev@dpdk.org; Xia, Chenbo
> <chenbo.xia@intel.com>
> Subject: Re: [PATCH v1] vhost: fix async callback return type define
> 
> 
> 
> On 7/23/20 7:39 AM, patrick.fu@intel.com wrote:
> > From: Patrick Fu <patrick.fu@intel.com>
> >
> >  	 * @return
> > -	 *  -1 on failure, number of iov segments completed on success
> > +	 *  number of iov segments completed on success
> Ditto
> 
> >  	 */
> > -	int (*check_completed_copies)(int vid, uint16_t queue_id,
> > +	uint32_t (*check_completed_copies)(int vid, uint16_t queue_id,
> >  		struct rte_vhost_async_status *opaque_data,
> >  		uint16_t max_packets);
> >  };
> >
> 
> Other than that:
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> 
> I can fixup the comments while applying if you agree with it.
> 

Yes, I think removing "on success" is correct there.

Thanks,

Patrick