DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: "Sun, GuinanX" <guinanx.sun@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
	"Yang, Qiming" <qiming.yang@intel.com>,
	"Sun, GuinanX" <guinanx.sun@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>,
	"Guo, Jia" <jia.guo@intel.com>
Subject: Re: [dpdk-dev] [PATCH v6] net/ixgbe: fix macsec setting
Date: Mon, 18 May 2020 02:56:25 +0000	[thread overview]
Message-ID: <DM5PR11MB1387742348D869098F2AFF0FB7B80@DM5PR11MB1387.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20191031113152.3587-1-guinanx.sun@intel.com>


Hi, Guinian

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Sun GuinanX
> Sent: Thursday, October 31, 2019 7:32 PM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>; Sun, GuinanX <guinanx.sun@intel.com>;
> stable@dpdk.org
> Subject: [dpdk-dev] [PATCH v6] net/ixgbe: fix macsec setting
> 
> macsec setting is not valid when port is stopped.
> In order to make it valid, the patch changes the setting to where port is
> started.
> 
> Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Sun GuinanX <guinanx.sun@intel.com>
> 19 ++++  drivers/net/ixgbe/rte_pmd_ixgbe.c | 125 ++-----------------------
>  3 files changed, 175 insertions(+), 118 deletions(-)
> 
> diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.c
> b/drivers/net/ixgbe/rte_pmd_ixgbe.c
> index 9514f2cf5..073fe1e23 100644
> --- a/drivers/net/ixgbe/rte_pmd_ixgbe.c
> +++ b/drivers/net/ixgbe/rte_pmd_ixgbe.c
> @@ -515,82 +515,19 @@ rte_pmd_ixgbe_set_vf_rate_limit(uint16_t port,
> uint16_t vf,  int  rte_pmd_ixgbe_macsec_enable(uint16_t port, uint8_t en,
> uint8_t rp)  {
> -	struct ixgbe_hw *hw;
>  	struct rte_eth_dev *dev;
> -	uint32_t ctrl;
> +	struct ixgbe_macsec_setting macsec_setting;
> 
>  	RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV);
> 
>  	dev = &rte_eth_devices[port];
> 
> -	if (!is_ixgbe_supported(dev))
> -		return -ENOTSUP;

This driver type check of is_ixgbe_supported(dev), is very important for PRIVATE API function,
You can not delete it, Please add it back, rte_pmd_ixgbe_macsec_disable() also has this problem.
Although this patch has been merged, please commit fix patch for it, thanks!



> +	macsec_setting.encrypt_en = en;
> +	macsec_setting.replayprotect_en = rp;
> 
> -	hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> +	ixgbe_dev_macsec_setting_save(dev, &macsec_setting);
> 
> -	/* Stop the data paths */
> -	if (ixgbe_disable_sec_rx_path(hw) != IXGBE_SUCCESS)
> -		return -ENOTSUP;


      parent reply	other threads:[~2020-05-18  2:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-25  9:21 [dpdk-dev] [PATCH] " Sun GuinanX
2019-10-29  3:24 ` Ye Xiaolong
2019-10-29 16:32 ` [dpdk-dev] [PATCH v2] " Sun GuinanX
2019-10-29  9:03   ` Ye Xiaolong
2019-10-30  3:19     ` Sun, GuinanX
2019-10-30 10:43   ` [dpdk-dev] [PATCH v3] " Sun GuinanX
2019-10-30 11:31     ` [dpdk-dev] [PATCH v4] " Sun GuinanX
2019-10-30  5:34       ` Ye Xiaolong
2019-10-30 14:27       ` [dpdk-dev] [PATCH v5] " Sun GuinanX
2019-10-31  2:12         ` Ye Xiaolong
2019-10-31 11:31         ` [dpdk-dev] [PATCH v6] " Sun GuinanX
2019-11-01  2:25           ` Ye Xiaolong
2020-05-18  2:56           ` Zhao1, Wei [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM5PR11MB1387742348D869098F2AFF0FB7B80@DM5PR11MB1387.namprd11.prod.outlook.com \
    --to=wei.zhao1@intel.com \
    --cc=dev@dpdk.org \
    --cc=guinanx.sun@intel.com \
    --cc=jia.guo@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=stable@dpdk.org \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).