DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Yu, DapengX" <dapengx.yu@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"Li, Xiaoyun" <xiaoyun.li@intel.com>,
	"Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix queue Rx and Tx offload reconfig cmd
Date: Fri, 9 Apr 2021 05:25:10 +0000	[thread overview]
Message-ID: <DM5PR11MB1401627A53B813692F69A81F8C739@DM5PR11MB1401.namprd11.prod.outlook.com> (raw)
In-Reply-To: <500b55c4-6ec5-1466-8ddf-60728e9cefcb@intel.com>

> -----Original Message-----
> From: Yigit, Ferruh <ferruh.yigit@intel.com>
> Sent: Thursday, April 8, 2021 11:42 PM
> To: Yu, DapengX <dapengx.yu@intel.com>; Li, Xiaoyun
> <xiaoyun.li@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-stable] [PATCH] app/testpmd: fix queue Rx and Tx offload
> reconfig cmd
> On 4/1/2021 9:28 AM, dapengx.yu@intel.com wrote:
> > From: Dapeng Yu <dapengx.yu@intel.com>
> >
> > Configure per queue rx offloading and per queue tx offloading command
> > shouldn't trigger the rte_eth_dev_configure() to reconfigure device.
> >
> > The patch sets the queue reconfiguration flag only, and does not set
> > the device reconfiguration flag. Therefore after port is restarted,
> > rte_eth_dev_configure() will not be called again.
> >
> Just to clarify the impact, was calling 'rte_eth_dev_configure()' causing any
> problem, is this fixing any issue?
> Or is this patch an optimization to eliminate an unnecessary call?
This patch does fix an issue, and it also eliminates an unnecessary call.

The issue is: 
per-queue configuration, for example: port 0 rxq 0 rx_offload jumbo_frame off
triggers the per-device configuration change: the RSS key is reconfigured and changes
after rte_eth_dev_configure() is called on ICE PMD driver, that cause a test case failure.

There is an unnecessary call in original implementation because both 
cmd_config_per_queue_rx_offload_parsed() and cmd_config_per_queue_tx_offload_parsed() 
does not update the "port->dev_conf" which hold the port configuration, therefore there is no
need to call rte_eth_dev_configure().

  reply	other threads:[~2021-04-09  5:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-01  8:28 [dpdk-dev] " dapengx.yu
2021-04-07  2:30 ` Li, Xiaoyun
2021-04-08 15:41 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2021-04-09  5:25   ` Yu, DapengX [this message]
2021-04-09  7:50     ` Li, Xiaoyun
2021-04-09 10:29       ` Yu, DapengX
2021-04-12  2:21         ` Li, Xiaoyun
2021-04-12 12:46           ` Ferruh Yigit
2021-04-15  6:04             ` Yu, DapengX
2021-04-19 15:46               ` Ferruh Yigit
2021-04-20  8:12                 ` Yu, DapengX
2021-04-20  8:22                   ` Ferruh Yigit
2021-04-20  8:40                     ` Yu, DapengX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM5PR11MB1401627A53B813692F69A81F8C739@DM5PR11MB1401.namprd11.prod.outlook.com \
    --to=dapengx.yu@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=stable@dpdk.org \
    --cc=xiaoyun.li@intel.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).