DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] app/testpmd: fix queue Rx and Tx offload reconfig cmd
@ 2021-04-01  8:28 dapengx.yu
  2021-04-07  2:30 ` Li, Xiaoyun
  2021-04-08 15:41 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
  0 siblings, 2 replies; 13+ messages in thread
From: dapengx.yu @ 2021-04-01  8:28 UTC (permalink / raw)
  To: xiaoyun.li, qi.z.zhang; +Cc: dev, Dapeng Yu, stable

From: Dapeng Yu <dapengx.yu@intel.com>

Configure per queue rx offloading and per queue tx offloading command
shouldn't trigger the rte_eth_dev_configure() to reconfigure device.

The patch sets the queue reconfiguration flag only, and does not set the
device reconfiguration flag. Therefore after port is restarted,
rte_eth_dev_configure() will not be called again.

Fixes: c73a9071877a ("app/testpmd: add commands to test new offload API")
Cc: stable@dpdk.org

Signed-off-by: Dapeng Yu <dapengx.yu@intel.com>
---
 app/test-pmd/cmdline.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 14110eb2e..b49e9f52b 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -15626,7 +15626,7 @@ cmd_config_per_queue_rx_offload_parsed(void *parsed_result,
 	else
 		port->rx_conf[queue_id].offloads &= ~single_offload;
 
-	cmd_reconfig_device_queue(port_id, 1, 1);
+	cmd_reconfig_device_queue(port_id, 0, 1);
 }
 
 cmdline_parse_inst_t cmd_config_per_queue_rx_offload = {
@@ -16044,7 +16044,7 @@ cmd_config_per_queue_tx_offload_parsed(void *parsed_result,
 	else
 		port->tx_conf[queue_id].offloads &= ~single_offload;
 
-	cmd_reconfig_device_queue(port_id, 1, 1);
+	cmd_reconfig_device_queue(port_id, 0, 1);
 }
 
 cmdline_parse_inst_t cmd_config_per_queue_tx_offload = {
-- 
2.27.0


^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2021-04-20  8:40 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-01  8:28 [dpdk-dev] [PATCH] app/testpmd: fix queue Rx and Tx offload reconfig cmd dapengx.yu
2021-04-07  2:30 ` Li, Xiaoyun
2021-04-08 15:41 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2021-04-09  5:25   ` Yu, DapengX
2021-04-09  7:50     ` Li, Xiaoyun
2021-04-09 10:29       ` Yu, DapengX
2021-04-12  2:21         ` Li, Xiaoyun
2021-04-12 12:46           ` Ferruh Yigit
2021-04-15  6:04             ` Yu, DapengX
2021-04-19 15:46               ` Ferruh Yigit
2021-04-20  8:12                 ` Yu, DapengX
2021-04-20  8:22                   ` Ferruh Yigit
2021-04-20  8:40                     ` Yu, DapengX

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git