From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E9365A057B; Wed, 19 Oct 2022 11:21:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DBC6A40E03; Wed, 19 Oct 2022 11:21:36 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 46F6640A8B for ; Wed, 19 Oct 2022 11:21:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666171295; x=1697707295; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=3QoWSJLfFclH2PcSMM6jRxRewRMmegJ5PdWjaESdJ5g=; b=IRCI5LkCycsnrfNfQN810lrC/Ls4/oBhvPK1zBz9PyFmhb+8D7b7TFDo pdCsJV0vzFxlbib59r+LG3wGM3haES+qHBfHrfxnL2WDSZY3Q7Am9QT8N S6lj1Z390ZBxh2EO55NzZMzukfzxJO5QSxtqjxoPkpxUO1f8Cdp9Yo9IZ yCKwTYu2zmElZQN6mmy6IVh76R5NyQtYZT7UMFK8unrEZuh8x0UXWKLk+ xwHhTTuz1Kry8HAEFPw6vsZw1bQkYLXX/gqEEf4QI2zOlb0ryKKloLYxi 0ZqtulduuIeEQlKdlWPFibyIK9yV+A9HpsdmQpTm2DeoxoFcGEvBrEdzV Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="370575518" X-IronPort-AV: E=Sophos;i="5.95,195,1661842800"; d="scan'208";a="370575518" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2022 02:21:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="958248058" X-IronPort-AV: E=Sophos;i="5.95,195,1661842800"; d="scan'208";a="958248058" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga005.fm.intel.com with ESMTP; 19 Oct 2022 02:21:34 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 19 Oct 2022 02:21:34 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 19 Oct 2022 02:21:33 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 19 Oct 2022 02:21:33 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 19 Oct 2022 02:21:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KLqlslie4gdoDZyq/iEQ4dVTLBVZ0tZ2L1cNVRo3UEqydV42qw59u3ki6VIV/W4icgw8qdpYooHVts+x9QLOtDZeOWm/qN1VT3x8ZgmF+ItFo128v6v0QOuU+6hX+4E4HCdPIWGxa6kJa4EbPR0sdTXK77K318P2huhPFdAwFVnYswk/wZnNOf/dD1Kn50qnCfj3vruV9f5Az7Fp3Ytbr3jKZ2TGqOqFEIWefhX7O07Uj5tfLl3qaR6jb0BRuBGh2k647S900qbuHL6Nnzd4jGLWUmThrTPb3hndL/ZplVa0m13G8xA1EOVy1DDbd3xFKzpOK6b+LQguejh6IzubZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4NauxRqDlJZd9aL6W18DIb/7xZ0+UDaVxl8jRoV7iBw=; b=CDz/QPdPTUSMA/tLxTD+Wrp8p99H2nCEvmigSH+reieqgrQScnQcmycniCBP2J1aUcLdKaHnR+bRf8MkwV5YkIhfDLU4Wpp0oi1+oxWDpCiPMJXoAv5rVYfjZt40fERY21Zg5XQEL/j+eDk/EdpxZyT4JsemPply5sLUPmc/ayQ+zKitMIgbkEPaN7JEgjLPxZoKkDEMdN2EegFuAGLzLs4VmxJqNxM6jat+sBjmuOCfwCENbr6n9Zp9kDl2hdK0n4X4bAiOeFnndFr4rvf4Td7NTY4kF4DoJ7PW1l73mTm5zi/tpz+xq6cqbkylXvHH8VhYR7gd0ZubvqGNh1dT6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM5PR11MB1739.namprd11.prod.outlook.com (2603:10b6:3:111::22) by MN0PR11MB6256.namprd11.prod.outlook.com (2603:10b6:208:3c3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Wed, 19 Oct 2022 09:21:26 +0000 Received: from DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::b8d7:6a95:bf26:e4ef]) by DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::b8d7:6a95:bf26:e4ef%12]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022 09:21:26 +0000 From: "Pei, Andy" To: "Xia, Chenbo" , "dev@dpdk.org" CC: "Xu, Rosen" , "Huang, Wei" , "Cao, Gang" , "maxime.coquelin@redhat.com" Subject: RE: [PATCH v8 09/12] vdpa/ifc: change some driver logic Thread-Topic: [PATCH v8 09/12] vdpa/ifc: change some driver logic Thread-Index: AQHY45r+yadvdOL/oki1IdiuYSc/2K4VcP6Q Date: Wed, 19 Oct 2022 09:21:26 +0000 Message-ID: References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1666094871-25721-1-git-send-email-andy.pei@intel.com> <1666094871-25721-10-git-send-email-andy.pei@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM5PR11MB1739:EE_|MN0PR11MB6256:EE_ x-ms-office365-filtering-correlation-id: 26f23603-8252-4445-bde1-08dab1b34c2d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 63UcfjwILDAITb6Z7GxzzT8PnKIxqR0Hy5YFMgr/UFcRMG4LpmWXfYMoaYMu3DrZ+iDlpG3VBMumVpMPwPxRazsMBsedgR6bEbCEb0ydCGQMxIYu93adx+mhvqGzHuvXg/6gjufCpWaolqco295C1VBEDuUdN8c/w11BucAA7ECyYXi/Dw8doKa1kHlB4qbSv0418trs593bVKYLGm91b3G+i84v02I4jvOmTMjKlHj/xtVJCL6tcHx63OrJLFe5we1GNJlgBlEZ4pyvtiI/WBIjYe2SjquLPfg5z7y6x+0RdGI0KskAbHO72Hs6XVBmnB1J07C3671JrE/14g21SE2cT1V2GTQuvXScRuM9of/ZJCq2uhKw19yBPCvfUe2BpNsWOXUeLsCLvXQdwEBbiZa238F1Hi/cUBC6c9uzfHmir516I3IHUQDNnxZqKKJqFSMR4lulmzuWACoq/32KIR4P0nI77NS8CgBCUgy1ULGqR1nezV04bbR7YlkYRheMQnfy22pAL/0wM+GdNAtfRccH1Sz48xBvP5Xlfirk97gGpH2DMPyl7Bo64tpki9lX9zI02XvxISeF6M4tQccqPP3gGx5E2X4IAyfR8IVXAt1l5gwZRyUaxyPwaTvi4NCG9AMIPbUMI1MztUijSlBcNm+MN2ssgflwC2MxNb8G2tTa4hzEcgXRGvBbjMaZvptA/kr0rIClxENJKPUqUOkYOHMmoIg+mZ06thrVKJFuwYuRsLmc49WT3NGprfWTZiM0HPfDIp2DI6smQP92S/vj8g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR11MB1739.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(376002)(396003)(39860400002)(136003)(346002)(366004)(451199015)(5660300002)(110136005)(66446008)(66556008)(66476007)(54906003)(316002)(8676002)(7696005)(9686003)(66946007)(6506007)(41300700001)(53546011)(26005)(52536014)(2906002)(4326008)(71200400001)(8936002)(186003)(64756008)(478600001)(83380400001)(82960400001)(38070700005)(76116006)(38100700002)(122000001)(55016003)(33656002)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?N6Hd5c9pqDODgbRHlaZYrOQXlSWrNY9FrtYpFcwOa0D2lcX8Kp4LLroIluIc?= =?us-ascii?Q?GWf2P/ZBCjTU9aDSpEKsBzDgo0LsMm/ChdPgaX3HzU+3e1h/g1vVUYGQdDBV?= =?us-ascii?Q?sFMchMxvyf89iikS8KKCZp9iWsBjdBv478BfR9ww9x9ihScPQP1qIUub3sC8?= =?us-ascii?Q?uJzWBArIjC+x59P5n0Gye4dGdzsStwyEMdyXS9dMNsBOdNxxaZsmD71lgdYC?= =?us-ascii?Q?iGFZCCLcYUns1me3f2ZBCwFCRSjZtXep+HYnpXNe+I3bf2P8hE6QWpo+71nt?= =?us-ascii?Q?eulE/DGK752z5iU9/fr7eczZ+YIvhtQXNahzbZo7xyRr5SI79ucv0MW9/pBm?= =?us-ascii?Q?fptJeOw3jAxkIpjXENB6Z/5P18Pr7MDM/i0YR7qwN9EO1LR9fzLu8uTwQKcM?= =?us-ascii?Q?5A0jmijHjmW/PrzClEpCZn9lqUIq4biCM3UEybxEvApxztbihPNEKL+yWklD?= =?us-ascii?Q?LXlAsSgG2lufKY//ZiIJaqy5jr48t0tSKmSzQwWC30k3kVzCVT6Hgo76DuWr?= =?us-ascii?Q?ialdbNpT6or2XXXzoo00YzErJnca6hqtKgD/0+8m4gIc0juPLjZSBOu7J+QA?= =?us-ascii?Q?iBe4p6haZE+NC5nB3jVPEQ5FcgBDQxVpoVI87p0eRPvEA1GRvuU8yzGxt9Gw?= =?us-ascii?Q?TK23/KBTARu+tNRhPmhqLTnP3ULAR9VBLJVrpsBDr78vV4EWUdWUGoQM3kWL?= =?us-ascii?Q?Dx2oYe8R851gLKXRKVe3YvMIZNOUHmLh3HvHG0pRR6IN8uvmRdtAH3mE7hs9?= =?us-ascii?Q?+8JXf6JoCmCIfzDU1SZjs7D2EdmOX+Vm5G+gp+qK2PreZP0p2WYg9cIukPhj?= =?us-ascii?Q?ba1i9Qp0ifIdIWuqidmXfoMGLd6NEU5SZaDusP7TOjjcF0fnBUG2iXZ3fQVC?= =?us-ascii?Q?rA40afEf/8mbjjJSk10v7HSlItevx7oqLZ7Z0BNbBN5AG/jxYywB0c4lgJS1?= =?us-ascii?Q?aHNBaDCOFTnBPGiF+SioqKE3AT+1Euql6jmxGZT9bcXtB8WXAaeKd/d+vGGv?= =?us-ascii?Q?yRTW3ldJr0RUXP8jibTa3J1CQpzlUouM1f0hFCsNR4Hbq6ERju4vp3Jt8qEI?= =?us-ascii?Q?eTXe7CKALV8Vq2FkdesGejIAC+9giHpfzUI6PiyJ0b23dBOAfG6mgaRKAAUj?= =?us-ascii?Q?j77Run/DMlZsp7lh1HBcH97dSBe9apf5aILt97GnKeOFIovkjjG3IHwpkgPi?= =?us-ascii?Q?ciVjviFwjkHxWTLlvIw/rFsEo73LdMEbUeQy7/wI7uGP/qiUoci8C9YAqU/G?= =?us-ascii?Q?Zx9waSMPDOIupZmjbhazhKD90LSz8SC7Rlhb9A6OgZNf2p6BSrlP83UO9ZDs?= =?us-ascii?Q?FCXLqtBNN/Xnp2JiYQgR+4wSI5lN3UKG4KKJEtaoTGuSCLCcA2mWPAjev8ju?= =?us-ascii?Q?ggDF6ghWxFKcrfLVTCX1iGCm4kJz1T8+al9/am6IbuFmZp0XcVKvGllouNFT?= =?us-ascii?Q?R4ZcVLImSB+Z/MUCyB3zfPZblpIoax2IflVCqa3cP44WceaskTSOJwQ6BLyQ?= =?us-ascii?Q?BdcNfQ0LAFebFuxoIkU/HN+oQgMVlTHZjWZgjyGVgjvCtEewVxpJ3tljNmzO?= =?us-ascii?Q?gxcDQfeipxdxTy4IzCwt5G/TU1CN3G5qHcbrVNJS?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1739.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 26f23603-8252-4445-bde1-08dab1b34c2d X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2022 09:21:26.1050 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iCZYq4wB1BvNpfFfQOgMGCVglTNGulWl5X1XUFql5rkavYllWN1f9hT4BixMiBUrt/I2Tm1oH2rQLsCvsh+CLg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6256 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Chenbo, Thanks for your review, I will send v9 to do this. > -----Original Message----- > From: Xia, Chenbo > Sent: Wednesday, October 19, 2022 5:13 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coquelin@redhat.com > Subject: RE: [PATCH v8 09/12] vdpa/ifc: change some driver logic >=20 > > -----Original Message----- > > From: Pei, Andy > > Sent: Tuesday, October 18, 2022 8:08 PM > > To: dev@dpdk.org > > Cc: Xia, Chenbo ; Xu, Rosen > > ; Huang, Wei ; Cao, Gang > > ; maxime.coquelin@redhat.com > > Subject: [PATCH v8 09/12] vdpa/ifc: change some driver logic > > > > Insert internal list element to internal list before register vdpa > > device, in order to call vdpa ops during vdpa device registration. >=20 > Patch seems good but title may be too general.. >=20 > Maybe: improve internal list logic ? >=20 > Thanks, > Chenbo >=20 > > > > Signed-off-by: Andy Pei > > --- > > drivers/vdpa/ifc/ifcvf_vdpa.c | 11 +++++++---- > > 1 file changed, 7 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c > > b/drivers/vdpa/ifc/ifcvf_vdpa.c index c16e263..8dfd493 100644 > > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > > @@ -1737,17 +1737,20 @@ struct rte_vdpa_dev_info dev_info[] =3D { > > } > > internal->sw_lm =3D sw_fallback_lm; > > > > + pthread_mutex_lock(&internal_list_lock); > > + TAILQ_INSERT_TAIL(&internal_list, list, next); > > + pthread_mutex_unlock(&internal_list_lock); > > + > > internal->vdev =3D rte_vdpa_register_device(&pci_dev->device, > > dev_info[internal->hw.device_type].ops); > > if (internal->vdev =3D=3D NULL) { > > DRV_LOG(ERR, "failed to register device %s", pci_dev->name); > > + pthread_mutex_lock(&internal_list_lock); > > + TAILQ_REMOVE(&internal_list, list, next); > > + pthread_mutex_unlock(&internal_list_lock); > > goto error; > > } > > > > - pthread_mutex_lock(&internal_list_lock); > > - TAILQ_INSERT_TAIL(&internal_list, list, next); > > - pthread_mutex_unlock(&internal_list_lock); > > - > > rte_atomic32_set(&internal->started, 1); > > update_datapath(internal); > > > > -- > > 1.8.3.1