From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7221EA0548; Fri, 9 Sep 2022 09:44:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1646340DDC; Fri, 9 Sep 2022 09:44:40 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 1F20840A7E for ; Fri, 9 Sep 2022 09:44:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662709478; x=1694245478; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=2CV9PscL9ge1i4UDiTavhrnnsiWAowScbiHeXRNUvms=; b=i+C7din46VVLI43eQrKJ7iqgcy5WFrAb+mfhlyNoknBVNQUxetTLEw99 6Zlhl++GTQbAHtlFXRqZL/jCvFO8Y3fG4FghXfyWjrUAEXCsuv1hdnvMs 7lDV+5ajc0Z5TZQs//HDq3b5aW/pOAs0c/6W/uaaOojA38lCkeRkGSe9F VCmRi1wmgdxfL3c2BNkHrqJmdREyAzBxDyaABMe5+Xn/DdW4UmSVp/kVB 30yhcaoog8UFgKGdd+EoBYmBxMqCPcJqDz1Xfdl3dm96z+RvlBYWqcUn2 1p02bfUoR/wxluI7lzs8JQqGnDlHY2oC3a1KBikW7GnEe/dHlG/ADYryJ Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10464"; a="295001454" X-IronPort-AV: E=Sophos;i="5.93,302,1654585200"; d="scan'208";a="295001454" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2022 00:44:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,302,1654585200"; d="scan'208";a="677062384" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga008.fm.intel.com with ESMTP; 09 Sep 2022 00:44:37 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 9 Sep 2022 00:44:36 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Fri, 9 Sep 2022 00:44:36 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.102) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Fri, 9 Sep 2022 00:44:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WUfLYFQX0RrBrdH6Zf/mAtYCYI7fhYIiv7IlUTMcdcXrJqAsYtFf1V3MdrtF8R3sOj6zh+waPaKXZyhLei0OS+ElHPBNvO02ubE39UdI3fw6WRGIjEDcNd134C0AGw1weetNW+e+fdqeBFbDHgUCM3Xw891PoJXXFJD7+xF5hGJsUYJBc1GFA3n18YHphmsMieq46IiMZM93pEJnzeL4g1QAWuLgoIeyqG2SRsHDFv/XHEyTjjkfeKE6vdTdQaruCmKb3DFdFNmd7aSquXTTGHHLGhOmz41cjZ39uRa6FfwXGugao34MJFYHdRM3v41osvWJb4Tf5Nbb918KB0KCDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6WFLrKZu/zecxas2aM7p/UombGv+qBEgRV/vjkLkoIY=; b=BUV1mvgxbhxxbUaIOsf9WBmbkNBqvLMPlhPkbMvBesMykNo1dzD+0qp2/at/lCDQyykRtfGEn2q7zGzJpahmGVRsn1LFlRvEQN/U0y5ZfYg3G0PrfVfGNOZULEL6UhWbDt4G3yUvzOSer5V2Afl7pB4JReYo4MD/FAubDzIoKdxfDQMwONACH/euir+5cZ3O6/t+XVwmyCVPrr7INXQptK33kDqr38HZDAPhm8Lp72BYNRSTcRGjByTOhORzyS8f1V5XOzZ1m1y941aFfpGy66dIsD1cQqwasKXDz6KVHswRUHzYok9R0BVJwq1DUUCgLIByIGPXJ+sZXEOmpkDQug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM5PR11MB1739.namprd11.prod.outlook.com (2603:10b6:3:111::22) by MW3PR11MB4571.namprd11.prod.outlook.com (2603:10b6:303:59::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.14; Fri, 9 Sep 2022 07:44:34 +0000 Received: from DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::4cf2:7f87:f969:3ef9]) by DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::4cf2:7f87:f969:3ef9%3]) with mapi id 15.20.5612.019; Fri, 9 Sep 2022 07:44:34 +0000 From: "Pei, Andy" To: "Xia, Chenbo" , "dev@dpdk.org" CC: "Xu, Rosen" , "Huang, Wei" , "Cao, Gang" , "maxime.coquelin@redhat.com" , Huang Wei Subject: RE: [PATCH v2 1/8] vdpa/ifc: add new device ID Thread-Topic: [PATCH v2 1/8] vdpa/ifc: add new device ID Thread-Index: AQHYw+Muy54DnwTOMEydxQqEvB6RGq3Wt0Zg Date: Fri, 9 Sep 2022 07:44:34 +0000 Message-ID: References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1662616458-164613-1-git-send-email-andy.pei@intel.com> <1662616458-164613-2-git-send-email-andy.pei@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM5PR11MB1739:EE_|MW3PR11MB4571:EE_ x-ms-office365-filtering-correlation-id: d5293493-2640-445c-38f7-08da9237237f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +pwmAXzmbXo/UBmA3UK5H9slAZ9oKhvxSXKPNRZhp4NLM1aGQvm3Rm9ff//ureIbRYdUbsz8RRCgsIDqf3genLfXqMB0TxSGT3xRA3bJf9fb7M93O2fYx/Ff8RG0HMfnT08nLmEdJP1xlz08pLFOPg99DMRPeQ3rV2yH+RKtLXK8OGRJALhyhVMQF7GGBGyhBhF6/h5z115zxvin7/9PzTqXckPkDwH9I8RLIPTnyUh+B7PitnxHHu5C/7qIKPHEIsX2dlUrKduohJ7U6iDVyQZIhjcATUa5IlBp99NYFiL6ksHKIBSvwtJ5nIQanh7zpbu0wt8I7vclk9IeW/3sdWeOeuylup0NTTRzGW7+q3wsOAKMkat7iwnwBlvgjLIDRHiITvOPhByc6f8mouXXINHRPdNpqWXAbBwgtoL5O7oOtwKpqv2TKr71qjamJ1Bdn7cGK+tjWJHuy1gGipG7ag+p6XNWs1aCgYhUzvzsk7jOq0MGH516J3ka80V85uPRUDjx91MPBNE4uvLmiKL5YolbrmAI1H+mFX5MNKIh6Av98wAFp1iSkbcazv9CqGBcq1kywPMGTbKa92bCXTdWClLcsiiGcEefw2z6q18RR1FXDOmN1oM/5dLuMVY+EL1wjRFt/Uc4TF00GrSyclCqlSM+y0698yhKe38vt6OSPKwW7rcqpti9w4Ue/1eYh1VIwdbdUgt7tl6F7EeSmReAdYxJ8bbFI6+Josdm3JN+OJdeab3yPMVaPK3HKsfZm6A9SBGHWlvD20hDEdeT0onwnw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR11MB1739.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(39860400002)(376002)(346002)(136003)(366004)(396003)(8676002)(33656002)(26005)(54906003)(316002)(66476007)(52536014)(76116006)(64756008)(2906002)(110136005)(4326008)(66446008)(66946007)(5660300002)(66556008)(478600001)(53546011)(6506007)(55016003)(41300700001)(7696005)(186003)(8936002)(38100700002)(71200400001)(82960400001)(9686003)(122000001)(107886003)(86362001)(38070700005)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MT77w2dDl/gPuOIYjnW9w8zMCKKwOmVUSzXsGzCeAXm7pA0pvAX4V/BzWLtd?= =?us-ascii?Q?Cm4g6NWZW3zufMtNjHRITRClRQHdhpkUOYdkgsWkvDxTrGpzLkmBGYwxygrn?= =?us-ascii?Q?0VtjsN7ohji8rtyzU3onHzZZWBstgRosimu7dEigGiL9tRblrUxbZk/KD3b9?= =?us-ascii?Q?0m43Nqwy+8MNHdfwmOC7Pr3etfnO5yorSAQyy2EMhuEsbK/uhSw5OwF7IEMP?= =?us-ascii?Q?C8xVTvZZz5gZB7VvYyFsdFCyY48sX87qnHEjJIZ2GDpaVxX35135SU7ShGky?= =?us-ascii?Q?wz0BFRt9ZAhh++HULi68twgI+iHoXQc46/8u8croQEV85jq079cDlIu75Ynh?= =?us-ascii?Q?UyMVQBU5HS2JA+y9eXJtumlLCr7SToWLaFdCZmQ/fqCTW3z7ZSKoqId9ZUp+?= =?us-ascii?Q?Hqaf7LA7YMdB/wC+NdWRxp7f9RVMvOUICtNg+EAvJ7RbwCP1gd50qxY2Uqc3?= =?us-ascii?Q?/9jmAWXGa2HFyEIyh60q5PR+Zrfhh2iArMEgI5HHRP2qqSocaB6187LQGB57?= =?us-ascii?Q?X3rDGGlfBD4pSecMkc5kzId3dqQx/fIg3xkfYGEpzrn5VAViYuN4cDfOXMDL?= =?us-ascii?Q?2kLQCrZLgzYpiqbmHUQtIIoRLTZYwQFeL0OPKvhzfOmXudNpGC2YdTmjZvgw?= =?us-ascii?Q?wEy86Tpdauly1vB9CTC29PpcDLdO3jKDahJAD5EjAuLb2A5LvPEVLo3gnjId?= =?us-ascii?Q?feLA1D8fu9KDXScxc3Co1Dbrj3XwNgOStGeeKiMZxYh8i5MnAILBZb4yPj86?= =?us-ascii?Q?lqzimOeGh0/VPoLvJFgWu2RKTusbAZGBmJJosTlzFUcyiqFNkiSLUrcmCXVR?= =?us-ascii?Q?kD2I0T4Va7Z0jSuFiZHJRGCEX4RIEu1ft7j594n4y3sIIIZDlV/NdwzNEvvD?= =?us-ascii?Q?QVSgr3HMANsibyrAiWH/87A4kNsId0d7VeeHwZG2mCAEAcXzheKPtMpfhzzW?= =?us-ascii?Q?OKZQ3G1OJl8h//UFz2DGc4tGwyHX131WryVpsbDBCyaxtcPU6dwm8gtbol4g?= =?us-ascii?Q?Y+TGp3rfKESmxdJdENoi1BuVilDd4LyqpnqTXe4jL+bnaiSO412F3KzbZEnd?= =?us-ascii?Q?cXdr5fvirg5wMfhOU/QlVKMIhck1nZGDf+dXO8CQoGCfw6ixMQNuMUU+aluS?= =?us-ascii?Q?I/Rf3EMD6Oai8lDI0/S6cCRQo6P3bj+cBdaW4kPYVpFlBr4nKD73Gx8pmyYJ?= =?us-ascii?Q?dIoP7cZi58E2TOPSuN3lUPm4JBid2ilg/QlHjnbHoikC0VKCYZAe3Qxi4FjE?= =?us-ascii?Q?ZJ5c1NYiDpCPOS/sl1ZG86MLwT6oG3WTLwpPlDJLsEOSg/3wMwXFanN4R3h+?= =?us-ascii?Q?n8r7nzCmdRPhkWt77mzwGg7wv15l5txiMEL8P9GYVZs66Urs4nGY//Wm4CPE?= =?us-ascii?Q?5pxrY2BhoqGJv9lLAwrb8g1atdvLa2rC3tvH2trYE0Bpft+ZJ9uMWrrxZfLl?= =?us-ascii?Q?0/3WUkZ4xdbBw8Dl9zWN9gTioTLMlvuZ6Q+GV04RvSV5FrFNSBL6gg8fHXS7?= =?us-ascii?Q?WEd06mca9o9MMYd7iPcnk7sqE0wrL1M+Byyb+zBOzHTFCOraCc/dmKkagyfh?= =?us-ascii?Q?xQpM9oTy1nNV/jrX9WI=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1739.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d5293493-2640-445c-38f7-08da9237237f X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Sep 2022 07:44:34.2118 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QyVF3U5p0sqpN2jVkl5B6N2mPb7IOMHFyDH+uVKYHDF83HTp3IYgiajJDicLtfIVhUYgo3K9o74iNOZ4cFsFNg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4571 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Chenbo,=20 Thanks for your reply. I will send V3 patch to address your 2 comments. > -----Original Message----- > From: Xia, Chenbo > Sent: Friday, September 9, 2022 8:29 AM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; Cao= , > Gang ; maxime.coquelin@redhat.com; Huang Wei > > Subject: RE: [PATCH v2 1/8] vdpa/ifc: add new device ID >=20 > Hi Andy, >=20 > > -----Original Message----- > > From: Pei, Andy > > Sent: Thursday, September 8, 2022 1:54 PM > > To: dev@dpdk.org > > Cc: Xia, Chenbo ; Xu, Rosen > > ; Huang, Wei ; Cao, Gang > > ; maxime.coquelin@redhat.com; Huang Wei > > > > Subject: [PATCH v2 1/8] vdpa/ifc: add new device ID >=20 > Title could be: add new device ID for legacy network device >=20 > > > > From: Huang Wei > > > > Add new device id to support IFCVF_NET_TRANSITIONAL_DEVICE_ID (0x1000). > > > > Signed-off-by: Huang Wei > > Signed-off-by: Andy Pei > > --- > > drivers/vdpa/ifc/base/ifcvf.h | 4 +++- drivers/vdpa/ifc/ifcvf_vdpa.c > > | 9 ++++++++- > > 2 files changed, 11 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/vdpa/ifc/base/ifcvf.h > > b/drivers/vdpa/ifc/base/ifcvf.h index 9d95aac..7ede738 100644 > > --- a/drivers/vdpa/ifc/base/ifcvf.h > > +++ b/drivers/vdpa/ifc/base/ifcvf.h > > @@ -12,11 +12,13 @@ > > #define IFCVF_BLK 1 > > > > #define IFCVF_VENDOR_ID 0x1AF4 > > -#define IFCVF_NET_DEVICE_ID 0x1041 > > +#define IFCVF_NET_MODERN_DEVICE_ID 0x1041 > > #define IFCVF_BLK_MODERN_DEVICE_ID 0x1042 > > +#define IFCVF_NET_TRANSITIONAL_DEVICE_ID 0x1000 > > #define IFCVF_BLK_TRANSITIONAL_DEVICE_ID 0x1001 > > #define IFCVF_SUBSYS_VENDOR_ID 0x8086 > > #define IFCVF_SUBSYS_DEVICE_ID 0x001A > > +#define IFCVF_NET_DEVICE_ID 0x0001 >=20 > For subsystem device ID, I suggest to add _SUBSYS_, please check all Subs= ystem > device ID and make all the names well-defined. >=20 > Thanks, > Chenbo >=20 > > #define IFCVF_BLK_DEVICE_ID 0x0002 > > > > #define IFCVF_MAX_QUEUES 1 > > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c > > b/drivers/vdpa/ifc/ifcvf_vdpa.c index ac42de9..61d0250 100644 > > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > > @@ -1684,13 +1684,20 @@ struct rte_vdpa_dev_info dev_info[] =3D { > > static const struct rte_pci_id pci_id_ifcvf_map[] =3D { > > { .class_id =3D RTE_CLASS_ANY_ID, > > .vendor_id =3D IFCVF_VENDOR_ID, > > - .device_id =3D IFCVF_NET_DEVICE_ID, > > + .device_id =3D IFCVF_NET_MODERN_DEVICE_ID, > > .subsystem_vendor_id =3D IFCVF_SUBSYS_VENDOR_ID, > > .subsystem_device_id =3D IFCVF_SUBSYS_DEVICE_ID, > > }, > > > > { .class_id =3D RTE_CLASS_ANY_ID, > > .vendor_id =3D IFCVF_VENDOR_ID, > > + .device_id =3D IFCVF_NET_TRANSITIONAL_DEVICE_ID, > > + .subsystem_vendor_id =3D IFCVF_SUBSYS_VENDOR_ID, > > + .subsystem_device_id =3D IFCVF_NET_DEVICE_ID, > > + }, > > + > > + { .class_id =3D RTE_CLASS_ANY_ID, > > + .vendor_id =3D IFCVF_VENDOR_ID, > > .device_id =3D IFCVF_BLK_TRANSITIONAL_DEVICE_ID, > > .subsystem_vendor_id =3D IFCVF_SUBSYS_VENDOR_ID, > > .subsystem_device_id =3D IFCVF_BLK_DEVICE_ID, > > -- > > 1.8.3.1