From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3FC64A0544; Wed, 12 Oct 2022 09:23:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2DABC42DC9; Wed, 12 Oct 2022 09:23:00 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 1902542BF0 for ; Wed, 12 Oct 2022 09:22:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665559378; x=1697095378; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=FUB+oYhNKgTGxQGGByUxSmFyIH9ilKpVXgoZdWDOG9M=; b=T4Sn+7p0yMRjOtT27bXXlr8nL4vaGGi1tRIjaLkW0n1Djt7/ZreMlBdq 5v4M3Oz0GwgqJnvHJq+Qjtvk/w4PfvXC0injpFn3Mdre0CJ2BaOqDiXbY uRE0mVHJSdlFehIOAGwsrZGAMfv/Ff3EQ168kdhlzoBta/yYrvF6e89bj TN9Yup+Ern7Ho/inKzAKqGCfdNHYI8uO6KXAbNnrSQszTskYp2lXEGtxR 4ZOMeQZ54+H+t5uH4KVKGrrdiC0GNPWEf4jezY/MQvhjMZzam6X2Vynlx L6Q/qLFbHGObXDSou2P2pQIoyfzdt1rdrNhSwU/vAITbfltbyfVmKPJB0 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="284448348" X-IronPort-AV: E=Sophos;i="5.95,178,1661842800"; d="scan'208";a="284448348" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2022 00:22:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="715819502" X-IronPort-AV: E=Sophos;i="5.95,178,1661842800"; d="scan'208";a="715819502" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by FMSMGA003.fm.intel.com with ESMTP; 12 Oct 2022 00:22:57 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 12 Oct 2022 00:22:56 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 12 Oct 2022 00:22:56 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 12 Oct 2022 00:22:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N5IzM8Kh0bY0w1a/XySqFxrEG17VynxG0Kykd/OsrEoAWLS3r49NQaDZ04mLpNLppJG5in1ihN0u9D+JgAnfr93nrFxKJDHlp/FCPzeLlSXWdWW+SoGkKK1y7L8tuSKAF8DxlGkT2i0SG844rwBPa/Lg5GSqXXNxEdWcuVcZwGOyC5Cjq30O4MpnJy4vgFqdPyJYu4UgGXz2GC101Jc9X12kri2dZCHYWHBNDazlufk+dTxIG73wlp023J5hNNb872iGXNvx7grrjmNszpVSeLGCwNtKZb7HpgkLe1PiGX9smsze2rHg5vt11ymszh15bhlaKbVMHaUuDMoX4LUZrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gK2TbV19bxlfLJ6O/L44Cv2VZ7gTHVWY5avLYy/qf5o=; b=cmKkmwOfmoZ9m4iv9IVt3sanuFZCpf6DkBYPS3B+aeFciAGFPqwq/YTy0b6NRt4eotElBdHJljfk73k/oUH2axwELwI3yISv7zYMpVgvubL1OxN9tFQYMOxCYmtPhoYRNlDrOP03Rgb1JzOg6md5z2T6XNwcndfEz3q1f4o3joHhnGNHGgtwkfKOJqn+VZk8r+Zt1ODAsEbguVjpL3inQETjoaTcw0EEymZW2iTJxtDhfRhJZMqC7W8LnkvIeySOi9JgKGKubZC+VdlUNsuZVG65XqwGWx1SFPC1JFFm98kS6UiG1kdyb6PqCuN0IVO+xncvdb57KLb6vxBpPluVjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM5PR11MB1739.namprd11.prod.outlook.com (2603:10b6:3:111::22) by SJ0PR11MB6621.namprd11.prod.outlook.com (2603:10b6:a03:477::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Wed, 12 Oct 2022 07:22:49 +0000 Received: from DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::b8d7:6a95:bf26:e4ef]) by DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::b8d7:6a95:bf26:e4ef%12]) with mapi id 15.20.5709.021; Wed, 12 Oct 2022 07:22:49 +0000 From: "Pei, Andy" To: "Xia, Chenbo" , "dev@dpdk.org" CC: "Xu, Rosen" , "Huang, Wei" , "Cao, Gang" , "maxime.coquelin@redhat.com" Subject: RE: [PATCH v3 3/8] vdpa/ifc: set max queues based on virtio spec Thread-Topic: [PATCH v3 3/8] vdpa/ifc: set max queues based on virtio spec Thread-Index: AQHYyZPna+E12LRgLUaid225pVMmIq4KbIVQgAAXFvA= Date: Wed, 12 Oct 2022 07:22:49 +0000 Message-ID: References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1663308990-621-1-git-send-email-andy.pei@intel.com> <1663308990-621-4-git-send-email-andy.pei@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM5PR11MB1739:EE_|SJ0PR11MB6621:EE_ x-ms-office365-filtering-correlation-id: 9248873b-e07d-44e9-f4f1-08daac22914a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WW2ow8uRoP6bvxib5zEmk+Hs717KGdBWCJp+61UZ0K8e6dRE8g37NVOIh34l0diaImfBV/lKUAglUL2C3ns49YG/6idJVU3xDkNT4QvLmajbKW5eMkhCQlTat6Q2CiTy4nrL7JNRTtIysPMHZ/YqPpXkTRk9VDb6SgRSnJPaAwQxALTKbNv3M/Lx74BgSnca06///ZZirFBfs2Gmu3aqjm0A4/tZml/S9/FHRKuQ4nGAn3kPuvGFcaZlgMd25yW03gtbHVJAWX8wnRVXTCaT61U/pHdDUyV08A8etxvA/wD/sIKzWW74kDjFsPokKrX+4lKx4JKHM0n0rCawO+CRZclGgroxzDbvm9jdLnCCu7TGov4OA8JvAMz34dPxgTkwEekTroBNQLMrwW9mj4txJzcTiRagUM0F/VTNG0mG78ZW1wNPof3yfZW/jlCvT5faeZg3GVgTUD/0e8pIAL/uZwUAsDdiMFyWEjjO2aX7weZXa8RY1IzQHCJNi+tSabkb0D4NSWphJ4gDPVZtHBiQtJfLUumEwtBYCw9Rg8zpkwecjIizedXiq/har2D7VWm54XZKZpqP0S/NVu8qG/sVpdKRiHjbb6UrSKDaIUC7ubHPppCMrFkGTEl/sLYfJDdmQA5YJBlOV+WYDTFo9A+4gCG9v2HqbaXmGPbyHR4TUVYEFxjE6RQlIz036xd6AkM7Rvulb0yivqbz+8uvUkhzM1EN/Bicysx9U0vAltoFN51uUD0GB8Mv0cqlFZgUvqye4yWx/FIzPaLXdQoiC01Fxg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR11MB1739.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(376002)(136003)(39860400002)(346002)(396003)(366004)(451199015)(64756008)(4326008)(8676002)(66446008)(66476007)(66556008)(66946007)(76116006)(2906002)(41300700001)(5660300002)(8936002)(52536014)(6506007)(7696005)(38070700005)(53546011)(26005)(9686003)(86362001)(186003)(122000001)(71200400001)(82960400001)(316002)(83380400001)(55016003)(478600001)(33656002)(38100700002)(110136005)(54906003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?TSrYR9rN21wLH4o3kD1kESIHqde3KEfOTG+iuzBZV6yDtmM4dkYYbJauhB2d?= =?us-ascii?Q?ry6V+cp/KyhFEtOS/d9SmpZ7Fw6Ohk8P8Iyc7SvdgYD8OmmGYjr5VK15U90C?= =?us-ascii?Q?7MQaIMGJeNrZiaHV+FNU6qMN0cfAkYQbd5v+CgNVvW5X3Keg0samMQlbwfJs?= =?us-ascii?Q?WKQq8ejAX7sKBKVcku2WeSjma412gTkr+7DtaiQEraawitiNsVbvfvW8lB1Y?= =?us-ascii?Q?+lKLq8qR9KD2j6FgCFZug0SDe0KGVXa+OZ4gtQGCBBk8Ebm73dweM5HUxjsN?= =?us-ascii?Q?P9zNd/xpjlvmNOiTrwySpbKLakOr1K2g2Z6HBayf5HE4RE6MLwfc9z4W08sa?= =?us-ascii?Q?JVbzqtfjyN3N74/aPpCJ43hZiKVX1MP0h7iBLaZ+gPAKy8yb2Thak24e6///?= =?us-ascii?Q?nquCBdfoXUouxiKBGabJBzoxEYsv9inqT++uDhC0zlKb/Vr1EstOFKR7X7Gv?= =?us-ascii?Q?I4nUO+LnXDFTkasauhU083cPiEGeRoestJemDqpv6PRsOBXSuQlYdKVc6H6C?= =?us-ascii?Q?HOjznh20ZtTN8LtlaBxVSEt9/DqwKyi4jc7gNeuU959Ch8hD3hlGDdlH+r+R?= =?us-ascii?Q?NmMuui07f3jK1liNPIxjNRCIpR7fBlZGH5r/cmz7j5Fjoi5uUbwfNKRLwliM?= =?us-ascii?Q?zUs9FIwkQ47Z4X1J7/Xqk8dAlEHslbcV5TbJeItau0zNHAZB64Ssb65KaWHq?= =?us-ascii?Q?XADCrUWu7hfg6zB8b3asu0inhXWDc8ZeD+WlKjLGDoSavqUcN+Kn1IMtlqS6?= =?us-ascii?Q?HYlKa9na4oeJDzQ/fSWF/yTQ9hfnTazCzcqZz5Khf6S1oR2lR7HJYSu8v+eL?= =?us-ascii?Q?gdUaCGES+8dVWjJt5ZvAiCdADcrcJQt0AlcT//vNSqnhmpW5iaAWEhRiWEHn?= =?us-ascii?Q?leY+VOcSLsIDJ2yl9gCnwvQX8fcCIMFLhDsLGKJgYsAtMLX0b4UBxFDvE0Wl?= =?us-ascii?Q?X23lOMPyQLpYwbRcOIaxi61yIyrzq8rtoxOhEyjztzfT0C0PHTbN9hcqK7bI?= =?us-ascii?Q?/CxbrVz3yruswm/2vTCzFiJ50dyj9pSQJlYmruoqSDb5Y/Y3E46bGXgaqsSR?= =?us-ascii?Q?FHTeXvna3ygT/nR7Gc4BZFKtggGTUQqPOpOfB2us67Hgt2iAfKIf2iEMKWLX?= =?us-ascii?Q?GpgiNhsHIkOU+yovTTeqDFkasa65khHmAcsg5UtjL1D5gKxv0Ntgu5hVq1BE?= =?us-ascii?Q?kAeePjPa3Ex7xt5LzeRV+lhu20m2Oa4Uy+dBniZFYOFryzCydfOyHfEao1l8?= =?us-ascii?Q?pnQpdWirmETT81E1juTeUFLR6xtzAjdjOYCs1l7Ivom6NeNcHc/zbZrig46r?= =?us-ascii?Q?UGtGYUeusPCpceSIBRMEl8CAXuEVI6iC4IIkHn6GQZ2aRtmphjWpUkrQEYtZ?= =?us-ascii?Q?KZbUMIaqspPigCOruyyefEwZ1Zc0YuKt5w9C73FsjVSdlJn7p5r5hlmif9w/?= =?us-ascii?Q?DDedgCstmTDSEJmqtxd7WRScRvc1DKqq7p4fo/E3Zd9KaTzWmgzyDe44kd0U?= =?us-ascii?Q?PljpJXIeDAdYqqf8VIdN9vwXaHxH7suJ3xbnRqP4n1Jpw8QMHWGfep9sCEsQ?= =?us-ascii?Q?gq6bWJL5TvQqaf1lqqDZiT6u6n4DTyDX3lH8KdGr?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1739.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9248873b-e07d-44e9-f4f1-08daac22914a X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2022 07:22:49.2508 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5CEN3wlspBoDcpoJ+scVaatg/kA6baTBWfR2QwtjuWGWe94TZwG5rS+2m8XdL8SML/cHsn2gED3BOg4xc/tyGQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6621 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Chenbo, Sure. I will address in next version. > -----Original Message----- > From: Xia, Chenbo > Sent: Wednesday, October 12, 2022 2:09 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coquelin@redhat.com > Subject: RE: [PATCH v3 3/8] vdpa/ifc: set max queues based on virtio spec >=20 > > -----Original Message----- > > From: Pei, Andy > > Sent: Friday, September 16, 2022 2:16 PM > > To: dev@dpdk.org > > Cc: Xia, Chenbo ; Xu, Rosen > > ; Huang, Wei ; Cao, Gang > > ; maxime.coquelin@redhat.com > > Subject: [PATCH v3 3/8] vdpa/ifc: set max queues based on virtio spec > > > > Set max_queues according to virtio HW spec. >=20 > Virtio spec >=20 > > For virtio BLK device, set max_queues to the value of "num_queues". > > "num_queues" is element of struct virtio_blk_config. >=20 > Set max_queues to the value of num_queues in struct virtio_blk_config >=20 > > For virtio NET device, read num_queues from truct > > ifcvf_pci_common_cfg, >=20 > truct -> struct >=20 > > calculate "queue_pairs =3D (num_queues - 1) / 2" and get queue_pairs. > > Set max_queues to the value of "queue_pairs". >=20 > And say 'get the queue pair number using num_queues and set max_queues > to it'. >=20 > > > > Signed-off-by: Andy Pei > > Signed-off-by: Huang Wei > > --- > > drivers/vdpa/ifc/base/ifcvf.h | 2 +- drivers/vdpa/ifc/ifcvf_vdpa.c > > | 19 ++++++++++++++++++- > > 2 files changed, 19 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/vdpa/ifc/base/ifcvf.h > > b/drivers/vdpa/ifc/base/ifcvf.h index d16d9ab..1e133c0 100644 > > --- a/drivers/vdpa/ifc/base/ifcvf.h > > +++ b/drivers/vdpa/ifc/base/ifcvf.h > > @@ -21,7 +21,7 @@ > > #define IFCVF_SUBSYS_NET_DEVICE_ID 0x0001 > > #define IFCVF_SUBSYS_BLK_DEVICE_ID 0x0002 > > > > -#define IFCVF_MAX_QUEUES 1 > > +#define IFCVF_MAX_QUEUES 32 > > > > #ifndef VIRTIO_F_IOMMU_PLATFORM > > #define VIRTIO_F_IOMMU_PLATFORM 33 > > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c > > b/drivers/vdpa/ifc/ifcvf_vdpa.c index 3e5ffba..376239a 100644 > > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > > @@ -26,6 +26,12 @@ > > > > #include "base/ifcvf.h" > > > > +/* > > + * RTE_MIN() cannot be used since braced-group within expression > > +allowed > > + * only inside a function. > > + */ > > +#define MIN(v1, v2) ((v1) < (v2) ? (v1) : (v2)) > > + > > RTE_LOG_REGISTER(ifcvf_vdpa_logtype, pmd.vdpa.ifcvf, NOTICE); > > #define DRV_LOG(level, fmt, args...) \ > > rte_log(RTE_LOG_ ## level, ifcvf_vdpa_logtype, \ @@ -1512,6 > +1518,7 > > @@ struct rte_vdpa_dev_info dev_info[] =3D { > > uint64_t capacity =3D 0; > > uint8_t *byte; > > uint32_t i; > > + uint16_t queue_pairs; > > > > if (rte_eal_process_type() !=3D RTE_PROC_PRIMARY) > > return 0; > > @@ -1559,7 +1566,6 @@ struct rte_vdpa_dev_info dev_info[] =3D { > > } > > > > internal->configured =3D 0; > > - internal->max_queues =3D IFCVF_MAX_QUEUES; > > features =3D ifcvf_get_features(&internal->hw); > > > > device_id =3D ifcvf_pci_get_device_type(pci_dev); > > @@ -1570,6 +1576,14 @@ struct rte_vdpa_dev_info dev_info[] =3D { > > > > if (device_id =3D=3D VIRTIO_ID_NET) { > > internal->hw.device_type =3D IFCVF_NET; > > + /* > > + * ifc driver always has CTRL_VQ, >=20 > I think it's ifc _device_ has CTRL_VQ >=20 > Thanks, > Chenbo >=20 > > + * and supports VIRTIO_NET_F_CTRL_VQ feature. > > + */ > > + queue_pairs =3D (internal->hw.common_cfg->num_queues - 1) > / 2; > > + DRV_LOG(INFO, "%s support %u queue pairs", pci_dev- > >name, > > + queue_pairs); > > + internal->max_queues =3D MIN(IFCVF_MAX_QUEUES, > queue_pairs); > > internal->features =3D features & > > ~(1ULL << > VIRTIO_F_IOMMU_PLATFORM); > > internal->features |=3D dev_info[IFCVF_NET].features; @@ - > 1609,6 > > +1623,9 @@ struct rte_vdpa_dev_info dev_info[] =3D { > > internal->hw.blk_cfg->geometry.sectors); > > DRV_LOG(DEBUG, "num_queues: 0x%08x", > > internal->hw.blk_cfg->num_queues); > > + > > + internal->max_queues =3D MIN(IFCVF_MAX_QUEUES, > > + internal->hw.blk_cfg->num_queues); > > } > > > > list->internal =3D internal; > > -- > > 1.8.3.1