From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 34039A0547; Wed, 12 Oct 2022 10:15:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2940042FCC; Wed, 12 Oct 2022 10:15:14 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 3344342E70 for ; Wed, 12 Oct 2022 10:15:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665562511; x=1697098511; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=KYXZ/XkppmrxYo28i22ZpsRgHbGUEIA+8lHLzAWwBcU=; b=Uzb4hWPjIeluIgPVccppdSr1dHJbPSjQJRaZs6jpJxyXZw3LLG0iYXOc CCesI7cJrJWQUeJQmqOuG8hpFnKsNQtA65vjQ3kPK06oN8vF6rIyxxNRW oZ0YKg6b3VFIcsE4jdxdCONxE2ypaQdSNmvpbs9xP7UXEnDs3b0zX3cbF Z9OMB5P3QQW6DcK07h/GD0Jj6ZVZm4KGL63wtGd/n8chH8AaldtckwOKx +zy9qgzeX3Rsse1X9HWRDMjVKu3BihKCQ8tb/VuNd/WGAzRhSzmCOrtpt slupjehNYJFfShZ/znQcRn9xIf9J1jEtpJpE4TxU+qM8P6XE47BI0r4n3 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="285113863" X-IronPort-AV: E=Sophos;i="5.95,178,1661842800"; d="scan'208";a="285113863" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2022 01:15:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="715835025" X-IronPort-AV: E=Sophos;i="5.95,178,1661842800"; d="scan'208";a="715835025" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by FMSMGA003.fm.intel.com with ESMTP; 12 Oct 2022 01:15:10 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 12 Oct 2022 01:15:09 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 12 Oct 2022 01:15:09 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 12 Oct 2022 01:15:09 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 12 Oct 2022 01:15:06 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WiQNqdrvrgw85YSN3/ATMBbgHAgl/4eu1lKZlGlB+Sj13S6u2uoUhjXZcnTbPuzOS0QyFtVu0/5Ff+EHeYVu83i043id84of5LBqYr93ymiBZQ7icfOrA3F5C7jN4RGp3GbOVE4PfDJ8HRrKVRc0ldsVCXOtWU48caZGgacm8mbx803dZ6M17O0wGKfx8BukSFUTiRXEOT1yoh42/iMGFO4rApyL782dbxLrvRUf4RC/fBoDaw+qV1scfXdJnlgNHWCa8dhuf4icQMFjrNGIeNwfantK0lxwcBtwGHSg4HQaNc8XBeMvx7Ei9OZ2lT2j0WjPPaPETLLciR/Z0H0tUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tg7IvBqapUa3QjBraAT2CL6/eD6OmPjy3c78Aacz4eY=; b=kZcKMutmiZDrPvWapnP6qmU5JxLA2GUs4FV2mnhQxfxNs8dF4iuPfcj6bk7KCLvrbAljEKs3RyaoYkXjiHS2NPrz9DwT1wqD0nC/fZY7Nk2UP555rkQj+F+lwhIgsgdxsETYYTybt9ZFWbD6bDV0zO+BkJjAFoKp9RvUVTKwh3HtIhoVo2iQrsqibrkDrvWeVa5ZrzLt4PjdWTftQyUnFFpRcF7+QwD17OHtH5u6ZJYujVburQOKwEMWQQ5qdZQlpHHPcFDjNWM2PiwDyXKedVbw06N4qWYNTCtZNWb4BcpOYjN7yGS5RrktRTjxopChh3vnF/OvI2X8nzlNbtb3xw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM5PR11MB1739.namprd11.prod.outlook.com (2603:10b6:3:111::22) by CY5PR11MB6116.namprd11.prod.outlook.com (2603:10b6:930:2b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.32; Wed, 12 Oct 2022 08:14:59 +0000 Received: from DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::b8d7:6a95:bf26:e4ef]) by DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::b8d7:6a95:bf26:e4ef%12]) with mapi id 15.20.5709.021; Wed, 12 Oct 2022 08:14:59 +0000 From: "Pei, Andy" To: "Xia, Chenbo" , "dev@dpdk.org" CC: "Xu, Rosen" , "Huang, Wei" , "Cao, Gang" , "maxime.coquelin@redhat.com" Subject: RE: [PATCH v3 4/8] vdpa/ifc: write queue count to MQ register Thread-Topic: [PATCH v3 4/8] vdpa/ifc: write queue count to MQ register Thread-Index: AQHYyZPrij2rvX6S0kiwNzU07SIWkq4KbzeQgAAidXA= Date: Wed, 12 Oct 2022 08:14:59 +0000 Message-ID: References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1663308990-621-1-git-send-email-andy.pei@intel.com> <1663308990-621-5-git-send-email-andy.pei@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM5PR11MB1739:EE_|CY5PR11MB6116:EE_ x-ms-office365-filtering-correlation-id: 729c8e86-73cd-439b-182f-08daac29db22 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FWFWzRc+ZIYLqg85kPE9MR14rX6wYwQrXrqDUiINY67XmtZlNJaOo0jytb/SihbPPJVRz3SHACsa0aUozgZDeRCgby3TmCJDPj4I6TmRN0/yTUbPerb6ZODuIjexhkDaMmU17S1wazzeH24h7l2Gk5JWKpKskZhx3tzRc38iwQyIwDltZ9V3aSOoJEF6p9qBFB/DkqFLZ14lSEJXJPyf2tNYmNHlG2Uo/rF+FkyLjVajNgSW6qVwfsE5PFuUQ2x/8eBEp3bbj4l0hsFHpxFzWe974shET+vbgrVLosTfFcNt+4704ETB8UVC3Vc2MfwEG0nndPdOEDaXjpDSyKrEP0S6Fg6Bt81HyXHZk2b3ZqOpDAB6a4PFyaYm/OB05FD40vpUaGzt/9uLZoclO9sRvfSqGJIn+IwNlXgsFnoYtMWjOO0nUGEvcq3N4L5V3Zbh38vKFfH5Vv++TZsCYr764D2Y/NxoGgWqbl85lwUlK7oTJoCjuSWhRK+crgvSwIEnZdZGi4RAe+LhziF6C3hiBu+8HhR8Owjv9jwvKrLkt21lg2x3LAc/lLfBnLQMAni80ppmz9oJOZYY/mSr6iMpceklF/Ih5cLo4OYA+r3riG3IuPNr/7klYRWwzTV6BDKRCAwL45S+2pHChrt1pEmovLt2GbtpFy4mOFflzGUV3V4dKkxlf+KEMqzEeqQy6sWvx9vsSzknaGX8ghQbXLB9JPp5KQfLyCeSiIOr97kt2gGbYZggF6gSTl0LT2BN8YRBiqWXk+nEJIle3nVmc0WNvQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR11MB1739.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(39860400002)(136003)(346002)(396003)(366004)(376002)(451199015)(4326008)(33656002)(66556008)(66446008)(86362001)(26005)(122000001)(38070700005)(38100700002)(186003)(2906002)(66946007)(83380400001)(54906003)(64756008)(7696005)(478600001)(316002)(110136005)(71200400001)(55016003)(8936002)(82960400001)(8676002)(6506007)(76116006)(5660300002)(52536014)(66476007)(9686003)(53546011)(41300700001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ZygSnlbWivehKguzpQl7DgFdC09mni8LElRyJ90Z1cG8qdGl4NAhcECrU4vR?= =?us-ascii?Q?mFfNzbYuCl8sK7yL2l6bTXefH3wzoUplKAbH4pwiZxMbXJbrzAaM/A+VjGj4?= =?us-ascii?Q?k6MOhSoPBzv+V/ojN+u/TRXgVOTQ/UsVTKQu040ywJv4n5vwEn+dY6SuHAhk?= =?us-ascii?Q?V3AyNhqRuWCao1yXtjvqLlLJPl+/yJffN+LFsH62/ipZiAyX0OAnluLO0iVT?= =?us-ascii?Q?VQzTXe/ZMuykJayTNZCrDUpguBqxnQ/J6Jj0vTYiBQ3qlmW2z0XG3d1hDSOU?= =?us-ascii?Q?Nmthp5r7SzHeJv9ueeEJEgY001kXeODup95paFxaKoaOw0IVT/OBLa8aQd9Z?= =?us-ascii?Q?NJCnxOSQZEtLbGn2YaNj3Fxeu6j6W7A/5HlLA4lSHt3V+2+POz3QsYvREG2+?= =?us-ascii?Q?9jTZENvMjTnQhvu6nFuz4zOdxbp5GyxpqYYLQrjsY3/TT8+npaC3yv/LPkcf?= =?us-ascii?Q?LgR0clIw90G/IO1APc1yFjLsxoKtDV6eKA6bOQtdM1jQP3WDAkx0RjKWiobn?= =?us-ascii?Q?FTPBfPPiYH4MF2MFt7Nc/CEVO74uiKnk6qUGFl2HjF5hLVfTYHQDiQri5Scy?= =?us-ascii?Q?ap3hWA40jg7YRsJ7lBQKvtqBLIg3Xyba0HFetVCtiacQzPbeoGG0J/UYn1Uj?= =?us-ascii?Q?aCumcnC0m2Zj34Ni9IevtIHEjR6hWmauUQKAQGK7ltMr0XGwWuXor/TcdmZZ?= =?us-ascii?Q?dXt+7+dfDu3GjYi7M8ta4sxoXBaEAuKn/MQEsVWzfYFswclOSce+fI6ilAzp?= =?us-ascii?Q?HueIMTDxgPUlKSnVFHWFbB5g8qDShcjkUR4xsqdRN8HSeM3SfCNTcJB7IMyj?= =?us-ascii?Q?bzhMOb31MLUzF+Y9usCPIXNbZNX0dv2k2tZt+OXUlxiSQ7D8y2Yl24SyE/4H?= =?us-ascii?Q?SJ5O2GIDlcAMCmEBgB44lAemRMfTMxTx0aCMOgjehIhFALUi9RX3wbcO6t8c?= =?us-ascii?Q?aQr4oB35L+dT8yCtpXsBIYX/t4U6XkgaXz/U2ws7zUdxgbX2LCilp3mYFknv?= =?us-ascii?Q?YUBIZaftkVhm2sShsOBGkALPR0gLRRocE5lLpAL41bRhh0rRKxTTPuGI+U9S?= =?us-ascii?Q?syjHWg2xFaLVXVl2hXSQAuqmbjG5WZQ8mOAemhEZr7JiHLwVLMaA/2C3JegF?= =?us-ascii?Q?wiBZhP+yZvfxphyhtYQHjxpN403TkRJJ4AYNepFO4efj7cEdyIU+4gLXmPUH?= =?us-ascii?Q?VQTrF4GASEcFbP10y7EcdCLqILFy7brolyA8loEmPEB2MooWwVBdPtWY1GVj?= =?us-ascii?Q?PsnDFuWfs5nS68dSlqL6fg+f6Td/EWCFRlVYoafPRPnJpwtXA6Ol9WDxS8GU?= =?us-ascii?Q?dT2+F4c6OFWKWiMld98oWhm/UXgfACmP9xZ4+pd+KN/pNB99y/6s3Fi4tNKv?= =?us-ascii?Q?WV1TZSM3ybUNqYLk2Vc4ysQOzS84U4lRAP53JOqLYUlMy/hv9ayvdP176wBK?= =?us-ascii?Q?9zEdst6+lySn1CZWYTORQMyhlr4ujYp/gZW4eNw4sXdn9U8TuQXnTUflHKYz?= =?us-ascii?Q?Uj6UIJRu+Hch//tyyd+pzv6KtJgy9dWn4LrS5IV18+DI0WdD1mdU25fcFGiU?= =?us-ascii?Q?2O4DfEHQGLlauLQoVoNwVJjGyPMH2Z9bj0V9KLIH?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1739.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 729c8e86-73cd-439b-182f-08daac29db22 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2022 08:14:59.6271 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rKaL/QXCEXlATYNXs7sL45mYJskIAudUW+FmppEK8DvBXs2iPQ6cDTpJTEnzvSY/yEF7W9RjeXH8VR9/DjdffA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6116 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Chenbo Thanks for your reply, my reply inline. > -----Original Message----- > From: Xia, Chenbo > Sent: Wednesday, October 12, 2022 4:08 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coquelin@redhat.com > Subject: RE: [PATCH v3 4/8] vdpa/ifc: write queue count to MQ register >=20 > > -----Original Message----- > > From: Pei, Andy > > Sent: Friday, September 16, 2022 2:16 PM > > To: dev@dpdk.org > > Cc: Xia, Chenbo ; Xu, Rosen > > ; Huang, Wei ; Cao, Gang > > ; maxime.coquelin@redhat.com > > Subject: [PATCH v3 4/8] vdpa/ifc: write queue count to MQ register > > > > Write queue count to IFCVF_MQ_OFFSET register to enable multi queue > > feature. >=20 > Multi-queue >=20 Sure. > > > > Signed-off-by: Andy Pei > > Signed-off-by: Huang Wei > > --- > > drivers/vdpa/ifc/base/ifcvf.c | 30 ++++++++++++++++++++++++++++++ > > 1 file changed, 30 insertions(+) > > > > diff --git a/drivers/vdpa/ifc/base/ifcvf.c > > b/drivers/vdpa/ifc/base/ifcvf.c index 34c8226..7efb408 100644 > > --- a/drivers/vdpa/ifc/base/ifcvf.c > > +++ b/drivers/vdpa/ifc/base/ifcvf.c > > @@ -198,6 +198,35 @@ > > IFCVF_WRITE_REG32(val >> 32, hi); > > } > > > > +STATIC void > > +ifcvf_enable_multiqueue(struct ifcvf_hw *hw) >=20 > Maybe ifcvf_enable_mq? >=20 OK. > > +{ > > + u8 *mq_cfg; > > + int qid; >=20 > Qid should be the same type as nr_vring, so u8 >=20 > > + int nr_queue_pair =3D 0; > > + > > + for (qid =3D 0; qid < hw->nr_vring; qid++) { > > + if (!hw->vring[qid].enable) > > + continue; > > + nr_queue_pair++; > > + } > > + > > + if (nr_queue_pair =3D=3D 0) { > > + WARNINGOUT("no enabled vring\n"); > > + return; > > + } > > + > > + if (hw->device_type =3D=3D IFCVF_NET) > > + nr_queue_pair =3D (nr_queue_pair + 1) / 2; >=20 > Why +1? >=20 > > + > > + mq_cfg =3D hw->mq_cfg; > > + if (mq_cfg) { > > + *(u32 *)mq_cfg =3D nr_queue_pair; > > + RTE_LOG(INFO, PMD, "%d queue pairs are enabled\n", > > + nr_queue_pair); > > + } >=20 > As blk does not have queue pair, the log should be different for net/blk. >=20 > The variable nr_queue_pair should be nr_queue as it's the number of > queues. > When device type is net, you can make *(u32 *)mq_cfg equal to nr_queue / = 2 >=20 OK. I will sent a new version to address it. > Thanks, > Chenbo >=20 > > +} > > + > > STATIC int > > ifcvf_hw_enable(struct ifcvf_hw *hw) > > { > > @@ -215,6 +244,7 @@ > > return -1; > > } > > > > + ifcvf_enable_multiqueue(hw); > > for (i =3D 0; i < hw->nr_vring; i++) { > > IFCVF_WRITE_REG16(i, &cfg->queue_select); > > io_write64_twopart(hw->vring[i].desc, &cfg->queue_desc_lo, > > -- > > 1.8.3.1