From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17216A0556; Mon, 17 Oct 2022 08:28:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B432D40143; Mon, 17 Oct 2022 08:28:28 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 4ECA8400D7 for ; Mon, 17 Oct 2022 08:28:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665988106; x=1697524106; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=QYd7Y3++aRtR3r4v31YzcdWP1+QO/nnhxZZhjC5IXZs=; b=Gtf2Fxe/H8yNc+6hYAqZeL/ZUvVYQT5B6cCV57azsqXdYuCG9ltDBZTk I63Ia6dzm8Ceaxard2YFB0VesWcX7OefcAdpK7YNAwlzWUnw/P2Resv+5 vv62c6CUq0xC9Ma6dnReCeFJPu+PJV46oTdrcvv1Y0sbZVaOCCjEYb8u0 2FpuboKaxLecsND2CefpsQAuy4TQzBEA600VRWUV0DbOF9G4eRKuoeu07 vcUPeB+HHiHTg0rixAA1dWc5ng/VHEZ3M5bqx0+46aRnps8qSw5uZt9vF LCrHZo/UZLw+ZAWAN2/9sww5pdAJMBcZnLThiEQ+YcLepI/4d8K0IUVms g==; X-IronPort-AV: E=McAfee;i="6500,9779,10502"; a="307375765" X-IronPort-AV: E=Sophos;i="5.95,190,1661842800"; d="scan'208";a="307375765" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2022 23:28:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10502"; a="803234982" X-IronPort-AV: E=Sophos;i="5.95,190,1661842800"; d="scan'208";a="803234982" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga005.jf.intel.com with ESMTP; 16 Oct 2022 23:28:24 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sun, 16 Oct 2022 23:28:24 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Sun, 16 Oct 2022 23:28:24 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.172) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Sun, 16 Oct 2022 23:28:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JoDn0W28iC8osv+zWfp6HQnyhL8knm/AZTHUuEcN9ywL6eDPCMAVfoXBj499DGKaBFCrznfz5PivK2pxS0L/L5J8BFOcFPq1ywOblHheLvHU2ho8+HsmIs5r+mnS8UsH6/g8uFV5iRRdtengVZ1rXDBguxVfWyUGvXNgRSxKxnFzqFVhQqL7WsS7qhRtAHxCPz6QhmLksCcHhiaf6+Pi4NC0BYGFDH53l/A/W1X9Om8oY/m4FKSu62v1DUv47PnP3DTnhRefYE750+/E5cwuZteesQh2UB5RK2IRHj8cbdAZmBZkz2gx8HPL66So+ZklUiCXYa5+wWc/Q/oBwAa1Bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U1FIqej06O+OSdgN5OMlw1JTaf9DecNX8OaqVkOyU0A=; b=oJ9Bsnip1tsZZ4iPD22oNXW1bPCVFB4bwvgt84c+FeCyAVJ1NLD551CfNHt13uc+56Y2O/9zqZXbTWJym7cih8Wp7M5mCOImW7Y6Txf9dyhHyates/pIPtKqKF5AgTxdVYf9WMQkzZoGBHn0QtI8WXNmOjwLeYpCHkeAfNkefopQJMNNO9yzS2a9JVJGBpm2VRwnhMvdFPnVvEF5fUqcyJd8EL4WcU4xtfcFODVF1Pfpe/vdYn2Ql7WBke1qFnl0lrk/7MGFFTFtGICrfXlwCtrwvycJkwzUZMSG9K1RcwC7oiQqaGOiXtfcSG2PCKe44a7gnsS2lu01IHkmyBM/rw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM5PR11MB1739.namprd11.prod.outlook.com (2603:10b6:3:111::22) by SA0PR11MB4575.namprd11.prod.outlook.com (2603:10b6:806:9b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Mon, 17 Oct 2022 06:28:20 +0000 Received: from DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::b8d7:6a95:bf26:e4ef]) by DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::b8d7:6a95:bf26:e4ef%12]) with mapi id 15.20.5723.033; Mon, 17 Oct 2022 06:28:20 +0000 From: "Pei, Andy" To: "Xia, Chenbo" , "dev@dpdk.org" CC: "Xu, Rosen" , "Huang, Wei" , "Cao, Gang" , "maxime.coquelin@redhat.com" Subject: RE: [PATCH v4 2/8] vdpa/ifc: add multi-queue support Thread-Topic: [PATCH v4 2/8] vdpa/ifc: add multi-queue support Thread-Index: AQHY3uB/9NtPwiOuZEOKAu7kv7CRyq4SI3AggAACA7A= Date: Mon, 17 Oct 2022 06:28:20 +0000 Message-ID: References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1665650674-291949-1-git-send-email-andy.pei@intel.com> <1665650674-291949-3-git-send-email-andy.pei@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM5PR11MB1739:EE_|SA0PR11MB4575:EE_ x-ms-office365-filtering-correlation-id: 4f631335-174d-4bf1-8bd5-08dab008c932 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CxSspN+hXJ941zHOeQcpR1I8jtnSZiJaCs/xVCbP6vBA5CcPUvHyc79VNK8ve1G3FaoZkzXO9jRCDSNkPewFeRsJgzFX34ezMKn0E63a7s7ZgKKh54Jn8/DJVEoFcFczu4TMhtljKsSKXA7rNAK2IefedUoRC7b0oBaF+ty9rQYHMLFam7eK+Fwh+DFJzbkQfm6VAHV+dLinx9pf6UNSOILgR2LvCgsDZPtV0t30UZJFK78bzG1T1tJCkhnolztLwGMyk8A0OCGSRaEKi2f5BgcNr4m1U1aV85eg0c0+5wWjkF/gt/Mjh8lPvm90WOQzOLiJtb1p9nRIB3p2ejYKbtcKQsHIKL2gLtophtJhBEuaybRwjNTqCkadrTtcU6i+/CkXCWa9Gi11bTzLkG69/ByZN9ciyuHbLiGWuFk5k/SRmk77PZquNyb8qaN5NpUBYH2KqNLGO68r7IpBNu9b3rXhQnpg4baTxGMB6q1J0qpuQEVyintFESkUm3AcasVh140abnHjf1fjyqVm3bl45TXmgS/+isBy4ABeIT8l9IGWZpvGqAj+jSWpf9hRBf8WU+4qEGLY2kBMUP0QYd9odBxkwn5FPWXQH7UBTl2u071wgBsPZOmyn45lpS9chA3NkwrzZfKChWA/xuEzd2HJMfyjFywTSOm4FLs9O8QHKORoivQCctM6IUmw9EB5Bga6F99ZhVyL3nadrBB0iJ6rd1wwB7x8J6rBalv0Mfln7yXkFvjhMUD7/uOlotx6w7LxnRKROa1PfeNTRdFQzJ0mcg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR11MB1739.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(39860400002)(136003)(396003)(366004)(346002)(376002)(451199015)(33656002)(86362001)(38100700002)(5660300002)(2906002)(82960400001)(122000001)(186003)(83380400001)(38070700005)(53546011)(6506007)(7696005)(316002)(478600001)(26005)(9686003)(110136005)(71200400001)(54906003)(66946007)(66556008)(66476007)(66446008)(76116006)(55016003)(41300700001)(52536014)(4326008)(8936002)(64756008)(8676002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wEVAFYprYuC+yFN8Yy9Tdb+khiGQYmTTZV3n96YLGGKzwpHiZD6yn2h7SGLU?= =?us-ascii?Q?CstVP+HoANeKuAE+alp8sDM8RPSDcslBGfIJk88QpHVs/X3hEqS+PvnPJC+3?= =?us-ascii?Q?h+ByoyOP1cD3tyTIdCIN/z/hHPkaQe0HBgnQ+7GPPxu9WXpvuATR8pX6cZTw?= =?us-ascii?Q?AqpvqIQ8chyshV9usVtFJKc+cl7MHEsy/gJuE0WIBB0+14s39PowLFStq0Ia?= =?us-ascii?Q?eUId6T1q8bFZdMnCELw6Yie9Ro7+is4B2MRRDHC0jUMvckjr3u5+SaIHRZo5?= =?us-ascii?Q?rGC+B5Ozg4biBKbkQLXspnoIKKM2bH122tXC8oPlbZPcKmVCv4xnE95WgQO4?= =?us-ascii?Q?V9dM3wxB9SDAnR+fLzC6uJInbLuQOKzsish7UQ/Gm5PRl+8LF7LbEsymp4uo?= =?us-ascii?Q?c/PAiFp0wX6Dy3hkkS7Q99F8yBIIJVlwGQ4MbdTlnpU/7lNAC2DsypXh6E+c?= =?us-ascii?Q?CyRhl3uKiS2Kj8qDqqNt481+OrXROB3IKMvtlL7GjIN+7Z8tQGlmJu86SLYC?= =?us-ascii?Q?AtxqraL60Fhzgjrq0ko7qauLMd+CSpzXRvOOv1QCguJ4hZ8/GkJXyPbA89Bz?= =?us-ascii?Q?5lfbH2g1rLpa0y/xzO+YBTDGKpXY4/a1+xEobLvPido+WP7usOnBrPsMvfTa?= =?us-ascii?Q?3kTkZ5l+QK4jLQF9XUCHlGNJL/Mpf2umpetuKCcVAuIx4Y0TTLcOQq5jT01f?= =?us-ascii?Q?YWMZqb+HkPNJt64gOCIJIB5UrlMNfjBiQly6nLmMIbY7lOVyY0WKmUy5Uy/+?= =?us-ascii?Q?yj2vZnQFvK+nRLkHvYHjo7LAIrsYP5s7xRAqy4sQsqGggFgVTdI+HuDi8RdQ?= =?us-ascii?Q?JdoxypwDUh4HVmTPv0SipCmOGIYeq2wat1PoI3FnExA0uPr59e2a7FE5RQ8j?= =?us-ascii?Q?l7WpdhqijKjGdKpjYFbvy9BZhhygVQvcMQyZ8eVphmy35BIllZf9D16FEOIO?= =?us-ascii?Q?pY3ekBrS0PiLFaih+xGLGAnG/ySO0gn0dQxk3NAmbw+6doDLRKIuoc/Rrtia?= =?us-ascii?Q?Eqa7CUwaStSqAl7UyRuzlrkep7Ql3oSim6dePSqnDS3S1UiJHip/wMzzO9gT?= =?us-ascii?Q?RTi5BSga3sPjgRoNVCXlwUSKpRKNsk9nRzBGWHMc2YFW2QlkC7SarlBywsvy?= =?us-ascii?Q?BsXXSwG5CVOIjEW+Zfu848EHCltJNXoSAAgLrUNvS6DUWPE+YDOzHcnAZ0U6?= =?us-ascii?Q?kiW2sWhG6Am9Ye1MBULbtodBi7ppt+AiLzHXwYyVLDbwjl1JmflgwnsHUzJ0?= =?us-ascii?Q?AftJvn5m2BsPZB1cFMQiHudTQM886hY20PYn3zBTQrO1aU0QP9//4rmcS41k?= =?us-ascii?Q?mRfUihWvi5TXSFrN4qAqtFyNdOjTDXN02o8ynTTh+JK5qJtY5Rzgwr+xj6xF?= =?us-ascii?Q?Ssi1385AFc0+mu1XZtuZIYvIaf4AL8cWhWYbQmdHEF7lrxeKXZaY9PrLJ/jo?= =?us-ascii?Q?wqI/+pzKL75lScQ6tkuAacozq+XdAz/0JWo+lw5RRtIsAd2xljq2ipLPxfUZ?= =?us-ascii?Q?VwtpNCon2Qrt/8rISBRY732/apmHDKmGfJq8izs1n3V/JeXjHAHcsbFuv7QB?= =?us-ascii?Q?BNXg9+c6xs/osv6dUfAsVwBy9zjHDgzdEx4b2qCI?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1739.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4f631335-174d-4bf1-8bd5-08dab008c932 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2022 06:28:20.7793 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: caRET8WZEyijCCxJGZDDZ59QBS4KTrWZHVV55fk2Ulxo7G6DxrjL5kZZXNID4f4Iz2SDrxoBjb1VPc29RlDfDQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4575 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Chenbo, Thanks for your effort. > -----Original Message----- > From: Xia, Chenbo > Sent: Monday, October 17, 2022 2:21 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coquelin@redhat.com > Subject: RE: [PATCH v4 2/8] vdpa/ifc: add multi-queue support >=20 > > -----Original Message----- > > From: Pei, Andy > > Sent: Thursday, October 13, 2022 4:44 PM > > To: dev@dpdk.org > > Cc: Xia, Chenbo ; Xu, Rosen > > ; Huang, Wei ; Cao, Gang > > ; maxime.coquelin@redhat.com > > Subject: [PATCH v4 2/8] vdpa/ifc: add multi-queue support > > > > Enable VHOST_USER_PROTOCOL_F_MQ feature. > > Expose IFCVF_MQ_OFFSET register to enable multi-queue. > > > > Signed-off-by: Andy Pei > > Signed-off-by: Huang Wei > > --- > > drivers/vdpa/ifc/base/ifcvf.c | 9 +++++++++ > > drivers/vdpa/ifc/base/ifcvf.h | 2 ++ drivers/vdpa/ifc/ifcvf_vdpa.c | > > 1 + > > 3 files changed, 12 insertions(+) > > > > diff --git a/drivers/vdpa/ifc/base/ifcvf.c > > b/drivers/vdpa/ifc/base/ifcvf.c index f1e1474..81c68c0 100644 > > --- a/drivers/vdpa/ifc/base/ifcvf.c > > +++ b/drivers/vdpa/ifc/base/ifcvf.c > > @@ -90,6 +90,15 @@ > > if (!hw->lm_cfg) > > WARNINGOUT("HW support live migration not support!\n"); > > > > + /* For some hardware implementation, for example: > > + * the BAR 4 of PF is NULL, while BAR 4 of VF is not. > > + * This code makes sure hw->mq_cfg is a valid address. > > + */ > > + if (hw->mem_resource[4].addr) > > + hw->mq_cfg =3D hw->mem_resource[4].addr + > IFCVF_MQ_OFFSET; > > + else > > + hw->mq_cfg =3D NULL; > > + > > if (hw->common_cfg =3D=3D NULL || hw->notify_base =3D=3D NULL || > > hw->isr =3D=3D NULL || hw->dev_cfg =3D=3D NULL) { > > DEBUGOUT("capability incomplete\n"); diff --git > > a/drivers/vdpa/ifc/base/ifcvf.h b/drivers/vdpa/ifc/base/ifcvf.h index > > ef7697a..d16d9ab 100644 > > --- a/drivers/vdpa/ifc/base/ifcvf.h > > +++ b/drivers/vdpa/ifc/base/ifcvf.h > > @@ -50,6 +50,7 @@ > > > > #define IFCVF_LM_CFG_SIZE 0x40 > > #define IFCVF_LM_RING_STATE_OFFSET 0x20 > > +#define IFCVF_MQ_OFFSET 0x28 > > > > #define IFCVF_LM_LOGGING_CTRL 0x0 > > > > @@ -149,6 +150,7 @@ struct ifcvf_hw { > > u16 *notify_base; > > u16 *notify_addr[IFCVF_MAX_QUEUES * 2]; > > u8 *lm_cfg; > > + u8 *mq_cfg; > > struct vring_info vring[IFCVF_MAX_QUEUES * 2]; > > u8 nr_vring; > > int device_type; > > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c > > b/drivers/vdpa/ifc/ifcvf_vdpa.c index b4389a0..008cf89 100644 > > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > > @@ -1248,6 +1248,7 @@ struct rte_vdpa_dev_info { > > 1ULL << VHOST_USER_PROTOCOL_F_SLAVE_SEND_FD | \ > > 1ULL << VHOST_USER_PROTOCOL_F_HOST_NOTIFIER | \ > > 1ULL << VHOST_USER_PROTOCOL_F_LOG_SHMFD | \ > > + 1ULL << VHOST_USER_PROTOCOL_F_MQ | \ > > 1ULL << VHOST_USER_PROTOCOL_F_STATUS) > > > > #define VDPA_BLK_PROTOCOL_FEATURES \ > > -- > > 1.8.3.1 >=20 > Reviewed-by: Chenbo Xia