From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 10219A057B; Wed, 19 Oct 2022 11:18:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F0F0E40E03; Wed, 19 Oct 2022 11:18:24 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id C8E9640A8B for ; Wed, 19 Oct 2022 11:18:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666171104; x=1697707104; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=o7RmUYQTyepy0PJzqbysLAV7S5wP7QHqg9OjnuJTcvY=; b=A6A5Lmi0LBh4pJdswsia6JuiDnaQM57WCJmecpnH0QwZ4QXP45FDDBhe PnI9r+fG3JiQh8VfBEth+bEt6nCMMnvkvPzN4wOPJvzBMoN82y8SOvaQV Nw10OGiiHCKmNBv9ea+cW9PfK0sOPuDMXLNnyKhHrQw9dMYHVRNkZlKQy +sPlQkxAjSZOr1qwKCb+bYN0CMTRUqYmrtJB9mhapyP1g81WVg8QAbyzU z6Xjds8TnZ88uCizcK17EGCKy/rHnyRP+OB9Dt2b8kZfSBV+2wV9g7QnY IyIzc1jwvIuPKhOb21qF7yY+FFwuf8iBrHllcHzllu6zsAytuf8eHq+tq A==; X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="368408268" X-IronPort-AV: E=Sophos;i="5.95,195,1661842800"; d="scan'208";a="368408268" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2022 02:18:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="662366448" X-IronPort-AV: E=Sophos;i="5.95,195,1661842800"; d="scan'208";a="662366448" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga001.jf.intel.com with ESMTP; 19 Oct 2022 02:18:22 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 19 Oct 2022 02:18:21 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 19 Oct 2022 02:18:21 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.107) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 19 Oct 2022 02:18:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eZStwlvyQwhWsyE/Sag5/+DWMNSLWn7QZQoqjXkR+fZMOA+TatKh4cr6Df2Qpav9qwNurNBEwXha6+EHJP5RAvYlIx/lgwFQFDDAAIpssO6720lnXXYiNACRmIpmFRtEqa5Xt+MiQXEOsgYvxXmm8naT5e5rImZoKoSQqIRpGPU9RIudpn/KvBYdUYzAbNaByxE/77YVDCp2bk84QuNPXQP0DLPBx1xTLMUEx3328l6Avvrq1BjEwFP4oO+rPuHW+2d6gDRUo/pzWUWCDo/+aogHsvm9b4MvMnpBeckTNMXBnY6W5NOmIsdXVnjpdgeuVS/AO6O4FlWciEYggM5LSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QBKOmtM2VipkjmFS1kfKMgzFxeDBZ+TCWDhGY+/6U0g=; b=arnbQ6j8IVa22RmkBviA+T9w9u+Ub4NLWo5Bk41kbsZ63fT/gjR0X6VmX2u1mmcEM54H4jyLsI3gMnCaPcFOzURV5gbyY3co6IWQ3/yUhm4wUHrP+87LRxdVeLLYGWjPeUWcEFPAxPoLfg/f7Jh8/ROafpFLVHNp8EClx5WhfmajjZLnhly/H2iO29yuxDO3cujStvGK6F8tpE0MBWvTg+mCCXSiGfLNQxXIfntdorf89hnjpqEPVPC3gcrQ5HSQJfEpDFO7qPuwXmbTF9bXqro6AfJVMmwi9Cqt+NHkSEKXI3QRnFdfaMtO5a5ZMriaSUNjMr5OlAcyUalZDaWr4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM5PR11MB1739.namprd11.prod.outlook.com (2603:10b6:3:111::22) by MN0PR11MB6256.namprd11.prod.outlook.com (2603:10b6:208:3c3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Wed, 19 Oct 2022 09:18:19 +0000 Received: from DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::b8d7:6a95:bf26:e4ef]) by DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::b8d7:6a95:bf26:e4ef%12]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022 09:18:19 +0000 From: "Pei, Andy" To: "Xia, Chenbo" , "dev@dpdk.org" CC: "Xu, Rosen" , "Huang, Wei" , "Cao, Gang" , "maxime.coquelin@redhat.com" Subject: RE: [PATCH v8 11/12] vhost: vDPA blk device gets ready when the first queue is ready Thread-Topic: [PATCH v8 11/12] vhost: vDPA blk device gets ready when the first queue is ready Thread-Index: AQHY45s18/VSE48GIUKqwT2uWp+95q4VcCFQ Date: Wed, 19 Oct 2022 09:18:19 +0000 Message-ID: References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1666094871-25721-1-git-send-email-andy.pei@intel.com> <1666094871-25721-12-git-send-email-andy.pei@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM5PR11MB1739:EE_|MN0PR11MB6256:EE_ x-ms-office365-filtering-correlation-id: cd0ac344-2f20-4580-1fa6-08dab1b2dca9 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HJpmoV/nZ4C51E4PYEnh9PCcpNaUJ/Xq6QX5iSvwg4T6XRKd5K/HlQsn0lRLxYrvmR1CmjG0izb2ODx9oLAy0P8ayYj3ODYeRTe+O+6Gg3gzql/97vEru4Eo3dptPNTq5LVG/rtcSYeXwD5Jg/gYG275mCboFwnqlEDJ9//Wa32CQpkc/b71yqeJdsbZqrg4hXVaAToZE0fNgytOZeUiWQePE2SJixoh51EVuxYmYHVD8B9pIboB12JntMS29I9o4BT9RTZ3yJj8bfEh2j3R9YygrCN3PWfdPGU5bwoFforbD7Zst2VC/KD96VZkCroCM8kC7AT7wG7RoLZel1WQ8bEQ+K9m/t1KJCRduMxnYcB36X7iK0rAo4WDq4VYSUFK63zVJRqpMifkEla+8So2XBnE2kGyxsrb5o2WbpGlBOjUSWY/c0iII0kodrA5Qu8e+1J229PHfWXzqbvq+cX8kDB26+TniRgFUhbB6AkZL1kmUYK5fw5SWG6Eat+ZuY/m5zm796wkh6aBFUW8cGTEFiF3iGI758YkPY94QbY/w/Jzx9hHGNCpuXgt9CrYedK/IfZk+tcqLxv4i6jDW0tuAMx6mrLPNtiqmedQhD/LKhW44RjWwQUnsNs5aLAIYH9eZH0tAhtK3weuLNxIKBI66F0+oxxBp1f7iAmr0EtHBDxJgM0kNMz0CH+3M8mmgotzS9TNS14rKc2ozDEQLi+NchjOlrhu/SiFZ6O9nIUXjS5c4IQcLh7pAfnDZn1XUVMJsG+6m4kANAG+/7u9aLNC4Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR11MB1739.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(376002)(396003)(39860400002)(136003)(346002)(366004)(451199015)(5660300002)(110136005)(66446008)(66556008)(66476007)(54906003)(316002)(8676002)(7696005)(9686003)(66946007)(6506007)(41300700001)(53546011)(26005)(52536014)(2906002)(4326008)(71200400001)(8936002)(186003)(64756008)(478600001)(83380400001)(82960400001)(38070700005)(76116006)(38100700002)(122000001)(55016003)(33656002)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+acJXUHlMOwyBPe5KMd6pBhAVJeU/9V4xTxBzIdpeTiB5Xnuq5d9jQn8RQmv?= =?us-ascii?Q?Jz2+YpRXP0p1ESAHLqL9R+uF46lvyybobAHUhl5X9NUFqHpAnOfQPL9LOkKu?= =?us-ascii?Q?YIqJhFaSAneP7m9dHI/5NSoKO1RV4NHXIguDgf4Z6x7eML6BpTAz9YDb+/D/?= =?us-ascii?Q?gfzJAqoSvrHRf8v0ND/1fjd5EGPc90GGlW47O152tjCYxQaZRHV5z3oebmhI?= =?us-ascii?Q?pmFfQsI97urco7S6E4d+XvHUpQFXY73IlD7FgYTNE+wCgSy/OdCo1maCcdMF?= =?us-ascii?Q?YeEdn2k5DSucbJcbRVtP07HvAdFHjOTud/YcSjIaFEUTRnllZwu68Rd4Rs5V?= =?us-ascii?Q?x9j7wLkwCZKa6h2U3OhY0cXWHH9W2XdbRTfyqnRLCDgdaINbeS+Sxt4m77MM?= =?us-ascii?Q?pFhBXFtB4oT2urYhoeggHBF7dlkmGoR0fuwt5eafu9MS8IMc8NYx0Z2bRE4Y?= =?us-ascii?Q?nbv1je2jmq5U1UtuzxM1ezrReRvTahG4wbO0PFE/XmI9dnLsFajGlXh8gvhy?= =?us-ascii?Q?KLf1/oO2Qxoonzquu6LTqrDJzB9csIeEZow+hR9e/uWu1hyfc3YWo88TLVzD?= =?us-ascii?Q?4zstk9A/SqomxZybGCZnC+30mcPC0exS1f6Ahahl8MdiYlGfsjVlGxiHjAw4?= =?us-ascii?Q?bv2rE/cgm9299fA2cxPXIfxqZICOS5KbNg9OpcMk1pvuVf4VV6GYdu9B/mBN?= =?us-ascii?Q?K5ga0RM1n/ZLdvG9ITSSv0luMIzcvDXQVCn7U73NHudLNpG7cTfjnASytDU3?= =?us-ascii?Q?nphwLEdoMcZg9ckdCKslbuEwyBahWYzM2flKghgFHcKr25wUi1SDyhF34i3Q?= =?us-ascii?Q?UE+BYMoI4ue6n+KIDTYEChr79h5KDlsJZXfqmg0ySpWDCWKw4JI1/RtqG5Wq?= =?us-ascii?Q?3LL70SZvBwa3l/TSDeKFPPwZyGd8MIo1lZkQhLS1boMUnmUkwPGCn98WmAQ/?= =?us-ascii?Q?ep7Wozm8dS1aM40dTuIIwKYAq2Xmj7hNX78//R4IJ0HbGveI70CJs/xk81lw?= =?us-ascii?Q?KPA55KjutNOGp89eUl+ztSeJRbTmt2rQctQoP5IMBxGZB/IM5X7p0cDtk9y7?= =?us-ascii?Q?E0RvOMaNbLZAhJH3dA9fUKYBf93MTfr33Km0ZKcNuhL27XdFnR3qshrOTyLH?= =?us-ascii?Q?jYLHS/gR4LrLxpyOFLoJ4YtC/vVJi270hbXD5LTxVOdUkjJsuMbpINKUw1Zf?= =?us-ascii?Q?YdQKHeYyRQZg2teYElXzntDL7n5Htcr0sAUTB5bgpJGTjgSw5g0vVHrfC6Cx?= =?us-ascii?Q?zKq531EFQ5A+sPQPXmIAsnPWVC5R32W7rhrRJMUmVygB8ArkjRrpObA0U+Qs?= =?us-ascii?Q?OtLFCt1u0KvYVBBbLD9pdgfIAzh5WiZFuG3WockIMBsAeJMImJlXQKXlwQt4?= =?us-ascii?Q?0tRQtXspBm8B7Zv+xkccCpwfF0AJJRRRFpamJtwD6nhqPSb8zrvwrWHYYiyz?= =?us-ascii?Q?gKHprx0cfRuy8870bJYT/IBQshG4rxz7/dLsyTXKxDzmLEEAxBDmq2vxbwCi?= =?us-ascii?Q?vnVyVL3Sfe+5J5SLeJq5M5jSnAoyWmSihwloKmBmsy7QHCsmU0M/hqjn5MYw?= =?us-ascii?Q?YDp9wx5xYYIwK30vQUi1Q7I1l4cBlRi0m06sYsMp?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1739.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cd0ac344-2f20-4580-1fa6-08dab1b2dca9 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2022 09:18:19.0244 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zbiImtJBjl0N/7UWrLcfmMOo/7PW/P9OH2Miw2ndQym1lFU8lxJQbejXR5GO9muokayLveUi3Z5jSOrMl+9QEw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6256 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Chenbo, Thanks for your review. > -----Original Message----- > From: Xia, Chenbo > Sent: Wednesday, October 19, 2022 5:15 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coquelin@redhat.com > Subject: RE: [PATCH v8 11/12] vhost: vDPA blk device gets ready when the > first queue is ready >=20 > > -----Original Message----- > > From: Pei, Andy > > Sent: Tuesday, October 18, 2022 8:08 PM > > To: dev@dpdk.org > > Cc: Xia, Chenbo ; Xu, Rosen > > ; Huang, Wei ; Cao, Gang > > ; maxime.coquelin@redhat.com > > Subject: [PATCH v8 11/12] vhost: vDPA blk device gets ready when the > > first queue is ready > > > > When boot from virtio blk device, seabios in QEMU only enables one queu= e. > > To work in this scenario, vDPA BLK device back-end configure device > > when the first queue is ready. > > > > Signed-off-by: Andy Pei > > Signed-off-by: Huang Wei > > --- > > lib/vhost/vhost_user.c | 33 +++++++++++++++++---------------- > > 1 file changed, 17 insertions(+), 16 deletions(-) > > > > diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c index > > cd65257..e0ff79d 100644 > > --- a/lib/vhost/vhost_user.c > > +++ b/lib/vhost/vhost_user.c > > @@ -1441,11 +1441,14 @@ > > } > > > > #define VIRTIO_BUILTIN_NUM_VQS_TO_BE_READY 2u > > +#define VIRTIO_BLK_NUM_VQS_TO_BE_READY 1u > > > > static int > > virtio_is_ready(struct virtio_net *dev) { > > + struct rte_vdpa_device *vdpa_dev; > > struct vhost_virtqueue *vq; > > + uint32_t vdpa_type; > > uint32_t i, nr_vring =3D dev->nr_vring; > > > > if (dev->flags & VIRTIO_DEV_READY) > > @@ -1454,13 +1457,22 @@ > > if (!dev->nr_vring) > > return 0; > > > > - if (dev->flags & VIRTIO_DEV_BUILTIN_VIRTIO_NET) { > > - nr_vring =3D VIRTIO_BUILTIN_NUM_VQS_TO_BE_READY; > > + vdpa_dev =3D dev->vdpa_dev; > > + if (vdpa_dev) > > + vdpa_type =3D vdpa_dev->type; > > + else > > + vdpa_type =3D -1; > > > > - if (dev->nr_vring < nr_vring) > > - return 0; > > + if (vdpa_type =3D=3D RTE_VHOST_VDPA_DEVICE_TYPE_BLK) { > > + nr_vring =3D VIRTIO_BLK_NUM_VQS_TO_BE_READY; > > + } else { > > + if (dev->flags & VIRTIO_DEV_BUILTIN_VIRTIO_NET) > > + nr_vring =3D > VIRTIO_BUILTIN_NUM_VQS_TO_BE_READY; > > } > > > > + if (dev->nr_vring < nr_vring) > > + return 0; > > + > > for (i =3D 0; i < nr_vring; i++) { > > vq =3D dev->virtqueue[i]; > > > > @@ -2958,7 +2970,6 @@ static int is_vring_iotlb(struct virtio_net *dev, > > int ret; > > int unlock_required =3D 0; > > bool handled; > > - uint32_t vdpa_type =3D 0; > > uint32_t request; > > uint32_t i; > > > > @@ -3170,17 +3181,7 @@ static int is_vring_iotlb(struct virtio_net *dev= , > > if (!vdpa_dev) > > goto out; > > > > - if (vdpa_dev->ops->get_dev_type) { > > - ret =3D vdpa_dev->ops->get_dev_type(vdpa_dev, &vdpa_type); > > - if (ret) { > > - VHOST_LOG_CONFIG(dev->ifname, ERR, "failed to > get vdpa > > dev type.\n"); > > - ret =3D -1; > > - goto out; > > - } > > - } else { > > - vdpa_type =3D RTE_VHOST_VDPA_DEVICE_TYPE_NET; > > - } > > - if (vdpa_type =3D=3D RTE_VHOST_VDPA_DEVICE_TYPE_BLK > > + if (vdpa_dev->type =3D=3D RTE_VHOST_VDPA_DEVICE_TYPE_BLK > > && request !=3D VHOST_USER_SET_VRING_CALL) > > goto out; > > > > -- > > 1.8.3.1 >=20 > Reviewed-by: Chenbo Xia