From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 326DBA057B; Wed, 19 Oct 2022 11:19:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 249F240E03; Wed, 19 Oct 2022 11:19:21 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 8E93E40A8B for ; Wed, 19 Oct 2022 11:19:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666171159; x=1697707159; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=5+BC+lEhOijurLHDJyOYtUhOO8poyyWWMz9Jpa7lRgk=; b=bpzU0PgnYeZyWjNYJv4maIOe6IM26KW9US5Q9EYlX1aakiLx4kHajnUx L2mh1W5FsTcFw5vKWqBhpUPhsK6s/j/CMmothXqm6HD4N5AR4+JGXF467 wl2deekhSVFlz4fSXyvEAm1aSot+ba/mqCaN0oJdhMgebnCRi4+1UL1WJ ovsP2X5fDNZ23MF/qHn6NXDdmECE5YeF3boL2gDWoccih8GJMOKT5VabC vEOvrjTXBm8fWo87U8SsSbpKBhENIjTaUmauh5BX4ptvyQc/4Sg7cm42c 75Y7cu1KyiLHejQ2OeX/7RcmYqZfYxrfQ6qhEeAIbxihPetPMFOM3044w g==; X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="286747789" X-IronPort-AV: E=Sophos;i="5.95,195,1661842800"; d="scan'208";a="286747789" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2022 02:19:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="662366823" X-IronPort-AV: E=Sophos;i="5.95,195,1661842800"; d="scan'208";a="662366823" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga001.jf.intel.com with ESMTP; 19 Oct 2022 02:19:17 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 19 Oct 2022 02:19:17 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 19 Oct 2022 02:19:17 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.109) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 19 Oct 2022 02:19:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hsDSiNGS8WCt6Spifea6u0eyEH4Y4rDt5PgLDcQKbu0+OahKECMqx+JOfZrd5fX0mjFDvqNLFY8tkYuMtfKUrbqrLNK+/RCSdBR0+2cMQiohJ4xHVq/1LYdIGHAjPM0t2IduqsbPus0cSjgUFpp0M7o8aTt7qV6dZ5GEgl0zBdMZtQtPIYvSyPRylb1//EcrFf/6ec2D+ombUlVjMDOfWChSKZASoUluFK0mcyt8BpikWG8ajn5BlHWnQ/GmR1VhRcmTlgEJ00hA93Vphwwhws3Erq/wi5UwTxB+peW5omuujPN6fyCp2+E5oXQj0u83hgp/T/ZKs4YJ3P8RUdMNCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ptI5TrUTCiA8xwcDYxkUyS6+zRd6+67nRNmfNZSwu5U=; b=jHK/GQX6c92kDYIlnhwfDmY07Z9yMuzEnnp4B/rVrvmssHkCcoKoYrrHxspEg/mzBZiCeGgh/gRSFWHcYupUcjyM4HUHBASOpG0kcbWvXOpGsdQpxAIxRR1J/Lb5gA5wRfxv+VN3N6zPhxERymgDrnDgT1V7Rd7HLIGFB47S6ycG3MID6qgn/coqFFK2Ze2ngtjHHg018NgnBBp8MDK0coP0DX7MtFt2eg/PHwnzw5Rum5t6QLGysrwUdp9rTkAwPS+UfWXox93MOW2sii8L33B0OIFcUZ1/SA/Hg/6KlMdgYhpeqGtep+Z8aLSWNGk0UxuRD5R9sSQHx+EHbQUnkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM5PR11MB1739.namprd11.prod.outlook.com (2603:10b6:3:111::22) by MN0PR11MB6256.namprd11.prod.outlook.com (2603:10b6:208:3c3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Wed, 19 Oct 2022 09:19:10 +0000 Received: from DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::b8d7:6a95:bf26:e4ef]) by DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::b8d7:6a95:bf26:e4ef%12]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022 09:19:10 +0000 From: "Pei, Andy" To: "Xia, Chenbo" , "dev@dpdk.org" CC: "Xu, Rosen" , "Huang, Wei" , "Cao, Gang" , "maxime.coquelin@redhat.com" Subject: RE: [PATCH v8 12/12] vhost: improve vDPA blk device configure condition Thread-Topic: [PATCH v8 12/12] vhost: improve vDPA blk device configure condition Thread-Index: AQHY45tFoaJ781PRA0GBqIO00xTASK4VcGZQ Date: Wed, 19 Oct 2022 09:19:10 +0000 Message-ID: References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1666094871-25721-1-git-send-email-andy.pei@intel.com> <1666094871-25721-13-git-send-email-andy.pei@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM5PR11MB1739:EE_|MN0PR11MB6256:EE_ x-ms-office365-filtering-correlation-id: d542bc74-8468-45ba-c46a-08dab1b2fb66 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /98890X5Qr2EIXgolkg9BBwZKC18kyQL3vjLaQjXM5qdbS++BIEMkzEFGxxeVv7nQrssQiKg2um/5yPd3V49+Pm3/mnhAEpjSLTxLZ0JhN3YVsADhzZOB3pWmjA9Ah0yf24RWT9wuX0dgBGYJ4dmt/dP4OkW8vIO/PfuMhwidS2JyiCd4JCbZd0W2tZCMJpa7u55g2dgz3hVOHyLiKJ9/IzMX+YFjHRSuCRARST2UkbMEyknUjn5+Be2oB5plA3LeTUfEl+hH/5Z50vwo7eEQUhoRseeWaiAU+Gz2hsTGkX79T+lOs8yxXc3o0vg+5ceevmcNFwpMgcvRPY06BWnq0xacMs5hMRtjOYnsLoYOymwnrxhBOA8CSlnoi0ScTdMBifwhAUanrZiNUo73oFviqnPjko4wx6ZqwOVpzzFslN9PDDwyOjs5myjETGhlZGIZK5Brkm85+2i/ldmL504uiavHAO4dON001dAee6pw0X1t1E3kbTvbmHlIuqsLzrzgRRqJKC9UctwwnKjPF6bdOrdpJ4Q7k8FEf1A1hJ5r6KOC/5GAEhYGWfwwiH1mk+gmTdXA+XSKk5KArSsUopErJHXPqy/7B9xhcR0pyzlLUIFRR8VHW7oBOgVRLuZw8BwmmnVJC0n2xZPoHFIXT/bPLWUXskyhsuZpKrxKO9L0KOjvDnq8bIgCVwvFFx9pgWrxLsS2EMlQGol+RJY/PrejPnrtpzXoJORjKSnbG3vLKNQZHUhCgX5VXAdW4JWcRDPzW+ppYW6Ri/xCSGR+PZlbQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR11MB1739.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(376002)(396003)(39860400002)(136003)(346002)(366004)(451199015)(5660300002)(110136005)(66446008)(66556008)(66476007)(54906003)(316002)(8676002)(7696005)(9686003)(66946007)(6506007)(41300700001)(53546011)(26005)(52536014)(2906002)(4326008)(71200400001)(8936002)(186003)(64756008)(478600001)(83380400001)(82960400001)(38070700005)(76116006)(38100700002)(122000001)(55016003)(33656002)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?d0cbBv+uMEYPTqDMT7ECB8FdW4HO9g2BPYk9DimWeRFMq939/eOWC+BBwYnH?= =?us-ascii?Q?eCWV2ybqxDr3CKq3yLzrHStcyPoQjJZlSgkP18Jw+dGyIX6hQF0KyQV9FOjx?= =?us-ascii?Q?IGjO3OR9+00H8nXlXbz3O6XQ32llUu/DBX66Eg0uuHYRrUjVDSQ5YFpCLt3c?= =?us-ascii?Q?dozW0Nt6epKMWWbGWWHOjDMPym1d8ufWkvvJidfMYbxzdjw6GYPt++ig+cVD?= =?us-ascii?Q?sZE1BMCl0m/kvV9ZfvVrTryfCxO1w6fxxIW/CdGy/SUQ9DjXkM1NzfB2zqY+?= =?us-ascii?Q?/Of86ZHpA2EbImppuAHtgY913Rdm6CbaBTxHMKKDQjcUzHerYAX3kl7yrfdv?= =?us-ascii?Q?FLG5CkbYHOX+y/XdrpSKv84ojjlPEFILfgqTBOruFBJKXX39t5ROKI4UDP2d?= =?us-ascii?Q?hYPnjFJLQIAGnaWfgEq09aYrR/kV3WgKEgjAAk20qCp9RxIIYS1C+/IiIqxq?= =?us-ascii?Q?MGYKlV0QIuAXYoSwt2ctQzDhVHCke48NbPRGTyEWKTSBukjSl4aGUSqfcX+o?= =?us-ascii?Q?9nBp4ItylyD00vyOmqS1EIpYIl1gWUOYvYCBhaOp+ZG+aBjAr+YcOcqZuHLk?= =?us-ascii?Q?vI529jzt+2F5OxGEmIJ0tLedWziGbQytK+mv8vxQcE+E4EBJGIBoJCrMeckn?= =?us-ascii?Q?B82/aDwbJ458o6EZpdJYXIanyZSkxtYZzV3vshQGemCk+OqSDWpHGka63px2?= =?us-ascii?Q?q6lTkqOtrWX38OXbLoCcvsd8/hxD2OZxnUHSPRWJFF0199aZjl+fNsYZZHPI?= =?us-ascii?Q?4mSexk6d5nSweZ6eurzQOBnqnL85aiYJolkSu3DRmsyo7514wfsTwWSrjV04?= =?us-ascii?Q?eFM7tGTftcsba3EQ/CJcUuk3+8c5Hpt41tV9tDop85tv0XnnzW0u9/84KO9G?= =?us-ascii?Q?IP3ueuz4cy5kL1NgIk3LgwMfdHhI9Yk+noOs+9shg7Le6CB3OgBiLUTmE0wJ?= =?us-ascii?Q?w4W0ni9iLJhCaK9Jgrk/0Ru05gKqWahpDZu9eACKXmEnmASZlNC0E7PasUr5?= =?us-ascii?Q?gludxktx2Ax8jw7C88mjxz+rMec3KRlMK95wWTd7ya4LXzvIFSmXNIo2fRkw?= =?us-ascii?Q?d8NYOP+LlhQvPbd5nOr6nC6U54SLO30q1DXLjYFvy8UO7w98/EzsgKXaPBpf?= =?us-ascii?Q?6nNwlnbRyQG1eUNXnAhGAhM6DrVPpbTzaqThMYQCLtRN+lWa9O5wVmsyBqLG?= =?us-ascii?Q?lsrxgqV3MD5mWIzqwQxPbUko14wpe/th/as3GWNpjiclKubNG2ne8Clwg4L9?= =?us-ascii?Q?3CmLSupZLrI79XKZZBw/Xli7VXMCzgQV1ltDkORJfQCzAkN5p6CHNdsqNB2h?= =?us-ascii?Q?X10QFf3e+B0RIs8oisBEpU5m7OiiW9q1maLgnjRtSyDsKCCwNe+p8ckuaRSG?= =?us-ascii?Q?nJT0+emo8c0okL/rPgB/1m8oam+IbCRIEJIbVY+4zeoS+i5ryqdHfStNFDJM?= =?us-ascii?Q?4Sr+KlkaxqI6QViHsQ37VBzV4snL1p3EmNzYE6lBDnZd8A52yhaQMtAnLIyt?= =?us-ascii?Q?fOI6rgpBXSRd76UZKV+qZ3R39v0gCz1700s/KYpADRqqRPkt6f3z6o5aC1kw?= =?us-ascii?Q?78Fsf9vTBrpbeWSG9wZ3ywbFeOdyXK4MunjzoixL?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1739.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d542bc74-8468-45ba-c46a-08dab1b2fb66 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2022 09:19:10.5676 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: F0HHXPV09RpgV2oMHHbpqG/bSkCbcGNmcFdipPP/ZFL7la/aNIUoT8vORoxL/DlWektjrbkgQ6X1VqZMTYrtOw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6256 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Chenbo, Thanks for your review. > -----Original Message----- > From: Xia, Chenbo > Sent: Wednesday, October 19, 2022 5:15 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coquelin@redhat.com > Subject: RE: [PATCH v8 12/12] vhost: improve vDPA blk device configure > condition >=20 > > -----Original Message----- > > From: Pei, Andy > > Sent: Tuesday, October 18, 2022 8:08 PM > > To: dev@dpdk.org > > Cc: Xia, Chenbo ; Xu, Rosen > > ; Huang, Wei ; Cao, Gang > > ; maxime.coquelin@redhat.com > > Subject: [PATCH v8 12/12] vhost: improve vDPA blk device configure > > condition > > > > To support multi-queue, configure device after call fd of all queues > > are set. > > > > Signed-off-by: Andy Pei > > Signed-off-by: Huang Wei > > --- > > lib/vhost/vhost_user.c | 13 ++++++++++--- > > 1 file changed, 10 insertions(+), 3 deletions(-) > > > > diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c index > > e0ff79d..9902ae9 100644 > > --- a/lib/vhost/vhost_user.c > > +++ b/lib/vhost/vhost_user.c > > @@ -2972,6 +2972,7 @@ static int is_vring_iotlb(struct virtio_net *dev, > > bool handled; > > uint32_t request; > > uint32_t i; > > + uint16_t blk_call_fd; > > > > dev =3D get_device(vid); > > if (dev =3D=3D NULL) > > @@ -3181,9 +3182,15 @@ static int is_vring_iotlb(struct virtio_net *dev= , > > if (!vdpa_dev) > > goto out; > > > > - if (vdpa_dev->type =3D=3D RTE_VHOST_VDPA_DEVICE_TYPE_BLK > > - && request !=3D VHOST_USER_SET_VRING_CALL) > > - goto out; > > + if (vdpa_dev->type =3D=3D RTE_VHOST_VDPA_DEVICE_TYPE_BLK) { > > + if (request =3D=3D VHOST_USER_SET_VRING_CALL) { > > + blk_call_fd =3D ctx.msg.payload.u64 & > > VHOST_USER_VRING_IDX_MASK; > > + if (blk_call_fd !=3D dev->nr_vring - 1) > > + goto out; > > + } else { > > + goto out; > > + } > > + } > > > > if (!(dev->flags & VIRTIO_DEV_VDPA_CONFIGURED)) { > > if (vdpa_dev->ops->dev_conf(dev->vid)) > > -- > > 1.8.3.1 >=20 > Reviewed-by: Chenbo Xia