From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96C61A055F; Wed, 19 Oct 2022 11:40:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3266040A8B; Wed, 19 Oct 2022 11:40:50 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 53A6040693 for ; Wed, 19 Oct 2022 11:40:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666172448; x=1697708448; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=zFffOGscbgfo04N1Fg+LWkok7XvfsoJPitFTHahmwF0=; b=Q5/sP6r1wJyjdhjbheIo0Wam7H7IZubssUZzeGVa9GkLQcsyuoQhTRWd AOAqO9PjGWazbAw88Ds80TTElhEE4UzeI+4QDVUIz2aK0nbGHCHG2K4rx EEGiAu3g0JAV1npMkzKvR3QnQg7YCDTmAHTxpszGkOEnqQm0BmGGSozrO NjdbcoXFFvfAOdh08qLXK0Rz2KRtwoq9c1cgeA5f+MSUa1TSzmqWcw4G+ Ot9RvfX2zrMvf61dY9Jz6MibIwak3rhCmgVTbDTdscYJGIpSfcCgjN2RB MXrM5MGN0hHPrel/CQYLlUpQOn9fGJypWh2FZ48Rh27rZhkuNi3OEItZ7 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="286753060" X-IronPort-AV: E=Sophos;i="5.95,195,1661842800"; d="scan'208";a="286753060" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2022 02:40:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="958256526" X-IronPort-AV: E=Sophos;i="5.95,195,1661842800"; d="scan'208";a="958256526" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga005.fm.intel.com with ESMTP; 19 Oct 2022 02:40:47 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 19 Oct 2022 02:40:47 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 19 Oct 2022 02:40:46 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 19 Oct 2022 02:40:46 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.170) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 19 Oct 2022 02:40:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GED7wumvzXZzoMnEa6ri+44B4jnYCRB0idIgp3OF7KpsB2eBhhMfiHM+OgXVOmqFxJf++T12cHy8mwRdHdzMLt5nJ66Cu5exg1lLMEBR5kJtI1jpVBf+EcQ+9YEVab5v9fF8GdPTnMpzxdRt4xw3OmF2p8oUMpZrIf+WW2on8P7T1kNTCAiOFZQaBFvGrJAPoIdZqNGEymOwfqH15TAGJ8aZQfc0LqVOj+bTTW0XAzbUyQiStmKl++Z4CcZ9n1X4xRwl2dh/Q0xcCpmAtQMMT7lHmW37J7j1A4VI8LTh7ewr5x9iPegx/fXbYYXCdgdVTn8rlNWJ+nBbN0plezM+bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yid7aFTWTYTzwsxIkkQc1D9fJY406v0kWpOLhPKeW0U=; b=LRqABJJzzOpc7WMwWG2X61Z/M8RkPO3M6SET4Q6DLeOWl+Gctaj4zOA/YZx6XwBgOAQ7GcYzUpNgy1SU10V8gWYnymrieXzyh/nssNWLAD+WtKmHyQUa8yLRTsyc3yyY44W4ICvWYhMhKPQIgOuGUwDkwqsF06dQ3PCgh9AJCcGmGFNW2sdfxFRCHkdqF1GknbleGnIoCxS/mXcyoHbN1RPNx3Uj2OkX64yLZdN9mNmS6UfYZ4Yq7P0RmL+wP5bgCpq1J3UuEJgIJd/E1KaidVm4JFJiisvCR4D3OzHMiCziZKClezD+oNxmug8USp6+ZHMpPs3c7UgqQE0Hs5E8kQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM5PR11MB1739.namprd11.prod.outlook.com (2603:10b6:3:111::22) by PH0PR11MB5880.namprd11.prod.outlook.com (2603:10b6:510:143::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Wed, 19 Oct 2022 09:40:43 +0000 Received: from DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::b8d7:6a95:bf26:e4ef]) by DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::b8d7:6a95:bf26:e4ef%12]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022 09:40:43 +0000 From: "Pei, Andy" To: "Xia, Chenbo" , "dev@dpdk.org" CC: "Xu, Rosen" , "Huang, Wei" , "Cao, Gang" , "maxime.coquelin@redhat.com" Subject: RE: [PATCH v8 08/12] vdpa/ifc: add internal API to get device Thread-Topic: [PATCH v8 08/12] vdpa/ifc: add internal API to get device Thread-Index: AQHY44jo4KV8Pb4VuEiftu7BYRC3mK4VdpLQ Date: Wed, 19 Oct 2022 09:40:43 +0000 Message-ID: References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1666094871-25721-1-git-send-email-andy.pei@intel.com> <1666094871-25721-9-git-send-email-andy.pei@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM5PR11MB1739:EE_|PH0PR11MB5880:EE_ x-ms-office365-filtering-correlation-id: 0cc0257e-7db8-49be-2029-08dab1b5fe3b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: C43fjTWRmA/AkEyuBvtwLAGnJqtcP3OOxN+Mo2QKdjDkPPgZd8EWg620lj/A72yFEVSq5RFbY2FC8BqRGUnf2mmAWvCmmwHNmM/VRKC7G+mCUMWrMU1tQnDiW/GG1kKAuwICjH1wKmCV7+Mcrj5JMHKhkIiNqr7Wx2Ekb+mOMOx8fFMgH6uLcp/Mob1vWg1Ocy3N/VtkDh98CMB24x5qzynuK7b+1wfT51MT6EIR9zFs0HSy2yaZPKgpfk1wbu2ErjHcnjr+A0lcPqeRekofIAGJPHLEBuDHafrc2hsOgo7Xp7w/39V1s8+Dv9IKdF1H9KrqoXuWPWyCKQLnTr4rkXz2quXOlVgaRFC5nzv0ucxCtRjX2gvw1qUAioF56qfGHeZ5efMhwBoeDeRLlukr+eBFhVyJl0fpGt09UZfMvH/If1g4l49uGwR8KmmF4TYy5n8668h0Sl+7dDEUGiU9tyFqrxLCU72Ld6JRwIfUc+Edj1IIWtdgef3MQpb5u1VTls6OF9V7RBCIKF6S1ce9WjU6a38VaJUwkfuXKzhV/o8XcVj3jD/roZCpNywNOBeMdHNVvfLExzDc7XajJaU9LSXh/+iKAtkPv4xSu2Uh9rtqHj3xFfDPKkomx80gcjNprSqNAIRoEWQLRer7vzwcZDu+Li+S5nqyMAWvGyPYsPThXM+36DFGRfXtGSOAuExH0BKkMSKHna6Z10tJH09Ro7xPCVlisZfotTFYfemrKuvvkSBANw+V0EqdyzaQoF5E3IzpvxQyrFuMfwjxgl640g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR11MB1739.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(346002)(136003)(396003)(366004)(39860400002)(376002)(451199015)(122000001)(9686003)(38100700002)(38070700005)(55016003)(33656002)(66946007)(86362001)(316002)(66556008)(64756008)(71200400001)(66476007)(66446008)(8676002)(76116006)(54906003)(110136005)(4326008)(82960400001)(83380400001)(5660300002)(8936002)(41300700001)(186003)(52536014)(7696005)(2906002)(53546011)(6506007)(478600001)(26005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ItIUhIXkJX6a0Znd0//GSYDFIJx5s23Tpyz7RwEerOab1soBGzhj6uEeYiOY?= =?us-ascii?Q?/CAypKAfTsZcxdqBWns/fKwhWp8+HcFNo9DzmI4vR//SOia9pPNTTYf6BrsP?= =?us-ascii?Q?GZw7QPAo49RlNnsEbUMC8LW6lYSkk+IKVvX3OzE0Y3p4lBT2rs9ttn13LRe3?= =?us-ascii?Q?rdmQo6rxlmQx07RwEfqVAzH88t608X+i0Ouy/mGEO6lm0Zd7IJaY5g7MzyKW?= =?us-ascii?Q?d2fAvQT9SWFcUou330XQGJjxPPo6kQtWO4Ogo7mdFmeDmowgPGQye4Scob7T?= =?us-ascii?Q?zqHAOAFBDhTDX5ZqskcQu0J3U+OpQA1R0MExgr+iKXgC2xWSG8XpcOuOBrHx?= =?us-ascii?Q?YGJYw9NSxwR1OweVZi91dyGfHVMMH1nPvKWhVLZLZDRbY7JdNkzhfvf56bSV?= =?us-ascii?Q?56osPNEAhs9V9PcNM31DluT/zB7DDopQ20d5Qmq2+hdHFHQFp10QfdsiEOcb?= =?us-ascii?Q?qu3XHxRTCbzca4Fpuevvhs2Vc+d+xfImZJ8devLTAP8u3tr6SeMtrJTkxScs?= =?us-ascii?Q?SWbB7JanZpo9NEJtuYHq29uQCHglCBQ5Dna0YvRz3yjCnv65Vs0xvpBDsekT?= =?us-ascii?Q?SncBxYXn+JftQkyPjqR9aM6K3SjV1YLnCMF2GoVbGv7uc6ezPEliSw1wHl3Q?= =?us-ascii?Q?9N4ltnyl4vHtPeU1+8pYzvg+QG5ywXFUSiPFdWA6v/t/rTCdeHWonZTqpYip?= =?us-ascii?Q?INZTFi8ibUYgTzHHViZrdUU1bm1Gtyf9C/UjEAzNRKqZ9SAqYmHTvIcNFqrx?= =?us-ascii?Q?eKrf/QQsJqE6Es78RaCuH/fxT5y5DAYqhEdjel4oVRhXLgDyob5zp9l5fAXg?= =?us-ascii?Q?/eCebHRWWxU7odGIGfLn4lvrtHKLbV+nP/GHQfREUUWXdmJBZpyUoUMD+/Yn?= =?us-ascii?Q?jN610tgtZiZk8gwlderWz8AfahlvlVUtuS83nRwuo4ZdONu0pMlDe66jKf8S?= =?us-ascii?Q?5/XbanDyskXhleE9CHg1lhSBSSkIqUmDIVQnVwLWQUcewwV7a0gY38qf0oWS?= =?us-ascii?Q?Z0SudSLsYyYVRdSz3XOipMnCO6fEfvVpgmwlxihKs2gi+pcyhXDTvUo3ttqE?= =?us-ascii?Q?+s8pB5iBhX3Jn5AjnfegaQnZQddBEfsZlMAI4MhAv13sjbRup4B7sJXusm5q?= =?us-ascii?Q?WG1Goeci8h6cDGjvOSFZjbMVOVDadcQl44bqOkIUo/H6NNb8T5lb0DufYVVN?= =?us-ascii?Q?zgvc8CmLC/KWYXTCQUy4o4xfm8ktxf+2HEmatuaAMV1Hi3urXh6qyw6O3MLW?= =?us-ascii?Q?JCin6L3VdDWUnAA5erCsbNBtng9WyRkSXClePNYCB/QFoY+mB8e6YMQV5hGP?= =?us-ascii?Q?HnrQrvV2k9xPktBdkKAEyBhF7iULhuZ9lEWVXKJyAs++4kuiu02sDQgorlCr?= =?us-ascii?Q?7a7WIrzkU+J/dRicTFN4BxXaqWFKSVA1Q01KoKvwHxbMJZaSaU2X9CJGVC07?= =?us-ascii?Q?q0kNDp+fnqr7XHTsI+rTzUCCYoiMqgPS21MgUj4GopjfQbRcLrfUFMKRQlCd?= =?us-ascii?Q?icWuopgISLOsvAworrx9YGEMhK3OxgQQC62+I9rptKR27hwrkyKPYhHAFbP7?= =?us-ascii?Q?RVXb89Q4yNk42/Td5APTpke0BQuWam91BTjNJup6?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1739.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0cc0257e-7db8-49be-2029-08dab1b5fe3b X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2022 09:40:43.8362 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mb/wu2KYQPJVyW849XCNADYzHHT2UGkx2URFkQixTA5QmX+5Tlsmc4Fj1O2KgE+frGiCF3YvOTlav6ZYs2nLXg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5880 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Chenbo,=20 Thanks for your review. > -----Original Message----- > From: Xia, Chenbo > Sent: Wednesday, October 19, 2022 3:04 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coquelin@redhat.com > Subject: RE: [PATCH v8 08/12] vdpa/ifc: add internal API to get device >=20 > > -----Original Message----- > > From: Pei, Andy > > Sent: Tuesday, October 18, 2022 8:08 PM > > To: dev@dpdk.org > > Cc: Xia, Chenbo ; Xu, Rosen > > ; Huang, Wei ; Cao, Gang > > ; maxime.coquelin@redhat.com > > Subject: [PATCH v8 08/12] vdpa/ifc: add internal API to get device > > > > Add new internal API "find_internal_resource_by_rte_dev" > > to get device. > > > > Signed-off-by: Andy Pei > > --- > > drivers/vdpa/ifc/ifcvf_vdpa.c | 28 ++++++++++++++++++++++++++-- > > 1 file changed, 26 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c > > b/drivers/vdpa/ifc/ifcvf_vdpa.c index 73d04ed..c16e263 100644 > > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > > @@ -144,6 +144,29 @@ struct rte_vdpa_dev_info { > > return list; > > } > > > > +static struct internal_list * > > +find_internal_resource_by_rte_dev(struct rte_device *rte_dev) { > > + int found =3D 0; > > + struct internal_list *list; > > + > > + pthread_mutex_lock(&internal_list_lock); > > + > > + TAILQ_FOREACH(list, &internal_list, next) { > > + if (rte_dev =3D=3D &list->internal->pdev->device) { > > + found =3D 1; > > + break; > > + } > > + } > > + > > + pthread_mutex_unlock(&internal_list_lock); > > + > > + if (!found) > > + return NULL; > > + > > + return list; > > +} > > + > > static int > > ifcvf_vfio_setup(struct ifcvf_internal *internal) { @@ -1398,10 > > +1421,11 @@ struct rte_vdpa_dev_info { { > > struct ifcvf_internal *internal; > > struct internal_list *list; > > + struct rte_device *rte_dev =3D vdev->device; > > > > - list =3D find_internal_resource_by_vdev(vdev); > > + list =3D find_internal_resource_by_rte_dev(rte_dev); > > if (list =3D=3D NULL) { > > - DRV_LOG(ERR, "Invalid vDPA device: %p", vdev); > > + DRV_LOG(ERR, "Invalid rte device: %p", rte_dev); > > return -1; > > } > > > > -- > > 1.8.3.1 >=20 > Reviewed-by: Chenbo Xia