From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9858BA00C2; Thu, 13 Oct 2022 05:05:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4691142C94; Thu, 13 Oct 2022 05:05:58 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id BC60A42C27 for ; Thu, 13 Oct 2022 05:05:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665630355; x=1697166355; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=4aG3F31u66+FEVNjBLGTrEJjB8YXPxXeLp1mgI9w5vo=; b=f/RrBczz+TAAt3qLWMZtbXsPqsZGQsiwF+Tr3SntV+jky2mpKFsgxhZw R96Q9gz+9FolNBuw/3vol/GyCjHBLV/Ulnm4sdXQ1ow2snPD+/cIPPUSe 3YpGeOnlFPMeVGEr5TTA4N7/V12e2k5t2AFQfzdkH7g6934IJ7IRqwQ/j CSfy8F7oTcGIZ67gseflrpNmwQBVmayZUpgCgmDS4qbf/R2PxvMjrWGf8 LRzIf9yomIDsz7tsTSOpmT0Pq/krPeIqQYptFSH84yGrNzl2hjMr8m60f s3WHoJtn5XG2+FPFmHjFSxD13n8K/0NJvRKDgjm5Dy4vkiNjo2RVVReB+ w==; X-IronPort-AV: E=McAfee;i="6500,9779,10498"; a="304953878" X-IronPort-AV: E=Sophos;i="5.95,180,1661842800"; d="scan'208";a="304953878" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2022 20:05:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10498"; a="629352065" X-IronPort-AV: E=Sophos;i="5.95,180,1661842800"; d="scan'208";a="629352065" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga007.fm.intel.com with ESMTP; 12 Oct 2022 20:05:54 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 12 Oct 2022 20:05:54 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 12 Oct 2022 20:05:53 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 12 Oct 2022 20:05:53 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.47) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 12 Oct 2022 20:05:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LUv99zwJW4fE7+Nngr9veG0jAQ09frnq89VoDWsnIdGUeRX+FwfjFbm0ah17hpbSOHI4gTQ35Ma5PtCOr33XzAHr1xsacAmggxP6aArU5MC2zf7sw47Irq0PYWFmLMXNzAzdwqd98RH+1o6xb7XHdlNg7if9kNrVD8RjUULL7cj0O6yWHW2XGJCTJroRvn1GQQ87NdkJv9llYWyxuDpT6SGpJLwp6JHQziHC2m+BCB9BeiktjTFeFfjA8omcwyn6FWnQa+0CMdtj2MJ8rKlh/rkrpMfpDm8SU/Dnbh6Iyht4lGcyziBSnfBb1pU6dSmquA4pcJbGR1pbgrC3UsL6rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EYS0CCa6DenZW1vwj6MOZMfG1Kum3ZOj8jlXyVnUP5M=; b=c40MBPvP8fa55NqrtXqTluyH9EITBj9abHHdDMV6ouqdeAoqrTd8rHM6zogbQsgkxgKHx3hAQ6tzxU974dbLm1/bSJosEtkviQYHsUWKfAGR6+5TVysa2bZkYc4EsDchvubn1SpHvjrnVUouJVdq2lCrLzVyO3/JHMqcgo6F4t6eZVy/fzkTtq5cjbCQO83WLAfvjYRHWJKesvT0gI8DKhvMkG5mKXjUC/qAryuDh+b43ByYw53Fpa8rNGSr2NqLbgAhALdN7uRij2cRgqK2NviMlOkt9WymiKV0WVvWpwaVzH1wtibUu77Sqp8ada9Lqmkm7omPe/++e+necUeENQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM5PR11MB1739.namprd11.prod.outlook.com (2603:10b6:3:111::22) by DS7PR11MB6272.namprd11.prod.outlook.com (2603:10b6:8:94::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.22; Thu, 13 Oct 2022 03:05:52 +0000 Received: from DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::b8d7:6a95:bf26:e4ef]) by DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::b8d7:6a95:bf26:e4ef%12]) with mapi id 15.20.5723.026; Thu, 13 Oct 2022 03:05:52 +0000 From: "Pei, Andy" To: "Xia, Chenbo" , "dev@dpdk.org" CC: "Xu, Rosen" , "Huang, Wei" , "Cao, Gang" , "maxime.coquelin@redhat.com" Subject: RE: [PATCH v3 7/8] vhost: vDPA blk device gets ready when any queue is ready Thread-Topic: [PATCH v3 7/8] vhost: vDPA blk device gets ready when any queue is ready Thread-Index: AQHYyZPwg5jqSf63gUuaLZ7O5PLL0a4KljxAgAA6gBCAANiWoIAAI3Wg Date: Thu, 13 Oct 2022 03:05:52 +0000 Message-ID: References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1663308990-621-1-git-send-email-andy.pei@intel.com> <1663308990-621-8-git-send-email-andy.pei@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM5PR11MB1739:EE_|DS7PR11MB6272:EE_ x-ms-office365-filtering-correlation-id: 898c341c-5c3a-43ae-3f5e-08daacc7d68e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VN3gyQrLpHa4M+SKAdGXb3VGl60CbDkvweHMftTqfP3KB4cOsUv7RIPMFygUuxr+YOpKdV7nRmFjcdIaBWR+PsTslZEu3JYfKx5WquNut5GdCfHYY4fyR982ATXQx7do+zpvFa+tX+hb3p0swYqcQf1Wmt3js7wt6C3tvGDFH6rvIQBSgJEsO8YliAOdVYn1hagEvRMupriiPWsvWgf4gWOqAcXx9v64VZ++MRnOG9V6U5Vaf36g3y2uyBaCb2pJGspjGql6SWgqxBWIan/xSniqb+YkOPND0pp0dGtub27XOLO9Gxesf1lmnzl9hWNfZ6fKgzgPLZvSqDJuboc52SPxHh0ksUvQ6Vp/F6Ol53bvnAXBrm5pp8Ig77h/aY9Cq2lmjGnkPbypkkdIDwX25BWvJozZxxGds2HYImR2GyEeRe7cShfYXTLoEGpvBJwpUVnWcS3q/EulGcF4zmjp9jA0rr//EDVVFktDuv47ul0pcfYpqGCu8hgR0NISdNVa+Tx18cNftKxxRpFDO70uvCASEK89ehYYg52TqB1jVlR+tMUKgz9G8MN47VSvK0XX8/9rUZPIU9K8ZwD21IYdULHYQtbFlHxB/euMFMlkO60i6OwnV9aeepv0k/9pN+IiJ3KHlXfDKhFiuuRKvpLyOhjwA8oSr/kthxs6iqPWOljBZ1diyvsdNUtySbU8tHbGt9t8nIBA71f01WtVJa2uOEDjPdSctRsjz8Xyh0x9IRDvusMDs2RUmbOt/WZo47HSi+fTks81naJAaXn+fGDhKg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR11MB1739.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(136003)(39860400002)(396003)(346002)(376002)(366004)(451199015)(316002)(55016003)(110136005)(82960400001)(33656002)(54906003)(8936002)(186003)(122000001)(26005)(9686003)(52536014)(5660300002)(2906002)(8676002)(4326008)(66476007)(7696005)(66446008)(64756008)(38100700002)(76116006)(66946007)(6506007)(66556008)(53546011)(41300700001)(71200400001)(38070700005)(83380400001)(86362001)(478600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?G2yoEtaUWLRy9z+GLZI2DkCn69zIfBBDVI63JjF3o7AlnIepYojcpoTAQOb1?= =?us-ascii?Q?AnQVggcnxSpaxwc1sMyyvbXntM02eKkIuUTVyQ3aP7aLLwigjtLFbIWkgRvH?= =?us-ascii?Q?+GK0mtyDHk1JFHkkrH774I2JcjMCV84ygbx6n3CchgrpBXI3forvTJzKZjqG?= =?us-ascii?Q?ymtr9A9deMG2Xsv9KctbIToWJXQEUoxbq2ip6CoUsgdvikBeO3sPaoqy11Pm?= =?us-ascii?Q?gzspUhOMkLrn8NLJqGwW7Tgg0/2Ka0+nbfIf2piHfHz0QbTiGzDY+3vUDT5S?= =?us-ascii?Q?ZJz0cznnPNyY1aCJh8J1LTDvRK5pmaH/ffatC77NLLmxNGEBBoh8vip+OuXi?= =?us-ascii?Q?5DVgv498umUtcPz8hnPZmsEJZc7BLpK0kvYKr/Wf0S1dgqjzImgLLMW06YWe?= =?us-ascii?Q?/W/kdUzsVBHPD2o98YtWDUfhZBygrZi3IToz/7gN9vuXdPy1kitU8wJsrzmj?= =?us-ascii?Q?r5XAmcrv2t4F+xD5WfowI/9dcj2YEj5H6uIhXPqwO023jX7M5hdcPDUaYtBp?= =?us-ascii?Q?HfWpkU9iSrwRsnS0grbjr5a6gmaqrkGpEN8k/Fgo77lZja1ebMSRPPbWT0E1?= =?us-ascii?Q?9CAKmFOtcEbqFOr1sTXCA9h4IyFeQ5EY6zDF3JcCx7WtvfKu3PiV3UraIy1z?= =?us-ascii?Q?VpQ4LlFQa62qOQ6+/tj+ECFS07QLX3uH+D7XygN7XW0i3x72cbhh9K9CbemW?= =?us-ascii?Q?KXladr4Ix9jnVM42ktWU3kKj5mZeuzmPYtKA7ezEM0SDkjgu66shh6MkdglG?= =?us-ascii?Q?vlqmatUXCoBWD8qmYWQnljw8ioBxn/XOFBIBtMIOpXlL18difhsO6Tx5nw0b?= =?us-ascii?Q?SzJCt6kGkHqJEknyBv54D8iGphifpC1YFx6rxct44JQSlIneBFQKN1zFDYVe?= =?us-ascii?Q?hKwQFKb7xrVO0S/wJUQ+qxFClPZQ81ub2pl6s+CjiBzaEeEkSScSCJwqtH8n?= =?us-ascii?Q?m20icYV5gQJjrkY6Pi5tfBZAKu6IrZ4rF2MBtLVxftefH26USFqV6e0Asb4D?= =?us-ascii?Q?bUZ2ubtudgHbn+mWDHllrCPi4qvK8TyzTfcWAP4ngUBWpxgzXXPjxzncVIds?= =?us-ascii?Q?UyKf//xI8I/PWvht7Igj+wWOKL58oE6w7NotcH5k9oRcRxpRvbkXIfRpHJSu?= =?us-ascii?Q?hLWw9/hdIRqI5MKsChnr/tbj8d/sGTa5FLreIDFy6KLl9DjSsvnHJQDrGp6Y?= =?us-ascii?Q?yWKOxPyfE0L7NrvsEDTWuoyUmmhQD2/uCo9HX44fgiU0qB1sKKmtb8YwKBs2?= =?us-ascii?Q?8C2ihy6CDOqDaPzlBZEJlNwQ8lPJPEiow7VZrHO+47ETmVxQuzVhFKxsjs2O?= =?us-ascii?Q?Z7vVj/ECS55YVPoR68R29+XpvBxWvpvJFJkPG72HhqVW/EIA+qiKfBvfJjEy?= =?us-ascii?Q?bEYri6u0saxo7klh1rg/U5J0COWAF3pJVuIvYPQd7x/gWPYYxnSyMFZLuN4E?= =?us-ascii?Q?8ps2PmB5cHmG8sx7X49tEQAvIHc7gs533PHm25XP1aym6TdGNO7+7mQhrzg9?= =?us-ascii?Q?ptyGKVvFaUI9WzWRYHOcQvBoGZuxLsxHX9HRf+etShYY9LlJtlQzM9jedpbo?= =?us-ascii?Q?yPt8bcrNRyJm119aZEkgZwL7Zz6mxxqleEe3426b?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1739.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 898c341c-5c3a-43ae-3f5e-08daacc7d68e X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Oct 2022 03:05:52.3837 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: utKxDVU8Y2Jvr0eMXODIju9Ajn2DYYnq1Up02amwh2WxVPyrAL48XjwUNbMTpiw5nBZufHhIzmY6BwIItaFTpQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6272 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Chenbo, Thanks for your reply. My reply is inline. > -----Original Message----- > From: Xia, Chenbo > Sent: Thursday, October 13, 2022 9:00 AM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coquelin@redhat.com > Subject: RE: [PATCH v3 7/8] vhost: vDPA blk device gets ready when any > queue is ready >=20 > > -----Original Message----- > > From: Pei, Andy > > Sent: Wednesday, October 12, 2022 8:13 PM > > To: Xia, Chenbo ; dev@dpdk.org > > Cc: Xu, Rosen ; Huang, Wei ; > > Cao, Gang ; maxime.coquelin@redhat.com > > Subject: RE: [PATCH v3 7/8] vhost: vDPA blk device gets ready when any > > queue is ready > > > > Hi Chenbo, > > > > Thanks for your reply. > > My reply is inline. > > > > > -----Original Message----- > > > From: Xia, Chenbo > > > Sent: Wednesday, October 12, 2022 5:09 PM > > > To: Pei, Andy ; dev@dpdk.org > > > Cc: Xu, Rosen ; Huang, Wei > > > ; Cao, Gang ; > > > maxime.coquelin@redhat.com > > > Subject: RE: [PATCH v3 7/8] vhost: vDPA blk device gets ready when > > > any queue is ready > > > > > > > -----Original Message----- > > > > From: Pei, Andy > > > > Sent: Friday, September 16, 2022 2:16 PM > > > > To: dev@dpdk.org > > > > Cc: Xia, Chenbo ; Xu, Rosen > > > > ; Huang, Wei ; Cao, Gang > > > > ; maxime.coquelin@redhat.com > > > > Subject: [PATCH v3 7/8] vhost: vDPA blk device gets ready when any > > > > queue is ready > > > > > > > > When boot from virtio blk device, seabios in QEMU only enables one > > queue. > > > > To work in this scenario, vDPA BLK device back-end conf_dev when > > > > any > > > > > > What is conf_dev? > > > > > I refer to > > /** Driver configure the device (Mandatory) */ > > int (*dev_conf)(int vid); > > So do you think I should use "configure device"? >=20 > Yes. It will be better >=20 OK. I will make it this way in next version. > > > > > > queue is ready. > > > > > > > > Signed-off-by: Andy Pei > > > > Signed-off-by: Huang Wei > > > > --- > > > > lib/vhost/vhost_user.c | 51 > > > > ++++++++++++++++++++++++++++++++------------- > > > > ----- > > > > 1 file changed, 33 insertions(+), 18 deletions(-) > > > > > > > > diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c index > > > > 4ad28ba..9169cf5 100644 > > > > --- a/lib/vhost/vhost_user.c > > > > +++ b/lib/vhost/vhost_user.c > > > > @@ -1449,9 +1449,10 @@ > > > > } > > > > > > > > #define VIRTIO_BUILTIN_NUM_VQS_TO_BE_READY 2u > > > > +#define VIRTIO_BLK_NUM_VQS_TO_BE_READY 1u > > > > > > > > static int > > > > -virtio_is_ready(struct virtio_net *dev) > > > > +virtio_is_ready(struct virtio_net *dev, uint32_t vdpa_type) > > > > { > > > > struct vhost_virtqueue *vq; > > > > uint32_t i, nr_vring =3D dev->nr_vring; @@ -1462,13 +1463,20 @@ > > > > if (!dev->nr_vring) > > > > return 0; > > > > > > > > - if (dev->flags & VIRTIO_DEV_BUILTIN_VIRTIO_NET) { > > > > - nr_vring =3D VIRTIO_BUILTIN_NUM_VQS_TO_BE_READY; > > > > - > > > > - if (dev->nr_vring < nr_vring) > > > > - return 0; > > > > + if (vdpa_type =3D=3D RTE_VHOST_VDPA_DEVICE_TYPE_NET) { > > > > + if (dev->flags & VIRTIO_DEV_BUILTIN_VIRTIO_NET) > > > > + nr_vring =3D > > > VIRTIO_BUILTIN_NUM_VQS_TO_BE_READY; > > > > + } else { > > > > + /* > > > > + * vdpa_type =3D=3D RTE_VHOST_VDPA_DEVICE_TYPE_BLK > > > > + * is the only case currently > > > > + */ > > > > + nr_vring =3D VIRTIO_BLK_NUM_VQS_TO_BE_READY; > > > > > > You should consider the case when vdpa device is not there. Maybe > > > you > > can > > > use int for vdpa_type, -1 for non-vdpa. > > > > > I init vdpa_type to 0; > > #define RTE_VHOST_VDPA_DEVICE_TYPE_NET 0 #define > > RTE_VHOST_VDPA_DEVICE_TYPE_BLK 1 And get_dev_type only return > > RTE_VHOST_VDPA_DEVICE_TYPE_BLK or > RTE_VHOST_VDPA_DEVICE_TYPE_NET. > > I think if when vdpa device is not there, this code runs in the > > original way. > > Do you think use init vdpa_type to -1 is better? >=20 > I was talking about readability, current way will be confusing. So adding > -1 will be better. The check could be if (type =3D=3D blk) ... else ... a= s Type 0/-1 has > the same handling. >=20 I will add=20 #define RTE_VHOST_NO_VDPA_DEVICE -1 And init vdpa_type to RTE_VHOST_NO_VDPA_DEVICE and follow your suggestion. > Thanks, > Chenbo >=20 > > > > > > > Also note that below check is only needed for some cases. > > > > > Yes, I got it. I will fix it in next version. > > > Thanks, > > > Chenbo > > > > > > > } > > > > > > > > + if (dev->nr_vring < nr_vring) > > > > + return 0; > > > > + > > > > for (i =3D 0; i < nr_vring; i++) { > > > > vq =3D dev->virtqueue[i]; > > > > To make sure queue index is not out of range, I will keep above check for a= ll the cases. > > > > @@ -3167,7 +3175,25 @@ static int is_vring_iotlb(struct virtio_net > > *dev, > > > > if (unlock_required) > > > > vhost_user_unlock_all_queue_pairs(dev); > > > > > > > > - if (ret !=3D 0 || !virtio_is_ready(dev)) > > > > + if (ret !=3D 0) > > > > + goto out; > > > > + > > > > + vdpa_dev =3D dev->vdpa_dev; > > > > + if (vdpa_dev) { > > > > + if (vdpa_dev->ops->get_dev_type) { > > > > + ret =3D vdpa_dev->ops->get_dev_type(vdpa_dev, > > > &vdpa_type); > > > > + if (ret) { > > > > + VHOST_LOG_CONFIG(dev->ifname, ERR, > > > > + "failed to get vdpa dev type.\n"); > > > > + ret =3D -1; > > > > + goto out; > > > > + } > > > > + } else { > > > > + vdpa_type =3D RTE_VHOST_VDPA_DEVICE_TYPE_NET; > > > > + } > > > > + } > > > > + > > > > + if (!virtio_is_ready(dev, vdpa_type)) > > > > goto out; > > > > > > > > /* > > > > @@ -3181,20 +3207,9 @@ static int is_vring_iotlb(struct virtio_net > > *dev, > > > > dev->flags |=3D VIRTIO_DEV_RUNNING; > > > > } > > > > > > > > - vdpa_dev =3D dev->vdpa_dev; > > > > if (!vdpa_dev) > > > > goto out; > > > > > > > > - if (vdpa_dev->ops->get_dev_type) { > > > > - ret =3D vdpa_dev->ops->get_dev_type(vdpa_dev, &vdpa_type); > > > > - if (ret) { > > > > - VHOST_LOG_CONFIG(dev->ifname, ERR, "failed to > > > get vdpa > > > > dev type.\n"); > > > > - ret =3D -1; > > > > - goto out; > > > > - } > > > > - } else { > > > > - vdpa_type =3D RTE_VHOST_VDPA_DEVICE_TYPE_NET; > > > > - } > > > > if (vdpa_type =3D=3D RTE_VHOST_VDPA_DEVICE_TYPE_BLK > > > > && request !=3D VHOST_USER_SET_VRING_CALL) > > > > goto out; > > > > -- > > > > 1.8.3.1