From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 38D7CA057B; Wed, 19 Oct 2022 11:19:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2D4F7410D1; Wed, 19 Oct 2022 11:19:59 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id D7E4740A8B for ; Wed, 19 Oct 2022 11:19:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666171198; x=1697707198; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=69e7XIjUYzv1ZEmUXQxmtDETiZdZ0cSj72Suw1VYsKI=; b=RMtXVF01K7jBShZp1yTcm4qh2/6aVsSjbqAD7M2X+IvpJ/Q0tpxE3hmy cMiRkRNDUOK0/8HL23jjuwZosOKEl9ZXqdDJa4RpxGEsqfEdNCzPzZsOD ijNT4X008DgsWEAay4gwen4K6G57jzT5Ue6OpKRTGnzqYL4kALjIiTF0U tzX4i53/dZw//d31XKF1VfLT1cce4xVJREr2r4fw6MSsc9wfNaa1eBjmZ to6FaB1PcJ8nGqFrFOnQEfjo+D/m6QbIT8ycuiTb6ri/WnMF7FuIBcHOw w2ojYJ+6FALkf+0aSuFDkL6TEnmnFCMd4aq0PP+qAS1Z21gAe9c4cRble w==; X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="370575204" X-IronPort-AV: E=Sophos;i="5.95,195,1661842800"; d="scan'208";a="370575204" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2022 02:19:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="662367078" X-IronPort-AV: E=Sophos;i="5.95,195,1661842800"; d="scan'208";a="662367078" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga001.jf.intel.com with ESMTP; 19 Oct 2022 02:19:56 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 19 Oct 2022 02:19:56 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 19 Oct 2022 02:19:56 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 19 Oct 2022 02:19:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gGCE7uJNHd10CifQpk23yE/MR/rEoQmHVtbSOoSL4P6dFc89I2pbSNXmSBldAULlSiWI76tY3JtBaw6qZvQ5H2iLeOm/ki20Z8pYfWy9pV4ybB6I/6GT/4rrEwYoN5VAoxaBZjNDG8wDmo87GaZ/tSec8SmhP4n4jCxhj3CbMBgAdNzAfPPfuHrt9deMNbbQNwG4wvenY3DCq4MwsFdn59SC+ago7rA75HKiB+/RksnZ2uY5CUdE/EYcOXHpZ7sQuDfYq/xCO/8EXBJ3zvEYtKjWQHjUm+15hoFB5O6qz0abG925j/i6qtzZ5MNRztefIbNZcLi4MA/cAPuhamQvnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cq7tGCV8jXtCnbfvEScoATl5Ys3s6NFtEabic+cw5Ts=; b=P9sHlmU/yHATke72iiTBLSuiF4U199d2Yf74GjgrA+KI/dLYIWE+ry0Sv1jL0ZKOGfDdFdNgPZm7t4QJyV27+VpgA8R0pCHQhhEujZwvgzJspfoHDDdCu4SHuB2N6K5OVTxFCquzoV84yPPe/rsyJv57ARuPqlmThHYPqe0kcAJe3rcCO9icJxZ1uuSj1QpEG6/Z+FucSHNWGqX83suDnAlArxXErStWdFvI8yPv7fi7grz0cmcpjve8rjXygvBEDFbEBad51qgEgWd0jXE3iDJkHa4V/FBSM1fCrPv+u2hVUiX+oWf24kxzbmY1fEwovXDbbyM/gED45V3KRhVxVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM5PR11MB1739.namprd11.prod.outlook.com (2603:10b6:3:111::22) by MN0PR11MB6256.namprd11.prod.outlook.com (2603:10b6:208:3c3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Wed, 19 Oct 2022 09:19:54 +0000 Received: from DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::b8d7:6a95:bf26:e4ef]) by DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::b8d7:6a95:bf26:e4ef%12]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022 09:19:54 +0000 From: "Pei, Andy" To: "Xia, Chenbo" , "dev@dpdk.org" CC: "Xu, Rosen" , "Huang, Wei" , "Cao, Gang" , "maxime.coquelin@redhat.com" Subject: RE: [PATCH v7 10/12] vhost: add vdpa device type to rte vdpa device Thread-Topic: [PATCH v7 10/12] vhost: add vdpa device type to rte vdpa device Thread-Index: AQHY45skSGgs/J63rkCqdE6P6USZsa4VcKBA Date: Wed, 19 Oct 2022 09:19:54 +0000 Message-ID: References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1666073977-175484-1-git-send-email-andy.pei@intel.com> <1666073977-175484-11-git-send-email-andy.pei@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM5PR11MB1739:EE_|MN0PR11MB6256:EE_ x-ms-office365-filtering-correlation-id: 121e084a-4e6a-47d0-c738-08dab1b3159d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vO5xGShOHSnu2H2fBQfSBRZp38Ugnk5ucE9DQUneMiFmO/Sl2hihA2kDHuVlPwLukxnpYXKk3QEB6DPGqqnscKNeWn7kSpP2T+bgp/8BCF5icqbFZOyr+rYYsJIeZ0MFA+t8KAJid7vl7R6bRSmwZDjSYE0Xk++czo8WFgLMFHmejFJwNIvDE6MBlbphVe/FIy71wodaFWrai7NUBtrGFSMPkGPFRI209ejaxeFD8cy12uXhO9MgOWbQ/Zrx5lEQMBBa2x8y5pUchFvJXAmGZWBraehuVuxePU+CW6uE2H+VnkfdK1++azH2JPxjtNosZ0x1c4Mb73KbOMYnABN6i+wsO83r2FzzIn242e9JJF3ZsTSYQgaK3TEBhn4sEhtEIl1ucuCR3UMux6GRLUtXEfxmaCnV19nbP1TScgvIsGQQeE3txdN6VhVcF7FlUVHLNEV1GXACXT/7MzXzqI8WbE191flRdjYcy7iy/73PQX2WXmZ5nN8sJuY+RzLroip1uJlxJV783OD1BOLSOtqHDSYK5oAcsfGSNSqc+K3icx0+d76wzG56t5UBHiylx9Ue/SUeNCBYWvOlGa5X/nuhf8Jrl+ELXu7v3jZKBfeTX7NhNMRfOagpkYlF5tnGQMjlemJgZqLgoA39QGxrrIikuKkx2f9k2acwhZF3wED6l4t+TWQ/WyzoG3fGyrlbZ+CNrBju3EGbkAfT1LvXR24A/M0koHX0arARc0phM2RwjtJsvX8/+mbnNtmDJrWYcortXMq0w/diK5HEAsNcGeGdVw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR11MB1739.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(376002)(396003)(39860400002)(136003)(346002)(366004)(451199015)(5660300002)(110136005)(66446008)(66556008)(66476007)(54906003)(316002)(8676002)(7696005)(9686003)(66946007)(6506007)(41300700001)(53546011)(26005)(52536014)(2906002)(4326008)(71200400001)(8936002)(186003)(64756008)(478600001)(83380400001)(82960400001)(38070700005)(76116006)(38100700002)(122000001)(55016003)(33656002)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WmjW5+LHuExPd0offjZ1WUr9mtCaikDe/XbmLV7sXiEoPq6k6YJvPqCZDxuu?= =?us-ascii?Q?UxcsiQjYkoyXuOYvoADh87s5auIvlOq6pDY+RPZYcg+/PVSmszWTZ19kjmyp?= =?us-ascii?Q?oCZ0c1dLbDVidifM7bRQRQJXzo9JIkD8NNfBG+iDklH6j1RpXZ9bXTbB3ql0?= =?us-ascii?Q?DADdyZpC1rlZrQW25LbIDppV5YjgvM7fikJKBIe7xna9jKBZ4tS5+O8SYqWF?= =?us-ascii?Q?Idzk/uhVi6S3h/fTcpG38x5t+AJg+qwH7mRvQDYJiRfOzPS+78pWQpe2JAK6?= =?us-ascii?Q?drhO6NqTVAl0LwuQ3vCDNclgJof2ADpI6Wmre4mF09qDT26fqnklnKPGUSir?= =?us-ascii?Q?cfZmAah7Dtnoftjjg+VdGsUwOZN+H3imrml/ALKdYPKtJFJQ7OlcJoZj6oo3?= =?us-ascii?Q?N0grPi8Sg/RvbOmzIS1o/yB3ClYDzVg6AIESVnpKLv5v48L8zWOKaVyRnUHB?= =?us-ascii?Q?NYW2TXz04/aKPTLvHmY4xDI1pL1ZZwbwwi6zjIokxHAQ4N7jWV5jzbxF8Fji?= =?us-ascii?Q?D6bkSUfzutCmJ3Da5yPhF6vC72faoNCa8pgpjKFHO0GRpEutu1GFmrxBc93S?= =?us-ascii?Q?9y6NMm+TTO9b5KL68Yfki52R/IKsvUPSQz7PthSEzaqRZiPZBhZs+BWwOKC9?= =?us-ascii?Q?u+ORkqNM3c3wfFoo5xGMyK55XIJuFYM7eFJc30b+IA88vdaRLhFgT/vOHNYH?= =?us-ascii?Q?Eyj4FFxqlaYcJMccIznpFn6bWTlNNn7kGtamW0/UAvkaEph9px6FWV147mYl?= =?us-ascii?Q?UiwMzEmeeAW22wvTHQBgekw2TS5rqg7n7AXOC2aRdqcsbbP9nCiQoNbq7huO?= =?us-ascii?Q?kj6NxV+ZJZYUYDV1+DqCuRtuLwSFWXc2/UM32h4aLbMkFYRSrvYARwOutYPh?= =?us-ascii?Q?X4+Dgt1YzojmuBx5HTUZSYz6WbQM5eNtVhr4C7SOxkrUehFvzqEz+IHUXAgj?= =?us-ascii?Q?RKxPzxPPTInYpZhzSL2/MOFMWUQgZ7NlFU0YnKo6qrqEDK8cAQRhdUAQ7xUb?= =?us-ascii?Q?B5szZey3z3HOB6OM90Ld4yqeAyB8KfxakiKnBv+gHChQx+eIshBDMxLoQMUw?= =?us-ascii?Q?uovOF8mQChg3ntx/jEja/lSoNVXaNRT2UsPHrWXLZY83YfnoKGAxospI68WP?= =?us-ascii?Q?8Oane1mw2InEzhg4oa2Kpm8efwppzWMbdX6LgWHkRfkSVToBTgVXY08gSJ9I?= =?us-ascii?Q?x2PEz/GPFjA0B/+kxYZoOHF0FHv+KUTEYI0PGh1C3pesCwykQCcSRnH7LkWW?= =?us-ascii?Q?cK0tHHMyoeLVy7VigqljjbxUEQZGAJbCXEzTCwajNxW/CznR/dHu2jDcGSn/?= =?us-ascii?Q?IW+77Z/5Juxob/6RY9y0r5gNwcyouGEyfUNeWol3ju2tiRrmSzJL7BsFFjIC?= =?us-ascii?Q?ErsA1B1Y0W6xZLAzOyPz1c8OSo6KhEB76DhmJWl2p5qGmtbeLKarDUejWO64?= =?us-ascii?Q?FtqnlBnxEkYCohm/Cgl3yChe8CvERFoBBEd6i4Oc3O3rN67AHwyAvgO0KbkH?= =?us-ascii?Q?cwq52J9TT3tT6j1796s7IV/L2XfIE/0YEvu5Ga8Dun8aJi+xGFeDSW/ZA+jj?= =?us-ascii?Q?Dyzp1W1a6s06zpD7k8l3aAIpS6KGw3VZHaTEDoFI?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1739.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 121e084a-4e6a-47d0-c738-08dab1b3159d X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2022 09:19:54.5801 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ShupLcELAN0IZ6EaY5E4v8Gcve7aETz4QKTmQIxyNRsMSl/4L5r22MpBZoBHiiKGmfWytV8Gc1lmDBqWQJYkIg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6256 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Chebo, Thanks for your review. > -----Original Message----- > From: Xia, Chenbo > Sent: Wednesday, October 19, 2022 5:14 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coquelin@redhat.com > Subject: RE: [PATCH v7 10/12] vhost: add vdpa device type to rte vdpa dev= ice >=20 > > -----Original Message----- > > From: Pei, Andy > > Sent: Tuesday, October 18, 2022 2:20 PM > > To: dev@dpdk.org > > Cc: Xia, Chenbo ; Xu, Rosen > > ; Huang, Wei ; Cao, Gang > > ; maxime.coquelin@redhat.com > > Subject: [PATCH v7 10/12] vhost: add vdpa device type to rte vdpa > > device > > > > Add vdpa_device_type to rte_vdpa_device to store device type. > > Call vdpa ops get_dev_type to fill vdpa_device_type when register vdpa > > device. > > > > Signed-off-by: Andy Pei > > --- > > lib/vhost/socket.c | 15 +-------------- > > lib/vhost/vdpa.c | 17 +++++++++++++++++ > > lib/vhost/vdpa_driver.h | 2 ++ > > 3 files changed, 20 insertions(+), 14 deletions(-) > > > > diff --git a/lib/vhost/socket.c b/lib/vhost/socket.c index > > 608ae57..f768114 100644 > > --- a/lib/vhost/socket.c > > +++ b/lib/vhost/socket.c > > @@ -627,7 +627,6 @@ struct rte_vdpa_device * { > > struct vhost_user_socket *vsocket; > > struct rte_vdpa_device *vdpa_dev; > > - uint32_t vdpa_type =3D 0; > > int ret =3D 0; > > > > pthread_mutex_lock(&vhost_user.mutex); > > @@ -644,19 +643,7 @@ struct rte_vdpa_device * > > goto unlock_exit; > > } > > > > - if (vdpa_dev->ops->get_dev_type) { > > - ret =3D vdpa_dev->ops->get_dev_type(vdpa_dev, &vdpa_type); > > - if (ret) { > > - VHOST_LOG_CONFIG(path, ERR, > > - "failed to get vdpa dev type for socket > file.\n"); > > - ret =3D -1; > > - goto unlock_exit; > > - } > > - } else { > > - vdpa_type =3D RTE_VHOST_VDPA_DEVICE_TYPE_NET; > > - } > > - > > - *type =3D vdpa_type; > > + *type =3D vdpa_dev->vdpa_device_type; > > > > unlock_exit: > > pthread_mutex_unlock(&vhost_user.mutex); > > diff --git a/lib/vhost/vdpa.c b/lib/vhost/vdpa.c index > > bb82857..b487f4d 100644 > > --- a/lib/vhost/vdpa.c > > +++ b/lib/vhost/vdpa.c > > @@ -73,6 +73,8 @@ struct rte_vdpa_device * > > struct rte_vdpa_dev_ops *ops) > > { > > struct rte_vdpa_device *dev; > > + uint32_t vdpa_type =3D -1; > > + int ret =3D 0; > > > > if (ops =3D=3D NULL) > > return NULL; > > @@ -101,6 +103,21 @@ struct rte_vdpa_device * > > > > dev->device =3D rte_dev; > > dev->ops =3D ops; > > + > > + if (ops->get_dev_type) { > > + ret =3D ops->get_dev_type(dev, &vdpa_type); > > + if (ret) { > > + VHOST_LOG_CONFIG(rte_dev->name, ERR, > > + "Failed to get vdpa dev type.\n"); > > + ret =3D -1; > > + goto out_unlock; > > + } > > + } else { > > + /** by default, we assume vdpa device is a net device */ > > + vdpa_type =3D RTE_VHOST_VDPA_DEVICE_TYPE_NET; > > + } > > + dev->vdpa_device_type =3D vdpa_type; > > + > > TAILQ_INSERT_TAIL(&vdpa_device_list, dev, next); > > out_unlock: > > rte_spinlock_unlock(&vdpa_device_list_lock); > > diff --git a/lib/vhost/vdpa_driver.h b/lib/vhost/vdpa_driver.h index > > 8b88a53..c4ec222 100644 > > --- a/lib/vhost/vdpa_driver.h > > +++ b/lib/vhost/vdpa_driver.h > > @@ -92,6 +92,8 @@ struct rte_vdpa_device { > > struct rte_device *device; > > /** vdpa device operations */ > > struct rte_vdpa_dev_ops *ops; > > + /** vdpa device type: net, blk... */ > > + uint32_t vdpa_device_type; > > }; > > > > /** > > -- > > 1.8.3.1 >=20 > Reviewed-by: Chenbo Xia