From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 509ADA0547; Wed, 12 Oct 2022 10:38:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E2AF242D6E; Wed, 12 Oct 2022 10:38:14 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 7821142B6D for ; Wed, 12 Oct 2022 10:38:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665563893; x=1697099893; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=P7Ocs21BTYjxF/vO1qy3saC6JT8DQ1Pw44uZa1aOeCw=; b=P0cAQh7czy4tUmjdB9V18QWF4omM4CdH1STjcQI5Wsg0lK0OsTMtHvIX WWcuwxNoYDcSIylslQHLHpMxys7Q0kHiDBLa4M+Gk/B66Ix9sElaaiTpa lMZphW6IXg3E0LqhbWULtx11P5An6bv/Z07jsutIhu/QYVsyF47cJOXQn +L9eUUXZduopRJ8AknZ6ErXNd/VnMQYSmRuvAGGPHhsMH/RQqzMI8bp/w Vw1oLr33YcXDxri4r5Xe0IiXt6dvDIl1CRDj0GNJMxh/hoJyPUk/ZZB7j 1Q72h30DaycR9MZtMV83Sh6vjAxMzb83ZE6ugNWMr+F9odp3EDvHqG6pG A==; X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="284462990" X-IronPort-AV: E=Sophos;i="5.95,178,1661842800"; d="scan'208";a="284462990" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2022 01:38:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="604472830" X-IronPort-AV: E=Sophos;i="5.95,178,1661842800"; d="scan'208";a="604472830" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga006.jf.intel.com with ESMTP; 12 Oct 2022 01:38:02 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 12 Oct 2022 01:38:01 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 12 Oct 2022 01:38:01 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 12 Oct 2022 01:38:01 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.177) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 12 Oct 2022 01:38:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lcz+SH2Oj+erE2c1DjwA42V3ydN5e/vaFEQzxfmMJkwOMf5y6EIzikLMxGVBa7eTJL2ppAg0Jm0rN8Sm1id5Hjcwr9Lxfud+ZSoHt+/IjR2T5Gnmn/HTkc7gI7APTBHtNqPM1DsNAx4wI9mkQw2EEVpn78EGkzgVOhotKCWBpx52Ww8bN+d11Kt+9LUy8DLOylEowHY+BuH6vZRH4xFV1iU24wPTdzix5mZdY+MdZfrF4hPwEYX+RHtdl62Nu450rIUlcwWTQLY+JRRxz+2uPWNOHWlpbIvTCwyw3YmfDl2y0sUJ0RGxI6v1+neTCpZ/Gn63SOGdIV3TIss4XlodYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zZEFxMhFYQfPFoutnx+2OqAH6JZjCsyTds07+bEkCpg=; b=iqusU5wgnAT6lRJpfU0A/GZh7m9WzDjnclyI1VpkHf+Teso6yg688S+CJNXo2PP78RAk6wNUnaAUipHzziKZjrbXewgO7CEHlLM71tX3asykitqZQFWqGO4lf2VxQAft+5leA6CtmbDCwkSIeJaUdV99CN/mQPSvx1bjoaDB7n6UT7uK3vUms98rye03YAAenRiwSvA2qTOPywWqV4h3pm8HkQQUyQi9Fa9hEe5KaAZyuPcYw03udnCh/ptC0V70RDtvvks8DMO5PAJH52AlB3UzvBFEpEy7Ili5sJs6UFK5QImu+uMfBjdM50o7sINyI6ckAQ/Ld/lpRImB3PuZow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM5PR11MB1739.namprd11.prod.outlook.com (2603:10b6:3:111::22) by BL1PR11MB5350.namprd11.prod.outlook.com (2603:10b6:208:31c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.22; Wed, 12 Oct 2022 08:37:59 +0000 Received: from DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::b8d7:6a95:bf26:e4ef]) by DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::b8d7:6a95:bf26:e4ef%12]) with mapi id 15.20.5709.021; Wed, 12 Oct 2022 08:37:59 +0000 From: "Pei, Andy" To: "Xia, Chenbo" , "dev@dpdk.org" CC: "Xu, Rosen" , "Huang, Wei" , "Cao, Gang" , "maxime.coquelin@redhat.com" Subject: RE: [PATCH v3 5/8] vdpa/ifc: only configure enabled queue Thread-Topic: [PATCH v3 5/8] vdpa/ifc: only configure enabled queue Thread-Index: AQHYyZPqbmZ+XrFNik+lBRaAI6Mhl64KkUTQgAAHXGA= Date: Wed, 12 Oct 2022 08:37:59 +0000 Message-ID: References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1663308990-621-1-git-send-email-andy.pei@intel.com> <1663308990-621-6-git-send-email-andy.pei@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM5PR11MB1739:EE_|BL1PR11MB5350:EE_ x-ms-office365-filtering-correlation-id: 94834a3d-9bc8-40c1-6697-08daac2d1171 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: po2F23M9rhT4uN3sAEfpMw3bam8jBou095KAo3wqjsJHXdQ0iV5VjEzSyXNCxrDmkgwh+M84MDR/R8kNYSVkB24ObudBZvNl9c/MsISe92UAz6SnPP3YvWbPJijXrpGsEcrnqlNZaEmZCoa1f33mv70YKP6uIwkisojMbC7orinQ43XJm+QF0Q6TmyG+a1yqbjlgG4kzZK9SOTpGHKgg0bmPKd7IQNNotWhcBhm+C3xNYkaZOwo5Fk1aZRkW5wC4jtnp6adBPp9S4jiupcdrqKYw8sEd7tlOgDjw2ZShDtJG3bKYdywUXGGjVngYzq+hj4fWvEOlWkybEW8iQ1M3tzZnixv/KmApjHpR500hN5WD+zaMPFs+f2CiuoTm/O8fh+zadTprVb5fiBfNk9wv3AjpYSTxEl2VMMh0HrwNGg5fE8tF6H+lN5kMAlEvtaApkjBQYexvHACIcvTY3cFCH3MOKAMQiI8JTu+Y/hvgGSJ1eYampY1wGZMKh652LRb0Al3HaIJf5uNMqKyZPFySwhJ2LDNnxBnhjzXbJzPjYT++d+z5ZPK8EYYsbouorddqumRFmiAHhCq5s02Qq4EdyGE+HMHP4swMkOdpf0dFa4V+lWKYHAgtN3JKlxzW2SvD2E30cU+2eEkpoDwChO5W2jSy1B4w1HwN7qtC1FCTv0QETfDUEwyxqifz0iZpnhqvhb4PFdDPiY0T6o9O7BxxNpdUZFY1URtfmHwXrR297WWMAfb14FGV8rqB39xyNfFDLJooZxx+It/fw2Oh5PzO/A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR11MB1739.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(346002)(376002)(366004)(396003)(39860400002)(136003)(451199015)(53546011)(26005)(316002)(82960400001)(38100700002)(71200400001)(110136005)(64756008)(4326008)(8676002)(66446008)(76116006)(66476007)(66946007)(66556008)(122000001)(86362001)(38070700005)(33656002)(55016003)(54906003)(83380400001)(9686003)(6506007)(7696005)(478600001)(52536014)(2906002)(8936002)(186003)(41300700001)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VT5AXzKS8uk+5Dr2dArWf4UCqZQQyv335Q38jDqn1W4eO8nGvU2p1Ps4COvg?= =?us-ascii?Q?vQReOBRSOGchi+2j5g7YNIF3jTrUs20YcR3f1tG1gePk/XFd5MqFqkrVy1R2?= =?us-ascii?Q?w/XOn8SbbF/q/U2s0ipXuCI4d28xSsn2+t1uA6THQxxKdNkP1Fv3IhgiVWv5?= =?us-ascii?Q?23MDDlTetjTcDdGR6sqDbHL9iJSiZB/etiKjdrAorE0+nI1/UNwDndiSQktR?= =?us-ascii?Q?VPv3CU9jY0r/gj3P2Dgy4x9BdJR/MZr3m2rcVyK7DJXvsgqD+BVQ9Yzd7XIL?= =?us-ascii?Q?SskpezttWT4c92iLUmj+OfGL1GRNu/3JtyRyXDnFakTFsxPKQcrQALjBwrOn?= =?us-ascii?Q?QsUq1Xu994TB83T1rkquwY8j5Go9c7KobPPpNq/rAtk8a6sQlFc+6zZ8r48k?= =?us-ascii?Q?vqKt9mbHaFXfYlyb75CqZJg3AAgdKsT4eWB0LT8HEy/qlZomRqHsbE45tn3h?= =?us-ascii?Q?62jWf/HZSnhN/qAN/65W0vLrKyYmjA4pqIO+bASTZHn70RTkHkaa9PsBheoA?= =?us-ascii?Q?tzVljFXKswZr2VpL5bdxW2G2iPWHUMBpdgKckfEV9Ta58hQuQjCSs6toUTzn?= =?us-ascii?Q?yh1Gv4o39TdCcYzqHNC+R2b5KigiepPhiZ4zoX5ObLvVsCi06Uzrb2GGoiTG?= =?us-ascii?Q?kNvDH2qtyf/nIZHtLvei5Lges2CypmxLAAnEnsW1WxEK4/ewZawDJaCWE/2Y?= =?us-ascii?Q?xsq2I2cWeZoYg4fbDKiR1N5ZiZuysSxs0y+5cBsmsVSxSUG52C2d3q6yt4Am?= =?us-ascii?Q?cEaDOlKXjNn6Q9iawrfroGRGzSxif5J3tNoB8GsyB7Dr/Uh6xDkYJmdChdVW?= =?us-ascii?Q?dbEg+Ozsr2UUsDy0VpCrcy3aM5CjtXuZds60DrAjy3SWTPR8Bs/nemEopSa4?= =?us-ascii?Q?G/8LOMiAITumpJefG8lzInAJeBsFLzWAwtLeVRnc3JV3JXTkRbYLOwURJLvy?= =?us-ascii?Q?loAcO5ti9EXGVjRDff+WzgkIHLq+YHs1ygWOiUxMpcyBkqNUI+piwWM6iqn/?= =?us-ascii?Q?nkj9ylMEGeL9/SACTNSwoYUBqEECFfUjTQ70wUc9b22ZUlPMusPZjquo9y9p?= =?us-ascii?Q?AzpOwkrnm8x5lUVT2Cx5V6dUHdG/txGzNbLbjCpuWIpoTaNjiC8erGnxvteD?= =?us-ascii?Q?RqKfjFPdFKM9YmNOH0GC7Un68Bh/BPEtgdR1am2sATa/Aqospg2jiKPgBS4k?= =?us-ascii?Q?sBg0jV1Q0ecRwoKKpeJSBf6DxNDuJVej9EQzKGAOfByTpXeEoE1B23fCaK4s?= =?us-ascii?Q?C2Df/bg3FjoZRLF0gQI9qxVb0MKP4CC1o/F0Vl7rmzA601Vxdxtz+aGmyR0Y?= =?us-ascii?Q?OqPAEfkkP2xYqnn7GuRVgKj2Jizis3PqLXxhs10RKsYU+QaNTmD8qfCcPfdg?= =?us-ascii?Q?nu8BdxE54jw1XCWFPfaFRNbhs9NS019Hu3w0RQDau+5dWgdi3IH5yEilVSWB?= =?us-ascii?Q?HeK5A1NQi+jYXxrQLIVe2PQY8rtObqwyj4YG1IwfRpl9Ehc4CLk3w78aQtAa?= =?us-ascii?Q?qMhQFhmQ/QbubE0S1ZFF8iviKs6UiyitjRnfkHqqq6eOawxf+VD8u6DBrGJl?= =?us-ascii?Q?P6y1I4bnUkTzjSyLrQ5sN+s+t3GvAUp9tWg3qmQf?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1739.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 94834a3d-9bc8-40c1-6697-08daac2d1171 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2022 08:37:59.2028 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: f7cau/cp6THXP7P76qXNu6zC9KFyR4S7VGys1MNH4Trp8wu64a0wbovQggHZfx/gT3OpACpDPhvVv9Kc3xSciw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5350 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Chenbo, Thanks for your effort. > -----Original Message----- > From: Xia, Chenbo > Sent: Wednesday, October 12, 2022 4:12 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coquelin@redhat.com > Subject: RE: [PATCH v3 5/8] vdpa/ifc: only configure enabled queue >=20 > > -----Original Message----- > > From: Pei, Andy > > Sent: Friday, September 16, 2022 2:16 PM > > To: dev@dpdk.org > > Cc: Xia, Chenbo ; Xu, Rosen > > ; Huang, Wei ; Cao, Gang > > ; maxime.coquelin@redhat.com > > Subject: [PATCH v3 5/8] vdpa/ifc: only configure enabled queue > > > > when configure the hardware queue, we only configure queues which have > > been enabled by vhost. >=20 > Should be capital 'W' and 'When configuring' >=20 > With this fixed: >=20 > Reviewed-by: Chenbo Xia >=20 > > > > Signed-off-by: Andy Pei > > Signed-off-by: Huang Wei > > --- > > drivers/vdpa/ifc/base/ifcvf.c | 3 +++ drivers/vdpa/ifc/ifcvf_vdpa.c > > | 16 ++++++++++++++-- > > 2 files changed, 17 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/vdpa/ifc/base/ifcvf.c > > b/drivers/vdpa/ifc/base/ifcvf.c index 7efb408..619b034 100644 > > --- a/drivers/vdpa/ifc/base/ifcvf.c > > +++ b/drivers/vdpa/ifc/base/ifcvf.c > > @@ -246,6 +246,9 @@ > > > > ifcvf_enable_multiqueue(hw); > > for (i =3D 0; i < hw->nr_vring; i++) { > > + if (!hw->vring[i].enable) > > + continue; > > + > > IFCVF_WRITE_REG16(i, &cfg->queue_select); > > io_write64_twopart(hw->vring[i].desc, &cfg->queue_desc_lo, > > &cfg->queue_desc_hi); > > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c > > b/drivers/vdpa/ifc/ifcvf_vdpa.c index 376239a..b00afdb 100644 > > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > > @@ -284,6 +284,8 @@ struct rte_vdpa_dev_info { > > rte_vhost_get_negotiated_features(vid, &hw->req_features); > > > > for (i =3D 0; i < nr_vring; i++) { > > + if (!hw->vring[i].enable) > > + continue; > > rte_vhost_get_vhost_vring(vid, i, &vq); > > gpa =3D hva_to_gpa(vid, (uint64_t)(uintptr_t)vq.desc); > > if (gpa =3D=3D 0) { > > @@ -499,6 +501,8 @@ struct rte_vdpa_dev_info { > > > > vring.kickfd =3D -1; > > for (qid =3D 0; qid < q_num; qid++) { > > + if (!hw->vring[qid].enable) > > + continue; > > ev.events =3D EPOLLIN | EPOLLPRI; > > rte_vhost_get_vhost_vring(internal->vid, qid, &vring); > > ev.data.u64 =3D qid | (uint64_t)vring.kickfd << 32; @@ -1058,6 > > +1062,8 @@ struct rte_vdpa_dev_info { > > struct rte_vdpa_device *vdev; > > struct internal_list *list; > > struct ifcvf_internal *internal; > > + struct ifcvf_hw *hw; > > + uint16_t i; > > > > vdev =3D rte_vhost_get_vdpa_device(vid); > > list =3D find_internal_resource_by_vdev(vdev); > > @@ -1071,11 +1077,17 @@ struct rte_vdpa_dev_info { > > rte_atomic32_set(&internal->dev_attached, 1); > > update_datapath(internal); > > > > - if (rte_vhost_host_notifier_ctrl(vid, RTE_VHOST_QUEUE_ALL, true) !=3D > > 0) > > - DRV_LOG(NOTICE, "vDPA (%s): software relay is used.", > > + hw =3D &internal->hw; > > + for (i =3D 0; i < hw->nr_vring; i++) { > > + if (!hw->vring[i].enable) > > + continue; > > + if (rte_vhost_host_notifier_ctrl(vid, i, true) !=3D 0) > > + DRV_LOG(NOTICE, "vDPA (%s): software relay is > used.", > > vdev->device->name); > > + } > > > > internal->configured =3D 1; > > + DRV_LOG(INFO, "vDPA device %s is configured", vdev->device- > >name); > > return 0; > > } > > > > -- > > 1.8.3.1