From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 457A2A0A02; Thu, 20 Oct 2022 07:53:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E5B6542C78; Thu, 20 Oct 2022 07:53:45 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 11BEB42C31 for ; Thu, 20 Oct 2022 07:53:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666245225; x=1697781225; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=/k8sv2qaTlVKnR+W5V14ZvqudDsmTeve6U5JwUBkWOk=; b=CycjVocrQ62dOjSTUFphtY0MTRX4RVRBBhN/8D/YcDP39Z601HozuK4s lq15BUv0Fu9L4MQitwNn7vnH+3yuJ7zow4e5xuQ7jMsj/x+4SPt9KBy0V BPTv3nWRiCDGiEvc8hMsmNVIzzY86+5WqGdz/YXClI0Y1pP1vJFKsI6u6 qE4We+Nv6Z+TVaLZf3UHdpIgFQ3GxZJQiDExdxKIaBNV0HbbtIrfKyBHe zGQPEy3KKfOcBhPEV5VGSDPHZ6ffwmzNZc/YW+Kl/idg/DkVsESx5ZJ3/ 8u8+VXMjihVyeLgGoccv7qX2gQ7lA68q3G2I2v1RoYO/BGACbuLD6XRSG g==; X-IronPort-AV: E=McAfee;i="6500,9779,10505"; a="333175973" X-IronPort-AV: E=Sophos;i="5.95,198,1661842800"; d="scan'208";a="333175973" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2022 22:53:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10505"; a="629610967" X-IronPort-AV: E=Sophos;i="5.95,198,1661842800"; d="scan'208";a="629610967" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga002.jf.intel.com with ESMTP; 19 Oct 2022 22:53:43 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 19 Oct 2022 22:53:43 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 19 Oct 2022 22:53:43 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 19 Oct 2022 22:53:43 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.176) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 19 Oct 2022 22:53:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dSAKC4Diq56GLIrjF9PMnCC3IlQWZt26YhhTvu/PTnKYrSZURVO4WVU6aYjUHcGH1ur9x/FFwjOiOJjWjDpcMoqNNB5j5mNYOOfcUr3Oc1Z75Mqawn0WscL1xaBdqGKHopF6X+UYwDyM5hgPGZ2S4VGy4tacpz0lIMbpOpVMGiMytA9DFYmgul4GhyK7wxhVdErSpxdXngl23RvYtr9AvVOluz91evDj73cglCNNlbGaUJL+fmmCKFg5yRRkUhebFYxo2oGvp9IueoRSzVbJElKR6DJHjwXZuu/utjRM/gkfmqxj94CdceGJWtcZGkk31Pnfr5kYmC4COyurJNK7Ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FoxVneVeLo7VnUJUj+7S6ybLdcWP8EvlTqxpQnRVXaU=; b=CUFIBdc8cuNdrTVbRz42p1amWdiOHHLTXNh75fgzUw3f1fIylL638rE6kv7NlkGDG/XHNVPPI9cMFUZPcK5+mHklBWILfc8GIgSKjumTs2Q7c2F6br5RqgaauUUPAqSrxs8W32u9m+gle+aig9/tzGrxB2XUTboZqogbjKA8Cm7t3cTvQjAxKQ8AsdLpJN9IS9dRt/+putshJ4uMNjaGxD/jnuNS/+72dVAqkITBo12OdS1W895PFu9s6wrQe4x1+ogfCa4WTSatfBavhyJavETa8zJ/I7gBqIf3A+CO9nBXLzoVHKdKIxJLxdNwEYQ0Kr8lGthVUKDaz3OsWMV9Mg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM5PR11MB1739.namprd11.prod.outlook.com (2603:10b6:3:111::22) by IA1PR11MB7247.namprd11.prod.outlook.com (2603:10b6:208:42d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.33; Thu, 20 Oct 2022 05:53:41 +0000 Received: from DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::b8d7:6a95:bf26:e4ef]) by DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::b8d7:6a95:bf26:e4ef%12]) with mapi id 15.20.5723.034; Thu, 20 Oct 2022 05:53:41 +0000 From: "Pei, Andy" To: "Xia, Chenbo" , "dev@dpdk.org" CC: "Xu, Rosen" , "Huang, Wei" , "Cao, Gang" , "maxime.coquelin@redhat.com" Subject: RE: [PATCH v9 09/12] vdpa/ifc: improve internal list logic Thread-Topic: [PATCH v9 09/12] vdpa/ifc: improve internal list logic Thread-Index: AQHY453qreqt9cgOrkq/zH7bdDE4Kq4WnsvQgAAqhkA= Date: Thu, 20 Oct 2022 05:53:41 +0000 Message-ID: References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1666168884-104665-1-git-send-email-andy.pei@intel.com> <1666168884-104665-10-git-send-email-andy.pei@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM5PR11MB1739:EE_|IA1PR11MB7247:EE_ x-ms-office365-filtering-correlation-id: 00c03052-9e57-49a4-c010-08dab25f70f1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: heSkUG6b9M1cJrSL5sSNl88v0LCrU4ZnR+2T9xWYsVpJ1fu/3k5YYnuYfjSRoxpib/3pf1d2pRbnrSb6XkDbIGVsL2kD98pgl2XOGEMNjOCj+xZImMSoEp5YYYTrvMBRUk9ohIRYKG+tsUz4EWn6Wpxr0q9ERAHU2dQbAKHyPTtqcnH4Z5jhTKFEkinHg/uo6/7uV1sR+bUNIFvhrKW1WSB383+gOSXDxKjOHrvEuPKmZGJfTO44opyJiGIZp45Isn4GnRcv2PZlZ+JNBREyqDLOZdeZGHwn2DXsVzkgaZGS790fwXdpaRYNbWD5VS9xiWIdRDOsLQ4HNuFsw8OUqQFH/Lh2Tib8qhw19ApGTh6fA72kvq/e6ru/uuqbdFNJ36UXQD2LszjpEXnp/kj8Hn8c7ymOkwqFPwKT93C9tuQgL+/zLl8urai6/ud97eLkfZqra74fzlDsUE+/jXaIXLgF05GMxKawvJI1dDIZI+xU+/GyNFgulDBfHHoUDPN3TmNR3vBCtGJvxjdXemLLsTlFzyRJYII5TVEAAcnQK4xea4h4aYwuKozTXtDg39wbmVbqLW4FYPNR3O3QcpulG2tRc4Ik6BvQJAW9kp8uTQrr6Ooc4J1XDQIIWEhVspgl7PC3WLdT7sdn09XnGzMn5W9N9L+v/t2o7f9VgCVhIKcl7cJxMahU4TaQctuyWsts/y1BXk1ZdhL+PX2caByQ58Yfy+Otbr0N1HI1RJqjHMdGoIfsnkd1fOZ+8x/UAuadMIG8eb2IUUFFVU1DVkVR1A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR11MB1739.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(136003)(396003)(346002)(39860400002)(376002)(366004)(451199015)(38100700002)(55016003)(8676002)(316002)(4326008)(186003)(52536014)(7696005)(26005)(8936002)(53546011)(66946007)(5660300002)(41300700001)(2906002)(9686003)(86362001)(122000001)(76116006)(64756008)(66446008)(66476007)(66556008)(71200400001)(6506007)(54906003)(82960400001)(110136005)(33656002)(38070700005)(478600001)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?JmCK/BbAEYeEtGbJ2mKRGwZDigB+Z3vJPqg0sKLFdbfGBM8fXXtw5l9TPrz5?= =?us-ascii?Q?ZKL7NeBvhLdDDcmrSdONxv6RV5nydK3VDRQdcKBzJBL6tg09tFeJQdYeRGoD?= =?us-ascii?Q?BwykBSZnVxp700TnWuoqoS0oMpTr4a2/wudoXFLIm08iFlCZzJDsNGSwwMuE?= =?us-ascii?Q?s3a4l1tJKErVL0zbpwRfau1zxTcSte8zBpDXIIMdJpn+3dMGXhMKFXtyHLz+?= =?us-ascii?Q?AR2P4eoH1u5MUey9fctSodlDV9wjt9wlMucu5YVrMj+eMs9pmVV2Utog2W4v?= =?us-ascii?Q?acgnkHO1NIXiB0VeVIKj1VoqkpgNQ/XSXpgdJAZqmEZbK+Jy5Lk8Aifd11XJ?= =?us-ascii?Q?AS5gkVKui3K+DrxZW9QCwQQJGUit4w2270DDj+DsTOLsolLv5GueAUZcWj+8?= =?us-ascii?Q?hwVsFI6C9Xa0xiX82URCmlkc3PByJXBlq0Sig35+ROX3CECovbWJROxbJlRb?= =?us-ascii?Q?mvVA+xpBWHoi7gsmNjVuJppQpebRw9vA4H1mz/+Ben3zdb/QPeE9VwQPYsZI?= =?us-ascii?Q?HcL8xPW0cqfMddGFPZeZyzP8elxiRC/+uMhiakuLO/jn3BOdffj/2Yb96jn7?= =?us-ascii?Q?Kv0bmGMeM/mtjWBdT1UkclYVcAZ/iGes5zs7pr75b0dRo0DjqsXzmjf6yKqk?= =?us-ascii?Q?NkkipPqSiLpKCZJSTzBN0lHr9ya+En05uoyNrP7R7cQpFG+mpn1eX4OrRT79?= =?us-ascii?Q?Yv8Nl+4r36nCiLRvO6Z0lpQdR9rBcxfhVqSpEwHB19X2MyZo9jQzCay62BV3?= =?us-ascii?Q?BGWvmm6iCDHVST2YKz1gUTZ08CoHUP7ZmGWit6qRBbpKfWMjYo57fEAGHdPb?= =?us-ascii?Q?W62R+BBK2TdIX+JzImTxcAauwqiClyZrOH6l5/GElMad0RPDZJ4skcUAGe50?= =?us-ascii?Q?u3Kr5jMj4YVSBBPTYN4f2T4Ilp674k1mdOh04ZkRfz3tIXQZu7dubEEqQ/xg?= =?us-ascii?Q?5+SqIvtxac4Isd8biHPi4L3INC4jUCnjxJi3WvKqRjCTE79MNGrH/NdIdNVJ?= =?us-ascii?Q?HzOghn/QDxYAAHoYgA1CoKlYQ7CxiS90laMKkFaFFgyXT5xng7vnOzpkY5xL?= =?us-ascii?Q?+yx+FA8VxMSGHNBUlsiKJw90l5rwP/yg4grHUxvWFFyiQu4ZVboVACkzXRTJ?= =?us-ascii?Q?ibT1NZDRUkbLxEp/9SZwfF0b31/hW7Xc0ndUGbvr7eEGptC+gkXp2tgawbt1?= =?us-ascii?Q?MRc7fu3PpXvhoDKPGxs1KGXP6E734yh+Bng/EpaUvplXKnxWqhoz6PyyiuHm?= =?us-ascii?Q?N/JeDKehkvdDeiYCgMotLL1WAXLM9J4CrEdQonUG/kRWKugo8MYP+qpl/lCI?= =?us-ascii?Q?rQ1XI4LD2c6VFATuGZc4ifW/acVT6O9NqiN04I558UnZ3JINxkD9tpOGL/NV?= =?us-ascii?Q?ILKpZ70qMtnan4FeWRllDIluVPk5Z+XzM9OhyqjON0ZKNl17xs+tbyJeGiiy?= =?us-ascii?Q?HQKj8EtTcwEqYD/jsPLPJYWdIQTIcqG9kKs/b9M9BGqDu0aeQ7fjtie0uWHw?= =?us-ascii?Q?1nZxsCiMD7oPCc0RJn9m9YhrGLtNYhXfaE1VabAzlUJo/UrwsjfxMQqhLIKJ?= =?us-ascii?Q?5mQjEn2iprOzxOIWqbinfrUfOy9aBfEP6oq6TLWW?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1739.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 00c03052-9e57-49a4-c010-08dab25f70f1 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2022 05:53:41.2562 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uN1RxeBYeE9nfbuyz0+HCociXCAoeCqz/t4o1g8BVhRz3xDelWU9MB3ZcOmuuUn58xZnjN8h2vkk9LOhuHWPEQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7247 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Chenbo, Thanks. > -----Original Message----- > From: Xia, Chenbo > Sent: Thursday, October 20, 2022 11:22 AM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coquelin@redhat.com > Subject: RE: [PATCH v9 09/12] vdpa/ifc: improve internal list logic >=20 > > -----Original Message----- > > From: Pei, Andy > > Sent: Wednesday, October 19, 2022 4:41 PM > > To: dev@dpdk.org > > Cc: Xia, Chenbo ; Xu, Rosen > > ; Huang, Wei ; Cao, Gang > > ; maxime.coquelin@redhat.com > > Subject: [PATCH v9 09/12] vdpa/ifc: improve internal list logic > > > > Insert internal list element to internal list before register vdpa > > device, in order to call vdpa ops during vdpa device registration. > > > > Signed-off-by: Andy Pei > > Reviewed-by: Maxime Coquelin > > --- > > drivers/vdpa/ifc/ifcvf_vdpa.c | 11 +++++++---- > > 1 file changed, 7 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c > > b/drivers/vdpa/ifc/ifcvf_vdpa.c index c16e263..8dfd493 100644 > > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > > @@ -1737,17 +1737,20 @@ struct rte_vdpa_dev_info dev_info[] =3D { > > } > > internal->sw_lm =3D sw_fallback_lm; > > > > + pthread_mutex_lock(&internal_list_lock); > > + TAILQ_INSERT_TAIL(&internal_list, list, next); > > + pthread_mutex_unlock(&internal_list_lock); > > + > > internal->vdev =3D rte_vdpa_register_device(&pci_dev->device, > > dev_info[internal->hw.device_type].ops); > > if (internal->vdev =3D=3D NULL) { > > DRV_LOG(ERR, "failed to register device %s", pci_dev->name); > > + pthread_mutex_lock(&internal_list_lock); > > + TAILQ_REMOVE(&internal_list, list, next); > > + pthread_mutex_unlock(&internal_list_lock); > > goto error; > > } > > > > - pthread_mutex_lock(&internal_list_lock); > > - TAILQ_INSERT_TAIL(&internal_list, list, next); > > - pthread_mutex_unlock(&internal_list_lock); > > - > > rte_atomic32_set(&internal->started, 1); > > update_datapath(internal); > > > > -- > > 1.8.3.1 >=20 > Reviewed-by: Chenbo Xia