From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 56382A0556; Mon, 17 Oct 2022 08:36:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 48E9A40143; Mon, 17 Oct 2022 08:36:46 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 3D0E0400D7 for ; Mon, 17 Oct 2022 08:36:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665988605; x=1697524605; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=wplEXetD7HNlZs1K4K5/LJO8xNR8OHJz9HK5s2jeRa8=; b=IC78atAagmeYjD8xIaD2o0gPXMtN0lWDSvs/Bnq6dnz+sYSxNbJvzoWn b3FseolyZNWoFkQl+9OKU7e0AEsPiBQ556pljvinPs1aozvEZJnMuV2BA cG/HiP4Ka24XOudcqI1tndmjFzc+sRZnm9uSjmQWDzd0eo7Tr6+6L58Vi RcnrZRV8+Q8srdXbGFY4Jtsf0jbXPbnzeyr0m7/QXlwjvKSQ9VXe0GXb9 aC4s6+TQj43eg5b1N6+LoNbky3jkj+//dA69FlKyr1yBkiZlgHZIwzKlg sGcNEW+bIAJ76aBga1MU7jKzYeGcOk3iKQQhdCav0jdfwTVSRX2uRMFCO A==; X-IronPort-AV: E=McAfee;i="6500,9779,10502"; a="306801191" X-IronPort-AV: E=Sophos;i="5.95,190,1661842800"; d="scan'208";a="306801191" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2022 23:36:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10502"; a="957225495" X-IronPort-AV: E=Sophos;i="5.95,190,1661842800"; d="scan'208";a="957225495" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga005.fm.intel.com with ESMTP; 16 Oct 2022 23:36:44 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sun, 16 Oct 2022 23:36:43 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sun, 16 Oct 2022 23:36:43 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Sun, 16 Oct 2022 23:36:43 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.173) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Sun, 16 Oct 2022 23:36:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ICzSDEVqINdeO2fn+wohfBFDTxO0I7HZHtKPUbZHd1g9qktipIlhvZhRWyiasmpEsq5/Xb1wAEBO50mHLYNIofEumjqEKfpaQHHMnuOY+IFL4GOYMukQCWDlTzHKoqIj3uAinY1CSpr12z08Sbix3QoeIOZzupmkvk4hSYjjLIwcS1t1XlHNkF/L0uCBmumxIFKw/dX8NHW4TbA/BDjKfsgc5WsDQ5n899V5IBy3wUQmg/lAd+mviaVYNXTMv4vG72jAEWAGkXkPFiNTNx4xti95mMofIsLECWizULTXkXyJObJ6oQMA0sf+2/nvabCLSPeykSWdmRqi6ODszl1Yyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G9SLdBNEh9wuGHrifJdk2WGW0AfDRXaZY4FKPasVxpQ=; b=fOpdzU6s8+EzooYtSKWw+v+Y9gGyEGoxMxNi7gTnghtwYfN+6GZ8tbA5cHpnNU4fr8i5r/x6ZobuFs06YCKbcW2XKtBMAWs0l4fs96bwoSMHoLqixPy/vK688Foo1pwWKx+/c9vDlq4aGddf5+8h+2Ch1y9w6bwbMsQa5dmnpOvqKWcGqkKrb4c1qdD+VgeoychDiM8YJUa4vcUMUDP8/hMX+nWuXnNxSQ8R0Vap9im4ht1paahvse1wwkCA43pkkpgYcw6MCwlmN/P3VOpVTrJACcat/aMprYZoHNVwGur1SWbmxVQP7XbIoSvcz+7piy/HAfTGjd3RKNVJqYL9PQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM5PR11MB1739.namprd11.prod.outlook.com (2603:10b6:3:111::22) by PH0PR11MB4901.namprd11.prod.outlook.com (2603:10b6:510:3a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Mon, 17 Oct 2022 06:36:41 +0000 Received: from DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::b8d7:6a95:bf26:e4ef]) by DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::b8d7:6a95:bf26:e4ef%12]) with mapi id 15.20.5723.033; Mon, 17 Oct 2022 06:36:41 +0000 From: "Pei, Andy" To: "Xia, Chenbo" , "dev@dpdk.org" CC: "Xu, Rosen" , "Huang, Wei" , "Cao, Gang" , "maxime.coquelin@redhat.com" Subject: RE: [PATCH v4 4/8] vdpa/ifc: write queue count to MQ register Thread-Topic: [PATCH v4 4/8] vdpa/ifc: write queue count to MQ register Thread-Index: AQHY3uCExfMAa3qzwEuGYGiHN+KLNq4SJB3wgAADpTA= Date: Mon, 17 Oct 2022 06:36:41 +0000 Message-ID: References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1665650674-291949-1-git-send-email-andy.pei@intel.com> <1665650674-291949-5-git-send-email-andy.pei@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM5PR11MB1739:EE_|PH0PR11MB4901:EE_ x-ms-office365-filtering-correlation-id: c6d1301b-4393-4aab-a3fc-08dab009f399 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xwuxm5hitn6zvhBmOjCLzwVNmQDeVLRap7gLSaFVQomBqFP6khqSsTRfxyO/l+o8j+irISB0VcI6UHt5CmWip9LZuaIaOmLfcjxwCexmLFi51yGlu1zwT5HG1Qwx6Ze4VpanvkVtrytOCcYjjVcI2b5LcUgCarDKe3Dun+wCd0QTa/GTFK7e1Cxn8X4p5GPVkkp7Fkp+c+H3KbjIKwRWH+zO8k099qQN2fYg42Rli22YZH5jQLOwtGJ2Zhdnr0i4S+/92g0XGZoZYI10psqXEUT38EbYsnPGcb2TqMWtR2fD6K5KZw8+mpxQMqtY7/YFcYsoNN24TbP/zwQKJot3eW3whx2gDov9oICmNhea66mgxBb0mWB3yjuba8ynArXGSwXcf3Dh8saOg4M/nFCmYcAGQboM05F/xZ2W4+/9gi6G1tz6FnvuYaUvFsr22A7ZRk3BY61rItzn2KILbOQ4+/IR82x9wO8G+snWIIsyCHUHpOfM4WTWxvAmzkX9Tlbaaeu1xTJU3ARRsT5WuKp0zVT+3vAs3sqPuNCSbVTeQtRS+SXz1YfM1JijaVL7dy+qN4+i+FrgKpjuglRUQqTb5KUza+1wyZw3awJ533uvmoGp3OW1cKXEJ9QL0hc59320iKLZJBcrL6SU2i5L2lvxUIZeN5KCNLoI9vhZSOTXX8fXR7d7TOCzqsMMKXJFTm+z2N1u9zmFQYt3wXUzD/LXH6eCyHUABRBmS49vPDwKHTvuOeHtoL/HEzyWUfc1Jjne8clIuT1aX6qLlZDQ9qEB7A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR11MB1739.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(396003)(39860400002)(136003)(346002)(376002)(451199015)(38100700002)(52536014)(8936002)(5660300002)(82960400001)(122000001)(83380400001)(33656002)(86362001)(38070700005)(26005)(9686003)(110136005)(54906003)(186003)(478600001)(55016003)(71200400001)(316002)(4326008)(76116006)(66946007)(66556008)(66476007)(66446008)(64756008)(53546011)(41300700001)(8676002)(7696005)(6506007)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BIElXOR3qMsOFmpgYvIDfUMed7v7+J3vArMjaVdSl7xINwzjVDMzKWqFyZmc?= =?us-ascii?Q?WUX8VE6WgsWDfyQsT3r8nf4/QXxaIqlv+wU/GEpcHjEzcO5k+dRYYRkibbxj?= =?us-ascii?Q?/vu2uvspiI8QlQPGnHC6gcOmIfKfvJcuVIQ+BK5Hw8Hvt1BOYSEHM/coQMCJ?= =?us-ascii?Q?sp5P/zb/T5mkHafHPSSB2/KMaGQFQYPF4fAVPVQOoqH2ZjjQo0GDsYsGB3w6?= =?us-ascii?Q?dtdLDeh6g3W90sc69p0n4aZc2M/dCAJr4mD48x5SaSF22fhVCm1VM5Rxw+jI?= =?us-ascii?Q?Tg8euklxLhLJDHLLEVBJfpIPKouBZ8j7Esii3tWxjiXxOhQCjXwuA6QA9UQs?= =?us-ascii?Q?vMTdWkREmWay64ziCtF0xMbairQz62UVJMIiX15q2kIGbhwfpKER6UTDcy5u?= =?us-ascii?Q?vJsztEn42D+EWxStD/kD6pCyRMzZCVE5qO3QxilVkrLNKGFekrlqFJa1H1JI?= =?us-ascii?Q?uGHG6l6O5utu2QExWi5iCEXWfaLtvAEyKA8OncGfH/Kri572Iwhgx5MUBSRC?= =?us-ascii?Q?HSmgdez6b2CvyAkDe9/d4bGClqqrZV5oWq0u9XsI5tLbPUBqPxp2U1OhFXfF?= =?us-ascii?Q?XwwRF25vB+srezpSlFoNHqO6cp0X+2wsQaVHsa09Zw3Ug4xX3+hdXOailUI7?= =?us-ascii?Q?X5TQhIvNHHiq9wPqq6e8YlXBdvjEvpz+DxYsRBIST5lMcaGw64JyTZE+UB6O?= =?us-ascii?Q?ly7p5uLY6zmQxK5ad+rL5XOPbKhw04rWIQknjOTldOfgpbzvaNUzTlQqxVAN?= =?us-ascii?Q?W7bewKOWb/DQAAPXXSlwq+iJxn9kot3UXDKw5QXorMup4AEaZS+kK1mZ3r/y?= =?us-ascii?Q?9wHAPaWBbRPp4YfRuhMnKQEPrzdlqSgRdJ50D3rOQqxuvyYd1hhZ+eBBV6bR?= =?us-ascii?Q?MyK65NKRvJ9hFDeA/q4SGqSC6tTjgesikHvdE+9AT3SC1PyyBUqFk/d0cyUG?= =?us-ascii?Q?Io1hyL+szU1hNwopYyDOiD9Q3L9pE8OlFfh06rmw3cQpZc6kDxhmwHCh8CGX?= =?us-ascii?Q?sOSTIuYMjGSHgSjVB6ZgAkxce6wuDtBGUBlPlzI7AzI9JBN1JBKanjRB6f00?= =?us-ascii?Q?It5Xc/bw6ph1nQz4t1ipYtB4oJRNHLS0meD7spBUEHt9OxcIWpgIKU9gkxGI?= =?us-ascii?Q?TQtF4FLrAw87LrFkkz2CH3aoJcmjk45d3ESJw7sLmA36nWIZawILCFDrpZFs?= =?us-ascii?Q?pgR72UFYaW/5MNy+Z9fNbuEA8se/B6iMsk9bWFTblgL2o1zuAVycInIIZnc3?= =?us-ascii?Q?GfSpFnGserx4X7vXrdVTiBd61MGS6yZ2r606MWZYUQvlEgppLnjw4JJGJoLP?= =?us-ascii?Q?rrZu+4NV6fMqV+fIJXARfM4b0RQbEs5lov7/OjbCdVvjfuxvtw47B+dmJV8f?= =?us-ascii?Q?bNNK3kdimvFLUP897Aoy4USlD6djfs5sJl3YtrxjOz4nZghpVxzPI7pLrdBe?= =?us-ascii?Q?B64flUxvpgd0hnG4VUIPYIe/nFxMbqG/cn5l7bpy5FscFP5dAAGwoqIbrEGM?= =?us-ascii?Q?FynZXxFGd3tijcK5Y3RSuGBk33BX0ZCGguFNm94eh7R4eVfRiyR9RycuhFmU?= =?us-ascii?Q?ti5bvU3PjLCNcPncXMYrTMTbXz3xArPxgKPdiIOU?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1739.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c6d1301b-4393-4aab-a3fc-08dab009f399 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2022 06:36:41.4160 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9NWWIyIebsf+ghwqanH/fmArHmHYbcwzfuAXg/NiXn8T207pdKMUMbZH2nwAO98RoPJ9IH/sGqYNC6O430OyWQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4901 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Chenbo, Thanks for your effort. I will send a new version to fix this. > -----Original Message----- > From: Xia, Chenbo > Sent: Monday, October 17, 2022 2:24 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coquelin@redhat.com > Subject: RE: [PATCH v4 4/8] vdpa/ifc: write queue count to MQ register >=20 > > -----Original Message----- > > From: Pei, Andy > > Sent: Thursday, October 13, 2022 4:45 PM > > To: dev@dpdk.org > > Cc: Xia, Chenbo ; Xu, Rosen > > ; Huang, Wei ; Cao, Gang > > ; maxime.coquelin@redhat.com > > Subject: [PATCH v4 4/8] vdpa/ifc: write queue count to MQ register > > > > Write queue count to IFCVF_MQ_OFFSET register to enable multi-queue > > feature. > > > > Signed-off-by: Andy Pei > > Signed-off-by: Huang Wei > > --- > > drivers/vdpa/ifc/base/ifcvf.c | 32 ++++++++++++++++++++++++++++++++ > > 1 file changed, 32 insertions(+) > > > > diff --git a/drivers/vdpa/ifc/base/ifcvf.c > > b/drivers/vdpa/ifc/base/ifcvf.c index 81c68c0..60c7017 100644 > > --- a/drivers/vdpa/ifc/base/ifcvf.c > > +++ b/drivers/vdpa/ifc/base/ifcvf.c > > @@ -202,6 +202,37 @@ > > IFCVF_WRITE_REG32(val >> 32, hi); > > } > > > > +STATIC void > > +ifcvf_enable_mq(struct ifcvf_hw *hw) > > +{ > > + u8 *mq_cfg; > > + u8 qid; > > + int nr_queue =3D 0; > > + > > + for (qid =3D 0; qid < hw->nr_vring; qid++) { > > + if (!hw->vring[qid].enable) > > + continue; > > + nr_queue++; > > + } > > + > > + if (nr_queue =3D=3D 0) { > > + WARNINGOUT("no enabled vring\n"); > > + return; > > + } > > + > > + mq_cfg =3D hw->mq_cfg; > > + if (mq_cfg) { > > + if (hw->device_type =3D=3D IFCVF_BLK) { > > + *(u32 *)mq_cfg =3D nr_queue; > > + RTE_LOG(INFO, PMD, "%d queue are enabled\n", > nr_queue); >=20 > queue -> queues >=20 > With this fixed: >=20 > Reviewed-by: Chenbo Xia >=20 > > + } else { > > + *(u32 *)mq_cfg =3D nr_queue / 2; > > + RTE_LOG(INFO, PMD, "%d queue pairs are > enabled\n", > > + nr_queue / 2); > > + } > > + } > > +} > > + > > STATIC int > > ifcvf_hw_enable(struct ifcvf_hw *hw) > > { > > @@ -219,6 +250,7 @@ > > return -1; > > } > > > > + ifcvf_enable_mq(hw); > > for (i =3D 0; i < hw->nr_vring; i++) { > > IFCVF_WRITE_REG16(i, &cfg->queue_select); > > io_write64_twopart(hw->vring[i].desc, &cfg->queue_desc_lo, > > -- > > 1.8.3.1