From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 32BA5A0544; Wed, 12 Oct 2022 09:22:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1C1E742D86; Wed, 12 Oct 2022 09:22:29 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id CE81342BF0 for ; Wed, 12 Oct 2022 09:22:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665559347; x=1697095347; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=FUB+oYhNKgTGxQGGByUxSmFyIH9ilKpVXgoZdWDOG9M=; b=I056EemGgIDozPtiRljQ2QRTZESK/cMVh1V3k67uhTTszddHu+t39zEH 4dNRYzoVNu+xxXEG1GPBEezEYVobs3KKomFA83QbOKdq3n9xBrfQz/Riy Eu9BJiXgO2vrMKFlfNmMvtkwc94yaselK0fPIChZVUOnVHoao3Eg1WXWM 81Jij7CsZ/HweA8GkC+zNbboOBu7Wr1Lmku2NPiqCAEialmoJqzWu6pBF SYyVcfOpukxu2LR7rbb5xdlREbuV+g2MSnAR26+zdUuVikfCWI2lBp0Gm bubuhESuaYR4Yy6oW08f04spQO2KDBTIdyMaUlaZ4ly6GWakHLsndedP+ Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="366721723" X-IronPort-AV: E=Sophos;i="5.95,178,1661842800"; d="scan'208";a="366721723" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2022 00:22:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="621688886" X-IronPort-AV: E=Sophos;i="5.95,178,1661842800"; d="scan'208";a="621688886" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga007.jf.intel.com with ESMTP; 12 Oct 2022 00:22:26 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 12 Oct 2022 00:22:26 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 12 Oct 2022 00:22:26 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 12 Oct 2022 00:22:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bh0+XFKWm3OwMUUNtE8AlYHlOLjqWuOuzi6L5GVo/zscaeOsrZ4xdPHOZSqaopzyJ+vqLgR1Nv5V7wAzyz89XhmN4mCtqSZ42LOIBYCMVup4j/01UsagB7tfhUlAVRm7fF9+CkI3+MM562gS5KPDHZYFpoXgOE0JsbWzJPBKMTvSpc+ADWa/+63qjDos1LvfrBCe6bcdUTaruGMXJzR/xu9aQhVtVsFU/t9RujIWRQ5fDeAvc1VnseeY3CokRz93D2CIvkwDmjDnyHmLzhV3T3SAaBorqhiD4l8vpaBgu49vyIkohPxWgrZ7aUBnSZx8tYNa6gqbvWIZfP7jP4JGGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gK2TbV19bxlfLJ6O/L44Cv2VZ7gTHVWY5avLYy/qf5o=; b=HmpMESKM803w3LI9vDu28OhBegOVHHyJ3nSv9EW1fpcM7IeXxQ+imQLtbhneOW1lJLhNY4UobLkNZ3V4uAR0j3W/Q36cj8Cf+k1azvDR0iMf7ow4C0CHe0BSTYvzvstVryuBZ6sWCJbAa0svCWIXabqZv46FdDExgyY+2z6u7u8nwWRN2ozrotDjFED+XknqikoclyEsNnxAB5MphlYdy68Z3LWAkt40H1gGck1I0i6h1kASK6lNBVOJchuzGY8eX8N0RmGDnziFfFpCp4n4f+cr41CvCXmMjmZEbNps+OuaFxp4wileZCVmZAlVRG8pJzkJnDnoGQjOtrPjUIhTiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM5PR11MB1739.namprd11.prod.outlook.com (2603:10b6:3:111::22) by SJ0PR11MB6621.namprd11.prod.outlook.com (2603:10b6:a03:477::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Wed, 12 Oct 2022 07:22:19 +0000 Received: from DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::b8d7:6a95:bf26:e4ef]) by DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::b8d7:6a95:bf26:e4ef%12]) with mapi id 15.20.5709.021; Wed, 12 Oct 2022 07:22:19 +0000 From: "Pei, Andy" To: "Xia, Chenbo" , "dev@dpdk.org" CC: "Xu, Rosen" , "Huang, Wei" , "Cao, Gang" , "maxime.coquelin@redhat.com" Subject: RE: [PATCH v3 3/8] vdpa/ifc: set max queues based on virtio spec Thread-Topic: [PATCH v3 3/8] vdpa/ifc: set max queues based on virtio spec Thread-Index: AQHYyZPna+E12LRgLUaid225pVMmIq4KbIVQgAAW81A= Date: Wed, 12 Oct 2022 07:22:18 +0000 Message-ID: References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1663308990-621-1-git-send-email-andy.pei@intel.com> <1663308990-621-4-git-send-email-andy.pei@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM5PR11MB1739:EE_|SJ0PR11MB6621:EE_ x-ms-office365-filtering-correlation-id: db82c316-2a95-4c1a-e15a-08daac227f45 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pq/K+tkoeIAeS6zafcKPgA6QZO44n+glfwmAWCl/5lhJVL4p0/3iq8EUuw4ZLxbD2H+UFrLNk38nipPiyIQerzLBfskZ+n03LLKmswvM454qw/JrXuHLoqSUi9hvQ9gKuogSu9CH+UG+NB/v8r4IF02/HG7BUSbxoaAo8jCCLs1SwOaj4bPb9w2q/IweLJIUqOd3Xt9awUf7pObTsSY0V/8J+EdZmALH01zU5LdGKL5ezvAnOfG1mZk2jJcS7oUY4qLMKnwk0W9uwtBfjWrU/W+Ts6M6TsAUhfW+YihOQos7/9I0FCyS4ZdUq2ZS+aTiPyYRVPAyM/uFFM+h3r70k3olIFxjeL87H47VQAdd86QLLmn/F3WRVhITwJqyEP66LdcRjQ4/AlCzG6LNz4P/eeFrIi+lokJPdDQm7SMT/U9rnj5XZ6HBCqTXdmPg5Er0iPK0f+GnEE7sZ7bLPOnkU2jjnAZDO4MKnd7xalxp9MZTYxjCyx3uKnd31njLn2jH3620gdcrz4iPASdgSAkMyLlLrmrCfTXVlOdQDA/QcJG7SOvQ2S6yr8AgaipCiLfMXRQ/mfw4nb+81XCMxyysFUr/JpVdKAkD7PTHkmQ4xX4n44BEbDv1009NnKv1q5SFumw2o8r/ugyWfE5z3/bImu/1C6d5ofhDShw45mFZ9L5w9FHzecipA27QRelwIe5nrbZMbRuz3zKGZyoU78b5S1hh4nuD8DVzF3BnyLT+/ioScTdj0Vki1vOO9h22PW93Ms4gzSDaS2xa+vv73q4JYg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR11MB1739.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(376002)(136003)(39860400002)(346002)(396003)(366004)(451199015)(64756008)(4326008)(8676002)(66446008)(66476007)(66556008)(66946007)(76116006)(2906002)(41300700001)(5660300002)(8936002)(52536014)(6506007)(7696005)(38070700005)(53546011)(26005)(9686003)(86362001)(186003)(122000001)(71200400001)(82960400001)(316002)(83380400001)(55016003)(478600001)(33656002)(38100700002)(110136005)(54906003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hpmvUh1DAtvufHCwve6hklSON6OxUYvluToLuyKN9WAGuS2qeXKHB3uUFr1c?= =?us-ascii?Q?ffzM2r8BH4miuu8VJ4Vo58H114R6Sa6r4d4CsjLps+t/q1fh0V4cCuynzZQb?= =?us-ascii?Q?JxKou8Vn4Tsx/TcptRJEVZ0yHKb5/wzcilV/ny1T1laKY0fFxpcntiWzFXCu?= =?us-ascii?Q?ZuqkcIq+szFkpeyq+WX15UaV0vA8cDve1eOx9rEme+JXnHqSASAO8wjv1IeZ?= =?us-ascii?Q?N4z3FIVsrQYCsSef6qxNmC++HXPLieTAHpTlwekqJND0I3xsXbTKIMxu7HQT?= =?us-ascii?Q?eDmOIAo8ddSTQ/3JIl2MOwOudKpc7p6TB4D2FjjV7ioUWaxtvcu6Fwt7s5KI?= =?us-ascii?Q?X+8HwrJn1Kl1d6Wf6DD7S1kaY1Ub9C50rbEyKfKOpSTfLwa1ZB/a3l4ftWI2?= =?us-ascii?Q?U378aPW9L42uXABK59B21M8dfgbEAVAjTBvdNrXXpMegEQIvTSphyTEB5Vnf?= =?us-ascii?Q?oq2tobjCrvnMdm2jetx6tUr33/+ncKD3gI4KC0K9oNQ1b1OUqEHGraDPYvZI?= =?us-ascii?Q?mVZps9SU1FCRCUQ541MJIum1GgnKhrZqMsSuxRQVjRwNcSi+1zxrAF6iBByk?= =?us-ascii?Q?GTzc6sZagKEH+2esO/LJ3AFE+X+36nrWQC/fQ136DReM3ZnyMswxM2+T1hIL?= =?us-ascii?Q?CIk8h9U+M5yrFG7/LwXSFiYmWUnRiGudKkS88h1XqoIOlYVR0eYBHH3d3U+0?= =?us-ascii?Q?FmLU/45MUq+z+QV/T9HxMMdiow1qSAiLIYNh3ixrjNJv+Oae8ldkKqStsu6t?= =?us-ascii?Q?ZtwnRTMoHN6oun4XdK3n0coBBZCoC7QHRVc2fac10fXtWgP4hdQeXb13Lc4p?= =?us-ascii?Q?3KV8nO0kXvLj7cj30rV6jD9NRUN6FkdCJk/HrddEwU3PKQLJAYpfV1mvNUiI?= =?us-ascii?Q?JlsC/amcBdNAroRLeT8ryftwtdgK1vSLNKBpSsDqM1QkbCQvCw4LNyYLRsxO?= =?us-ascii?Q?pkqKpNYfKuT40LQrdwjjAO0tAP5VTlj1WZC/rPvzt0D/yIZPMvCFd4rA0Oxa?= =?us-ascii?Q?sHyTddrZCQ9qlXQtTjxHouTj2rGoRr/g2/hSKPfKSlj628n1BF8Q5CIaR78R?= =?us-ascii?Q?HnEjRklrPQZBJWnPqqjN7SsGfUgbQbnuHfXnXcG40Cce3oYEqvngfAyUdfOV?= =?us-ascii?Q?T30Gi8tZV18xNPDP7Fkrmfqzp/n17cDqNx9Y5q2VeTMyokEKiTcMgFqweH41?= =?us-ascii?Q?uHe2ZM4TRO6SrTTdqIpggN00siu7Q5X3Dfa400kFDxSCRH9l9M45rb+f2vU6?= =?us-ascii?Q?dx8iXl3H+GFpRCYSZ64BtK7+pLgER5Ffw/lW3APaIqPgM8o5U0IGeCYk+q14?= =?us-ascii?Q?DAxgz4hgShRKtvs9CjYBdvZZNoYb7/RLQs0SWjk1nkZwQsJNKBH7JcbUrlw5?= =?us-ascii?Q?uMDLe/wJ6mrq+S6T0CEnDt+LNzOoboUzWs8LFMvEf6jUpKF8uLPKh6KyD0lH?= =?us-ascii?Q?UnURcCFWBwMtA4abrdXs6LcqRmMfrHbedKAtDMNsTpKzPMzVEbWNFU+CRdR6?= =?us-ascii?Q?ydZreNkKLCX/5c4DwBRa5HbHWly8emDslAvHzIOmhyCLNkdax2rGhMqLqJpx?= =?us-ascii?Q?mTfFr/13IkX9v0YcVF1KJr1qHOdrjc7knE9BX+3H?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1739.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: db82c316-2a95-4c1a-e15a-08daac227f45 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2022 07:22:18.9873 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 51GoQ0z8AdDxWw2iJRFUtzDKomnAuIo58IfrIAsISM7F7ieEYFhmVEnALjxcKX6ooN4p/G4psF0VEgnphh+fag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6621 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Chenbo, Sure. I will address in next version. > -----Original Message----- > From: Xia, Chenbo > Sent: Wednesday, October 12, 2022 2:09 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coquelin@redhat.com > Subject: RE: [PATCH v3 3/8] vdpa/ifc: set max queues based on virtio spec >=20 > > -----Original Message----- > > From: Pei, Andy > > Sent: Friday, September 16, 2022 2:16 PM > > To: dev@dpdk.org > > Cc: Xia, Chenbo ; Xu, Rosen > > ; Huang, Wei ; Cao, Gang > > ; maxime.coquelin@redhat.com > > Subject: [PATCH v3 3/8] vdpa/ifc: set max queues based on virtio spec > > > > Set max_queues according to virtio HW spec. >=20 > Virtio spec >=20 > > For virtio BLK device, set max_queues to the value of "num_queues". > > "num_queues" is element of struct virtio_blk_config. >=20 > Set max_queues to the value of num_queues in struct virtio_blk_config >=20 > > For virtio NET device, read num_queues from truct > > ifcvf_pci_common_cfg, >=20 > truct -> struct >=20 > > calculate "queue_pairs =3D (num_queues - 1) / 2" and get queue_pairs. > > Set max_queues to the value of "queue_pairs". >=20 > And say 'get the queue pair number using num_queues and set max_queues > to it'. >=20 > > > > Signed-off-by: Andy Pei > > Signed-off-by: Huang Wei > > --- > > drivers/vdpa/ifc/base/ifcvf.h | 2 +- drivers/vdpa/ifc/ifcvf_vdpa.c > > | 19 ++++++++++++++++++- > > 2 files changed, 19 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/vdpa/ifc/base/ifcvf.h > > b/drivers/vdpa/ifc/base/ifcvf.h index d16d9ab..1e133c0 100644 > > --- a/drivers/vdpa/ifc/base/ifcvf.h > > +++ b/drivers/vdpa/ifc/base/ifcvf.h > > @@ -21,7 +21,7 @@ > > #define IFCVF_SUBSYS_NET_DEVICE_ID 0x0001 > > #define IFCVF_SUBSYS_BLK_DEVICE_ID 0x0002 > > > > -#define IFCVF_MAX_QUEUES 1 > > +#define IFCVF_MAX_QUEUES 32 > > > > #ifndef VIRTIO_F_IOMMU_PLATFORM > > #define VIRTIO_F_IOMMU_PLATFORM 33 > > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c > > b/drivers/vdpa/ifc/ifcvf_vdpa.c index 3e5ffba..376239a 100644 > > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > > @@ -26,6 +26,12 @@ > > > > #include "base/ifcvf.h" > > > > +/* > > + * RTE_MIN() cannot be used since braced-group within expression > > +allowed > > + * only inside a function. > > + */ > > +#define MIN(v1, v2) ((v1) < (v2) ? (v1) : (v2)) > > + > > RTE_LOG_REGISTER(ifcvf_vdpa_logtype, pmd.vdpa.ifcvf, NOTICE); > > #define DRV_LOG(level, fmt, args...) \ > > rte_log(RTE_LOG_ ## level, ifcvf_vdpa_logtype, \ @@ -1512,6 > +1518,7 > > @@ struct rte_vdpa_dev_info dev_info[] =3D { > > uint64_t capacity =3D 0; > > uint8_t *byte; > > uint32_t i; > > + uint16_t queue_pairs; > > > > if (rte_eal_process_type() !=3D RTE_PROC_PRIMARY) > > return 0; > > @@ -1559,7 +1566,6 @@ struct rte_vdpa_dev_info dev_info[] =3D { > > } > > > > internal->configured =3D 0; > > - internal->max_queues =3D IFCVF_MAX_QUEUES; > > features =3D ifcvf_get_features(&internal->hw); > > > > device_id =3D ifcvf_pci_get_device_type(pci_dev); > > @@ -1570,6 +1576,14 @@ struct rte_vdpa_dev_info dev_info[] =3D { > > > > if (device_id =3D=3D VIRTIO_ID_NET) { > > internal->hw.device_type =3D IFCVF_NET; > > + /* > > + * ifc driver always has CTRL_VQ, >=20 > I think it's ifc _device_ has CTRL_VQ >=20 > Thanks, > Chenbo >=20 > > + * and supports VIRTIO_NET_F_CTRL_VQ feature. > > + */ > > + queue_pairs =3D (internal->hw.common_cfg->num_queues - 1) > / 2; > > + DRV_LOG(INFO, "%s support %u queue pairs", pci_dev- > >name, > > + queue_pairs); > > + internal->max_queues =3D MIN(IFCVF_MAX_QUEUES, > queue_pairs); > > internal->features =3D features & > > ~(1ULL << > VIRTIO_F_IOMMU_PLATFORM); > > internal->features |=3D dev_info[IFCVF_NET].features; @@ - > 1609,6 > > +1623,9 @@ struct rte_vdpa_dev_info dev_info[] =3D { > > internal->hw.blk_cfg->geometry.sectors); > > DRV_LOG(DEBUG, "num_queues: 0x%08x", > > internal->hw.blk_cfg->num_queues); > > + > > + internal->max_queues =3D MIN(IFCVF_MAX_QUEUES, > > + internal->hw.blk_cfg->num_queues); > > } > > > > list->internal =3D internal; > > -- > > 1.8.3.1