From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1C2D1A0544; Wed, 12 Oct 2022 09:25:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0E3E242D86; Wed, 12 Oct 2022 09:25:22 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id CF6DB42BF0 for ; Wed, 12 Oct 2022 09:25:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665559520; x=1697095520; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=lbPovQX2iHbNX58ETK97CZydO7Mb4klJZpFkoKFh2a0=; b=DcfAugPzJa93mHs+LG0tP1jKA2ywI6k72HlNvXvvyN8ZqyWTUGfuw60Q g5E03/XE4OM2q043VEQIOQKjRAgPXNHFD8yNLSf4i9bZzX+uOmOZa3svF ZhiQqxBjSto5mesn3UXCdDmTEKXvsYvHxZBia/L0SiDLsnUojPWqL7i/d v6CScWpxgHjautZSKoCKoOhy4lpD7MX0g34Y8uTjbh9PMY3UvNS+229fT rB6v1BXHgGxnvR/jHxfj0aHuQqitkP9mgz8Id5DiDsd229Oa1yw/7nfrt r7r3SUtapv+dEbtekiUtVqlw2wImiojF8ynnjou4EzIOgiLT/mJDqXpJN g==; X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="391028794" X-IronPort-AV: E=Sophos;i="5.95,178,1661842800"; d="scan'208";a="391028794" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2022 00:25:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="715820220" X-IronPort-AV: E=Sophos;i="5.95,178,1661842800"; d="scan'208";a="715820220" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by FMSMGA003.fm.intel.com with ESMTP; 12 Oct 2022 00:25:19 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 12 Oct 2022 00:25:18 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 12 Oct 2022 00:25:18 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 12 Oct 2022 00:25:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ehUeaQwW9YLG/fPW+p1EcNwTFhqO2FCtdVErVbliEeAFZGA4MYnqpNMiFksJx6WaO3yRJc1fpm18e+VEW/zUKOVNcNwwl0rK4e7MillV4dtKCrNAmtPfSF3ll8EYuYZ4XfFsapfmIYsbOMqMdWzsMPEbSadXhU0DP6SyO+xT5v5fPo7AxoKeMLvxI6WtIkCuzmJvHtqGXSALP5OtHvWjEiHptKJVFjWyGThsTskYGwU+O8hlh9HwJbSadG9MNkjVR+jN7koCVQhRQigGuDc6cYjWVdlP/CzfDyYDFfPv9gPYQyo4j5xxfLxNZJQhcnvgIDMlzkQZDTkbuT5RnnsOaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b+MCL0/2iVkE4WrIM2u+B6qO3cxkDwS63krLjeNYDCA=; b=BNjKMkSAAU0KM1Bw0yR1EJfCNDah0PY18mnqFCdVGDr/D9AyfLXmI/DNa478uFKTXt3UFykfez3/Zm4OcNPjr7lUj1W8jf/7XgAJKOMCb8fhGz3Lk1JXy10bSRWY64RyH7tvO9JWOnwJqxpSbVx+R1L1TPnGZnjZfFX/YZmYcp90rx9pkU3F4xDlhrsoJgqYYkRh6ZyfhVhbMg3IjRPzgtIb53j1cQ937VDWeS7txQe9mb1G9lYXx3nT6DoEE/E/MGQBBCCKvuusaHxT42cvUpW+PkfvjWAAYTo1w1TssT+TCqx4RN5imw7Gkz4zEOrbhaq7pfEaaoDzDiWqaCvZwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM5PR11MB1739.namprd11.prod.outlook.com (2603:10b6:3:111::22) by SJ0PR11MB6621.namprd11.prod.outlook.com (2603:10b6:a03:477::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Wed, 12 Oct 2022 07:25:16 +0000 Received: from DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::b8d7:6a95:bf26:e4ef]) by DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::b8d7:6a95:bf26:e4ef%12]) with mapi id 15.20.5709.021; Wed, 12 Oct 2022 07:25:16 +0000 From: "Pei, Andy" To: "Xia, Chenbo" , "dev@dpdk.org" CC: "Xu, Rosen" , "Huang, Wei" , "Cao, Gang" , "maxime.coquelin@redhat.com" Subject: RE: [PATCH v3 2/8] vdpa/ifc: add multi-queue support Thread-Topic: [PATCH v3 2/8] vdpa/ifc: add multi-queue support Thread-Index: AQHYyZPjhD/OuJdngE+p46Dob/WD3q4KOoTggABJ2IA= Date: Wed, 12 Oct 2022 07:25:16 +0000 Message-ID: References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1663308990-621-1-git-send-email-andy.pei@intel.com> <1663308990-621-3-git-send-email-andy.pei@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM5PR11MB1739:EE_|SJ0PR11MB6621:EE_ x-ms-office365-filtering-correlation-id: 4d34aa9d-98ee-4363-6ceb-08daac22e8e5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FkWmH+Z3W4QGxY140VbWJ0PLJDUHNvgfhGjMjJW1d+OwDhfNCuEKuWe7sqxIfMYrcPmpel3qyIocoOoCEhefneh0vdcIyJbqwY6QuWQFClB47YDBObptHjlJ16ybmTmVXtUItMnnE9jppMkNrqEXS0SJU4G/VZm/LB/IZqMRW42Yz9J4wfx+A487HPizNmZFUB1JaAllN3FvKxh54h2nHbjGOt3I3C1yskgAa3jFrSv6x/OlRDmxkX4D5yTrrsgUvfd5FJIOc1tCfOP5FLrWU0THodM8zfDwd4I8iTkTIiBWpstw4KE9Fr1s0Yp1CwohEYGZ+f3EatqpaTwcHtbjMA4TlDqiENcRf7aM9bj46uXltIB6q8n5pKvbeaKk8wN1BWlgT36WzV2o6Lqn5fI8ez3ndF0lDavXplFOjqlJ8FVjFQfj76Znt99sWdZL0OiHmwePrp2Qwh2Yh5V0LhRQSIHXNaTariesCeXHJBONo3JgyJObJ4CVVhcVUg5/5H890+WzA7/0RSZAhdp0wQVJqgWaDQDyCf6lHPghdBBhNVxJHnqD0LGPwE8OtVrScApIPR5tEYim/ujRm8RGh9xjsxYteym5tuAR+crC8OTdyGZdQ6coyk1bbhKCL8eX+yYn3+Vu9nBiXAAPhC9SKiRAj+AiXTBUtyYxxrSulqj6trVi5/BuiOilvfhSbawDqBWKaXa0j+ZFDoV7nsj3v08fTidp+PQhV5iv5Gaziv2H2Pwbt09JPvdssVXo5XI0wWGBQUqhV3vBUlVbSjpcn4bNZw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR11MB1739.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(376002)(136003)(39860400002)(346002)(396003)(366004)(451199015)(64756008)(4326008)(8676002)(66446008)(66476007)(66556008)(66946007)(76116006)(2906002)(41300700001)(5660300002)(8936002)(52536014)(6506007)(7696005)(38070700005)(53546011)(26005)(9686003)(86362001)(186003)(122000001)(71200400001)(82960400001)(316002)(83380400001)(55016003)(478600001)(33656002)(38100700002)(110136005)(54906003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YCTQMfUQ5gE8mz1HDsRopxNdj1oZfkOCvMaTVUsmDRYERa7EfMbI69OO0Uxk?= =?us-ascii?Q?HIS1+qyveQdtYiPC9tyltouWlzYOxcF1xGZJd/vaC1oqqv6UE0qFuV7VpSjO?= =?us-ascii?Q?0QUahtWroKM1fbL4Ws75eYBVz1h14ZLZABYir0uqKq8rDM5S3BpECKtMYRUw?= =?us-ascii?Q?ZPu1sMJ5wzQQdC3+oc5GoIAfemRmMIZ5J6EwkAm7O95kC4ziGRZ3Bsem0IrU?= =?us-ascii?Q?Yzw0bFOx3vkUW3Hp8xE8u0eIaQjhA2UdABQRCGB4q5+eOsMPSgGeIqENzu7U?= =?us-ascii?Q?FoKwD1ltjmy1f5cva46NrrBk1c1HZ5ujXxYZ+gdmDdK6oLVP9OxtmYFpjWOF?= =?us-ascii?Q?d0TM0jbpiDjg4NpeMU//hQ/K8tVRR9Qs+ysBayhBwvkkLgZSB01umYs5HiUO?= =?us-ascii?Q?1Nba+nXxWyvLE0ofeeTv001BgJ9HN4P6DHgNr4OgdEu1fFOEumrkMdrx1QLs?= =?us-ascii?Q?4aG1YB+0sI3GWq2QCO54+S3RyIwO8unx5xMTn1p994vYhsKiAStFOiAGuNrD?= =?us-ascii?Q?L8aD7NF/cdCsa7FEDAiLVjgw58Ms84TYFCtEPN4Mx5U6+utdnQkarxEbVtj3?= =?us-ascii?Q?1Olxkf2GZtrzOSUGfk2DyJtWf9AMPfYDYLJ4IUp8H4Cd1COhTW+HwqVZ+HFk?= =?us-ascii?Q?A5CpQsS482WJ04+us0BqLsiwx0f43LE+tponjTGhuKZ6zHSzQBo+Bffv4MEx?= =?us-ascii?Q?/iw1PW+GWZ4p9P2VZi7zq468FlTUb7PfoJ0UEcOKB4oEVSNaNScQ9df/7eVe?= =?us-ascii?Q?ya1lAmUFnKU3rhfKuSfQ1nit+ygyk9uYG97sNeW3+FOS7mfP/lSoKGLFJ8O1?= =?us-ascii?Q?IMPCesa8FD1Zna2EzPm2Ee+09jkLgQEmUW+ATKPnMjM0+UNIWLvtGNJ+LWXJ?= =?us-ascii?Q?YQTgttCqGVQTUjQgGkS7XCQzFvmjdzRg2mYSKjrnuYPeQmYZ7KOa6t2gU0GW?= =?us-ascii?Q?iqXicTH7EPZ/qbfuQC3Y8tqNbVIfs/xjJ0ijMphcnpKv560bsQyYVS9d1wC3?= =?us-ascii?Q?UPmhVFzVnMJi36ebDa8gtf0ocGq3ZZEriTW0n9inYhmQc6RWhm5hfMWW0Ar/?= =?us-ascii?Q?DiXtT1RCsSew4LriEFBrQT4e0cKJmIMbcDA3KZWpAESWP1UWFFadAjV4vbzR?= =?us-ascii?Q?L8LxPgoi/LnpBvbC0d+qE2Jnee4AlBc3Vlib3jdvAhOSkH1eDffemo3aqjMZ?= =?us-ascii?Q?CfYPpCMzBGPghs7HwSF6Sb4O7eNo8ox3DuQxhcQX1D4fTIYP12SaRd62BRwD?= =?us-ascii?Q?oTSdq1qEWfm/vkn8N6Zn5LPfrXKSmK17aGhxe8siZPTFYakgCesMSlhgVGxw?= =?us-ascii?Q?KOJeNDW0IOxON6Svxocs1R/0jTFh/ofEdfAqzAI2ljdbpQjbE/toa5a5o21e?= =?us-ascii?Q?qOUVqYOZdH94FNM+656uoPpyuURmXdY3ozeMXTAktZ4RFjxmJsgXgtEKfeZv?= =?us-ascii?Q?VmTfdA+rdsyIvEPFEv93+HWr/xL3GwLMHan3uXSXUxzPNpWrC3WzOwthWdWC?= =?us-ascii?Q?WH0C+3QboamUw2fsCrRa/nqqNw6QvEwkh6cs8CxkPlIW/ys/a55Fk0lvJeA9?= =?us-ascii?Q?+mtcIU0mQt46K8D7BBxMYA80M5u3QAmqAlOMtaCf?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1739.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4d34aa9d-98ee-4363-6ceb-08daac22e8e5 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2022 07:25:16.2405 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DMRDYfpY3lRxLotDm/gCoSqdQdhOKolbx1Bg5PFtEVyZRczP9zqBZhvBWtCUfeyi8lKIhBl1lxRIKPZzHCyX/A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6621 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Chenbo, Sure. I will address in next version. > -----Original Message----- > From: Xia, Chenbo > Sent: Wednesday, October 12, 2022 11:02 AM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coquelin@redhat.com > Subject: RE: [PATCH v3 2/8] vdpa/ifc: add multi-queue support >=20 > > -----Original Message----- > > From: Pei, Andy > > Sent: Friday, September 16, 2022 2:16 PM > > To: dev@dpdk.org > > Cc: Xia, Chenbo ; Xu, Rosen > > ; Huang, Wei ; Cao, Gang > > ; maxime.coquelin@redhat.com > > Subject: [PATCH v3 2/8] vdpa/ifc: add multi-queue support > > > > Enable VHOST_USER_PROTOCOL_F_MQ feature. > > Expose IFCVF_MQ_OFFSET register to enable multi queue. >=20 > Multi-queue >=20 > > > > Signed-off-by: Andy Pei > > Signed-off-by: Huang Wei > > --- > > drivers/vdpa/ifc/base/ifcvf.c | 5 +++++ > > drivers/vdpa/ifc/base/ifcvf.h | 2 ++ drivers/vdpa/ifc/ifcvf_vdpa.c | > > 1 + > > 3 files changed, 8 insertions(+) > > > > diff --git a/drivers/vdpa/ifc/base/ifcvf.c > > b/drivers/vdpa/ifc/base/ifcvf.c index f1e1474..34c8226 100644 > > --- a/drivers/vdpa/ifc/base/ifcvf.c > > +++ b/drivers/vdpa/ifc/base/ifcvf.c > > @@ -90,6 +90,11 @@ > > if (!hw->lm_cfg) > > WARNINGOUT("HW support live migration not support!\n"); > > > > + if (hw->mem_resource[4].addr) > > + hw->mq_cfg =3D hw->mem_resource[4].addr + > IFCVF_MQ_OFFSET; > > + else > > + hw->mq_cfg =3D NULL; > > + >=20 > It will be better to add comments about the explanation that you sent bef= ore. >=20 > Thanks, > Chenbo >=20 > > if (hw->common_cfg =3D=3D NULL || hw->notify_base =3D=3D NULL || > > hw->isr =3D=3D NULL || hw->dev_cfg =3D=3D NULL) { > > DEBUGOUT("capability incomplete\n"); diff --git > > a/drivers/vdpa/ifc/base/ifcvf.h b/drivers/vdpa/ifc/base/ifcvf.h index > > ef7697a..d16d9ab 100644 > > --- a/drivers/vdpa/ifc/base/ifcvf.h > > +++ b/drivers/vdpa/ifc/base/ifcvf.h > > @@ -50,6 +50,7 @@ > > > > #define IFCVF_LM_CFG_SIZE 0x40 > > #define IFCVF_LM_RING_STATE_OFFSET 0x20 > > +#define IFCVF_MQ_OFFSET 0x28 > > > > #define IFCVF_LM_LOGGING_CTRL 0x0 > > > > @@ -149,6 +150,7 @@ struct ifcvf_hw { > > u16 *notify_base; > > u16 *notify_addr[IFCVF_MAX_QUEUES * 2]; > > u8 *lm_cfg; > > + u8 *mq_cfg; > > struct vring_info vring[IFCVF_MAX_QUEUES * 2]; > > u8 nr_vring; > > int device_type; > > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c > > b/drivers/vdpa/ifc/ifcvf_vdpa.c index 07cc63d..3e5ffba 100644 > > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > > @@ -1248,6 +1248,7 @@ struct rte_vdpa_dev_info { > > 1ULL << VHOST_USER_PROTOCOL_F_SLAVE_SEND_FD | \ > > 1ULL << VHOST_USER_PROTOCOL_F_HOST_NOTIFIER | \ > > 1ULL << VHOST_USER_PROTOCOL_F_LOG_SHMFD | \ > > + 1ULL << VHOST_USER_PROTOCOL_F_MQ | \ > > 1ULL << VHOST_USER_PROTOCOL_F_STATUS) > > > > #define VDPA_BLK_PROTOCOL_FEATURES \ > > -- > > 1.8.3.1