From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E75AA0548; Fri, 9 Sep 2022 10:33:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1208940A7E; Fri, 9 Sep 2022 10:33:14 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 4D8E44003F for ; Fri, 9 Sep 2022 10:33:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662712392; x=1694248392; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=A+kR1KnP/A4LrRzgTYAD4SMF3NuRgW1XIc82gSQgtLk=; b=BdKJucccHRf0ghx5++4rp2rsHpW4RrY7xNfm+G4H41BHJQjABaU35Mp7 EltUSVPdJkCEImihQf99uQrwnE+iQRkUlf1GsTQVhsqUe2QLTq4oKI4W+ RjOktwW0AojSriUztjA/XVyNS4RdaFXsfZ1skHKsWa5SY+AkSC1ECWaCD e/Es9XBqUzB46Rc73+2LE7/7Wzs/Z+Ai3FuX7XTFjCEnEhEfHGmk3/5Hg 61B9NJl92qNg53SIfmffMbt6o2RZPsp5VbNcO3shNX2FIIqTfRuNRhPCq kerTj+AbPzpWxnQjhWGLAvSm1F4QMBfRmnw7S47FFg1W1qgLspgFYNNwe Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10464"; a="359152329" X-IronPort-AV: E=Sophos;i="5.93,302,1654585200"; d="scan'208";a="359152329" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2022 01:31:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,302,1654585200"; d="scan'208";a="677075366" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga008.fm.intel.com with ESMTP; 09 Sep 2022 01:31:43 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 9 Sep 2022 01:31:43 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 9 Sep 2022 01:31:40 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Fri, 9 Sep 2022 01:31:40 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Fri, 9 Sep 2022 01:31:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nKcCaB10WbXBye9QiWf+l9XFLQthaafj6FHLloBfuZrcAACmmDrpQmVXt/cQhd2a23cMD0P+Ycl749E8eJJMqQUrtgAiYastYHdbkCn1P3L3L4Mdo8u9PgKMm971gMsOpgm4rS7lReGux/tRVMJ6/xKE6CBTfBvKn3gs2P/Ka/p0QKJ/FOou14gO8MKGCeu2OPmFkW6Q3C3hssLApsmy4w0RXZlzIn4mNl+boJKwZiXDRJD6MAwHd0WgUnC3qEivNgkOobZCl42IFryQo1zjiNLrTkU4zmpfqQ99dbL7ThG0A4zfWXhTixORz39SS0QVYiowoKY+KlYu6+G0FyArKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HRgJsOwCkYlBNDixMH5XrLPvmIqAlr6CpEPQDEx9XJk=; b=DIv+8ru9pY0cb7SsFq6SsCapO9hXFg9Rtxc2D6mnL352PdIZJaQpljpBE7xqCMLr6rU1KK7LSRCW8+8HhVUSebaL/eJ7VmP5DhYJyBqtSMI0MHqqTykrb4evfqf1p/SjjZ/45Wl6kaHX547fht+i26/mU+ZG7p/PRW2TmxTzQuMU88PD0gWME23eLxJaDaz+82vwCEqjd2uQYigfwXLlUgglzWV9v4ze/NyYrV/aZUwX1ZYMAjF5gq3hGVc1PEE0N0xHtum/G8lFI0UKrSWXCznmJxq98My+5QItH3Ppoe/l1gSlEase+TdSTG4sOCUZXoz730LzdZnOkDqUD7M4xw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM5PR11MB1739.namprd11.prod.outlook.com (2603:10b6:3:111::22) by MN2PR11MB4661.namprd11.prod.outlook.com (2603:10b6:208:26b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.19; Fri, 9 Sep 2022 08:31:38 +0000 Received: from DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::4cf2:7f87:f969:3ef9]) by DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::4cf2:7f87:f969:3ef9%3]) with mapi id 15.20.5612.019; Fri, 9 Sep 2022 08:31:38 +0000 From: "Pei, Andy" To: "Xia, Chenbo" , "dev@dpdk.org" CC: "Xu, Rosen" , "Huang, Wei" , "Cao, Gang" , "maxime.coquelin@redhat.com" , Huang Wei Subject: RE: [PATCH v2 4/8] vdpa/ifc: write queue count to MQ register Thread-Topic: [PATCH v2 4/8] vdpa/ifc: write queue count to MQ register Thread-Index: AQHYxB6qJFIYzsu7akGVEaHB9zeFCq3Ww97w Date: Fri, 9 Sep 2022 08:31:37 +0000 Message-ID: References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1662616458-164613-1-git-send-email-andy.pei@intel.com> <1662616458-164613-5-git-send-email-andy.pei@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM5PR11MB1739:EE_|MN2PR11MB4661:EE_ x-ms-office365-filtering-correlation-id: 6ce47750-04c7-45ae-1313-08da923db696 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: E4rZ6POdzba9NCy+Gq428Q3wdnbNEyOJhMvfljAqPBj5DvXwPkwNbcMPNdiQyWSBzZV3ZBu3xGimlnjkIn4vlPKnuG+wDENTPwJO3A04GkVNqNCGGLmf3MQj6WMJNDqFacW4rXsITFxx/LlSw+qXvaelg5waXk2WdWAMGSONoxVZugkxz47pFBc0oKioV9PWX0GAa6CDNXQZXGS7AYD8VfndV1uAEsZm7ks7V3YvpsUUEx6ImJ0eoKED5cELsqmadI0+LvFATdObYHv8b3v7nP9mw7XmE5USrndtilnN909GErDRP/cfwrJLvnwmm17nVRvjE7MvN45uenlfXVuXO5NEnwALBWjrNPcjeLp+Q2eRHAQdXvPgOhuhp8l3Sfv8+YJzEADCGaFK4ceYKHnN805AhjNvumAAzKOH434NllLPzGE8BiqfRrTd74RMll0S8WNoIm0QlINCZ74Oo5PklNcJNRFyIZ5fiZCasSphaE+iyTU1Q9YZjuIzl8PXb31Af+qRPSGq7v10mpiMPjptLw6JhY4AO8ZGaFhqEXMoiw6aq8zuKApZAS0j4iYIHtLRl33dby2WUziqqlV+ul5uLT2Z4zoQ5WETN9RUHwNs/EcV26TXlAbcKzXLHl24163b4t0BTdl0U63wjnIC9cOy6wmY81ns1IspUSO6lCBVbnqPegKevTP/eFWsMcYvGlzZiKP0dA9SLfkGWBAPaV0vg1KVR/z350dDWyAW92DAskzOXRxH/5pglQUerVzAVrLcddPKft33MRduNzYXzn5IqA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR11MB1739.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(39860400002)(136003)(396003)(376002)(366004)(346002)(2906002)(55016003)(8936002)(5660300002)(7696005)(33656002)(26005)(38100700002)(9686003)(41300700001)(66556008)(53546011)(6506007)(38070700005)(66446008)(66476007)(66946007)(8676002)(64756008)(4326008)(52536014)(76116006)(82960400001)(86362001)(71200400001)(110136005)(54906003)(316002)(107886003)(478600001)(122000001)(186003)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GdgEV9npbzxriflYYXB1689HOPDqbw+ipBMW17qyfF+Mc328SMv1hM2hUusU?= =?us-ascii?Q?GyYpmgwuYD4jKNMO1gPktEkgGarV7Oc23+Zdk2QPQWKtYqI04+TcCy6oDMxm?= =?us-ascii?Q?kWq36VyVMwO9I01bi8biS3f/9moLRVJV73zoUHfJ4iD38ZEX77yHOh9ai6Ir?= =?us-ascii?Q?HPwEtTwLA5PhW8AxAmxt103IS50HjUoWuKOeQcYpWK3QNbJWrq8xppE+GscQ?= =?us-ascii?Q?otF/fopEltq1trACwUVWdp5xzSNZHYVgta+SkCn8NEMCxGL/gkoAIyYrAJ3l?= =?us-ascii?Q?ZhsLLCXmgLSP0sCTqA9t9wizjL5aZbl3hFmt/Mi+PCsd7t2RoYphENCsS/6d?= =?us-ascii?Q?R7Jp0meUdOAeHXQ4cmKQLpmTtBPba41vFfdZqNZlBq77apH6BmdKm90nsw5R?= =?us-ascii?Q?/wH4S5WV7QouHd5yYAP8km/j5AQCM8I+ko/XU7yZoSakIKhXTOSqP7w24CQw?= =?us-ascii?Q?5sJ+U6YUWGiiv14mqwAykfbQfVuCof5lx5I0VcS6HdVaR+RZJApfy7bp1ECv?= =?us-ascii?Q?/BdGHxmLKN877Tlr2BdOSI+S08CLnGKP55r9jmCAM4+PUse0D6yEZ7n/6s0k?= =?us-ascii?Q?LbLxeSseR2pqHYWNipvSr7Rq08/uzlFMX85nCBK2XdgT3GshpF5TLz+9Fw0a?= =?us-ascii?Q?+TRI5eynGxuRAS0kQ1AXMmJLDc6c1/HGJeD0QpduKlQsrt/fbAXQNWGGr1Zp?= =?us-ascii?Q?ro5xv5lsXhHZj+MhMg76OaQmVfkHIp1tWggz2wn5slhBzJPY4vn4AUcIqb9y?= =?us-ascii?Q?x/9ki7iQhlK1yUWf2936BfY8hLw24GUl3NWaBCuVeqg7UBK1bVw7mLHJ2t0/?= =?us-ascii?Q?cxjIdXuOU5x1vkKAEVZEz7Go5naYduI8phGmsEZJ+76VMthKq12H8YA06Gw0?= =?us-ascii?Q?NWc3gocMfsIs/FrebrSItYEyl0mM1JO0k0TPvF4lFDt8M2ge6Mty9Rx+o0DS?= =?us-ascii?Q?90VrQikPpheNjtbM8A3eYiAGq2WAPut1JasPupPXTac+kzmxDtSzztsQTiIj?= =?us-ascii?Q?EJNtn0RaynRBeiHbV//Y/klIsMDG0YdVfHZTblJSYN3eN9lS9QmBEQZZVye0?= =?us-ascii?Q?TUEK4bpov8c3VBjAMbN86zwJ4HKI3ZMa+tI556Lc/dBCfBK0YGiKBr6woMCM?= =?us-ascii?Q?lhzeTzBwlaQ7LsAqFIbhbn90mCOY5d1v0DgBdE0lhn6owRkFcuOp613VvaJJ?= =?us-ascii?Q?IhKUJo+Zma1d+pL9XwZQZrQqFqfuZZt/ytYTHLRIR+One7KaB/LmzjMM1u4f?= =?us-ascii?Q?vAI9YL64qz4wwDd5einfK79eT+Gsp9M3ZVXEXPesH2YwK5pnz8SQkjcSTqG1?= =?us-ascii?Q?KofeXE7jKzmSx7ktTPTboUUE2nCjM9Phu+pt7cz/AL7JqZ6mE9OJ0wnhA6/l?= =?us-ascii?Q?eWgptN2CgJN3kQmBx9g63cLRzuLkx++5/gqUbkXVnOHhPv3GSW0GsbOrv48P?= =?us-ascii?Q?67eM/6ilkTea40xz++J1Q7TFvDAF4D23jiLnC8Ax3HdKKysXRoMrhPAN+gF2?= =?us-ascii?Q?JzPcEVfd3jT1zelg+tZEUVfaU9y7n3Fan/xXBTXjvvgFg+Af1caHS+/zle8s?= =?us-ascii?Q?uTQ7RazAPcCVGAFypgs=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1739.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6ce47750-04c7-45ae-1313-08da923db696 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Sep 2022 08:31:38.0139 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +q+SZPc/KoKDG2CbJlo6luQCT+qqI1VDpf5bqN1bKk1c8KeyoSgTts4QEjhDtXqPppj/umDiGGzGiyw0F1wdXg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4661 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Chenbo,=20 For BLK devices, ifc driver does not have VHOST_USER_SET_VRING_ENABLE msg. So it does not need to dynamic configuration. But now I think it is fine to use the same logic. > -----Original Message----- > From: Xia, Chenbo > Sent: Friday, September 9, 2022 3:35 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; Cao= , > Gang ; maxime.coquelin@redhat.com; Huang Wei > > Subject: RE: [PATCH v2 4/8] vdpa/ifc: write queue count to MQ register >=20 > > -----Original Message----- > > From: Pei, Andy > > Sent: Thursday, September 8, 2022 1:54 PM > > To: dev@dpdk.org > > Cc: Xia, Chenbo ; Xu, Rosen > > ; Huang, Wei ; Cao, Gang > > ; maxime.coquelin@redhat.com; Huang Wei > > > > Subject: [PATCH v2 4/8] vdpa/ifc: write queue count to MQ register > > > > Write queue count to IFCVF_MQ_OFFSET register to enable multi queue > > feature. > > > > Signed-off-by: Andy Pei > > Signed-off-by: Huang Wei > > --- > > drivers/vdpa/ifc/base/ifcvf.c | 33 +++++++++++++++++++++++++++++++++ > > 1 file changed, 33 insertions(+) > > > > diff --git a/drivers/vdpa/ifc/base/ifcvf.c > > b/drivers/vdpa/ifc/base/ifcvf.c index 34c8226..0444d74 100644 > > --- a/drivers/vdpa/ifc/base/ifcvf.c > > +++ b/drivers/vdpa/ifc/base/ifcvf.c > > @@ -198,6 +198,38 @@ > > IFCVF_WRITE_REG32(val >> 32, hi); > > } > > > > +STATIC void > > +ifcvf_enable_multiqueue(struct ifcvf_hw *hw) { > > + u8 *mq_cfg; > > + int qid; > > + int nr_queue_pair =3D 0; > > + > > + if (hw->device_type =3D=3D IFCVF_NET) { > > + for (qid =3D 0; qid < hw->nr_vring; qid++) { > > + if (!hw->vring[qid].enable) > > + continue; > > + nr_queue_pair++; > > + } > > + > > + if (nr_queue_pair =3D=3D 0) { > > + WARNINGOUT("no enabled vring\n"); > > + return; > > + } > > + > > + nr_queue_pair =3D (nr_queue_pair + 1) / 2; > > + } else if (hw->device_type =3D=3D IFCVF_BLK) { > > + nr_queue_pair =3D hw->nr_vring; > > + } >=20 > Why above logic will be different for NET/BLK, could you help me understa= nd it? >=20 > Thanks, > Chenbo >=20 > > + > > + mq_cfg =3D hw->mq_cfg; > > + if (mq_cfg) { > > + *(u32 *)mq_cfg =3D nr_queue_pair; > > + RTE_LOG(INFO, PMD, "%d queue pairs are enabled\n", > > + nr_queue_pair); > > + } > > +} > > + > > STATIC int > > ifcvf_hw_enable(struct ifcvf_hw *hw) > > { > > @@ -215,6 +247,7 @@ > > return -1; > > } > > > > + ifcvf_enable_multiqueue(hw); > > for (i =3D 0; i < hw->nr_vring; i++) { > > IFCVF_WRITE_REG16(i, &cfg->queue_select); > > io_write64_twopart(hw->vring[i].desc, &cfg->queue_desc_lo, > > -- > > 1.8.3.1