From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E455CA0556; Mon, 17 Oct 2022 08:38:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7D65840143; Mon, 17 Oct 2022 08:38:48 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 1D249400D7 for ; Mon, 17 Oct 2022 08:38:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665988727; x=1697524727; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ZRXB6lytYsu3t2U9B21feKkjkOL1j+RogLn1z+E+Db8=; b=MnbcNIEViuC9UNyYrFvNT5j+V1sISS/kzTwChkNZT2Hk4jMWbkq/XK5x B5TjIodIn6yI/4hFy5qWMTKoLG6THKr66pbDquUpXNUYnceDnAYm6Cgtf YhTS54ASCWx5qvqXo7gpHq6EJ3sI2kgFArDazWPqtF34lXsNo/OIsRAbS Kxzr7qA0gEzDwQ1SXSM/hA3vc1KAGzaxLtqIiaeyhE5zCopi4p2nCw/Kb KZFkV4YiM12aYWT4RX+PR23Rzezbbcv4SO+tsc6F5NmP6+nxVwW/gYe0w 3wmRbWV/0s0ORwo5NJnelhywBUcYfWaGAZgTUGUZn4Cu1aJEB0ZFGKfG6 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10502"; a="367745133" X-IronPort-AV: E=Sophos;i="5.95,190,1661842800"; d="scan'208";a="367745133" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2022 23:38:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10502"; a="717385186" X-IronPort-AV: E=Sophos;i="5.95,190,1661842800"; d="scan'208";a="717385186" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by FMSMGA003.fm.intel.com with ESMTP; 16 Oct 2022 23:38:45 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sun, 16 Oct 2022 23:38:45 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Sun, 16 Oct 2022 23:38:45 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Sun, 16 Oct 2022 23:38:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=leDs1tqS3ip4bWTeSDjNE3h2PTThQEKZ8GnjmwMqKUY9DBEhzz1uiITr7jVrKrpHL9nZ5c0x5sMgaxg7obfzKjLPzoaoS/fm26vyTB8YuWIyMTdeCpE/bOa1HYZRZiYKTHWb2rEF9oYCOYFuYAQuyjGCueKF2KRlLnpoP6LO3tURwYBRwA5KMGIcph6kM1paWn8C7Twv300XNvPFBAlfaYgSRLK78zERWOQWmlNUr2HHHLWw+PBhw9i61iaM88wEvpgqDBCjN3mGDwnZ2ZdfOd/mFjn9n1dVfEvCyvejnHP1L8Mzn4YaUUDhU/GvAAMaJuiqE0ae/8E6VVlK2jjMqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5IEsfvXEWENUFBf9Uv8DO3SGT8vr1zizSXivHGPG7WA=; b=Tow0dTSZp8OZgAvZsdGGpPuid9Yde9pW1pPAmswCwoCh9H0i5dYbJg+DA1O66V3xxLac9EXpEOUrC+V7Wz6v7SWRuDIPMZm8v7HYL2BqzhuE693wGdGAfelSxedvPK4GxLOdoTrPYD79ikQwLfn8IMI2Z6Prke9rZViye7y4GopyjqXgXJ5l+MtW4nEhVgT8AssW2gBwfnV/VkdQK5mfYyLFrEjBmS8/nLGy9D8tA5ZA1msu/5QUnP1aH/uEcjjMnTOAt24nI6OhKy1Fjc07FYKljR0velmlTIkVHaicTh8cIYoViEVZJ6Gz9u+Ml6//nRXMz6jewpfnoLOGPjHApA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM5PR11MB1739.namprd11.prod.outlook.com (2603:10b6:3:111::22) by PH0PR11MB4901.namprd11.prod.outlook.com (2603:10b6:510:3a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Mon, 17 Oct 2022 06:38:43 +0000 Received: from DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::b8d7:6a95:bf26:e4ef]) by DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::b8d7:6a95:bf26:e4ef%12]) with mapi id 15.20.5723.033; Mon, 17 Oct 2022 06:38:43 +0000 From: "Pei, Andy" To: "Xia, Chenbo" , "dev@dpdk.org" CC: "Xu, Rosen" , "Huang, Wei" , "Cao, Gang" , "maxime.coquelin@redhat.com" Subject: RE: [PATCH v4 5/8] vdpa/ifc: only configure enabled queue Thread-Topic: [PATCH v4 5/8] vdpa/ifc: only configure enabled queue Thread-Index: AQHY3uCF1V6MUJszV0uRJgNvhp/5fa4SJGPwgAAD7TA= Date: Mon, 17 Oct 2022 06:38:43 +0000 Message-ID: References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1665650674-291949-1-git-send-email-andy.pei@intel.com> <1665650674-291949-6-git-send-email-andy.pei@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM5PR11MB1739:EE_|PH0PR11MB4901:EE_ x-ms-office365-filtering-correlation-id: a38b32ec-b67e-4e9a-47a3-08dab00a3c6a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QVdrO6d2Ve3qcQg+hXxI39QiPWAYM5xOYTZKZU4V+c8VP3VEKpSDLGd3az+WJ61a3eEAE/qjXVt8bMSQwWEQsaKwkZUupW3cfgbwfSKxnfmZwbjXwylTIa4Yxm87wZcx0L2TghxL7cZlqFod4LBGOOkeB9fJvxqnDMiY3UOAJluAt3Tpgs+kL8GWjK8DV1bK59FYAvvljpQcTNHSI9dfHxqjER5zVK/m29fzHHKJXwrxCJZWrv++uqZ3qe62dj08xpOOjq6TqBsHIPCCgi2hBDTgHEALuI44dOOXL9G0h/Y4GKYajJq37J1mIEBScHutDK25hUUt4Iq7r0t7m+Y7liMWPDj0dGTFLSIERbXZhFpZl7gF/bjmKzeCqKiwu8rGRcOtPmGISW+vFOf33IbKY63Qv4mY0VIGPjMF1fEjaUoWDm4YUoSQ2exUUVQ30fvT7a4v7wIjqxcfLI3/ShR1JAgFq3BlRGsqGJ4hIzaGz/ylufOxOSYknPvYPhQyVx6Wd8xSwmVPRZo+PARQRGFX08ZBiUg3B0z1jLk9FDiMX42AWxne6mxlAc3ii3vrIbWTUUkfQ+cMG6urGCRSEQmhYqokCeJU1trvjcP91TrKiKjqa+LQmFn093dJT+M4DH7/TjN0GkabDkKZ7woa3CptZB8v2JmxJai4IrHEYFuTligfGI+ub1KqKVuT5UhbCoYozMOoE9E8JiypMO+Wyz+nIjpvNU17l0OD1wnzbY5qNmvYT/zSxyrOOmvZyPzvtyODNRLEmVx31YKPe7VPO9HNNQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR11MB1739.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(396003)(39860400002)(136003)(346002)(376002)(451199015)(38100700002)(52536014)(8936002)(5660300002)(82960400001)(122000001)(83380400001)(33656002)(86362001)(38070700005)(26005)(9686003)(110136005)(54906003)(186003)(478600001)(55016003)(71200400001)(316002)(4326008)(76116006)(66946007)(66556008)(66476007)(66446008)(64756008)(53546011)(41300700001)(8676002)(7696005)(6506007)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YuGtVLbTygDUnWJ/0WBoJYdJa/2FGmiiVfeYjGVndvCezhOZl4h4IhDb+gH1?= =?us-ascii?Q?5wDscxmOqPFgzABdzH9d09n7uKX0gTGY2RJJaMC7E4Nn0IgaMa2gf5C5He8U?= =?us-ascii?Q?V51CxVmOzkPV1stqmGEL9ngKE0EF198TjqyRclU0I6efsHxyWZYK5grWnE9m?= =?us-ascii?Q?oLm8Mh1QER2G2c43u7B71Modg1Rna0gosLGVvJ6wCJiT2RuOp03/hTUGTcWm?= =?us-ascii?Q?mbd57wEWTzwKX1h9TbBpuERqBLULyOQ8CGsBLOa9HmnjgpfgKesyakLH4xeV?= =?us-ascii?Q?eU1DN5BBAO2Rx4aV34bgvx5JuRasJuMUeeY0Hw2HDj9wUzSK7SkwaHs8wQnU?= =?us-ascii?Q?TIldf0mnHu9+wZeGEoS8nLOQZjLptQOkB7xSzAPTcgmnwxfA8Lu7b1X0lNX2?= =?us-ascii?Q?y8VqO0jHfbpE0Z+ot0s57pG+xVKEsVjHgY2IUC5cByuZMMFOfWc9vPF2DVmV?= =?us-ascii?Q?2v3tYF9+ZYkSczu4CFGZvF9zQFIQfINWOrgXpY/E4p+9sNtZdAxCfBa8LYPm?= =?us-ascii?Q?pMVcZCxmDjthBEXTbmo/I4amBQNlZSy7Dx5Zs4ZS9R9iM3HXBO05NVuDygnJ?= =?us-ascii?Q?Dw8Bz5RcMboecl9V73drtUD+pDvSSbIQOIQ3oONpkY6APU2LStRxh0Mf6/O0?= =?us-ascii?Q?utsyJ6Dy1TZqzRs9kZ/0Tw3RQKMEkYWsuz7nS+g/BLZdkaf2oCbisqt0sEPD?= =?us-ascii?Q?N0zdcS1XbLiD7phvX2HgNoNDOe/uXkmHupJ1Od23e+FaT840hIjbLylM9YJj?= =?us-ascii?Q?8rblPjJ2lh7P40vm9031n1OmmXDYN1uafdItlwUlly2QQ4PV1aJSxQ0RxrAX?= =?us-ascii?Q?q0jgUeZFrpJ1NrULZDRgpsGjZGxRpVN5B2KSRFELAxsbgyr53HjwI/KOR2Zx?= =?us-ascii?Q?5ksX7dBIvP4YWPoDC+zIpkr9sCWtuyiqZHp6yvJXIZFd+JbnBaI3RUimWbnV?= =?us-ascii?Q?h2cnYqPavYtuFVi2O2jsy/LSJwV66TyEWwJt0jQRbIIjUxru9CLiaGDhKDe1?= =?us-ascii?Q?aF8HMyBAKVt+yitAFD642oDW3x0T1SRwJ2fbpbvG89kr+TGibU3N52AaAaZY?= =?us-ascii?Q?LlJaC3tx7Ye0MFrjtIUCmcLq/aZg/d9zZh+eoig5ZtwC6PFyyQRN4UhWD2ps?= =?us-ascii?Q?HX1/ARDVfCUt1pKMB00x+OkQ8iJC9twFAXqRwRHD3oxeDmL8EugyhTDKlwnf?= =?us-ascii?Q?yryAR0k6Or4aX526iFHUayQ85361iYZQVkKKnn/8PPFHtSkMUjvYERr6Kz8b?= =?us-ascii?Q?Oct29l1Y2NR8wfkiCyA/uK+V0bk0Be33N6+BzeEWsj2GvspINUOrN3NCFil2?= =?us-ascii?Q?4vGDIIME50osUu/HtldTC94g8/0IbpN8ZFSXjaGED5RUbgK6vF7YPqZ5Qzbo?= =?us-ascii?Q?/39SukXE3mGXfM7fK4U/C0ilCcx2/dBFD9Vja1wzC/KXWPYLfNpC0he2rlzx?= =?us-ascii?Q?sH/W/QQVIdhgG7hWVCqlPSykEA0G5Gc0iAyXK52d62OuA2xy83uoossYGMfb?= =?us-ascii?Q?kdbUKFU38yfwzUTPxJ55rp1mQ6Ko8P7f0ZCBRfbsOmQaK1+ajPOV/w3zjS6+?= =?us-ascii?Q?FilcDsdSFY0Qd7AvtFnBReCcshBaS2nmHqFXVZCZ?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1739.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a38b32ec-b67e-4e9a-47a3-08dab00a3c6a X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2022 06:38:43.5481 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 04tR8nau0rElZhATCaAec8tXWKf02qAZoyd1m6upy3OkwVNHjW5fFy6XG3pySDrVWQNyLMQVdr28fiECTHWgcg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4901 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Chenbo, Thanks for your efforts. > -----Original Message----- > From: Xia, Chenbo > Sent: Monday, October 17, 2022 2:24 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coquelin@redhat.com > Subject: RE: [PATCH v4 5/8] vdpa/ifc: only configure enabled queue >=20 > > -----Original Message----- > > From: Pei, Andy > > Sent: Thursday, October 13, 2022 4:45 PM > > To: dev@dpdk.org > > Cc: Xia, Chenbo ; Xu, Rosen > > ; Huang, Wei ; Cao, Gang > > ; maxime.coquelin@redhat.com > > Subject: [PATCH v4 5/8] vdpa/ifc: only configure enabled queue > > > > When configuring the hardware queue, we only configure queues which > > have been enabled by vhost. > > > > Signed-off-by: Andy Pei > > Signed-off-by: Huang Wei > > Reviewed-by: Chenbo Xia > > --- > > drivers/vdpa/ifc/base/ifcvf.c | 3 +++ drivers/vdpa/ifc/ifcvf_vdpa.c > > | 16 ++++++++++++++-- > > 2 files changed, 17 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/vdpa/ifc/base/ifcvf.c > > b/drivers/vdpa/ifc/base/ifcvf.c index 60c7017..4d85911 100644 > > --- a/drivers/vdpa/ifc/base/ifcvf.c > > +++ b/drivers/vdpa/ifc/base/ifcvf.c > > @@ -252,6 +252,9 @@ > > > > ifcvf_enable_mq(hw); > > for (i =3D 0; i < hw->nr_vring; i++) { > > + if (!hw->vring[i].enable) > > + continue; > > + > > IFCVF_WRITE_REG16(i, &cfg->queue_select); > > io_write64_twopart(hw->vring[i].desc, &cfg->queue_desc_lo, > > &cfg->queue_desc_hi); > > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c > > b/drivers/vdpa/ifc/ifcvf_vdpa.c index 5a24204..0c3407a 100644 > > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > > @@ -284,6 +284,8 @@ struct rte_vdpa_dev_info { > > rte_vhost_get_negotiated_features(vid, &hw->req_features); > > > > for (i =3D 0; i < nr_vring; i++) { > > + if (!hw->vring[i].enable) > > + continue; > > rte_vhost_get_vhost_vring(vid, i, &vq); > > gpa =3D hva_to_gpa(vid, (uint64_t)(uintptr_t)vq.desc); > > if (gpa =3D=3D 0) { > > @@ -499,6 +501,8 @@ struct rte_vdpa_dev_info { > > > > vring.kickfd =3D -1; > > for (qid =3D 0; qid < q_num; qid++) { > > + if (!hw->vring[qid].enable) > > + continue; > > ev.events =3D EPOLLIN | EPOLLPRI; > > rte_vhost_get_vhost_vring(internal->vid, qid, &vring); > > ev.data.u64 =3D qid | (uint64_t)vring.kickfd << 32; @@ -1058,6 > > +1062,8 @@ struct rte_vdpa_dev_info { > > struct rte_vdpa_device *vdev; > > struct internal_list *list; > > struct ifcvf_internal *internal; > > + struct ifcvf_hw *hw; > > + uint16_t i; > > > > vdev =3D rte_vhost_get_vdpa_device(vid); > > list =3D find_internal_resource_by_vdev(vdev); > > @@ -1071,11 +1077,17 @@ struct rte_vdpa_dev_info { > > rte_atomic32_set(&internal->dev_attached, 1); > > update_datapath(internal); > > > > - if (rte_vhost_host_notifier_ctrl(vid, RTE_VHOST_QUEUE_ALL, true) !=3D > > 0) > > - DRV_LOG(NOTICE, "vDPA (%s): software relay is used.", > > + hw =3D &internal->hw; > > + for (i =3D 0; i < hw->nr_vring; i++) { > > + if (!hw->vring[i].enable) > > + continue; > > + if (rte_vhost_host_notifier_ctrl(vid, i, true) !=3D 0) > > + DRV_LOG(NOTICE, "vDPA (%s): software relay is > used.", > > vdev->device->name); > > + } > > > > internal->configured =3D 1; > > + DRV_LOG(INFO, "vDPA device %s is configured", vdev->device- > >name); > > return 0; > > } > > > > -- > > 1.8.3.1 >=20 > Reviewed-by: Chenbo Xia