From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E2DB1A0556; Mon, 17 Oct 2022 08:29:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D741B40143; Mon, 17 Oct 2022 08:29:12 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 36A63400D7 for ; Mon, 17 Oct 2022 08:29:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665988151; x=1697524151; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=axt/SDyhDXUYlsKOuYfTC0Gnac3wnWQ6/x5x3CDWRc8=; b=Cyir+1MYl2rb9s3y/GPZwYDJeQrrRhB3dQxB9Yp4AFlogxudxm18hvvG hs+2vWRw6PbbKKfXb8qMXdD5sgKGDZFFLi5MBmFgMFUVlFBihHiO1GJIb FRXB1hzWfH5Ct6HkJNHXIKytJvqhjG6gmF/AvNnPVOBpUjF04mSy3t1Fb 9l6ErElaKZMViG9wql1YMpG+mZWsvDFWeZJU7isIM2KekHglP0pxZJWxK aQJzvQlJVo5NTnSJlmrc205ySsJrzNRwyMunoYl2tSB/9fAjPie8AhHEA x34P+JsxBSAn2deuODC6QmsfOoZ/80wLOQaGPqU0xQJlelmSvs4QhfsUv g==; X-IronPort-AV: E=McAfee;i="6500,9779,10502"; a="307375904" X-IronPort-AV: E=Sophos;i="5.95,190,1661842800"; d="scan'208";a="307375904" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2022 23:29:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10502"; a="661376792" X-IronPort-AV: E=Sophos;i="5.95,190,1661842800"; d="scan'208";a="661376792" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga001.jf.intel.com with ESMTP; 16 Oct 2022 23:29:10 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sun, 16 Oct 2022 23:29:09 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sun, 16 Oct 2022 23:29:09 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Sun, 16 Oct 2022 23:29:09 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.175) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Sun, 16 Oct 2022 23:29:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n5ynE0Ta/bO6nWRD0ozZGRW1xge1WVE50Y/3HHZy016RJBAnjZKI1DjcHCiHAkCrYbGwbnDtanfY23EH9F6+9kWZXbLeEE6gu7dwMY8MhBG8N6CZdMqK2c/5h7AL+7neZB2jjOvHY6bbcmZqrgVvlS9JPvxhqv4XGqhES9NQccEhYrqP1UZTRMEPuWlaupDwrbVjqoqYvDAo8i/cwGULYAgf2BlffsDWgZ4QAjFCuZJL3L4+cAzavB18v0BLh1vR7THfkQakKCTiBn4C6a/NKbR4ABP+2A2VpjHdGOczux9MHBKojD4IQoh5CDr8FB2CKjj16j2Pci5Qiedwh9CXeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6Koz6kMzd3gidaTNkkb4d3eVFnrsZd/KU+l+2Mtxjfo=; b=FSjasVnl8p4tlSKy90CByOcYbR+WZenqYOzVs/QdNPcSaove0pPkvJ9JTLVQu6sg3Vrj5Xi8c9jLMyfGH2G3SWngVVsokqgUEUMI5am4bDn0rCz37vrfweB/81iHhtb+Pwks4bquGmt5elZa4q2nI9Dxf8yvWrjqDHndiddNNAHNN8SgSsG+wIE60V4p4PLByBYOTWf6oRhCdOIINhtQt0X4w1rnjCDr7QE5k1gningnDlnM+MUpm9guqlzI5wrGmSFOY0CdisYmopm6UTe65gwaw3qtU8lVJ3GR/8HfTGTUGKx9KCk2UCfeo98BfypjDiiOL4UmWYXl1IX4F8bbAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM5PR11MB1739.namprd11.prod.outlook.com (2603:10b6:3:111::22) by DS0PR11MB6494.namprd11.prod.outlook.com (2603:10b6:8:c2::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Mon, 17 Oct 2022 06:29:08 +0000 Received: from DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::b8d7:6a95:bf26:e4ef]) by DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::b8d7:6a95:bf26:e4ef%12]) with mapi id 15.20.5723.033; Mon, 17 Oct 2022 06:29:07 +0000 From: "Pei, Andy" To: "Xia, Chenbo" , "dev@dpdk.org" CC: "Xu, Rosen" , "Huang, Wei" , "Cao, Gang" , "maxime.coquelin@redhat.com" Subject: RE: [PATCH v4 3/8] vdpa/ifc: set max queues based on virtio spec Thread-Topic: [PATCH v4 3/8] vdpa/ifc: set max queues based on virtio spec Thread-Index: AQHY3uCC0La0z5tIsEuf/AO0OqgFGq4SI5tggAACAJA= Date: Mon, 17 Oct 2022 06:29:07 +0000 Message-ID: References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1665650674-291949-1-git-send-email-andy.pei@intel.com> <1665650674-291949-4-git-send-email-andy.pei@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM5PR11MB1739:EE_|DS0PR11MB6494:EE_ x-ms-office365-filtering-correlation-id: 691d3364-e994-4d45-5c1c-08dab008e546 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /lRhj9a+64kbghtiKgy5krFmp/06/7sM9I+AZn5kaBAn+adKOUVajpp/FCM3XxQpiDD5TCJ3PskT7NuQ46idK3GYh9xkOK4lGgDXbLq2AZRaXFgt38HdaKWWEiaSTxwLAumf+ZJelk+gKtLeNrRiVzApjW/4c+wf2OrBn/4Pfzx0vN2MJqUbF5bX00dPsY9bFuq6+XQ2ufHED7vjkiHs9aBYgbLCZrRloWffjCaAFWVpP+YprVFUCu3yA1lu92G/5HwbGcggmrT6Y2R8UfE77RlNQkyGLydQoxG7uVnRLwPbcK9Uw6V3mNslrvEA9PJ48bhUVjBShzgsIIYhN5YOWK5C4FfW9IKnL0+7APBjrJRaoQ/147uts9cQPmjm+4mdVnqy2VyLKEU+LNUEE9H3yde0Y8HPqJJfrGyPYhIDwDlL8eAP+q66D+h4tOwkO6afoYd+8bKAcEA2Y1AaXfzy+iWIaOBV4dCLGTZmFaTxCrgfc31zEq4nHtD2iCz/VGZ8PRI5oHwCaKxUem3GadszCOLl6QccpDPfjFJwAALvI32uSaL+BI4mCi2fhNy1VF/R5gAt7+yuLRi0IIEo+jdIAYZc21vlU7V3z0efp3ul5Tu9N9GxtSzJE+trUC4M+gGuMfsghQBSdULerZcLeA2Ory7WMpDQcn7kMMaytWa9A+9JaQ0Kn6LELpVaVonHHiUw5YYbb1MoX+u+FXs503bzCTYRHNluRHOitzwSNWAdwbl3EeqVnMdG7tFF+1cE2wxoupQWAzOZH9WqLmOhbLYE6g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR11MB1739.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(346002)(39860400002)(396003)(136003)(366004)(376002)(451199015)(83380400001)(38070700005)(82960400001)(55016003)(33656002)(86362001)(38100700002)(122000001)(478600001)(76116006)(66476007)(66556008)(66946007)(316002)(54906003)(110136005)(66446008)(5660300002)(8936002)(64756008)(71200400001)(2906002)(186003)(7696005)(4326008)(6506007)(26005)(9686003)(52536014)(53546011)(41300700001)(8676002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3/3NBoCRst9UScXG3G7HvCYBzHyZkd2jfpAKvxzVauA23QxEhZwVSHVPd+bK?= =?us-ascii?Q?g26+jrTZs8PY5VX4WdZjawHnqBkPsYgLNQOGkogujVqERox2v6RMYo48kmt1?= =?us-ascii?Q?TA+1KsKmuvvjaX2k7fYh1FLxU4kg4chtIobY4niyyuMJtIkChF1/Vs69aWib?= =?us-ascii?Q?hyoPgmpS2K8L3vFxTQBiZL8kSl0tUZSP1XzjfDXqJX0SdBSZBYSznszMAuBK?= =?us-ascii?Q?UFDdE0iwC4W8MqPqnYNxtrMvn9sGak3mdva5hTDtIxrGqWO5xxssJtk6mLbn?= =?us-ascii?Q?Ao5j0ilgXbG8B43mB6iJObYagsqTrdAKb9HiNHP+QtYA8mRY9dAO86y1xTvH?= =?us-ascii?Q?M+E3TekfoyWXOQCpM10X+KtqyN5Vfx7WZuY8snMDyCdPWHmZPE/q/g5wv4XE?= =?us-ascii?Q?UCX0qaktcEIbJad52/B7LMqORfbZAvLMVuwbv+JdYx1j3lJwHFtJRcrBI6rM?= =?us-ascii?Q?2KrYNzlxbrQ+ar9wS4AeuR6zpNeu4WozamP5+W1QVFIVthgi4viSssc1c1n1?= =?us-ascii?Q?DCWH/1kIFgFJNeUXygJzVjaWg/Dx6VzvnNxDr8Hh349J39At/F5l3cn8dJ8v?= =?us-ascii?Q?dkfOR7LQRR1aXkv/mYsuuBzLzOgSnOYK/EDstGV3rXQk7uH7LoulEIr4vba7?= =?us-ascii?Q?4RhMGDijqobx2OmT706Dhdsay8Xar+FGoT9R451m7i2a9pzPm1jkMo5EPEm/?= =?us-ascii?Q?brzjYLD0TN4JEu5PNPvRNgPU61IvNz4T6bkxvK5MG0yLBgBkeD4mlcbuJP/l?= =?us-ascii?Q?jEl0756VSkw1LFjkjDCwjdeEz8FOj1wUTRZeGOXaDEFSO03X/TlxAoNk3VLv?= =?us-ascii?Q?q2AI5XDLJDRDgVF34KF2ceZmBsu6qwtLaXRefgxh+DgiJxVZMftEiMt4TyIk?= =?us-ascii?Q?aarXvL6ihY7+TLph4ogNu5494YMH9OyUGAqRHOn0pipnRoziEvNRPu3o1R8j?= =?us-ascii?Q?vBKyWhGb4dnoEg186hp5qT2NP0vGJl1ry1GR3Ft9QrEjYjkggfG985ADgR77?= =?us-ascii?Q?n0p83C5+eVOLMRYSeMjxVfUvxiPXh1tLOvQUmYguJnNahvwPF5x/BWeqh+bO?= =?us-ascii?Q?IRiZgYWBNvkZ3ufCttCUbUDyoUQjZQ6klUQc7Sbq6Yg6FtXvzzN6VPqlH17e?= =?us-ascii?Q?ekJGUX+hidov8pVcX8hhGKPx02qAizhdM+K9RigwJbWOYR1cPdmmfxuYpwoD?= =?us-ascii?Q?nyCR4n0GHtYREGxBxhtC83kTBiRPRDsyFxNOzYc3BwRnsnlbU/dtm046mRnZ?= =?us-ascii?Q?h5/77tWtohR7/+pjH3ucK+MUmBfoyymSz/4/KFagkQfaaeA/jwniujT5eCiL?= =?us-ascii?Q?c/3Sa/bZ8JSMvIttyEsc0t4oaDic6S7wsVotazUUmv/JZMqRyLu63fuElInq?= =?us-ascii?Q?ijADkRkKi6qzhsU0dMFtfPcexe1o6e9qs+RV7iZPCzNvdfS0Qd7zzMi/FR+D?= =?us-ascii?Q?cHYjyaLx2H3zCOGbqkwCZxJOIC/0YksD0udbyn+6MXc94AfeFnKsHNYLfSom?= =?us-ascii?Q?wCpBixUZZC36Lyxpo1VaZszLs/0QvteIFNAzckma858vsgsfN83mHr3V3ZTx?= =?us-ascii?Q?WLWCd4+An4dUx+YrqLzuHT3ALlRtkYy+Zhfg/zKh?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1739.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 691d3364-e994-4d45-5c1c-08dab008e546 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2022 06:29:07.8385 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mcMXsD86HbqhUK0n4oUgHDlzphkks8Nppzql2oXyvQVbGibOawBXIm0jNMhfZ7mfClhG2ybkQscaxEbZG84f+A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6494 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Chenbo, Thanks for your effort. > -----Original Message----- > From: Xia, Chenbo > Sent: Monday, October 17, 2022 2:22 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coquelin@redhat.com > Subject: RE: [PATCH v4 3/8] vdpa/ifc: set max queues based on virtio spec >=20 > > -----Original Message----- > > From: Pei, Andy > > Sent: Thursday, October 13, 2022 4:44 PM > > To: dev@dpdk.org > > Cc: Xia, Chenbo ; Xu, Rosen > > ; Huang, Wei ; Cao, Gang > > ; maxime.coquelin@redhat.com > > Subject: [PATCH v4 3/8] vdpa/ifc: set max queues based on virtio spec > > > > Set max_queues according to virtio spec. > > For virtio BLK device, set max_queues to the value of num_queues in > > struct virtio_blk_config >=20 > Missing '.' >=20 I will fix in next version. > With this fixed: >=20 > Reviewed-by: Chenbo Xia >=20 > > For virtio NET device, read num_queues from struct > > ifcvf_pci_common_cfg, get the queue pair number using num_queues and > set max_queues to it. > > > > Signed-off-by: Andy Pei > > Signed-off-by: Huang Wei > > --- > > drivers/vdpa/ifc/base/ifcvf.h | 2 +- drivers/vdpa/ifc/ifcvf_vdpa.c > > | 19 ++++++++++++++++++- > > 2 files changed, 19 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/vdpa/ifc/base/ifcvf.h > > b/drivers/vdpa/ifc/base/ifcvf.h index d16d9ab..1e133c0 100644 > > --- a/drivers/vdpa/ifc/base/ifcvf.h > > +++ b/drivers/vdpa/ifc/base/ifcvf.h > > @@ -21,7 +21,7 @@ > > #define IFCVF_SUBSYS_NET_DEVICE_ID 0x0001 > > #define IFCVF_SUBSYS_BLK_DEVICE_ID 0x0002 > > > > -#define IFCVF_MAX_QUEUES 1 > > +#define IFCVF_MAX_QUEUES 32 > > > > #ifndef VIRTIO_F_IOMMU_PLATFORM > > #define VIRTIO_F_IOMMU_PLATFORM 33 > > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c > > b/drivers/vdpa/ifc/ifcvf_vdpa.c index 008cf89..5a24204 100644 > > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > > @@ -26,6 +26,12 @@ > > > > #include "base/ifcvf.h" > > > > +/* > > + * RTE_MIN() cannot be used since braced-group within expression > > +allowed > > + * only inside a function. > > + */ > > +#define MIN(v1, v2) ((v1) < (v2) ? (v1) : (v2)) > > + > > RTE_LOG_REGISTER(ifcvf_vdpa_logtype, pmd.vdpa.ifcvf, NOTICE); > > #define DRV_LOG(level, fmt, args...) \ > > rte_log(RTE_LOG_ ## level, ifcvf_vdpa_logtype, \ @@ -1512,6 > +1518,7 > > @@ struct rte_vdpa_dev_info dev_info[] =3D { > > uint64_t capacity =3D 0; > > uint8_t *byte; > > uint32_t i; > > + uint16_t queue_pairs; > > > > if (rte_eal_process_type() !=3D RTE_PROC_PRIMARY) > > return 0; > > @@ -1559,7 +1566,6 @@ struct rte_vdpa_dev_info dev_info[] =3D { > > } > > > > internal->configured =3D 0; > > - internal->max_queues =3D IFCVF_MAX_QUEUES; > > features =3D ifcvf_get_features(&internal->hw); > > > > device_id =3D ifcvf_pci_get_device_type(pci_dev); > > @@ -1570,6 +1576,14 @@ struct rte_vdpa_dev_info dev_info[] =3D { > > > > if (device_id =3D=3D VIRTIO_ID_NET) { > > internal->hw.device_type =3D IFCVF_NET; > > + /* > > + * ifc device always has CTRL_VQ, > > + * and supports VIRTIO_NET_F_CTRL_VQ feature. > > + */ > > + queue_pairs =3D (internal->hw.common_cfg->num_queues - 1) > / 2; > > + DRV_LOG(INFO, "%s support %u queue pairs", pci_dev- > >name, > > + queue_pairs); > > + internal->max_queues =3D MIN(IFCVF_MAX_QUEUES, > queue_pairs); > > internal->features =3D features & > > ~(1ULL << > VIRTIO_F_IOMMU_PLATFORM); > > internal->features |=3D dev_info[IFCVF_NET].features; @@ - > 1609,6 > > +1623,9 @@ struct rte_vdpa_dev_info dev_info[] =3D { > > internal->hw.blk_cfg->geometry.sectors); > > DRV_LOG(DEBUG, "num_queues: 0x%08x", > > internal->hw.blk_cfg->num_queues); > > + > > + internal->max_queues =3D MIN(IFCVF_MAX_QUEUES, > > + internal->hw.blk_cfg->num_queues); > > } > > > > list->internal =3D internal; > > -- > > 1.8.3.1