From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BF701A00C2; Wed, 12 Oct 2022 08:34:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ADC0342D91; Wed, 12 Oct 2022 08:34:58 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 0A7C042D91 for ; Wed, 12 Oct 2022 08:34:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665556496; x=1697092496; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=yr0o4koT4vI/7hvL7GHQd/VjkW06j4gQXbWKrwdqWKU=; b=nnFcXCF886SIsUWdC6J5HAerzQD0xO9ZsoIzzB8sqPI5/JmCsQqRLnnU aVJGSqqz3TqDGGZxIPcEizSS5Dd6SFPLsHC1BdRYEMaKzUsidF5SBbeKG KFfsww+UZDCc0zws/ceWKa4fA/+bXGpfsmnCaBkYZ2plw8CuRwGM7ndAi IN+2X+NGPmx80ogZAaS2syS783jm4/CXqQn0AufWzFZYA4GvbppTv9sfq LdK2EVGDM2xEhS4v9S0DlqoLnA9dwzwuqgzXx8wQdNtaSoo9j0RsKY8lP VfcuZv36xPCA2SebAKJIwOtndN7cMKBmk3mb3T/hbnglDIME5kIFNqKQs A==; X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="391019475" X-IronPort-AV: E=Sophos;i="5.95,178,1661842800"; d="scan'208";a="391019475" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2022 23:34:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="577722333" X-IronPort-AV: E=Sophos;i="5.95,178,1661842800"; d="scan'208";a="577722333" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga003.jf.intel.com with ESMTP; 11 Oct 2022 23:34:31 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 11 Oct 2022 23:34:31 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 11 Oct 2022 23:34:30 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.42) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 11 Oct 2022 23:34:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X9L+bWbN5ggnUGOevPkgLh7U4cSodxqbn/UKeyUrjoNO+2NfABfQUHmk/SEKmvnXVTi8b5zgdlxgoyn+vpto6AMg3fNbkVxY8dau6QQkIh5CQbSb2O5YNbR7HMvJnAbPUNKDE4jEVGm2kCZN2PaS1nzGVCfCDjAQl0UzekgBn2/YKByiZyJnfUYGRCmxpT/JCk9PiN2+6uLPSAaJFk8nih6VcpK41KBPSIb0As4mwr+OC2tMfvhd1phz0a15vOB6jB2b9XkjFPrOat4OBCXailJypy3fe8napKWgtkNv1TrGe55DVbSfCTqy/7ukaC1xkqKwHrU02nWyRyK800HiMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UaI1fnDBO5BHyxBc+xFuziuUHX7KAXKexIW8JazsPN4=; b=NT3s1LepbUFZUHuUsisZ9oIcM6Suuo/9ImVuqR2OM5VBwKG68KNhJ9kLPJERwOxAkbBPVYpnWKTWm7evOhG02MrrLvuO0NOZlHxfepEIN4tNz5W+rEleLfZEIPYae1Ikjniya3ZDIqgnCm88xDTQfAMVQ56z7MLEZr2pl0YL1ojWzP58/g9xH2ntyKvXEox2+kaIoxlB0cfoA6U9DCKRSBN+luXM2kHhe9Paz977qYtFXuck3jvEaTMqRgxSzoHieIvQ82w8ezZY8RhSXAzBkAFDtS7RizWA0A7HEHrxMNQXVAngy7glH+X8UydmPdKIWcjVhArszxbtxo/rebSo6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM5PR11MB1739.namprd11.prod.outlook.com (2603:10b6:3:111::22) by DM4PR11MB5520.namprd11.prod.outlook.com (2603:10b6:5:39f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Wed, 12 Oct 2022 06:34:29 +0000 Received: from DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::b8d7:6a95:bf26:e4ef]) by DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::b8d7:6a95:bf26:e4ef%12]) with mapi id 15.20.5709.021; Wed, 12 Oct 2022 06:34:29 +0000 From: "Pei, Andy" To: "Xia, Chenbo" , "dev@dpdk.org" CC: "Xu, Rosen" , "Huang, Wei" , "Cao, Gang" , "maxime.coquelin@redhat.com" Subject: RE: [PATCH v3 1/8] vdpa/ifc: add new device ID for legacy network device Thread-Topic: [PATCH v3 1/8] vdpa/ifc: add new device ID for legacy network device Thread-Index: AQHY3gSs1Gnl5ONVsUi4n/O+UdEHdA== Date: Wed, 12 Oct 2022 06:34:29 +0000 Message-ID: References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1663308990-621-1-git-send-email-andy.pei@intel.com> <1663308990-621-2-git-send-email-andy.pei@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM5PR11MB1739:EE_|DM4PR11MB5520:EE_ x-ms-office365-filtering-correlation-id: c7526e79-f56c-49cf-a7d3-08daac1bd0e5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GfSCZBW13P2h6AncA7RHxrpW9EFBw/dr3UJsorNpG/H5nm/Do9j/galYQaIiLj6ir1G93vA0yAjSu+8NDSDSI1x16d9HGRsswjcuhCRYCzZcMZgEXXZ9HFHg0e4POtarWd9pIZJIqyUekeWh/o0J+pjdekifc82zoTI/0cYmeuA7PrppH546Dh97cXzSf2Lmq4k4ZeGQiZglsM7SSmvg9YPwJR3OJ7/hIby5mecDgIIe5YjASWtC3PUZRL5QaCp696DmIK2NyDe/raSoO+p5pDKvvnm1imnFqxKYlv8lGaV4zTeMDrHPt9DKYqDSL5EiyMbWlHuFpqSBXti8hE4yiVG9y9+DHwZnjwmYw9K/zTSH6cTBx4qMzZ9MzC+XF+R8uu1vaSJ/OX+v/EOEVKLSh+4sOUILbUxHjLchF8sIB87xPvuyf13toT5eh+H31rRTwukBtAIey5uQPh4j4Y7MB9A3AAHd8D/j4XuBFlJrLoWB7A1OVanLelY76kgT3HhIWFmaQNV4kShQuzcb5y9/lR6GysI8OIO6J7LyC3Nwh/dKtk6ALwQxpAs61/DqvgC58JRJAleLItptviEpBN91oimA7TmQGkGxS3TUy66Tyd0J4F7n9YTZDVUcnrYdI6xaSOy6s3Mislq/EmeN/RsLj4ciOJ5ld4vrBPNo9rbzUWhKqzrX5KBhsxV2wGrg6BdMHdJ4cvj4cpSjD0vy5pu2LCtcA7od50gluN8Ka6O8rHoKdcXc4ZN+nD+/toatGmxipif0qO8AfgL3XF90eqCEBQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR11MB1739.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(396003)(136003)(39860400002)(346002)(376002)(451199015)(186003)(83380400001)(8676002)(38070700005)(122000001)(82960400001)(38100700002)(5660300002)(55016003)(41300700001)(4326008)(8936002)(110136005)(52536014)(2906002)(26005)(71200400001)(9686003)(53546011)(6506007)(7696005)(478600001)(64756008)(66446008)(66476007)(66946007)(54906003)(66556008)(316002)(76116006)(33656002)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3xQ0filw5W0J9T73vznIENoA8jqgEzsIZVorShl0/nVXe9NwVwrA84Byn6Y/?= =?us-ascii?Q?CxzoFnJT+ky764P2DxtVasRI9Ufzv2PlIx6S1hPLMcBQ6qcKeV5J6QU+bku5?= =?us-ascii?Q?ayNeLCPoe3XN65ir8NXZm67eq2gVgPq5Ol0rP/89NgQu8ViHSKN5fyeFkBGU?= =?us-ascii?Q?oaqLC+W8E8K5cSAmT1hyjL8Snr+WNjjRoM6+Dh81ZO+IAmk0SXx+ecSXYqlC?= =?us-ascii?Q?RsvpteK5zxyQ17vSFw3EMeWoCHJvKzlMnKVFxFGCfH0dXsuOZMyB+Kr/dbnN?= =?us-ascii?Q?ho2leMhzBB/e2kFC94T90vpsqfry5Z+iH0AzR+k1xMnAFl7ayTgcMLjRsrlC?= =?us-ascii?Q?VfHsDJnESWMzPxO1Kr3TzhsoJGTs/J9/99ZvvIU5Uxrd1SnWVGeqlDspJBK8?= =?us-ascii?Q?+KkSTkR4gNbUeDmTxujrH5cD8n+mtt3ObbOVc3pPqexLGx+vFM2SrMv+9Gxi?= =?us-ascii?Q?YEHYNZoXwRshHqXNvl6kXgsodg/H1BYgXoF6r67bPiaAcIqU2ydkHV+TrHcV?= =?us-ascii?Q?VqkvtXYY78iCREv+90AJk/GGxia3yW0C5TmDRTcsnHDqwsaVfUVtG4e9shg+?= =?us-ascii?Q?U5+uU6aJx3WZXEV+lMepEQtmPXpCTzrdds6KBDmYUXZA5g4UJFw3qIC7qKdg?= =?us-ascii?Q?vfoPbfusVjMHWmQFF66rc06Rxubbe2aw+2rIBjLLPP8291ZZS4c7k/Kq6k4d?= =?us-ascii?Q?hoNhe3XraRimQKlfzwarWLenHxfwnpPJUm7XiMNko0m2h5ppXMqbog8PmaK1?= =?us-ascii?Q?s9ESnQPD3riSaFoyJ1k/NAQP6PN7SBc8WwPlrpEXlfQ/t9li6gqP+hK0fRNE?= =?us-ascii?Q?VXGNyfS2U9TD5XaTq0vtzyw8O9T5T08D7MBaOm2G1bIdacZhkD2qL4V66jcF?= =?us-ascii?Q?mujlcjpk2EHMI0h/ThpXjycr+lN8+Bhs/JYTwGIMGVIVQNPXjLEIkrmEYQBa?= =?us-ascii?Q?eMPRNqdGF7wZL0DJJ3ws2Zwtmhfn242pxuzWpPUMu8vCiKhlvYpNLNXKAKHk?= =?us-ascii?Q?6tWCZPy7n5NApVIAxwYUhdBL95Fj+aUPACBbSS8G3BVjJUClV1zfzWc0UVx/?= =?us-ascii?Q?XLU6rtsjbmZDMuvBX5s/CkmCXvvLBX3fwi/Nu0TtR6O8q6jKtahad6Qa6dKn?= =?us-ascii?Q?bQ6PY9e0iNtMds/BO7W59ywJtehrHoGHOTnfHeN5SKDsW35wRJCV3x9XIPhr?= =?us-ascii?Q?YabcVzmdCH18k2RB0poBKCdTnFrC/wuS2aDVpXNChML6qUU8Ga28OrqjK7CX?= =?us-ascii?Q?Lut3DuaMuj6fI62ipWnNJtKasMBlRp14UvoAY+aSl4mqfhZZ7jg+otNGRTBk?= =?us-ascii?Q?eTWuTyTJHIBFpjbrfKJ6HM421k35Al3kfzwz7YWcnDxQZEQyk+St1G4qVwUc?= =?us-ascii?Q?jjnjVafyYNHeIKVi5BM/WLHszMAH82LYMKoDjA1Nmb0WiF/6sY1iAwi7IzRg?= =?us-ascii?Q?zpijy43NdexseRw7b5FGkdheyPeLzgev/5A2xJ42ScjrWZr1UClNxu1Xy7Ua?= =?us-ascii?Q?vjZe7n5Xzumx/owhg0a8F/697zPhsSxtp/3YnHGcZwfIUirHv8sJVMehalz+?= =?us-ascii?Q?HVloP/eVSjriU5c/zlCok+a1ZYQlD2Qu8MU3hpDy?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1739.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c7526e79-f56c-49cf-a7d3-08daac1bd0e5 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2022 06:34:29.4683 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Puu0tz8WuY1WPYQ0wtQX6+OQ95IxR4JJ0DZ1ZB0NPWleMZ7My7YwqTYw8xQ7llp83Yr3lBAzXRud4CaYdNa+EQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5520 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Chenbo, Thanks for your effort. > -----Original Message----- > From: Xia, Chenbo > Sent: Wednesday, October 12, 2022 11:00 AM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coquelin@redhat.com > Subject: RE: [PATCH v3 1/8] vdpa/ifc: add new device ID for legacy networ= k > device >=20 > > -----Original Message----- > > From: Pei, Andy > > Sent: Friday, September 16, 2022 2:16 PM > > To: dev@dpdk.org > > Cc: Xia, Chenbo ; Xu, Rosen > > ; Huang, Wei ; Cao, Gang > > ; maxime.coquelin@redhat.com > > Subject: [PATCH v3 1/8] vdpa/ifc: add new device ID for legacy network > > device > > > > From: Huang Wei > > > > Add new device id to support IFCVF_NET_TRANSITIONAL_DEVICE_ID > (0x1000). > > Rename macro from "IFCVF_BLK_DEVICE_ID" to > "IFCVF_SUBSYS_BLK_DEVICE_ID". > > > > Signed-off-by: Huang Wei > > Signed-off-by: Andy Pei > > --- > > drivers/vdpa/ifc/base/ifcvf.h | 6 ++++-- > > drivers/vdpa/ifc/ifcvf_vdpa.c | 13 ++++++++++--- > > 2 files changed, 14 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/vdpa/ifc/base/ifcvf.h > > b/drivers/vdpa/ifc/base/ifcvf.h index 9d95aac..ef7697a 100644 > > --- a/drivers/vdpa/ifc/base/ifcvf.h > > +++ b/drivers/vdpa/ifc/base/ifcvf.h > > @@ -12,12 +12,14 @@ > > #define IFCVF_BLK 1 > > > > #define IFCVF_VENDOR_ID 0x1AF4 > > -#define IFCVF_NET_DEVICE_ID 0x1041 > > +#define IFCVF_NET_MODERN_DEVICE_ID 0x1041 > > #define IFCVF_BLK_MODERN_DEVICE_ID 0x1042 > > +#define IFCVF_NET_TRANSITIONAL_DEVICE_ID 0x1000 > > #define IFCVF_BLK_TRANSITIONAL_DEVICE_ID 0x1001 > > #define IFCVF_SUBSYS_VENDOR_ID 0x8086 > > #define IFCVF_SUBSYS_DEVICE_ID 0x001A > > -#define IFCVF_BLK_DEVICE_ID 0x0002 > > +#define IFCVF_SUBSYS_NET_DEVICE_ID 0x0001 > > +#define IFCVF_SUBSYS_BLK_DEVICE_ID 0x0002 > > > > #define IFCVF_MAX_QUEUES 1 > > > > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c > > b/drivers/vdpa/ifc/ifcvf_vdpa.c index ac42de9..07cc63d 100644 > > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > > @@ -1684,23 +1684,30 @@ struct rte_vdpa_dev_info dev_info[] =3D { > > static const struct rte_pci_id pci_id_ifcvf_map[] =3D { > > { .class_id =3D RTE_CLASS_ANY_ID, > > .vendor_id =3D IFCVF_VENDOR_ID, > > - .device_id =3D IFCVF_NET_DEVICE_ID, > > + .device_id =3D IFCVF_NET_MODERN_DEVICE_ID, > > .subsystem_vendor_id =3D IFCVF_SUBSYS_VENDOR_ID, > > .subsystem_device_id =3D IFCVF_SUBSYS_DEVICE_ID, > > }, > > > > { .class_id =3D RTE_CLASS_ANY_ID, > > .vendor_id =3D IFCVF_VENDOR_ID, > > + .device_id =3D IFCVF_NET_TRANSITIONAL_DEVICE_ID, > > + .subsystem_vendor_id =3D IFCVF_SUBSYS_VENDOR_ID, > > + .subsystem_device_id =3D IFCVF_SUBSYS_NET_DEVICE_ID, > > + }, > > + > > + { .class_id =3D RTE_CLASS_ANY_ID, > > + .vendor_id =3D IFCVF_VENDOR_ID, > > .device_id =3D IFCVF_BLK_TRANSITIONAL_DEVICE_ID, > > .subsystem_vendor_id =3D IFCVF_SUBSYS_VENDOR_ID, > > - .subsystem_device_id =3D IFCVF_BLK_DEVICE_ID, > > + .subsystem_device_id =3D IFCVF_SUBSYS_BLK_DEVICE_ID, > > }, > > > > { .class_id =3D RTE_CLASS_ANY_ID, > > .vendor_id =3D IFCVF_VENDOR_ID, > > .device_id =3D IFCVF_BLK_MODERN_DEVICE_ID, > > .subsystem_vendor_id =3D IFCVF_SUBSYS_VENDOR_ID, > > - .subsystem_device_id =3D IFCVF_BLK_DEVICE_ID, > > + .subsystem_device_id =3D IFCVF_SUBSYS_BLK_DEVICE_ID, > > }, > > > > { .vendor_id =3D 0, /* sentinel */ > > -- > > 1.8.3.1 >=20 > Reviewed-by: Chenbo Xia