From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3981FA0032; Wed, 14 Sep 2022 05:59:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 19D274021D; Wed, 14 Sep 2022 05:59:12 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 9AE1940151 for ; Wed, 14 Sep 2022 05:59:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663127950; x=1694663950; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=m+2yzpE9wQbnLtXEt9VFZ2ZVEoIswM7wUudpLnHJtpo=; b=gW8tvX8haq6rqLMWLTX6CFnmD4FhZ8jYhw9CSWGxm1sWBgQKjKYT59Lv zRRuTSJJCGbZxkQKNr+dCz3d6uXShQFrPkn5SKdx9R4FXHkDanMjglGVw VBpqV/YjRbe34xbCQC7K5PyGYkNefiH7I+RQSNIJDxGlKo+5MN5ZNNEKH ZFVrBs+FQkSQMXUqGlIu19RVYf6+/vT/0SkGi5h3EU9udJsVn33QoxN2W f3TppDYrY08E/DKOER1Ye4K+D/uqIw038SduDXXs9gBLuqWxtYrGZjMMP mzmEVb3S+Kwv7cBPqMGXfR+HZ6HG2qMdIiADsF6GkLKo2xJGAa2GNB9gI Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10469"; a="299683284" X-IronPort-AV: E=Sophos;i="5.93,313,1654585200"; d="scan'208";a="299683284" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Sep 2022 20:59:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,313,1654585200"; d="scan'208";a="705810327" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by FMSMGA003.fm.intel.com with ESMTP; 13 Sep 2022 20:59:09 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 13 Sep 2022 20:59:08 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 13 Sep 2022 20:59:08 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 13 Sep 2022 20:59:08 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 13 Sep 2022 20:59:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d1DQHrZ2SeexpiZ0KSQ6/VY4Gv0uSU9PupDZP5zOQerDnwgevaj7K7PEB/678tkKblLu50Owrwzeep0SB/EbxmW6YLBzE8eflKR28FAeK9QmjKjhSHDtqJym0s/ZzRVYbWLZ93KjwaEzKjFV6IT/nCpiwk6XhWAyaqXrM8q8MC2U7tIIuGRMt44eVzA+2IklXlsvRUXV7QpNSK8H/XqDzcR0SgF5As3HF8co6KzwFlqD7qtq3rQdRjLjnMm0JR0d1TUqALmZvKEVVGl0j0RbJ2U14GWyYnKT9rpbe4xjLjaHb4n57072Ab1QnGLQGpBUE5Sj7hkCYqy7SKYr0DcKjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7kS/wg0oV4ao751X+dHn62rs6mYfnQi1mXh2IRpMWsQ=; b=g9jYxfYHpyeol9QS+jNJXZr1zTHFyhzhqRUEekpyLfDegxWoMMCQLwdtvEbDtIQGW68Qd6a6dkxu2T2TpG39ioOvKGuqQ3vTS9cMjZSDei3mBluF+AuWI5W07qwMMkIXFBh35zFmtLAxqaL6agYBxNZHgh0X2y1Ygd+2rCglps8JgaVn9njoB8DjzfdTWmAdkihd0BWDHLlXJ9B5SRkuwVELudwPxbpiCL6Dk3Kz9XHiZjlYC80Yhf498Y2Kiwkh/zoOo1CXlIfCPgGsT4jClCHgcbW1nIZfCPPxyeI6xlyPaXR9pFWx2Y+nw2yVnF3zMeiy/5sO21Oto3/5/hmxQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM5PR11MB1739.namprd11.prod.outlook.com (2603:10b6:3:111::22) by BN9PR11MB5372.namprd11.prod.outlook.com (2603:10b6:408:105::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Wed, 14 Sep 2022 03:59:04 +0000 Received: from DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::4cf2:7f87:f969:3ef9]) by DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::4cf2:7f87:f969:3ef9%3]) with mapi id 15.20.5612.022; Wed, 14 Sep 2022 03:59:04 +0000 From: "Pei, Andy" To: "Xia, Chenbo" , "dev@dpdk.org" CC: "Xu, Rosen" , "Huang, Wei" , "Cao, Gang" , "maxime.coquelin@redhat.com" Subject: RE: [PATCH v2 3/8] vdpa/ifc: set max queues according to HW spec Thread-Topic: [PATCH v2 3/8] vdpa/ifc: set max queues according to HW spec Thread-Index: AQHYxBDmUbNF1Xc/WEORhsFQxiU9V63eU9HA Date: Wed, 14 Sep 2022 03:59:04 +0000 Message-ID: References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1662616458-164613-1-git-send-email-andy.pei@intel.com> <1662616458-164613-4-git-send-email-andy.pei@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM5PR11MB1739:EE_|BN9PR11MB5372:EE_ x-ms-office365-filtering-correlation-id: b4f368d0-b70d-4225-f017-08da96057720 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /1AEZv3pQUEhs/VaJA+N8HoQllWglG89X45dzuzRNWnN9853NZck9RdS30lnGbggimAOuDtim2kJjS7ehi/KJ+mUhtdqqkVz07gHYiqcDKLwglZHbvzW8GdKUUesl5fn0y0Aj3n0oGR0fH19pyJTe+/Uc9biE9eumcLu31jPmHMIm0zoqhzDroRThChInOEEfv2bFQIRR+16hBrOert26A0dsDHs1KDGOKjnpPUzqZAtVTibmp/hg2V/zROnl8Zvr04dDbe0MVO6v2UevMjKBygvpMuNEIS9/ZhJkjmtAvmiuQiI2xGXSFTPl2T6v12DPB4tr00VE7rwPHOCYblPyFwdSZ1bnUOhomRrGuY9QsPbImLScFq13wdcKSh/oBhodEWy2GgvKGmo2Au0KnruFY8dxkkRprzZ7GgDZA/sANW/HBELq05jahezHhjj2OorwgTiqkX/emsQ7TjW46Fj2h4YaNn0JrQWcxjK7iT1QJF5v/fibhnfMFEIx93Dh4rzz7NPG1Mwg5brpZF2iQ5c6eHabo/ORp5UQna3yxjh/Libkac6vqV51XxuTW0wuhs0lwq0zq91gYJX8Z4mtfrw2gDk/qYaz4Gl+ZjS3SGWhIgRaMLAWkUZ8/ugwDMNgNDQWF3lxMpeu0jlptvV6Zn30archlasrq+EzjzfrFqg0RWFbwAMEXN/q0qWw1/LOFBkUwt0pY8R06wzUrDYcwqcU5W5D4yfrhosLvfkyO9bSJNzlN5YKHfo4hVECG6tDtB1/Zko7ep+lB7Bm69I1rj13A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR11MB1739.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(346002)(136003)(376002)(39860400002)(396003)(366004)(451199015)(53546011)(66946007)(55016003)(316002)(76116006)(64756008)(8676002)(2906002)(66446008)(110136005)(38070700005)(186003)(7696005)(9686003)(478600001)(26005)(83380400001)(86362001)(33656002)(54906003)(38100700002)(41300700001)(71200400001)(66476007)(6506007)(66556008)(82960400001)(5660300002)(4326008)(52536014)(122000001)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7YxgaNZ2yTmKHwad3kcUBl8YQfAO9Jov+ydQp9LXANJzJqF/d2iM2cJoXrcx?= =?us-ascii?Q?g7Qw39XijO25v4u8FwYsYrPgseB9bBjdroOikSic23SHxD5WPLIoWxgmHYZm?= =?us-ascii?Q?jZpLqwaWom6zABWNhnOJfofMNWTYq03z369lCQKbOSz6XkC8LOocb8in43cr?= =?us-ascii?Q?EJ1SlOH/MoXAsPAE4Qo3Ha+Nd9bIQ9bOyH2nOu5IrsPtAGwy4oZXjEbqSpBG?= =?us-ascii?Q?mDciYci7+HWRAGFuhDfImlQ41ULVnmNi9z6S+HGl3eKZ2UiEQUC28XVO+EZB?= =?us-ascii?Q?Zv6C3ae1IX0ROic2VyN0Y5xb/YhMMv+rk40xpNoQLkbcSPbVNe3jkTS6crBK?= =?us-ascii?Q?QvORtStC43T+zJaN/TP+hEfhu+EJl/UyIOfyXAJc+WCLWEAtNMie5EdARgcJ?= =?us-ascii?Q?2OQaDBDms1IRrEkU+Kf2bSrKjXzLCx3xW/D6Aq1Ny0YE44QmCQPLx0s6U4/c?= =?us-ascii?Q?RpbeR6hMjN3U313s/yHjHbNk1gI+0TZzQ7hHHNsuJ7R6DYqQNmZemd/W0KxX?= =?us-ascii?Q?bPfrv/XNYIdFf5+9t9bFAMpUlOeGS9ykH0SomaV7T4bcLBt01TbmWNOdljpA?= =?us-ascii?Q?gKBIA2+d1mf5a4ei8ZjpPOi00TkhUIRPmYsYt/JMG+7ExFyPSHx1i1umfj3N?= =?us-ascii?Q?eHQZ/l29gw7XYGDO4McYrzgyltirB9K3uMO5e/H/7HK1+jxfprV4yFSCCvVU?= =?us-ascii?Q?JcwL+embpnQ74UZvMIzfFueQVi6ERe8u0hEGwHs9BptyfcIL+SU6tU56P9UV?= =?us-ascii?Q?D3H0MMQAUJCvryFAFiOeRwekTJ1QjlgApLJTYMG+Snk3C23MDq/z8+FT5GEv?= =?us-ascii?Q?0eKltZSrsqquOgr2CLEQT5DfUP+JVX86GKh0RTHNzm0fy7mUnpDqF5B9fl4S?= =?us-ascii?Q?zBhnGYFSE1nPflkPAkhnG//Wbe8IA5HrBBRs9VImK0ZynuvDab0Bq6fAxPMc?= =?us-ascii?Q?HaXqTjZY3M08TUaKqqZRLmLSeSFRURvoqVsSysET71GdAE+03EgEOqMEboT0?= =?us-ascii?Q?izPhWNfR0k3m4FqHNSNAeVtMxKPWImcyJL2cQGzLJxMPnXXb0sH8Pgz6fYLD?= =?us-ascii?Q?kly2JD/rPc2QtqT+bNS22ZRHCr2ljT6icuy/t2nvqIT2SHrZslduBpqqa2U7?= =?us-ascii?Q?LGVuuI8nZLHMyvmNKcQRJ+iftF6Oa8Qz7sSXwx68PLj/rKM2uKzy7wyowrA/?= =?us-ascii?Q?k4IQgMun7A0P7ypOmYxinNPDEAULSn99HjBmTBe8KXBEzSyK7Yn9C60jO6kr?= =?us-ascii?Q?nekCUYGddvc5nqHtogTE92rMkXJmNb2J0lD+tcLh2k+PjTexGWGCyOgEDXLZ?= =?us-ascii?Q?CCqcOkruIqZd9OlMOlCitNS8t66VivZIzUaJVkropL5KhihlqsQW42xmPh+d?= =?us-ascii?Q?19QqwPQDlCu897WigNOx+2GodXXJmIrn+cXqymNMx34FDyipfG9pSzYa2eVv?= =?us-ascii?Q?N3L8HGP4CuNPDa5+2WSg8kBIANNfsFGpMo+xgoIcX0yfNLniZTgXoE6CmwsR?= =?us-ascii?Q?RKMmBQQl0UTHIUAuA1gCjI2+XPmrGR9mnEO8XxihEdLXOYYpKE2KGguMTRFT?= =?us-ascii?Q?M22RZXgxqnUjtGi/8/w=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1739.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b4f368d0-b70d-4225-f017-08da96057720 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Sep 2022 03:59:04.3684 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vxngo3SCyFzXVc9Qc64Snv/3hIvIDUENzaoMdnEcNoQodlugk9k6s6aGxUJgKdkSDxDz9jNErSxkUWdY7zPIPw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5372 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Chenbo, Thanks for your reply. My reply is inline. > -----Original Message----- > From: Xia, Chenbo > Sent: Friday, September 9, 2022 1:56 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; Cao= , > Gang ; maxime.coquelin@redhat.com > Subject: RE: [PATCH v2 3/8] vdpa/ifc: set max queues according to HW spec >=20 > > -----Original Message----- > > From: Pei, Andy > > Sent: Thursday, September 8, 2022 1:54 PM > > To: dev@dpdk.org > > Cc: Xia, Chenbo ; Xu, Rosen > > ; Huang, Wei ; Cao, Gang > > ; maxime.coquelin@redhat.com; Huang Wei > > > > Subject: [PATCH v2 3/8] vdpa/ifc: set max queues according to HW spec >=20 > vdpa/ifc: set max queues based on virtio spec >=20 OK > > > > Set max_queues according to virtio HW spec. > > For virtio BLK device, set max_queues to the value of "num_queues". > > "num_queues" is element of struct virtio_blk_config. >=20 > Both virtio-net/blk should be described. >=20 OK > > > > Signed-off-by: Andy Pei > > Signed-off-by: Huang Wei >=20 > Email is wrong, please fix all in next version >=20 OK > > --- > > drivers/vdpa/ifc/base/ifcvf.h | 2 +- drivers/vdpa/ifc/ifcvf_vdpa.c > > | 21 ++++++++++++++++++++- > > 2 files changed, 21 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/vdpa/ifc/base/ifcvf.h > > b/drivers/vdpa/ifc/base/ifcvf.h index ad505f1..c17bf2a 100644 > > --- a/drivers/vdpa/ifc/base/ifcvf.h > > +++ b/drivers/vdpa/ifc/base/ifcvf.h > > @@ -21,7 +21,7 @@ > > #define IFCVF_NET_DEVICE_ID 0x0001 > > #define IFCVF_BLK_DEVICE_ID 0x0002 > > > > -#define IFCVF_MAX_QUEUES 1 > > +#define IFCVF_MAX_QUEUES 32 > > > > #ifndef VIRTIO_F_IOMMU_PLATFORM > > #define VIRTIO_F_IOMMU_PLATFORM 33 > > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c > > b/drivers/vdpa/ifc/ifcvf_vdpa.c index 2d165c0..2b42850 100644 > > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > > @@ -26,6 +26,18 @@ > > > > #include "base/ifcvf.h" > > > > +/* > > + * RTE_MAX() and RTE_MIN() cannot be used since braced-group within > > + * expression allowed only inside a function, but MAX() is used as > > + * a number of elements in array. > > + */ > > +#ifndef MAX > > +#define MAX(v1, v2) ((v1) > (v2) ? (v1) : (v2)) > > +#endif > > +#ifndef MIN > > +#define MIN(v1, v2) ((v1) < (v2) ? (v1) : (v2)) > > +#endif >=20 > Above ifndef is not needed? >=20 > Seems MAX is not used, so remove it >=20 OK > > + > > RTE_LOG_REGISTER(ifcvf_vdpa_logtype, pmd.vdpa.ifcvf, NOTICE); > > #define DRV_LOG(level, fmt, args...) \ > > rte_log(RTE_LOG_ ## level, ifcvf_vdpa_logtype, \ @@ -1512,6 +1524,7 > > @@ struct rte_vdpa_dev_info dev_info[] =3D { > > uint64_t capacity =3D 0; > > uint8_t *byte; > > uint32_t i; > > + uint16_t queue_pairs; > > > > if (rte_eal_process_type() !=3D RTE_PROC_PRIMARY) > > return 0; > > @@ -1559,7 +1572,6 @@ struct rte_vdpa_dev_info dev_info[] =3D { > > } > > > > internal->configured =3D 0; > > - internal->max_queues =3D IFCVF_MAX_QUEUES; > > features =3D ifcvf_get_features(&internal->hw); > > > > device_id =3D ifcvf_pci_get_device_type(pci_dev); > > @@ -1570,6 +1582,10 @@ struct rte_vdpa_dev_info dev_info[] =3D { > > > > if (device_id =3D=3D VIRTIO_ID_NET) { > > internal->hw.device_type =3D IFCVF_NET; > > + queue_pairs =3D (internal->hw.common_cfg->num_queues - 1) / 2; >=20 > Please note this logic assumes CTRL_VQ is always there, if for the read h= ardware, > that is the case, then it's fine. You can decide yourself to check CTRL_V= Q feature > is there or not. >=20 I will keep the code as it is now, and add some comments to explain ifc dri= ver assumes CTRL_VQ is always there. > Thanks, > Chenbo >=20 > > + DRV_LOG(INFO, "%s support %u queue pairs", pci_dev->name, > > + queue_pairs); > > + internal->max_queues =3D MIN(IFCVF_MAX_QUEUES, > queue_pairs); > > internal->features =3D features & > > ~(1ULL << > VIRTIO_F_IOMMU_PLATFORM); > > internal->features |=3D dev_info[IFCVF_NET].features; @@ - > 1609,6 > > +1625,9 @@ struct rte_vdpa_dev_info dev_info[] =3D { > > internal->hw.blk_cfg->geometry.sectors); > > DRV_LOG(DEBUG, "num_queues: 0x%08x", > > internal->hw.blk_cfg->num_queues); > > + > > + internal->max_queues =3D MIN(IFCVF_MAX_QUEUES, > > + internal->hw.blk_cfg->num_queues); > > } > > > > list->internal =3D internal; > > -- > > 1.8.3.1