From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 115C1A0556; Mon, 17 Oct 2022 09:12:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A696440143; Mon, 17 Oct 2022 09:12:37 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 3644E400D7 for ; Mon, 17 Oct 2022 09:12:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665990755; x=1697526755; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=PUsJPOwWNOi2k9h7XpdabWIcXz39bejGtLz0U4r1mAo=; b=XUThx33MKeSWC+ENhGIYvNoIb09y83g5ncAyNwVD+/ei2JZVU+20j401 S5hY3TfJAo+B7S96UVWEaEn+JI7xaxliFk0yP/NQrK0MGeI9r3JTshTqP /E+p1/846ivcYJr+jO63nlxSETeCMxeSFSckcmDVYT60481obsdS9ljBJ 8IqEqASEhE/sl3+nUTkq1Bi/aWZJba0m6RfdG3ZOkkT9SI7efF8i5gYJa Hrm+fF0yAZsC6xOVA+LGZqx7X5RKwyn1FziZJzye2GRCL2OguegDJDMQr 7HWfmFxWbOFY9fayGUB2+JoCRx44RFPsL3V41aZRnOq6kHVDsEkJIDnSa Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10502"; a="332255982" X-IronPort-AV: E=Sophos;i="5.95,190,1661842800"; d="scan'208";a="332255982" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2022 00:12:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10502"; a="579273537" X-IronPort-AV: E=Sophos;i="5.95,190,1661842800"; d="scan'208";a="579273537" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga003.jf.intel.com with ESMTP; 17 Oct 2022 00:12:32 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 17 Oct 2022 00:12:32 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 17 Oct 2022 00:12:31 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 17 Oct 2022 00:12:31 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 17 Oct 2022 00:12:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HQH/x6BqQzB2FPpABUXcAU3VST5FOOG0uv7L+zVf4Uo5of8Nby/A5BnjbEniP2W4WwvPPihGq1VrbQVcbWe3jb8emtTPK+4vO2rczAtHuFp2UVkGtQC4x40rs7iIR/Gw3zNlWnQNDWHOUS/QbIT5w0pVuZtlO6k8306Z+o3LY6EfdqEfPd/hPFcTB9cNX6raUmr1YQ8IYNY69e16MOxvtQKtBu1OnTnW62vDqVS7gDo9AOyux6wIZ48ZhH2T3d6iVHclCmsxO26wbNGX1fHQL7j5aS+mqzj71h0/bVhMqG1b7GvNSC2EACoJ1sqLjjV6fX122RbRVY+yvYt6YHjKgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WlzRzVjza92eXsTZSl/yzCVN1MT7GflVOiDd9eIcLuQ=; b=QbAqUqyXAorsp2w8iW95ZF1fJIg7o8SM6FAOteTTCGgAMW/mPHeg5DiZE3NJqhHJfQXtZdmRIa2RaSt9SGWgBYDBN80JrKXAE00udKT2mRGIR9wA2FZ5eUTnPZBI7SVcGJZX7o50p7AZSJ5MdfJIxylWQuF6K53Vt7vaG4/+YATa/TSDRoXQvBJsvqFP9g4YvPij2N1fZHsZW/1KvqOFP4CdgmhoBNRCGPPq/HFkP9pMOXlVbNfRlv9XuPslGcoqBjD0vibaWPBz0702px61BqP4/EZWt4FlFjlXFvY8pgdfxnapxGHT0xhF0ExcFiftEBS2SroB0C2FiAYyGTeA7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM5PR11MB1739.namprd11.prod.outlook.com (2603:10b6:3:111::22) by IA0PR11MB7353.namprd11.prod.outlook.com (2603:10b6:208:435::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Mon, 17 Oct 2022 07:12:30 +0000 Received: from DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::b8d7:6a95:bf26:e4ef]) by DM5PR11MB1739.namprd11.prod.outlook.com ([fe80::b8d7:6a95:bf26:e4ef%12]) with mapi id 15.20.5723.033; Mon, 17 Oct 2022 07:12:30 +0000 From: "Pei, Andy" To: "Xia, Chenbo" , "dev@dpdk.org" CC: "Xu, Rosen" , "Huang, Wei" , "Cao, Gang" , "maxime.coquelin@redhat.com" Subject: RE: [PATCH v4 8/8] vhost: improve vDPA blk device configure condition Thread-Topic: [PATCH v4 8/8] vhost: improve vDPA blk device configure condition Thread-Index: AQHY3uCKDdt93ksdE0iFWtrcIu1sAq4SJ0TggAAKjdA= Date: Mon, 17 Oct 2022 07:12:29 +0000 Message-ID: References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1665650674-291949-1-git-send-email-andy.pei@intel.com> <1665650674-291949-9-git-send-email-andy.pei@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM5PR11MB1739:EE_|IA0PR11MB7353:EE_ x-ms-office365-filtering-correlation-id: d0d237de-1d5b-458a-4ffd-08dab00ef433 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: e6jRpmVAe5Eoku3qnP2TTx01U0DpvkSL3jp+yxsDzJee2bpP9cJfLu3LTLEeqqRAuyf+SFWy5Qyra1MnH7IEMSGGWm9FBIoHYPr7Gxo681enqiI2L5iZKNxLvOjqKZZWGY/Xqqn/HJ4z08VmoF1kMByGYqCYNlMFel8XO4MeWV03aTWlkTU213wXj2T+Rs6ip9BHuz1iNkiyA1H44pYYjr+QDuiBpAmAzLOvOP6XjrHs4nx+K2FgST+3HkXZkPnmtEFe8hIpVCuvEHkFhWbEPoHdJJByX3A5zmae9Ny+oR8y/fdDwccnJZnn9p7M8t1MxIDSthLwYTmmL1BIpV2JdTLXbQEteDA32iRnOn2vzCLNlsplyv4wsf54v+1LWYbK4+Kx8SZYlDx104dTwn63ElNChLSUOO2nYFJ/i4q985VBjMy6UMTYuuEwm+IUrSfemwe1g0sfe4kttWi93tUNmEyjzT3IV/nNtL6u0a+SRn6onuQ9N2aj4Zikhak+ZkIVxzO331YYrCLwKGckmGb/kQH8MQ6VwD6p9aIVhViTbbUjbcki2HMOEKAlV7ChBD9QzgSdhTm3BgbnqSx2Kgo7t0h09lVfJhTwKCZiTU5hoQx/rwpx0W2D2SmH3mUAq366HVNUd2eSunzCxYGnODkBY2WD2RrRTo/oi9u/xQ9/ggmjcJ2rZwQBfvsSJ35oV9Pt1Fh9/8sAcTkWDmvBcodiM+Rd9/z+kCvUpmnkOj7f9v4KG8G4+lFB8hl76CE6QP6Bd296a9Ri+Fza3qE/pQv6qQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR11MB1739.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(39860400002)(136003)(396003)(346002)(376002)(451199015)(33656002)(83380400001)(41300700001)(66476007)(26005)(8936002)(86362001)(76116006)(110136005)(66446008)(8676002)(66556008)(66946007)(64756008)(54906003)(186003)(9686003)(53546011)(55016003)(122000001)(4326008)(2906002)(316002)(52536014)(6506007)(7696005)(38070700005)(5660300002)(71200400001)(38100700002)(82960400001)(478600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?E2jckwo+mO6B+99sIlmsjz0BbZ6T/ZTtrmcosYk0pkuFWRA/C29o0jM6fXRH?= =?us-ascii?Q?pFlv8JCI3LbpGPyeWuc8UxX5qrJMo8DZichmvbw7Vd8W76NUsjo/Uykd2gf5?= =?us-ascii?Q?ykcbXPbCmmLVxWP2j55SagREpIfTRcfKuRSCmq6SsBUitq3SKa9nJxeZQpqK?= =?us-ascii?Q?HQYBilAAQ37n5ztB1LhMV/8jNNnAVKlW/s7RXgokdO5XGU/J0KL4GQpXSbQE?= =?us-ascii?Q?vzL2OZAYTjzvgZBaq74KrtTMNcH4b+mdZcZ9FJcmiP21hX14njvKgc3WLSuI?= =?us-ascii?Q?sre8KETUw+EZKttUHmS0gr0NkKypC168LPVkpnlzUKDcbBIzFaZx5CuX+NBc?= =?us-ascii?Q?Pgf5j28iQL50ud97oCyAQMFcbtskNzhNj6TbPBKwSoOGVpwAzp46vHgVqHzg?= =?us-ascii?Q?oqXCxtKMl0NzbTHEIk3gOYiz7Mev/Mut62GH5P1MZwyOB0CY4ew+jaCSd2XF?= =?us-ascii?Q?f3RTLfLFNr8FCOM3epV+Pp0MTOasBxCxFYEUs65sz4IMzU1b9c6RXOgraQhL?= =?us-ascii?Q?3I0NEPZ4sX8JC+otvIzP8msACFegKPGA9plO4UTqxcq0aOJVUOHelqarRNRr?= =?us-ascii?Q?oJN1JNVrg3XWsyFRBGOX/TGfPQFeRFZzUCAaH5rmh9JRI32cCiKxij6J0X/v?= =?us-ascii?Q?KyYN7fJtC5j1UXdeBIbBTPsnRP4koZzYm72Tr5UFjSZl/otFTwXxS0OqEsSK?= =?us-ascii?Q?wIwbMJr1x7sHHqUWcuwnCyZekDV0Cd/z33C+RU0wqgvBzOWkRVZPAPBdm2xR?= =?us-ascii?Q?42tCp6celSaTSHChO5kEsfF/+HA0aKL4H6SGTJWmhfqThXipoo++1wLUQLJa?= =?us-ascii?Q?tg/mx1+YHPBtADebyZIbB9LxFynUa2YPbpcldYajzB8TevYYKjb6K2VgWFDA?= =?us-ascii?Q?4P/5VJobzijA43qKz1hvhvIiaEhnQow0d8dFKcUwzqgu+XQaXz14ICagJ5XZ?= =?us-ascii?Q?U7qx7ibo8Ho70o4u15AqSIumEmjRms4vMqRADrz3vneX5XTx5GjEbqLDd+3t?= =?us-ascii?Q?owstxj7HJUAutd2P5GDjqlDWuedepYT+YoI9UtNb+c6BSv27bz2q3f/ZRWkr?= =?us-ascii?Q?U1dPCUVZwXXRqahGdTuKVXq+f18n+9xwbUF46+cGMEKZSsGHVUvRaZGTaTwj?= =?us-ascii?Q?IKJoe/iMmtp6kTWn8mdsH9TXoNNEf3emvZL1WJSLC1cG1XwUp0T6ieNr3Pes?= =?us-ascii?Q?lYZBPUZT+d07+iERt220s5Cv8x3W+WehbNvT73ewPtIa1lOWLPTYjzXIogfR?= =?us-ascii?Q?4NHdw8/xQvM+QqLtNZyBSZbpdqS4AcLo81RERkghE/aXnGuRjTeHOLJh7Sbv?= =?us-ascii?Q?Jd0J7IzuUZqnkqyFQLa6gr7/JppBZT4yEO1mtOFxekZkcOMT1rYguqh/ppJB?= =?us-ascii?Q?lRIdPjn5t6H9QUQbu1tSlHzyb08B7cGDlnSKu9SHC83+fI8s6KQtbyKmUtoS?= =?us-ascii?Q?D0Q1eormb4x0bEgDTfBSXvDwanD9oPHcSna38EEauSKg0AuQ3Volew1lCSzB?= =?us-ascii?Q?kxLDl6Ug6egXhwC5vYyCm7eYNbTQsYRs1uzYIcema2mnzPaux23C3bypG68D?= =?us-ascii?Q?kM6YyMWr1j8xaZg5M0NOpQuQzN3LKq6d3FT6QYyh?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1739.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d0d237de-1d5b-458a-4ffd-08dab00ef433 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2022 07:12:29.8755 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qL5bH4KLW/+NfFsrO/iX/fxMRq7ugqWl4xBf7x61RybPLIl2fMGW4EIESdGf4MWwoQ5QZRg15YmVvtivAhVDmw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7353 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Chenbo, Thanks for your efforts. > -----Original Message----- > From: Xia, Chenbo > Sent: Monday, October 17, 2022 2:35 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coquelin@redhat.com > Subject: RE: [PATCH v4 8/8] vhost: improve vDPA blk device configure > condition >=20 > > -----Original Message----- > > From: Pei, Andy > > Sent: Thursday, October 13, 2022 4:45 PM > > To: dev@dpdk.org > > Cc: Xia, Chenbo ; Xu, Rosen > > ; Huang, Wei ; Cao, Gang > > ; maxime.coquelin@redhat.com > > Subject: [PATCH v4 8/8] vhost: improve vDPA blk device configure > > condition > > > > To support multi-queue, configure device after call fd of all queues > > are set. > > > > Signed-off-by: Andy Pei > > Signed-off-by: Huang Wei > > --- > > lib/vhost/vhost_user.c | 13 ++++++++++--- > > 1 file changed, 10 insertions(+), 3 deletions(-) > > > > diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c index > > 0509025..3ede83f 100644 > > --- a/lib/vhost/vhost_user.c > > +++ b/lib/vhost/vhost_user.c > > @@ -2965,6 +2965,7 @@ static int is_vring_iotlb(struct virtio_net *dev, > > uint32_t vdpa_type =3D -1; > > uint32_t request; > > uint32_t i; > > + uint16_t blk_call_fd; > > > > dev =3D get_device(vid); > > if (dev =3D=3D NULL) > > @@ -3191,9 +3192,15 @@ static int is_vring_iotlb(struct virtio_net *dev= , > > if (!vdpa_dev) > > goto out; > > > > - if (vdpa_type =3D=3D RTE_VHOST_VDPA_DEVICE_TYPE_BLK > > - && request !=3D VHOST_USER_SET_VRING_CALL) > > - goto out; > > + if (vdpa_type =3D=3D RTE_VHOST_VDPA_DEVICE_TYPE_BLK) { > > + if (request =3D=3D VHOST_USER_SET_VRING_CALL) { > > + blk_call_fd =3D ctx.msg.payload.u64 & > > VHOST_USER_VRING_IDX_MASK; > > + if (blk_call_fd !=3D dev->nr_vring - 1) > > + goto out; > > + } else { > > + goto out; > > + } > > + } > > > > if (!(dev->flags & VIRTIO_DEV_VDPA_CONFIGURED)) { > > if (vdpa_dev->ops->dev_conf(dev->vid)) > > -- > > 1.8.3.1 >=20 > Reviewed-by: Chenbo Xia