From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ACD21A0548; Tue, 27 Apr 2021 03:51:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3536540143; Tue, 27 Apr 2021 03:51:10 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 38F8E4003E for ; Tue, 27 Apr 2021 03:51:08 +0200 (CEST) IronPort-SDR: Rv32LkAIoXFDimtnfhm0d77L03is4p9lPBu94LCp8eS5FGZG7Uf+H2DnSpolbfOSakJb9D6P8G fWLyYVouyg1g== X-IronPort-AV: E=McAfee;i="6200,9189,9966"; a="183569408" X-IronPort-AV: E=Sophos;i="5.82,252,1613462400"; d="scan'208";a="183569408" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2021 18:51:07 -0700 IronPort-SDR: 3WLU73QeMVih5A3KjUn6oHv3Wi0/k8V9+qv9odFq736gqrYwgWps/lnV7KkLPDUcuQLVccDS/L w8u0e+D8uc/g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,252,1613462400"; d="scan'208";a="429614780" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga008.jf.intel.com with ESMTP; 26 Apr 2021 18:51:06 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 26 Apr 2021 18:51:05 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 26 Apr 2021 18:51:05 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Mon, 26 Apr 2021 18:51:04 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.172) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Mon, 26 Apr 2021 18:51:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ydvae6ytoKoPFxO/a1/rF4CHmPMAnJ1e9J2QVGsc+8uWTy0re2bTa2t5lrga/BnismocTurNaBAo7yAC/PlG5yIRWycuLg355PwdZ0wm/buyWk5ejNEgYfgVtywkT+bwnYNWFIw4eOH6W+AsTqw97NLqrZBLkmNVSIPyqxSTmbGPR1rThEjvPod4QpC0bFAYWGjCW2fTKe/IsvcTeJ6g4JRkTaVETjTcv2S0UBH3nFLHHnwhFw0SuunNozxRO/zTIgzzwjJIKcV0TNq4K+7mopylIsW5N+0MyU2l/4/gX3XhgpAN2ISlO4vnknEItASxlEJ1QZ1u6Lfdq+CcQk6QPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ziyybh6IekI7XUhMmYgyUv/AjaSv25VQ20KKgbVaEU4=; b=AqR6k0hJlRBwQXbG79+0FZTxqvutJhk+MWxWr6W9X0w66hGKpCmU21uV8m15PRoMXODTqYx7wYHZTvksD+q1R8Aflru3dzEHkQIAdlZkqDrPA+Ju2Dmtvg8i/vldWWjKwOGXtuoZVQC/kHbXm4ssfDs8/WmWj0tZO8ZpalpeiC1BIVKggxK5zj8geUcYVJw2mgPbmcujejNveyeWn0MKThCpsp1FSfcBO1WVjPC+Y+P/XyxHEA79k9Bqrk5mV2hbRtApykj7eHsfKWMazYUQ97qQcg0fRmq25RdvEtTA2m1Xe1DGngzj2Xtb5fnSl8vffwT04eabgJMtwpqABJLjmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ziyybh6IekI7XUhMmYgyUv/AjaSv25VQ20KKgbVaEU4=; b=pVEh4k4t4hDSy7art0i/gK8fzsKvhbPiRS74EFMK024sajlsSRJj/RbCYLqlJMGXDUmsRE0S5uc0ZSYzJz/nWW8MJ/S/j8eUF96y4zS26EbHW7sQ7fyg7M+ZCmSD9GLPK+7OvgEpOi81l/n0h6s2aIaUr/O3RhCUB6Ot8Eq2CuI= Received: from DM5PR11MB1787.namprd11.prod.outlook.com (2603:10b6:3:112::18) by DM6PR11MB4580.namprd11.prod.outlook.com (2603:10b6:5:2af::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.21; Tue, 27 Apr 2021 01:51:00 +0000 Received: from DM5PR11MB1787.namprd11.prod.outlook.com ([fe80::ac6b:3e4b:65d9:8e21]) by DM5PR11MB1787.namprd11.prod.outlook.com ([fe80::ac6b:3e4b:65d9:8e21%8]) with mapi id 15.20.4065.027; Tue, 27 Apr 2021 01:51:00 +0000 From: "Lu, Wenzhuo" To: "Zhang, Qi Z" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/iavf: fix performance drop Thread-Index: AQHXOl0y16WtgptnFkKmXPBcK+wMqarGgaCAgAEYPuA= Date: Tue, 27 Apr 2021 01:51:00 +0000 Message-ID: References: <1619414983-131070-1-git-send-email-wenzhuo.lu@intel.com> <0e87d690425949c3839a1ac48dc0406b@intel.com> In-Reply-To: <0e87d690425949c3839a1ac48dc0406b@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.206] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f0685d42-185e-49a8-fbb5-08d9091ee8bc x-ms-traffictypediagnostic: DM6PR11MB4580: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2043; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mlRnlI6CltkCZZrP4Io5wXnrmZKQ1jKW4AYhmrzgh5sZsgHMhJpLAvYUS9zp1Sa/nCzF2V1EAoHNb0XSmiNWBH4GuPgNi/4buo4ovXNi8jZpV8T+TOmPx6CsoblfqOEsJoQF3tXpjZ0+Ox5bLvz9TDxsd5UhVFbACidEFjOAUuK4RNNx4smq9oB6Q/kPHLa6zdTlKxm2g0OV7JKuD4/xJ8+A8ncM2mrOwpdDqf/j3SGcgorn1P5p0rS+o2y05N7uCUNI1Krul0rBOmNZiVP62p/n6IpP28+gtff18ME2W5XOEZSnr+6+F0LA3SeOnbd4MrX6fEpXyPCDrs2HnNA2GhmsoLu9C1uk0bPR9PORyAAGIUMR35OtGp86IHP20criD0vKgbFZAL+T0Q3X+tOOeHt1WXNl5XpEwE0R1U9i8zpu3tDvWVXUbuYJXLxeYKqLQ8QmTvqfZG+HQfmO/E+hI/fkgItEXhA1cecWx6nB/ZM0uyShUqjDiLF5lyFFBAY/dI0yWWLtO2RiqV6aa+r4mEkTB3MHfbPOp2HR6Bhwrfx+5DAIyCyz1f2iBMjrdroxwESjPBoBzdD/BaoxI0B4gWTY9bUN7l0+jFrg3IXh924= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR11MB1787.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(396003)(376002)(136003)(366004)(39860400002)(66446008)(66476007)(66556008)(33656002)(186003)(76116006)(64756008)(478600001)(2906002)(66946007)(26005)(8676002)(8936002)(4744005)(86362001)(38100700002)(7696005)(122000001)(6506007)(110136005)(52536014)(55016002)(71200400001)(5660300002)(9686003)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?Q02i9sHLVZe1dhTqKJo27SQiPqsYKZ8hzyyCnNVcV+hwTo2uc9tTCX+XqkoF?= =?us-ascii?Q?JwkN83pnOKTaTQ/rGKO9h4f0QhBNRuKpQzvPT8NVJiFVS8L3im+EjjizAbmk?= =?us-ascii?Q?+8kKYvXQQ3c4ikTdAsYm79eUDoM+iRVqQvxlgrrEKJH1hnQ/Q2JfaFntO+ij?= =?us-ascii?Q?41lX3SUwlawnlLeG3fsJZP2MXAt8BqROUmZ8ALPwb8/IR3jE2DDQbiO+VORQ?= =?us-ascii?Q?DlsccIwH5RHk5RCva2nkpDQSbvZ85pHbEGbbiIFEKnPbw45mVd0GdvrI0fyF?= =?us-ascii?Q?qEQj17VmwutjQ2Zy9VZ5lnD+lKPI1FlBNyRcMQt6eNiQgamL2RkD9wae+9UQ?= =?us-ascii?Q?eYRL8K25egMXfhgR3jC3fyjV9El24aSgm8H+MNYzZbQ/kuj5nlV0xZGRFiqj?= =?us-ascii?Q?DglXzGreZ4n+GjYigBJ4ennWJR2k0GjKmxcMRH05uZrOEIJgga5JxvVQ1beN?= =?us-ascii?Q?8XukjWsknJmHhEapS4uMeKSSLFGfuonwYFA1xLXMBnzlIwtfWf9+IR1dV4FA?= =?us-ascii?Q?gt7bBUvmbOunE02/z8AooJJxoDLrt7Mra8ydUxfeiKV+8PKlYnLjWlOS0Szb?= =?us-ascii?Q?ARiFv2FUbP4XZIKvtwSNT3+VtsM0ZvBc2uGs64fUO5UvH8r1KX/y+BttFuq7?= =?us-ascii?Q?BJ3RH5jj68d4QrYh8LTxgEASANGCl/hqDqOnTCE3Uz3AuEoFXbeLD/fqUb3+?= =?us-ascii?Q?tAI/LYhAuH6twHOCxuaSFWFBnTfnymB0O8bCFuJwDOlLTTEvhUsJRFMC0ojc?= =?us-ascii?Q?ClOI6hO09xMRMk08WbDZ417v2A7+OK8dQqk+s5jW9HIV65hZs/jheCzuhgKB?= =?us-ascii?Q?vSxmTKThyFnaEtR8gLT9D/T/ygL1SeH2TmlW59Q+kOOmKFQ5kwz2+7Rr4Sfn?= =?us-ascii?Q?3IZ/B1a7MJFWVM1Nkn+m0+Ry5FAoeEhJ+tkpJ5Za+HdKkF5NAdYqO04X03KZ?= =?us-ascii?Q?gGdsRKnSWJ5SR99D2z/AWjK8aYXgmSdb64O0FM4vR4xWv+f1Kyr6mOLV0bZR?= =?us-ascii?Q?XTDGQsoSuTj1WDCWost75qsjqu/MzLgGz/5w8WDsFN3vLHMjfVoVBfbU5549?= =?us-ascii?Q?dOGdKYFPsZcIcM6fFYB3Q8CnH9MOYJuS8a4ComuEuOUkXyiLIKK3hIJj2X04?= =?us-ascii?Q?7XQ06K/LiWIz+3bfsbbsZAyaeHD9SWce5sd9HETBGJk5ZjHhchG1zJT+cfu0?= =?us-ascii?Q?6bTvwwoRWtJw/zxe8oemObjZdoe1YQkGibmSv1qTDroj+84jDRNjJy3Ww7P7?= =?us-ascii?Q?gNFn7DAKuX9AGLaI8Osdh2usW31bMpmJsIuc3MLOs4nfNF2OJC7V/BhlOtGV?= =?us-ascii?Q?p72B3iJgkR3lDeByc0s/iVI1?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1787.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f0685d42-185e-49a8-fbb5-08d9091ee8bc X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2021 01:51:00.6584 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Ts1ajKpxYEfHhYPmy4QQxIPcsPYAMNABxZBk0KgHc429lEGedKe4XmTCkXpKT+2+78XKldi9Z1Q0bVFCGInqpA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4580 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/iavf: fix performance drop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > +use_sse =3D true; > > +if ((rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2) =3D=3D 1 || > > + rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) =3D=3D 1) && > > + rte_vect_get_max_simd_bitwidth() >=3D RTE_VECT_SIMD_256) > > +use_avx2 =3D true; >=20 >=20 > Not sure if the right path will be selected when avx512 is not true, > (CC_AVX512_SUPPORT is disable) while check_ret is > IAVF_VECTOR_OFFLOAD_PATH? >=20 > Currently we have >=20 > if (!use_sse && !use_avx2 && !use_avx512) goto normal; >=20 > Should we also add below check? >=20 > if (!use_avx512 && check_ret =3D=3D IAVF_VECTOR_OFFLOAD_PATH) > goto normal; Not necessary. As explained in the commit log, AVX2 and SSE support the off= load features. The purpose of this patch is to let AVX2 be chosen when offl= oad needed and AVX512 disable.