From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 310F6A0548; Tue, 27 Apr 2021 07:09:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0009B40143; Tue, 27 Apr 2021 07:09:48 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 4DBE74003E for ; Tue, 27 Apr 2021 07:09:46 +0200 (CEST) IronPort-SDR: eITR2cdHw2A0Z9B5gic3+LyLrZNh0VGC7pz6Dtsb2zPwv0KyH1qyQz24q0zWmNoGnHob2jEaDj vXngb6rCQIkw== X-IronPort-AV: E=McAfee;i="6200,9189,9966"; a="260404271" X-IronPort-AV: E=Sophos;i="5.82,254,1613462400"; d="scan'208";a="260404271" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2021 22:09:29 -0700 IronPort-SDR: m3HOJz8qBuF4ebWwyM2XXaD3/zbxC5Qb8U0yUDX5v+BAuDDWcwnTHcRUN8vMjYvrdWbR9/HO1M oAS72Gci928w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,254,1613462400"; d="scan'208";a="447484968" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga004.fm.intel.com with ESMTP; 26 Apr 2021 22:09:29 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 26 Apr 2021 22:09:29 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 26 Apr 2021 22:09:28 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Mon, 26 Apr 2021 22:09:28 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.106) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Mon, 26 Apr 2021 22:09:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MYNQaCvCb+LldlL2AbsTCYcy360MMStqtiibZUk3Z2uwIzbdRtXT1CMN1cVaCzY3Bxs2erZR6LUpE5WY2thYbKeuy2wX4Kka9mP1um1qIuV/1wLftTCHNVv8uRLMhUnoeSSIUSNTHJD+McNDnjz96O4948C+E3lJysn52rl41nRPxafPSZU3yiTyEpboAN9FLV4kh4uunUB4FrSkZ816lA+gGPrR/gWXVRdrVaTcbqajmavf+Wj2PBPE2gYmMhfh2JnzFakk0BOq65Spu7ApA2dCID94w7YsUggRjC8J++x9RMqG4oLneyZ6Cn1V880kMPz3LNGz4C/SgH7LaZxpCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yo9vgTbozSocoxetg1N5IcuTaNlWStPDnjwJYtxp6Uw=; b=MGT4oLkzM3UivYJhC7eUugQ/EJRUmgzb0TtCEzTj5lC+1bCLRb2SGaDOS1Rv0yjEa0CGhEhIVeeb3QamLTUPh1rRTWzKZfIkBcRzqNDHIvBMLCzYc70x4AycAGXvgIZdLRNpRaHMvenKC6v+bgstbEZSAYaXvX+Pk9vAIHdNQs9jZREZHroe2Yyu4M2p5AhzVFt49jv7lz21SkCsUrrSerJ9hG4NYSuBL/vnYpBA/HlA9z2gwEMXHBFbEa2mah3OUTeuf9Yiao4OWiHzw7GOzRkdBTmYA2eUA4LTpeMNBi4uPFnc/mXn4arX+Wp0mbONIWaVYoD0XwOiH8kQmXtoFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yo9vgTbozSocoxetg1N5IcuTaNlWStPDnjwJYtxp6Uw=; b=hayojfmT0iBSiuuCHe6Bxe82/zWZw1SC6gjIoTDXkPP5x2PmberTNl2pShhv8INb3WKxpEQ3pwFZs5Bmf52wZq/UcYtE5gFu1OGQrTF0Lk5LsZzYmURNi/m3mA7eHkgQwqWPQXpx84isBSLZRGQzYscrr9q0vHR0UPvlIbraCeM= Received: from DM5PR11MB1787.namprd11.prod.outlook.com (2603:10b6:3:112::18) by DM6PR11MB4473.namprd11.prod.outlook.com (2603:10b6:5:1de::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.21; Tue, 27 Apr 2021 05:09:25 +0000 Received: from DM5PR11MB1787.namprd11.prod.outlook.com ([fe80::ac6b:3e4b:65d9:8e21]) by DM5PR11MB1787.namprd11.prod.outlook.com ([fe80::ac6b:3e4b:65d9:8e21%8]) with mapi id 15.20.4065.027; Tue, 27 Apr 2021 05:09:24 +0000 From: "Lu, Wenzhuo" To: "Zhang, Qi Z" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/iavf: fix performance drop Thread-Index: AQHXOl0y16WtgptnFkKmXPBcK+wMqarGgaCAgAEYPuCAABN7AIAAJMAA Date: Tue, 27 Apr 2021 05:09:24 +0000 Message-ID: References: <1619414983-131070-1-git-send-email-wenzhuo.lu@intel.com> <0e87d690425949c3839a1ac48dc0406b@intel.com> <0cff5b06a6294e5e9cad58e71553d11d@intel.com> In-Reply-To: <0cff5b06a6294e5e9cad58e71553d11d@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.206] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fc458819-c8d0-4b69-7f7e-08d9093aa018 x-ms-traffictypediagnostic: DM6PR11MB4473: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3276; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vTLjMNGlZ2DV6kJxJKgFkaZSfpXNFRDRP1kMH+/N6R4RbJDmRwQoF6NrTK1Jbt/jFWDXwQj93n9PBoiUH5tIWZGKcLp5uxR0i+VGFy4BYhD3acnUxdrOuD1z8aThP5l7dQc+MSqNurkqSNiqXJlBVlcO7tOH7/gIRgbSVDSDoWhknGWDfZwTSrp9z9/YVt8MVf4BapBHLW/zXfqazM6PbULwSltQ/EKPLwJwQM9SYW9U+FX7Iyi8M3uAaPrBGYOji2+3a3yo7SQyqDOn5DY1Kzb30YOAGDgUXZFsPiAH/fGqbgnz9dYpsak7f2/XhhNcjnFr185piCHNCcXnb306qXJWffZy3c02Hi7zrCqiN6k3I96H7hp2DfDaugXk9FpiDKJzGyxgo6QjJ3YPStFjb5PDqp6yJ6ubErulIRHm7Byb1KcmTSastFwN44h8HsV+OKDRKQzUb3gbhPn80Enkk9tKmgvrV/YqKFGASvrADlVhr6GoE/I0eRmaXmlf3xC2avQs9Z0Ye8ne9medEy85CaxVoaDm0b4WniYDM02EVZcNpsOV6MgeoJo2XtdDu4HLDyLeDkK7o2NCH2/rAJnHB9/uuRwkH78Tcg4ghTTznlU= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR11MB1787.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(376002)(396003)(346002)(39860400002)(136003)(66446008)(66476007)(64756008)(38100700002)(76116006)(66556008)(9686003)(55016002)(66946007)(26005)(316002)(122000001)(86362001)(5660300002)(52536014)(478600001)(8676002)(2906002)(8936002)(33656002)(7696005)(71200400001)(110136005)(6506007)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?39ea/j1bTm/nS1GGKZejpz9vyVFq0ysw1VnI+mXTWMnUjYoBGKfs7VYdI3PT?= =?us-ascii?Q?9H8wKpKHKaV7TFdtdKoIdBjYDf3u1ZxkB+BbYs4M122UPkJuKnGREJg++TAz?= =?us-ascii?Q?PIIBvUTuFgoCxhTjfnl2OBJ+nCtrnDP8noqg90+hXnwtWY3EcK0uIUko4CRw?= =?us-ascii?Q?KPgCEQYMfClLmAUTbwJD8SBxSYo6BTInCLcdTc2qK5liW+2QybdpUB1uaqk/?= =?us-ascii?Q?Kkc7Y7XZ5+jEIFXRkiew3HBrN+sqt+qRDlEWavimY7QKJDDPwKAW0rjmrE+8?= =?us-ascii?Q?BK9o0wbQNCnu/1ek+Y8rQ5OUC3X11TMUwd4GEM73Mp3fdHUDQqaWvj1duepD?= =?us-ascii?Q?9TcPuc8FqQUXccC+FKBoM/JTBwase37pc1+iXEXGaRl9VwQrclSOwor21foD?= =?us-ascii?Q?CRJ8XU7xcP0/pqxDop/cpzMvVYN+XEuVFG/euJpLO1WRQl06yeqt69ZvxRSo?= =?us-ascii?Q?pyF9RdG2Zdgy+pL9eUDQuKsa1ONJxpcB+siduXJDxsemavFCSIwpm4DjEGeC?= =?us-ascii?Q?87B6+Tv3+AR39Pdt0aoyjr58DznA5ploIdC5E3nzL2zsjTL0GVboNp4yJApG?= =?us-ascii?Q?aMENOawd5J1cRrkDZu2wTJKMKhKEmA2BgkaX5sQq6mmYalkJ75vil9vp67H/?= =?us-ascii?Q?hdcjSOFW8kaEYUP7jF+f7pb4MWnOcg917mpTQYB/d1EThXRqdi/m231eLDWy?= =?us-ascii?Q?fROVhuoHJwOX9CLOX0d5EZXbQUBg0abPHhW+mQTMXoXc1lm9HseurWtRtoiu?= =?us-ascii?Q?bEOlen5Rp7KcHRyyRu5/1RLunsnTFmQlRQdHizV4nfgY2yauX9dCsfvRr5Pq?= =?us-ascii?Q?2cuPQEpdoKN+1+ywnaTa0QEUzNTt73J7cZY49qG+jNVcWcoHGoiRpc8nuBKs?= =?us-ascii?Q?RHEK4DsU4dffd60UTC3ICy9VfCOYCKz9IE9zfp2p1gGSv+pFLqYYgN+HbVRe?= =?us-ascii?Q?7qEEQcr7Xoxm9j6LMenp/V0gMO/J1UEwMwQteG5B7oYRIqnDRE5+SjDAg7IU?= =?us-ascii?Q?lg3AyWXjt3ucvITYzED+hg/NuxPfhb0JXk20JqEIDVdtW3yLYqfQ5877xwOg?= =?us-ascii?Q?dOUYpKIB42x/xZg7ttxyJpGje7uCJi0+WxSJMz1QUBB/JXiEOvJPXgc2CHE1?= =?us-ascii?Q?bzP67iew4EVv9lEyrlcix5W+xhyqaTxOyT7UWj7nA/K2QgLDoSXdo8AgFO/R?= =?us-ascii?Q?fK9MxKjvsY83/eYDvMsCxijw7k08bY9hyrj35z/ZOeX7L64UXE29DjzAwRis?= =?us-ascii?Q?AvaNMy9Nw55YndWlmPuWAeFGMI6ntdM3PPhc4R6H/P3WixEMiEVYF87Do4dG?= =?us-ascii?Q?stCnwm5nS2ccDXYIVt7mbEUT?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1787.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc458819-c8d0-4b69-7f7e-08d9093aa018 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2021 05:09:24.7629 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cIVE2iMY/mQu7TA0obTW4t4pCS4GMHrFRlztFdYtS3/sKGQCuTwvI8J2Rynqci08dLGF6EJqL5DEebN0udmkzA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4473 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/iavf: fix performance drop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > > +use_sse =3D true; > > > > +if ((rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2) =3D=3D 1 || > > > > + rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) =3D=3D 1) && > > > > + rte_vect_get_max_simd_bitwidth() >=3D RTE_VECT_SIMD_256) > > > > +use_avx2 =3D true; > > > > > > > > > Not sure if the right path will be selected when avx512 is not true, > > > (CC_AVX512_SUPPORT is disable) while check_ret is > > > IAVF_VECTOR_OFFLOAD_PATH? > > > > > > Currently we have > > > > > > if (!use_sse && !use_avx2 && !use_avx512) goto normal; > > > > > > Should we also add below check? > > > > > > if (!use_avx512 && check_ret =3D=3D IAVF_VECTOR_OFFLOAD_PATH) > > > goto normal; > > Not necessary. As explained in the commit log, AVX2 and SSE support > > the offload features. The purpose of this patch is to let AVX2 be > > chosen when offload needed and AVX512 disable. >=20 > OK, now I understand it, I will suggest to change the commit log. >=20 > From > AVX2 and SSE don't have the offload path. >=20 > To > AVX2 and SSE Tx path already support offloads but can't selected. >=20 > If you agree, will apply above during change during patch merge. Sure. Thanks for that.