From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 62791A04B1; Wed, 23 Sep 2020 09:17:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 33C771DBA8; Wed, 23 Sep 2020 09:17:08 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id EEE0A1DB68 for ; Wed, 23 Sep 2020 09:17:05 +0200 (CEST) IronPort-SDR: 9Mt21iAJgAS+fP8q49Au7G2IqcZ05oq6jXgRPiwpbFLYYnctV22DQW0JeSaHyFihFcpNJCkgbD d81jN/p03pvw== X-IronPort-AV: E=McAfee;i="6000,8403,9752"; a="178887666" X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="178887666" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2020 00:17:05 -0700 IronPort-SDR: xNjbVxp8LKSQKgUndHoq5GoW19VuzNsR3qYeHUhhzYa+kPHk0tzeQvGcSVPd9FKFlb2cDUsUMx u3rvTlQuNPKw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="290696319" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga007.fm.intel.com with ESMTP; 23 Sep 2020 00:17:05 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 23 Sep 2020 00:17:04 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 23 Sep 2020 00:17:04 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 23 Sep 2020 00:17:04 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.174) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 23 Sep 2020 00:17:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IsHB0cDLJiS47rntNHaQXIwn6HWIKJXNnSeUaUSH+HLiDuLt5BGE/aeEFPz/IfTtpZo78AF+Zp4b5+xWKnHf7zI4MIRvQO00F6K8dMOuvr8oNVHH4hGwoD3DJmXN92tO7B5qxpFT7oQgTJcU/Bf+Qer32EZiV9qU2yD6rlg2J1QvJntLQg5BUiYbZECxwIBywD5lMv7y/LXbb2CWaL+asb/KCfyYBHMnZ4oxRc3sFkrvmYTjkErxW0imfez9Sj1ZbfsSIOom4prVfbE8TrPOAf9uTj3V5hi7QEmmloljDTqWWLACeXoiQrbpox/yM8iqfTxy7HbqgX5Q5e/g6EiNdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3HapELkb1gpIRCLur3lW7BDgky3xxHVzogcComjbvBM=; b=IJCfSwTWQ2bTGkNuiE4cBvdaQb7lPyNAHbquMzjZOdUHX3y236ohfm/i0w1bJj77eBrQY0Xtxd2xiskPsOp4wmFzM5E+KmXTogrWHBPByuWpthmVnmsLV5pF2083seCkVdauKdIafcBdYVj4bL6FgmqBG8cDE5JiMHeZgAjryZjdoP/un8lvKnCPIP65WpHdD1XWQRBUrcsNlsVJiU/0F2Kes8dTS0FekzoO0ZJk+JXH35M1013lrsGsdgPC9+XJ5Xr+MXhzOzkyd2p6jfmuoNB8zRf7wrBc5cfWZM4EJdmKCA/QtZEM0dvAFJSFklN+uH1w9iyzIy+k+23ADMdGyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3HapELkb1gpIRCLur3lW7BDgky3xxHVzogcComjbvBM=; b=o1eXVqSgb37IpVAIs0J3d0YxWkkmLrXq/MKJpBM2aSdODL2+k20R5fRjhhK/Jzbf7coF6XjGq7a2ILQnVB13e9ZUrXPYi9nDFDNRhZuRhXaSXrOvWw8ljIzKme7O2noI4KNAS8g8wcTfJ0X919uiun7VFt7XErhvRly6EMwAIiU= Received: from DM5PR11MB1834.namprd11.prod.outlook.com (2603:10b6:3:113::19) by DM6PR11MB3115.namprd11.prod.outlook.com (2603:10b6:5:66::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.20; Wed, 23 Sep 2020 07:17:03 +0000 Received: from DM5PR11MB1834.namprd11.prod.outlook.com ([fe80::4056:b6c1:1923:f1a6]) by DM5PR11MB1834.namprd11.prod.outlook.com ([fe80::4056:b6c1:1923:f1a6%9]) with mapi id 15.20.3391.026; Wed, 23 Sep 2020 07:17:03 +0000 From: "Gujjar, Abhinandan S" To: Ankur Dwivedi , "dev@dpdk.org" CC: Jerin Jacob Kollanukkaran , Anoob Joseph Thread-Topic: [PATCH 1/3] test/event_crypto_adapter: return error with unsupported mode Thread-Index: AQHWhcC1yYDJ1So6OUGIgVlNZgXtbKljELJwgAr4YMCAAH0iAIAAAK4ggAAHZQCABzvSgIAAHKyQ Date: Wed, 23 Sep 2020 07:17:02 +0000 Message-ID: References: <20200908091534.24305-1-adwivedi@marvell.com> <20200908091534.24305-2-adwivedi@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [103.5.135.70] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0974cd29-13da-470d-ec92-08d85f90aba5 x-ms-traffictypediagnostic: DM6PR11MB3115: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZFh2Rt0jHmlSALWmu9miBZOyBjomDOD7sOdZa6bceQ61wT22pNXuSxXDGKV0NYCjyOpFgzgDrAriL7nwTEnoDtMFITE27qcGgWKmrdxtqCXVGuQ/5quIYMyDfpQILFYhXtvqccBorqCp6BaBdh/52Yn8IRD2qcgku24t/MITg0/WDavvHe9uynwYzSKL5v7Dft1kUHqp/S8pzlzPiYx6fbiyiHCsFGWDnXDO6yKvOIJbxt/5YsdkYIWXHvhWjwJi5WMmrEOcWF/Gk9zHjYVDo0aLyQ/OFNa2NQCbuZj7JfVqce2zUkVvqC29GkJ7SYZmqvEkGBflvo6Oq10buJVO0TwAIudqn9TsWc6HJp5AdJPw/hQN8BgWVIqORRgYD8wg x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR11MB1834.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(396003)(39860400002)(136003)(376002)(366004)(9686003)(66556008)(66476007)(66946007)(64756008)(66446008)(186003)(53546011)(83380400001)(2906002)(76116006)(6506007)(54906003)(55016002)(86362001)(52536014)(33656002)(5660300002)(316002)(71200400001)(4326008)(55236004)(8936002)(110136005)(7696005)(8676002)(478600001)(26005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: uz0s3U9f8bEbcIQsTmmu5D+YsJoIBVg9gHEujQfhoOMZg3vD+SaHdR1cf37PsM/yl8vFZUDX4jQjivNuao1UwQnJLpZDfoVqWqaHNJIX9KePRcJttg9xJD7MwbKBATrqD6mFsaGotrR2asHfsGZwvbTyjyOFf/0rpMNS5nvkw5rJ1wEDstkLqqHkzo29p46E0W2dipsd9YD7I+XK5Fz/0mBGLBH3KfmvHHb6X1ujDMJtrrgdxKi0Xe2W3q8kMlzKUctO0eDEnpwcLZVJQkYSqXPbK/Iqz06oAu86WIWMbR/Afpj+Gi1amSH9XtC2LEQNq+Epjwem4zZCuPdl/BSEUuET5P+a+jFoSPFF1+5KhBqqEYmamNwS01qnLbPDSmn39H+yRFGT3tp7jVeDRamvNzaDmhBHrlUUf9bY0XU/hhkaXYMEAl0+nX0X93DpQlYTvfC65f5SGhrfdYQM+kRfNEApqyNy4KWrpGx8qVSuTrQIh9X6XA7Qp7/GsUUv4qq7AsiueWwESRG7E9Cfforyk0sMFpypUkiNtXsjvlepiBRoWsIuez4tlbUh1U3UWX8nIf5Nw3ekBV5BV1y5K4MExXC6dcCErMlx7K2zYkOSrcrE01otFPH7cNdrOLHo+4aw5MBZetzhMk+0gFaAqZbWsQ== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1834.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0974cd29-13da-470d-ec92-08d85f90aba5 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Sep 2020 07:17:03.0763 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Sv70gthPoc+SB+zRsvqCxnzBZkTJpINedTNjfY0M2hWkWlGhH6aMKJ/ELhz2aQ3qR1Be6sO4rlLuaBtH1FszhjTseiLzMuUbcc+6uEAiLYo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3115 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 1/3] test/event_crypto_adapter: return error with unsupported mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ankur, > -----Original Message----- > From: Ankur Dwivedi > Sent: Wednesday, September 23, 2020 11:02 AM > To: Gujjar, Abhinandan S ; dev@dpdk.org > Cc: Jerin Jacob Kollanukkaran ; Anoob Joseph > > Subject: RE: [PATCH 1/3] test/event_crypto_adapter: return error with > unsupported mode >=20 > Hi Abhinandan, >=20 > Please see my comments inline. >=20 > Thanks > Ankur >=20 > >-----Original Message----- > >From: Ankur Dwivedi > >Sent: Friday, September 18, 2020 8:34 PM > >To: 'Gujjar, Abhinandan S' ; dev@dpdk.org > >Cc: Jerin Jacob Kollanukkaran ; Anoob Joseph > > > >Subject: RE: [PATCH 1/3] test/event_crypto_adapter: return error with > >unsupported mode > > > >Hi Abhinandan, > > > >Please see my comments inline. > > > >Thanks > >Ankur > > > >>-----Original Message----- > >>From: Gujjar, Abhinandan S > >>Sent: Friday, September 18, 2020 8:13 PM > >>To: Ankur Dwivedi ; dev@dpdk.org > >>Cc: Jerin Jacob Kollanukkaran ; Anoob Joseph > >> > >>Subject: [EXT] RE: [PATCH 1/3] test/event_crypto_adapter: return error > >>with unsupported mode > >> > >>External Email > >> > >>---------------------------------------------------------------------- > >>Hi Ankur, > >> > >>Please see comments inline. > >> > >>Regards > >>Abhinandan > >> > >>> -----Original Message----- > >>> From: Ankur Dwivedi > >>> Sent: Friday, September 18, 2020 8:05 PM > >>> To: Gujjar, Abhinandan S ; > dev@dpdk.org > >>> Cc: Jerin Jacob Kollanukkaran ; Anoob Joseph > >>> > >>> Subject: RE: [PATCH 1/3] test/event_crypto_adapter: return error > >>> with unsupported mode > >>> > >>> Hi Abhinandan, > >>> > >>> Please see my comments inline. > >>> > >>> Thanks > >>> Ankur > >>> > >>> >-----Original Message----- > >>> >From: Gujjar, Abhinandan S > >>> >Sent: Friday, September 18, 2020 12:41 PM > >>> >To: Ankur Dwivedi ; dev@dpdk.org > >>> >Cc: Jerin Jacob Kollanukkaran ; Anoob Joseph > >>> > > >>> >Subject: [EXT] RE: [PATCH 1/3] test/event_crypto_adapter: return > >>> >error with unsupported mode > >>> > > >>> >External Email > >>> > > >>> >------------------------------------------------------------------- > >>> >- > >>> >- > >>> >- > >>> >Hi Ankur, > >>> > > >>> >This patch requires minor change. Please find the comment inline. > >>> > > >>> >> -----Original Message----- > >>> >> From: Gujjar, Abhinandan S > >>> >> Sent: Friday, September 11, 2020 1:07 PM > >>> >> To: Ankur Dwivedi ; dev@dpdk.org > >>> >> Cc: jerinj@marvell.com; anoobj@marvell.com > >>> >> Subject: RE: [PATCH 1/3] test/event_crypto_adapter: return error > >>> >> with unsupported mode > >>> >> > >>> >> Acked-by: abhinandan.gujjar@intel.com (For series) > >>> >> > >>> >> > -----Original Message----- > >>> >> > From: Ankur Dwivedi > >>> >> > Sent: Tuesday, September 8, 2020 2:46 PM > >>> >> > To: dev@dpdk.org > >>> >> > Cc: Gujjar, Abhinandan S ; > >>> >> > jerinj@marvell.com; anoobj@marvell.com; Ankur Dwivedi > >>> >> > > >>> >> > Subject: [PATCH 1/3] test/event_crypto_adapter: return error > >>> >> > with unsupported mode > >>> >> > > >>> >> > The capability of a event device should be checked before > >>> >> > creating a event crypto adapter in a particular mode. The test > >>> >> > case returns error if the mode is not supported. > >>> >> > > >>> >> > Signed-off-by: Ankur Dwivedi > >>> >> > --- > >>> >> > app/test/test_event_crypto_adapter.c | 30 > >>> >> > ++++++++++++++++++---------- > >>> >> > 1 file changed, 20 insertions(+), 10 deletions(-) > >>> >> > > >>> >> > diff --git a/app/test/test_event_crypto_adapter.c > >>> >> > b/app/test/test_event_crypto_adapter.c > >>> >> > index 8d42462d8..930c2a9bc 100644 > >>> >> > --- a/app/test/test_event_crypto_adapter.c > >>> >> > +++ b/app/test/test_event_crypto_adapter.c > >>> >> > @@ -750,15 +750,23 @@ configure_event_crypto_adapter(enum > >>> >> > rte_event_crypto_adapter_mode mode) > >>> >> > uint32_t cap; > >>> >> > int ret; > >>> >> > > >>> >> > + ret =3D rte_event_crypto_adapter_caps_get(evdev, > >TEST_CDEV_ID, > >>> >> > &cap); > >>> >> > + TEST_ASSERT_SUCCESS(ret, "Failed to get adapter > >>> >> > +capabilities\n"); > >>> >> > + > >>> >> > + if ((mode =3D=3D RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD) > >&& > >>> >> > + !(cap & > >>> >> > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD)) > >>> >> > + return -ENOTSUP; > >>> >> > + > >>> >> > + if ((mode =3D=3D RTE_EVENT_CRYPTO_ADAPTER_OP_NEW) && > >>> >> > + !(cap & > >>> >> > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW)) > >>> >> > + return -ENOTSUP; > >>> >> > + > >>> >SW adapter does not have *_INTERNAL_PORT_* caps. Just noticed test > >>> >was failing here. > >>> >Could you please bypass this check for "event_sw" and repost the > patch? > >>> [Ankur] I was thinking of handling this by reading > >>> rte_eventdevs[evdev].data->name. > >>> If the name matches event_sw0(which is the default device name), I > >>> will bypass if checks. > >>> Can the event_sw device name be anything else? > >>> Or, if there is a better way of handling this please let me know. > >>Yes. You can also use rte_event_dev_info_get(evdev, &info) and check > >>info.driver_name for "event_sw". > >[Ankur] Thanks for the suggestion. I will try this and make the > >required changes in v2. > [Ankur] I thought of an alternative to implement the above. If the capabi= lity > does not have any *_INTERNAL_PORT_* caps, it will be a SW PMD. Is this > correct? > In that case capability will be used to skip the if checks instead of the= pmd > specific name comparison. Please let me know your thoughts on this. Right now, SW has only " RTE_EVENT_CRYPTO_ADAPTER_CAP_SESSION_PRIVATE_DATA = " as caps. See, if you can use this info and continue to execute the test without retu= rning error. > >> > >>> > > >>> >> > /* Create adapter with default port creation callback */ > >>> >> > ret =3D rte_event_crypto_adapter_create(TEST_ADAPTER_ID, > >>> >> > - TEST_CDEV_ID, > >>> >> > + evdev, > >>> >> > &conf, mode); > >>> >> > TEST_ASSERT_SUCCESS(ret, "Failed to create event crypto > >>> >> adapter\n"); > >>> >> > > >>> >> > - ret =3D > rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, > >>> >> > evdev, &cap); > >>> >> > - TEST_ASSERT_SUCCESS(ret, "Failed to get adapter > >capabilities\n"); > >>> >> > - > >>> >> > if (cap & > >>> >> > > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_QP_EV_BIND) { > >>> >> > ret =3D > >>> >> > rte_event_crypto_adapter_queue_pair_add(TEST_ADAPTER_ID, > >>> >> > TEST_CDEV_ID, TEST_CDEV_QP_ID, > >>> &response_info); @@ -813,6 > >>> >> > +821,8 @@ test_crypto_adapter_conf(enum > >>> >> > rte_event_crypto_adapter_mode mode) > >>> >> > TEST_ASSERT(ret >=3D 0, "Failed to link queue > >%d " > >>> >> > "port=3D%u\n", qid, > >>> >> > > > params.crypto_event_port_id); > >>> >> > + } else { > >>> >> > + return ret; > >>> >> > } > >>> >> > crypto_adapter_setup_done =3D 1; > >>> >> > } > >>> >> > @@ -845,24 +855,24 @@ static int > >>> >> > test_crypto_adapter_conf_op_forward_mode(void) > >>> >> > { > >>> >> > enum rte_event_crypto_adapter_mode mode; > >>> >> > + int ret; > >>> >> > > >>> >> > mode =3D RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD; > >>> >> > - TEST_ASSERT_SUCCESS(test_crypto_adapter_conf(mode), > >>> >> > - "Failed to config crypto adapter"); > >>> >> > + ret =3D test_crypto_adapter_conf(mode); > >>> >> > > >>> >> > - return TEST_SUCCESS; > >>> >> > + return ret; > >>> >> > } > >>> >> > > >>> >> > static int > >>> >> > test_crypto_adapter_conf_op_new_mode(void) > >>> >> > { > >>> >> > enum rte_event_crypto_adapter_mode mode; > >>> >> > + int ret; > >>> >> > > >>> >> > mode =3D RTE_EVENT_CRYPTO_ADAPTER_OP_NEW; > >>> >> > - TEST_ASSERT_SUCCESS(test_crypto_adapter_conf(mode), > >>> >> > - "Failed to config crypto adapter"); > >>> >> > + ret =3D test_crypto_adapter_conf(mode); > >>> >> > > >>> >> > - return TEST_SUCCESS; > >>> >> > + return ret; > >>> >> > } > >>> >> > > >>> >> > > >>> >> > -- > >>> >> > 2.28.0