From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C08AA41D8F; Mon, 27 Feb 2023 10:27:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5577B40A7D; Mon, 27 Feb 2023 10:27:56 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 5A8B3400D5 for ; Mon, 27 Feb 2023 10:27:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677490072; x=1709026072; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Jy0yUi6F04FxUoaEMLn86WNzn/BE1V0Gxb29bZKFZTo=; b=k0PtAJNLvDJAMNjEXxLIqJOaISMugHbYdRh2LTVKKps1VxqqmJLOI6jJ VLJvWnaw+bsMoqaOmgH1cmPgyutBJEo7yCIpu9Xsr2g3L+DbLsav2le3R B8E9NszsjaNOin3jqQoECD+oVzzKMs6UP5C7Wp6TMER8OjllnNZMNeACU 3jM1/8ByrlZ8bWczoHqMYCYpbG1HmqdVvZ8ksGxWUZAH2R6G1leoIuEG5 50tmDlU9QQ/fcpvNG8e0Ktaz8u2spps3+ZN/F4u4hCQFI0USS0RPu2A8q t45JSvFzUzRr6Br5+ph1i1wtChCR/D+Zi6IWlEGgfry1KkqIRYF5z+zm6 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10633"; a="336097932" X-IronPort-AV: E=Sophos;i="5.97,331,1669104000"; d="scan'208";a="336097932" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2023 01:27:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10633"; a="847738229" X-IronPort-AV: E=Sophos;i="5.97,331,1669104000"; d="scan'208";a="847738229" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga005.jf.intel.com with ESMTP; 27 Feb 2023 01:27:48 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 27 Feb 2023 01:27:47 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 27 Feb 2023 01:27:47 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.177) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 27 Feb 2023 01:27:46 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SgDE7aFeD0ZAxCDADwDOmtORRTWyuMECONrVRyrfb6UTzNaUP3F6I5RYQpSs5B2ZdSyatRDbXT3nFT1fwHc4lSbEsg3jaNU+vynnQ+ks9Sbksri6hQo1al7OjFtdJroCUO90ROxj9ldsU9CgMOxNPALVUEvjIv/8zpgFFn2uynNjhQTD8Co4QW9Ab/TiIOh58IiGGbw4wpXN7KG+csUw/U9amKU156fz64XHjU5Hjys6Y/vPkoBJ7K2qS5A0JQREyJkyN0nMmccLxIx98w0Nj/LkF/SNsmUxaeMI8e8IJmzmLaqjYtvZEPiMteXaCtlvQRULVA6ge68hEsvKfVNa/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B9K4oUZwRrhbnDCaA8dj0hmKjy4IjuH5G6UbxznDC5k=; b=QUYuvmUqX9OqDeO7dGN/BGrmPzMq3zpoOTcogw0shj1C00lc2saQnYdZNt3Cl/XNou67/M8gBpM7wchB33psyYbSTDM5h/P9KkROUL51fPrdILkuph0hVezJkqNMQJU3gzDy8WkbPvcEFEO6aXngspuh/difhZuQ3L6X6xv6t7S1+4E/W817v47B13WcCVyLKnSr76uwL/ay8f8g7XyaXBnUgHNARdhvVL8XHzEBRWTcwybQ5eD2wbPa6o07I1EOAGAvD7MdQhzWTcGqGOtAarL4/FksQ+6vYwFlYT5ahaNtdu5XFzGuUDbyIYbcWf11woC9DaSBGFrITry4tzDmDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM5PR11MB1851.namprd11.prod.outlook.com (2603:10b6:3:114::18) by CH3PR11MB7273.namprd11.prod.outlook.com (2603:10b6:610:141::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.28; Mon, 27 Feb 2023 09:27:45 +0000 Received: from DM5PR11MB1851.namprd11.prod.outlook.com ([fe80::3c23:7638:8d23:670f]) by DM5PR11MB1851.namprd11.prod.outlook.com ([fe80::3c23:7638:8d23:670f%5]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 09:27:45 +0000 From: "Dooley, Brian" To: Gowrishankar Muthukrishnan , "dev@dpdk.org" CC: Anoob Joseph , "jerinj@marvell.com" , Akhil Goyal Subject: RE: [v1, 10/10] examples/fips_validation: add extra space in JSON buffer Thread-Topic: [v1, 10/10] examples/fips_validation: add extra space in JSON buffer Thread-Index: AQHZOjnlxob5cd1AYk6QEl3FotUtFq7ipqrQ Date: Mon, 27 Feb 2023 09:27:45 +0000 Message-ID: References: <311e28cd27874f1d75c36b5825425e6f84889d64.1675693844.git.gmuthukrishn@marvell.com> In-Reply-To: <311e28cd27874f1d75c36b5825425e6f84889d64.1675693844.git.gmuthukrishn@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM5PR11MB1851:EE_|CH3PR11MB7273:EE_ x-ms-office365-filtering-correlation-id: 22661f24-7903-4eef-d52f-08db18a4e23f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TlzNgzerMxyo1Byhp8kXmVmEXQXVQZMiOaIi60l/IcOze6aUzvBv92NSOCW7bdyLt8995szLJn/ONo6qm0g1OId2uYeNqAbq6rx0kA/OGh24yEIdReSvn9W5d9clv8vZZPXWEIHYJe1wwhuMYAWIIaLn5PeRoo73gm9cen4lnlvbM+ZEKrquEonf1RpklKjDAqY0GM/oN+1Q5y49uHO+shg4Ifl8DoTRl+X0yebLOzonz2jJ3xl005eXw6g1RRVbIchZ923xHmzb768rl98WnRjoiIjeR+FkyfyOZKUzaXp6EpeZsNHzP5J4/X2PdbkFfzYR0oRX4CGyc6rNEaJQ+id5vpPiFyBDYVGFQRsSkbwq+QikWBCUiN7jlr2c2poSoS0EiGgPYVkeCzdIeXdiR4Qpxbi6oizjhXNJAJXZuQMrIJBY1KaER3kjfmapwlhZsD7QTOLTjXQllSG7zYKDNK477IUhrF5IRu+bYHU+e+QhG2crYkHMJgOUl/+imiX44iN4QCbi8KMDiVXPWnZ9MmFGcv+32fn6GK3D9Q02KC5cVc0DojK1DXJlg88bda7WZKrGrAUtvZrTjDSpO8G76GoL89SE7uqxsOvI7NrNxcB393oVqKda83K7eZ5dLaDwcaI3q14EqWikisqsBR+fShjSlQ51JZnYNeCu/vjeVB28RcYyojca2q0Y6igsjBCLzwFmQ4G5IPzWbQM6elu7hQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR11MB1851.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(396003)(366004)(376002)(39860400002)(346002)(136003)(451199018)(52536014)(5660300002)(8936002)(6506007)(53546011)(38100700002)(82960400001)(122000001)(83380400001)(26005)(9686003)(186003)(110136005)(86362001)(316002)(55016003)(41300700001)(66946007)(76116006)(54906003)(66476007)(33656002)(66556008)(4326008)(8676002)(66446008)(64756008)(7696005)(71200400001)(478600001)(38070700005)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0Um+0a/c3saogQtj6fpcNpja8OCY5VTCvshPuG7cAirHjWFPjTw1SqfI6KTr?= =?us-ascii?Q?m9105VVhJUViS2kryeLGE8ZZWd5T1G80LD7Bu49WTpfxn9M8ucjfaUbKfPE8?= =?us-ascii?Q?C3yJ56Mr7UgPEsPaMYBbMlx3lPtTKw3c5jUGZPuEPXGhIzCfCZ7jx8QJRS7e?= =?us-ascii?Q?5ug+1LAOBg+hFXGL1JsCVVyOY38AdbIvFqSqZAeZPI4P9uVg5Pvv0c4NztRT?= =?us-ascii?Q?oSWec1FqwuU4TORzWg0rrVcviAuzqLFSWrEZGWPGC5OmB04IWTR84ZIlnfx/?= =?us-ascii?Q?wys/UEvx+g6auprMunyKsQiub5E/XlYjsX1XcUiXoWBGp8z5heebX5awAfi5?= =?us-ascii?Q?sDvKDOFX2wqc1Qx1v5RjnC+DJgpyXU3FInt7Rw4hbhpQqFhnWfkW4s/6XRdx?= =?us-ascii?Q?opmf2RwnAH97fBqdlNpOG/Dtf8irhCzBuw//h0myU+KoR5graRsOs/8ebxRS?= =?us-ascii?Q?sri8iP4iVbDuALZzr0GLP4PWjtDIwJh7K9HKfHH9tMYxuTswg3KNScuJL93Y?= =?us-ascii?Q?MogMkkr+3VjLti1JRL+Zri6G0FYJoQZoVOAq4N+sBEMFinCuHtwChaqjCSFF?= =?us-ascii?Q?k1GY83MomccpE6NvsGoehg6J2Pi2R2FDjbeZ2mFyUTgjZ+6RovMWjjO8q525?= =?us-ascii?Q?5/1UnjK5oFQTWaD3tOZvc92RWGOH0B8zWqECRi7rgDw5Ce2/8EB69UwE3A2O?= =?us-ascii?Q?xxd1G/iiC2Vd4egVN1bH+QX6e6S4udwp/eZA+hd0grOKvB45CbH1TctGpMBs?= =?us-ascii?Q?r3yda5DG+39r7Rpelia7zUjDr0FZF4+bZr0fopcx2dTTxXuUJcQhVwlRkNYQ?= =?us-ascii?Q?AdvyorxEBBfTJH1LmmR61Tbj0bYbuYdu0NeFD4v7fh/75x2cGyMqmKR7Ixl+?= =?us-ascii?Q?PaUUb2O9AfpQdupna08duHtD/C2ZHdYIXjZUDfRaxZWSeG44kD01E/4NhoIa?= =?us-ascii?Q?91bH2bu/A1zzT0ZCA2491kTWIQECsxMsxiMntd8rcpalJSbKr8nnyRRFAXXy?= =?us-ascii?Q?V+lNwOyUBT8+cF+Pj1b3uCpJmOZGicEEBn4q0zH5u+LgBnjm1PLBgr3J+JZA?= =?us-ascii?Q?FQmHGtMhND3x2yDkWuKrDcvhXow7ywYjFuTp/ux7EepQeR+tQYx1EfhnNt/v?= =?us-ascii?Q?RG9cdNjmtfGn80HXlBebomJuFNFVptSm0GhU8iushMDrSpEvvNxqpK3x36Zt?= =?us-ascii?Q?hxwMnKOweg5wwpQwaKT7xsqoglglWQWhqcpNdFdbuyZ7dIv0X672yMO6tLO6?= =?us-ascii?Q?ln8FefZ12CnGktTjARCupHgJhtKqOzifNuCe2Y610Qe/AtFbFy7NLJESCuEP?= =?us-ascii?Q?AL6FXNcMBHJ642HahIQUAF9JilH5a9BPzwB/4btz5CHwzBFgkklmFL9EQexP?= =?us-ascii?Q?1ar+CgPOskDzthp61q1WYReA77PaKHEyibZ71QnjyygK5y+r57s+7okKzLb+?= =?us-ascii?Q?YESm+swC9VZmp4JHU59fF8ABMo+5siXbUMhPfE8IiPMWMaQv6OXbe4QyX2qt?= =?us-ascii?Q?ydXYKTpBs3JXhDIQxi/4xf10MhMlA23klF4yStKqPRM1DL4WeL1EWtQOYSPG?= =?us-ascii?Q?ZkN3Rz58Xnv/NqCAWWmNZo74YvrJRzr0WYvQPICW?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1851.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 22661f24-7903-4eef-d52f-08db18a4e23f X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Feb 2023 09:27:45.2125 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jQ2zJb1L2Uo2sn74c1+pQXN83lMRdh4nNw6ra2cr1p/6PI0Ag66J0aOMyIzAOUwif39vasW5IzvN4yCcZgyLwg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7273 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Gowrishankar, > -----Original Message----- > From: Gowrishankar Muthukrishnan > Sent: Monday 6 February 2023 14:46 > To: dev@dpdk.org > Cc: Anoob Joseph ; jerinj@marvell.com; Akhil Goyal > ; Dooley, Brian ; Gowrishanka= r > Muthukrishnan > Subject: [v1, 10/10] examples/fips_validation: add extra space in JSON bu= ffer >=20 > Current test buffer to copy input data of maximum possible length did not > account NULL character, due to which a last input character is always ign= ored > and it causes tests like RSA SIGVER for modulo of 4096 bits to fail. This= patch > fixes it. >=20 > Fixes: 0b65d54f3a4 ("examples/fips_validation: fix JSON buffer size") >=20 > Signed-off-by: Gowrishankar Muthukrishnan > --- > examples/fips_validation/fips_validation.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/examples/fips_validation/fips_validation.h > b/examples/fips_validation/fips_validation.h > index c4988053c1..abc1d64742 100644 > --- a/examples/fips_validation/fips_validation.h > +++ b/examples/fips_validation/fips_validation.h > @@ -247,7 +247,7 @@ struct ecdsa_interim_data { > * Esp, in asym op, modulo bits decide char buffer size. > * max =3D (modulo / 4) > */ > -#define FIPS_TEST_JSON_BUF_LEN (4096 / 4) > +#define FIPS_TEST_JSON_BUF_LEN ((4096 / 4) + 1) >=20 > struct fips_test_json_info { > /* Information used for reading from json */ > -- > 2.25.1 Acked-by: Brian Dooley