From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7084941D8F; Mon, 27 Feb 2023 10:29:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5DD0F410FB; Mon, 27 Feb 2023 10:29:24 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 6DC1D40A7D for ; Mon, 27 Feb 2023 10:29:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677490162; x=1709026162; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Wfo5JdsNK/MfUCi5X9s6NAuQJZIO2YoY0GwFcr0hLD4=; b=kaF3lnT/Wfst/uwxWmagjxc0PP3hEBMhK/+ZMtXCwk7TvEQwS3h21esn qBs0DXwNsG5JG/oaNpO0vFI60yk/5EAgnTnEgszxUaM7H28jR7kSjeN40 oaIWiTUmxR1fkd1LSRPCqHXxyUtve0ONu7k5nZ09SSHbWWuTSTiKd72wD ndjJCl5sb1r82Bn1EjHMpRvJWGFwChR1mKIpo/8dTEsfNVRqdjwNuexlk xdEWEa9Tc5sy10ajz2fbrxAuvmsflQqc9KdDCuIqqqkMFYY3RakS7xAvK Ax61nDM8i924nC6GHOk1InICtgJkg1BcNH4JGWa79EP4f8kLQ7mxlVLp2 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10633"; a="332541900" X-IronPort-AV: E=Sophos;i="5.97,331,1669104000"; d="scan'208";a="332541900" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2023 01:29:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10633"; a="742468156" X-IronPort-AV: E=Sophos;i="5.97,331,1669104000"; d="scan'208";a="742468156" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga004.fm.intel.com with ESMTP; 27 Feb 2023 01:29:21 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 27 Feb 2023 01:29:21 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 27 Feb 2023 01:29:20 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 27 Feb 2023 01:29:20 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.173) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 27 Feb 2023 01:29:20 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bLkJgrCKPk/sz22CJCrXaVl3t6efAM6shwVKpMQpRIKAfY5KZn01U7+aZ8pXQgi4mYYK08thWACAt6YSekGB+iP61Ot+gFbRf1j6WTbBfkQKPez7hA+fchzsnkEGDJUdzdUzKyAbisdbQASxWYwVqPwwqIXOYbGpMPJ5bb6gjZf4VFMLcVLt9eLBMgorrGcRu6iEcJ/Y2P1tqLzvdTeYrQkcomYyr7MNlNezDDV0ljQSyv3MyzQ0pseMZvUZllHmKOwuLKh7VVlDp1Gr/xmQW2B9IjRygcD2PZb5Jej7LP2BboKZlCKPyTjBBUJUdO2TpB+Eia/T19ehTO9hZweTtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UAFFIlIJDoUzsLnEYkp+816yyuVzRflx/H0lCnjJBe4=; b=Vy3aatSyuI4jmIh6mRunhrRoF0KCIj9jd9w9/dJ5izJtun7PxRLL+e030DBPJCCT4Xr0YQSjAKpVdaBz5ouQFzREzV1aF1AVt8knHr3FHg7hWbjfjeJPqeMWjvA8KoiloTcGJV9fsXT0lWzLfQuA4YXSV3JhiGdP4qr5ZPVctEYiKoKoyqO+RL78ZhCx9c71VaF7es1W15lck+GAJ7PWOqDCV/02NXSRejp8cnUWVCgTWlCzo8JFi1hF0ojLhIzfMl3X4xWZmB19iZn8I8WOWghMBC3neUye3IBKmI7oq4w+SwC3hQzDF0kQ5xEc8LLIj6fAun/65sG1XR8jD6JGwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM5PR11MB1851.namprd11.prod.outlook.com (2603:10b6:3:114::18) by SA1PR11MB6664.namprd11.prod.outlook.com (2603:10b6:806:258::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.28; Mon, 27 Feb 2023 09:29:18 +0000 Received: from DM5PR11MB1851.namprd11.prod.outlook.com ([fe80::3c23:7638:8d23:670f]) by DM5PR11MB1851.namprd11.prod.outlook.com ([fe80::3c23:7638:8d23:670f%5]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 09:29:18 +0000 From: "Dooley, Brian" To: Gowrishankar Muthukrishnan , "dev@dpdk.org" CC: Anoob Joseph , "jerinj@marvell.com" , Akhil Goyal Subject: RE: [v1, 08/10] examples/fips_validation: fix AES GCM validation tests Thread-Topic: [v1, 08/10] examples/fips_validation: fix AES GCM validation tests Thread-Index: AQHZOjnfUwSfw4vPPEGe0kYe9u0zJa7ipz9Q Date: Mon, 27 Feb 2023 09:29:18 +0000 Message-ID: References: <24a928d04200ab33b4ce19c109e5ed905871f993.1675693844.git.gmuthukrishn@marvell.com> In-Reply-To: <24a928d04200ab33b4ce19c109e5ed905871f993.1675693844.git.gmuthukrishn@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM5PR11MB1851:EE_|SA1PR11MB6664:EE_ x-ms-office365-filtering-correlation-id: 1374d7f1-5af5-4ea5-4f4e-08db18a519df x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MiiUzFQb1G87w8v4UQrxFAXp1PUOSpOoV3XNeNq2s3PdjuGayiCNriXWH4tHcvoqKaVS265HQnaKG7J6BohZiVQpIxu37m/vp4AKrPmpWCdwlTz9P7i0YTPCHWofbb/m4Tk8+KEMtsqmu3uC0od7aPWGVHxHjFMKnM0xLjlnUW50yhLk3p0kLmZaUbunjjiLvXuey/aNm8Yl7cfvlDvNu5F76RUYyj8OmPuZ8AIhyy+yLly7n0s5xQcRqty2dkmylONH0vclmSvTMzR4RgrSOS5tD0U5OHftwkNAeI6jF6xaEtd12eWw85cCSH2AEHKQigdrWrL6dDj4aD/O4vZ6FG29QaaUmAnJxdXPJ9fTOtKfgI6OHYGtrgg/2ldRyHu47DUkmIQLbhtLfTwFDuphLfpBocRxjOfNsSL3z7AprWJm7KOtbgArK6U4oz5E9fOkSFzOiFzB4pLSARZDje7ma8guGhNP2ainTScb3H1EmOuvWRSExnoFkkPTOK7i2sConMjyotP2K76o5cT6/crrg+sqdLVe6CWg3ji8yCbKFo1UXuuWQrnK5o/YOW6SVnYFUAnZL2P1lKeI/3J6TMRyDTedyqsWQy+hSmMkKlX0OVW4HnqtGcnn9S2fO8ll8hfIe3LW8B1PkmXfJ5LUpmsvLjvTvOS7ei4MHcx+OQIatTfKXobDLNFC84Ph31YpJwZsfytyyY2XlB4f5o+UQa56lA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR11MB1851.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(136003)(346002)(366004)(376002)(396003)(39860400002)(451199018)(110136005)(54906003)(316002)(33656002)(86362001)(55016003)(38100700002)(122000001)(82960400001)(53546011)(6506007)(83380400001)(38070700005)(9686003)(26005)(186003)(5660300002)(71200400001)(2906002)(7696005)(8936002)(52536014)(478600001)(4326008)(41300700001)(8676002)(66476007)(66446008)(64756008)(66946007)(66556008)(76116006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?h2ZP846itKSDRVKJUnvqruUV3QwlNb5atVQDlEpcUwv1N6o/1I081PFJfDkG?= =?us-ascii?Q?VU8ZQAXJ9sdkJ01fjrBvIqL1fOzoi3T2EcW43CJiqosy1IWTpwRC2vo4P4eV?= =?us-ascii?Q?be5KOanfWjtczwErpf0CjDO9nXbFzRM9Nu3g+A3aJz/jNrT9S6Vw2ZY5wc7k?= =?us-ascii?Q?h34SZXlWBai8WYJr5KaRU1tkaxpqrAEdp2XaproOUrCRBa6WPSXJGZw6s/av?= =?us-ascii?Q?lXGw0rSgYvwyOicfFzIXcAOmM8IBUeWfJDtOA36XilXFG0JmrUt30eD4MhTx?= =?us-ascii?Q?4oCDqQaqZo86sRHB4MNUgYnIqDmwlyX7r9NpZLTVenXEfjhHnyrSrFMnqeov?= =?us-ascii?Q?Md9o+JI/TJeINT29n1hcg+7e+uXHaMTxDMAR87xpObnZPibkGmgWNk2y0WAF?= =?us-ascii?Q?0ueeuvO33s3w0Di7rHXZv2649x9VNiG7JhONGtN4Ek10q5AjKjJcFG3+PEzz?= =?us-ascii?Q?gJqhlRlRs7FpfgdLN3wZGOMXVi+q0KvoXJ+/WLHm6MZ1fxChin9eDQIN75WF?= =?us-ascii?Q?28OKtqsHmZp6MHoCG+8sC1IwfAi7edsEbjnH3A2bErrs/J+Ej0oWNVvoxts8?= =?us-ascii?Q?viOqvdiTkQUKGYMVOkkVOI2jYzu0+Ai9zxDqtj1R35Yn0svyAq7jdlcpV3Bu?= =?us-ascii?Q?/4ltWAmC4Bs4dnOh2aGRmqPDwYzTWag1gykDu3kt84LXNI1X1xvsQ2J2rtpm?= =?us-ascii?Q?NQi9GhgdEmNfEZM4Zm4gbjzFzAhqcKLiQPUV20NZW4x2ouYbGGck2c8BTUqb?= =?us-ascii?Q?crCLXIiRf5z2stv0GmU5yObzuAu6WxSW4IolqQC1+ivX9ZDx+UYCLemWL086?= =?us-ascii?Q?w9G89tanVuhBdoZqbZHFBUoPzJpHIM02jTtvp0Rlc5hpBN0WCqWVl1khEifN?= =?us-ascii?Q?1OXSR9+NAtQKae1gvaT+5oL3EViq1xLkGgw0g3ROYiHUaMbdY2C7blQbLicE?= =?us-ascii?Q?fPfDuPp/W9iXWAbsUUznVd0o71dVZkInelhyzqea8N7AIG+nKVG1xa7mOKCU?= =?us-ascii?Q?bzCRkFHtrQ040D+9G3LFykrAsNGvGj8MlAEqUPs63kZ5i6nTX9134fSTikiy?= =?us-ascii?Q?JFXr5DrsirAAexhhGsckw2rZLLylhl3a232YytqPL7GPAxLvcnmybL8/6HXM?= =?us-ascii?Q?mCJgl3Ql1ZvMt8GN64+yIxoFmULzQMZ/VcPsXQgv/yluJ+SvM/XBEcukXsQq?= =?us-ascii?Q?lRCfMkWIK6r2CDNfPRYv4M8P2roqOfen4gA0xWtG5khCmNpNwKjzkERn8jNl?= =?us-ascii?Q?akZCgZoD1Jo0lT3tFEQAt2mUuDw/yTwPW0lPcA1hoDcF0vgLX369JD2BnWXQ?= =?us-ascii?Q?DSFzQg2c43pQdek+Vh6Z9CaN+QlsMLtWwgVdT24VOfsVoJiUOIvy1kpQd+bT?= =?us-ascii?Q?6UIDugv8pkfE+rDBR5K8zsx0UJu3NHjxjb92A+6jOciVS4kWZ3K9RwSdGI9D?= =?us-ascii?Q?jDmQsMuJvOSVQtziL+hsTxvZ4M7RBoMrajNUTS1GKRKDX/J8jvoPGG+1eL7k?= =?us-ascii?Q?/F0Gz1rSUqzEieg1M1rLEPmuy/aP9AwgG7MsO3wXHFeiTHfDVyduKRDEfo0s?= =?us-ascii?Q?wFrO0yigrlu28+fJ/JSPHK6TDGTV50Vo0eeqFfGm?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1851.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1374d7f1-5af5-4ea5-4f4e-08db18a519df X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Feb 2023 09:29:18.5167 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qe7+F84bU8dGA9XJME1IYm8U0JVuup14nbmR/jYKbrj7AyuVIu1EcOdaLwl0VLRqQEcLwn+0TkrW8hzO5ssPMg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6664 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Gowrishankar Muthukrishnan > Sent: Monday 6 February 2023 14:46 > To: dev@dpdk.org > Cc: Anoob Joseph ; jerinj@marvell.com; Akhil Goyal > ; Dooley, Brian ; > Gowrishankar Muthukrishnan > Subject: [v1, 08/10] examples/fips_validation: fix AES GCM validation tes= ts >=20 > AES GCM validation tests fail in FIPS validation due to incorrect fields > populated in response file. This patch fixes them. >=20 > Fixes: 5b540bebac8e ("examples/fips_validation: fix GMAC decryption > output") >=20 > Signed-off-by: Gowrishankar Muthukrishnan > --- > examples/fips_validation/fips_validation_gcm.c | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) >=20 > diff --git a/examples/fips_validation/fips_validation_gcm.c > b/examples/fips_validation/fips_validation_gcm.c > index a80d8b3e4d..bf08d1b995 100644 > --- a/examples/fips_validation/fips_validation_gcm.c > +++ b/examples/fips_validation/fips_validation_gcm.c > @@ -79,7 +79,7 @@ parser_read_gcm_pt_len(const char *key, char *src, > if (ret < 0) > return ret; >=20 > - if (vec.pt.len =3D=3D 0) { > + if (info.algo =3D=3D FIPS_TEST_ALGO_AES_GMAC && vec.pt.len =3D=3D 0) { > info.interim_info.gcm_data.is_gmac =3D 1; > test_ops.prepare_sym_op =3D prepare_auth_op; > test_ops.prepare_sym_xform =3D prepare_gmac_xform; @@ - > 296,6 +296,7 @@ parse_test_gcm_json_writeback(struct fips_val *val) > tmp_val.val =3D val->val; > tmp_val.len =3D vec.pt.len; >=20 > + info.one_line_text[0] =3D '\0'; > writeback_hex_str("", info.one_line_text, > &tmp_val); > ct =3D json_string(info.one_line_text); > json_object_set_new(json_info.json_write_case, > CT_JSON_STR, ct); @@ -326,6 +327,7 @@ > parse_test_gcm_json_writeback(struct fips_val *val) > tmp_val.val =3D val->val; > tmp_val.len =3D vec.pt.len; >=20 > + info.one_line_text[0] =3D '\0'; > writeback_hex_str("", info.one_line_text, > &tmp_val); >=20 > json_object_set_new(json_info.json_write_case, PT_JSON_STR, > json_string(info.one_line_text)); > @@ -334,12 +336,8 @@ parse_test_gcm_json_writeback(struct fips_val > *val) > json_true()); > } > } else { > - if (!info.interim_info.gcm_data.is_gmac) > - > json_object_set_new(json_info.json_write_case, PT_JSON_STR, > - json_string("")); > - else > - > json_object_set_new(json_info.json_write_case, "testPassed", > - json_false()); > + json_object_set_new(json_info.json_write_case, > "testPassed", > + json_false()); > } > } >=20 > -- > 2.25.1 Acked-by: Brian Dooley