From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9566CA04B5; Wed, 2 Sep 2020 05:36:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 45378137D; Wed, 2 Sep 2020 05:36:26 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 16AF6CF3 for ; Wed, 2 Sep 2020 05:36:23 +0200 (CEST) IronPort-SDR: +FOo9sPyAluFDKzSyKjoixIrD0rKu6VfgQheBwYvr3WzzyyFrrrbwlm0uszC47EZwVIxQy58sS vq5Yd8fNcH2Q== X-IronPort-AV: E=McAfee;i="6000,8403,9731"; a="157317401" X-IronPort-AV: E=Sophos;i="5.76,381,1592895600"; d="scan'208";a="157317401" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Sep 2020 20:36:22 -0700 IronPort-SDR: HXsaSsCmrSrAx005RBqC+cnihkehy5225qh38AHu/YZr2mNosCB+IDNXdpspTYWpcT8OiI/0uv QHDgrdSQ0enQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,381,1592895600"; d="scan'208";a="325616691" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga004.fm.intel.com with ESMTP; 01 Sep 2020 20:36:21 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 1 Sep 2020 20:36:21 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 1 Sep 2020 20:36:20 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.175) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 1 Sep 2020 20:36:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EllLbZdvdnRo+Wte6lN5bnfiN4dCujWPvTy1dAQtFBhgasBeZTsWxbuGTo5+rm21lLUgTYTBDNkUmjMGxWFyiNZPw3jVKY51P4PmcpC2m3fVyMXauLBwyhIiAIqgM0ZSvP7gTMq5O4dd8kWiCk5sTkkPChiqTKw2usMFS0TvZAaXR2miOMIVD6wxaKCiL3c9GobPi/dHTH9I6oC7e3/dUUFJJ4pD7YtGoKHc+ROV8235dr3DqSeQPjIH+cDzvJUObeucl/8m/KxYJ0woyLYdoGMhN/pIY7rbBON2Z339urVd9gBZ47tJ402EgvyNOetBKwFQ1RtoUYJcv5SbuW5G4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kR6DNmsTTiogmOcODhiwhyvCHhdZOfEMccV0QGKjwIM=; b=fj7tJCyPh0OhqK4aH1HqSq4ub0wUgfYrIVrjJAgz0L+oWUu4CkRoFymw5yzNcg/WhosIU+/HW8+/vDkuUucQpNrW7hjwM8kYPlezatPCaN2NXQy7MPv6Nnz+F3ioZnnVOwY/ZRh5CI5gEm6M8VheBidxKgBPRO+A+WyAsM1wl/0xUwyo2GrStLGHmd/+8S/gu9/vAFmajGoSX3fXbHdyAKzmrpigO4X5vMA1Dx0jXdXtz4oL6MKNmXeLj3/1GxzWdgKzeXNx4C07lYu9IlWjToBKYz+6XPNLOCXvDifj2qqhz9OeIxGIL8XzLGLyKHvCY3zvRVj/dVNwqEFzvwMQOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kR6DNmsTTiogmOcODhiwhyvCHhdZOfEMccV0QGKjwIM=; b=MjEp6oahgxsI/deoMZ823+GUqXoAzJ1BL0u2eAmyjeqiMXqK4yYY69S8bexN2EqXQipSzJOZbjOzv55Q/82jppeSsLruZgpRyCedQrWj/DXnKQ9SBnwuM8G0AY0pCMEfr7tVRWf5vR8L2grTNh9twMll1nJPmXCNPFDeRbuQpSo= Received: from DM5PR11MB1852.namprd11.prod.outlook.com (2603:10b6:3:110::8) by DM6PR11MB2650.namprd11.prod.outlook.com (2603:10b6:5:c4::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3326.19; Wed, 2 Sep 2020 03:36:05 +0000 Received: from DM5PR11MB1852.namprd11.prod.outlook.com ([fe80::7485:7ada:a420:31a5]) by DM5PR11MB1852.namprd11.prod.outlook.com ([fe80::7485:7ada:a420:31a5%7]) with mapi id 15.20.3305.034; Wed, 2 Sep 2020 03:36:05 +0000 From: "Peng, Yuan" To: "Guo, Jia" , "Yang, Qiming" , "Zhang, Qi Z" CC: "dev@dpdk.org" , "Guo, Jia" Thread-Topic: [dpdk-dev] [PATCH v1] net/ice: fix none GTPU TEID hash Thread-Index: AQHWfVDqKKId0YdcnU6awYOSOrIpG6lUuZzA Date: Wed, 2 Sep 2020 03:36:05 +0000 Message-ID: References: <20200828153410.88469-1-jia.guo@intel.com> In-Reply-To: <20200828153410.88469-1-jia.guo@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.208] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b83683ac-a589-4dc3-eb0d-08d84ef152ef x-ms-traffictypediagnostic: DM6PR11MB2650: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1824; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eM5/M0ue0bIhBAH4iulcEqwz6/VMHswOk3Xp2+bRdJ1YDpPODlJKCqVk3mK3eX75Ynef6jdpeExOJet4j+yM0VtzKE0HIN/51ITsYejkKgL7CNl3RdUPn6gLvS+HmKvRhzfbU6sCSFjjdZGNDv3gWyLh9e8/X9dYfgle+U3bCQs/t90YOPWl2AdTml/iXGqESgx5iUITc6RmxFuzrZ8iZJpG2imcyEcu2P8i+f0esc+XR7Jv2GJniUA4nTsW/zEX5rNkriwBW+KcVOkN5iBFY+HBKmxATHlEhYUxTwudrBxx6HrA17vJJM63IFQ9nqEVZpUFuUci8jkDNneSycSmOA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR11MB1852.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(366004)(346002)(136003)(376002)(39860400002)(66556008)(64756008)(107886003)(83380400001)(66476007)(54906003)(26005)(86362001)(53546011)(316002)(7696005)(5660300002)(66446008)(6506007)(110136005)(66946007)(52536014)(76116006)(8936002)(6636002)(71200400001)(186003)(33656002)(55016002)(4326008)(8676002)(2906002)(478600001)(9686003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: g9uvk2oFSKbbDYT0MsGK9faswKjzSSySUlwYAgpocrnx+QQ7K04MdKQlyz/d39sdnJ0ew6BIezoIa4O3pzn+/jS8NUwv7PxB/eSB5xkxDMWnb+dy9/OgGas08QsnDe4I1TBhgJhOCV0mJh3gvnR0Y8DN892Ar/YheFBTU6eSfXEWiJa079nyHYNpeLHXTkyGZa9jTUONm6HldhV5Vn1BDXAKPt1Tu0ffjriLy2kRmqOefVCq645F/5j3paDiOZQOVxC1Z2rax60OAihc/azUB/hBn5ClSWc1znoPafczkcIJwbgbKl3RcNrcHtbAaPiUDZ5gDWJVvLVFzieQZGMr2bzkohR/0KPWJ54MX0vKJK1c6HI8U8ANTbK9XqGeSsXAhAaIF0EoP34hTGjG82+vGUmG2T1IaMx/a16mkzSAaF63hFCNG3iSrbfmf6HcGnPByc0zQv1lNZn1Iv5oWeqSW5dV6vnRHk4cduXwCC18NOISiXn3rpaPECRpmI1IHU07zEqzqUzvOmdzk053cyGQSCPnRaNisqH1Q4ylToJN9eW9tT22Dgwuz5sUtuXPM/WHslttsJTmb7gp186rZAttJwFL+Tae4ZXdNvGECWqhbwyxy/Zo/njS7WRWQ0AEKU0p1sRX4Mc5MFDq6wSx+OmgBA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1852.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b83683ac-a589-4dc3-eb0d-08d84ef152ef X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2020 03:36:05.7145 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8OpDz1IhkaYBUymho5dKjb+avVny7ptNa0xVmmDk5lGq8/spgYFLuScOc+Tl2ABiTsIMBuxIkvtPP9lZSqp5kA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2650 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v1] net/ice: fix none GTPU TEID hash X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Test-by Peng, Yuan -----Original Message----- From: dev On Behalf Of Jeff Guo Sent: Friday, August 28, 2020 11:34 PM To: Yang, Qiming ; Zhang, Qi Z Cc: dev@dpdk.org; Guo, Jia Subject: [dpdk-dev] [PATCH v1] net/ice: fix none GTPU TEID hash GTPU TEID hash should only be enabled when ETH_RSS_GTPU is required. Fixes: e7cc68c70736 ("net/ice: fix GTPU TEID hash") Signed-off-by: Jeff Guo --- drivers/net/ice/ice_hash.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c index = c0271dff5..61054557e 100644 --- a/drivers/net/ice/ice_hash.c +++ b/drivers/net/ice/ice_hash.c @@ -1151,7 +1151,10 @@ ice_hash_parse_action(struct ice_pattern_match_item = *pattern_match_item, } =20 /* update hash field for gtpu eh/gtpu dwn/gtpu up. */ - if (hash_meta->pkt_hdr & ICE_FLOW_SEG_HDR_GTPU_EH) { + if (rss_type !=3D ETH_RSS_GTPU) { + break; + } else if (hash_meta->pkt_hdr & + ICE_FLOW_SEG_HDR_GTPU_EH) { hash_meta->hash_flds &=3D ~(BIT_ULL(ICE_FLOW_FIELD_IDX_GTPU_IP_TEID)); hash_meta->hash_flds |=3D -- 2.20.1