DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tal Shnaiderman <talshn@nvidia.com>
To: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: Matan Azrad <matan@nvidia.com>,
	Shahaf Shuler <shahafs@nvidia.com>,
	"Slava Ovsiienko" <viacheslavo@nvidia.com>,
	Andrey Vesnovaty <andreyv@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH 1/1] net/mlx5: fix flow shared action destroy	error code
Date: Wed, 25 Nov 2020 05:30:48 +0000	[thread overview]
Message-ID: <DM5PR1201MB2552EB6436F4AF97F05CCBC0A4FA0@DM5PR1201MB2552.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20201124224022.2550640-1-thomas@monjalon.net>

> Subject: [dpdk-dev] [PATCH 1/1] net/mlx5: fix flow shared action destroy
> error code
> 
> External email: Use caution opening links or attachments
> 
> 
> In the function rte_flow_shared_action_destroy(), the errno
> ETOOMANYREFS has been replaced with EBUSY in the commit dc328d1c555a
> ("ethdev: rename a flow shared action error code").
> 
> Another occurrence of ETOOMANYREFS, added later by mistake, is replaced
> with EBUSY errno.
> 
> Fixes: fa7ad49e96b5 ("net/mlx5: fix shared RSS action update")
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  drivers/net/mlx5/mlx5_flow_dv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_flow_dv.c
> b/drivers/net/mlx5/mlx5_flow_dv.c index 253f598310..aa21ff9613 100644
> --- a/drivers/net/mlx5/mlx5_flow_dv.c
> +++ b/drivers/net/mlx5/mlx5_flow_dv.c
> @@ -11541,7 +11541,7 @@ __flow_dv_action_rss_release(struct
> rte_eth_dev *dev, uint32_t idx,
>         queue = shared_rss->ind_tbl->queues;
>         remaining = mlx5_ind_table_obj_release(dev, shared_rss->ind_tbl,
> true);
>         if (remaining)
> -               return rte_flow_error_set(error, ETOOMANYREFS,
> +               return rte_flow_error_set(error, EBUSY,
>                                           RTE_FLOW_ERROR_TYPE_ACTION,
>                                           NULL,
>                                           "shared rss indirection table has"
> --
> 2.28.0

Reviewed-by: Tal Shnaiderman <talshn@nvidia.com>
Tested-by: Tal Shnaiderman <talshn@nvidia.com>

  reply	other threads:[~2020-11-25  5:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-24 22:40 Thomas Monjalon
2020-11-25  5:30 ` Tal Shnaiderman [this message]
2020-11-25 12:58   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM5PR1201MB2552EB6436F4AF97F05CCBC0A4FA0@DM5PR1201MB2552.namprd12.prod.outlook.com \
    --to=talshn@nvidia.com \
    --cc=andreyv@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=matan@nvidia.com \
    --cc=shahafs@nvidia.com \
    --cc=thomas@monjalon.net \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).