From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD794A04FF; Tue, 24 May 2022 14:36:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7341D40140; Tue, 24 May 2022 14:36:41 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2059.outbound.protection.outlook.com [40.107.244.59]) by mails.dpdk.org (Postfix) with ESMTP id 235A2400D6 for ; Tue, 24 May 2022 14:36:40 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FyOhg8aHCB2zRMGTnUDWv89IlCvqAKmzgFttVNVt2VDpuLxC7mVLLqe0gyO0wu5gidk8KQkYp286U6PijOuzssyXC59izbXZwZCLH/iEN7GYlQuh/VV3gTzXAOQ71RhktNubwA2g3Sb+t7k0D2YTGRPXQv+9KS1+YdM0svyzfLj93Mdqpn0QJVKLMJjKlgSRnlTdH0xB/qsjTrq3O85DVhuRdwnXlk0uU3WzelsYNfIk2L9a6CDX5+f5cVVfTuVZHQRFT0V5lNPXTvVAAVNSboCXxfHW4KIW14BVOqMzRkwIlrTiY1PUWf9ZcEQY2tXVWEw6FT/gljzyF0Gu3mK32Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=atDdoKDAXzbAfD4cvHelMKOEds8ewXTBrDgWq7xsF5k=; b=dIUl0fUZrhN5Pmi5Bwx7HEBS/1RSBcQSGHW9+FCpKGr7ZMv2zryAS7H0r4IIpYJASqhM5U0gRxUkqIoNKlE12e54pqiolYvVjI7WsI6EI2p5RQSYKqgnUH+GR6wTCodIaM7xNcqVqehymxEz2wv9+PQVcbe5Ywn7uG5c503OdIzWC/Rm+bkvkPBD+KtTJn7+pUsP8ZupjEiZoH1xz6sRVRQRoXeTp7UtAW7md4/JTG2Y3pr2HoreyDnUESbPJYyy42qxeRt1W0oKIPf3mNShnWPHCunhCDTqirE3YmAYf77KRKrRivY655+tRBDCakEdeiGIUJXidQGcado1rRbWUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=atDdoKDAXzbAfD4cvHelMKOEds8ewXTBrDgWq7xsF5k=; b=NtRpnkfhjnZtL5idgCxN6ipyDcUXNyIxCP+ppr/DV1gdaZWQwz0rtqATR5vpvEvpAF+265Y2AEnY8s+EDl5O7vzFInH3HxPHtCm6UJedfjX2jxNfdf5Yfbb+HRrmmjBEodSqUbqTzdSW2F181uw3h3pBkgfil3926k4I7qZnuVlCkpE7ejIsUY/LlgIfoGHavgO+d9faMxDElb5hn3vE1VZ00XQoLSL/0/7PMuGpZFeyeGQ4Lct+l39shk6aK/peILpm9JwCTuWBFQqmMqtdbQXEtfT+LE/4ofBOrQZEvdPXghqnJ3IPI5Zs9eMQFa44/lzwYvb0MFHM+49u8RKBhQ== Received: from DM5PR12MB2405.namprd12.prod.outlook.com (2603:10b6:4:b2::20) by BYAPR12MB2710.namprd12.prod.outlook.com (2603:10b6:a03:68::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.15; Tue, 24 May 2022 12:36:38 +0000 Received: from DM5PR12MB2405.namprd12.prod.outlook.com ([fe80::65cb:941f:347f:cc4f]) by DM5PR12MB2405.namprd12.prod.outlook.com ([fe80::65cb:941f:347f:cc4f%5]) with mapi id 15.20.5273.022; Tue, 24 May 2022 12:36:37 +0000 From: Alexander Kozyrev To: "Dumitrescu, Cristian" , "dev@dpdk.org" CC: "jerinjacobk@gmail.com" , Ori Kam , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , "ivan.malov@oktetlabs.ru" , "andrew.rybchenko@oktetlabs.ru" , "ferruh.yigit@xilinx.com" , "Awal, Mohammad Abdul" , "Zhang, Qi Z" , "jerinj@marvell.com" , "ajit.khaparde@broadcom.com" , "Richardson, Bruce" Subject: RE: [PATCH 3/4] ethdev: add meter profile config calculation Thread-Topic: [PATCH 3/4] ethdev: add meter profile config calculation Thread-Index: AQHYanC6mJwnSQS7U0qRap5nb1KhJa0mS/WAgAewYeA= Date: Tue, 24 May 2022 12:36:37 +0000 Message-ID: References: <20220502200439.4100965-1-akozyrev@nvidia.com> <20220518043459.1281590-1-akozyrev@nvidia.com> <20220518043459.1281590-4-akozyrev@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3833db4d-379d-40d2-c7ef-08da3d820bc0 x-ms-traffictypediagnostic: BYAPR12MB2710:EE_ x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EDf9OQtK0oxc6V1yBJ26q5TZVnfsLxJRTXj4WhfXGxYYs9yaeB4W0XpBTS45B3WES3yLcTGc2A7OC2lSTZXX79MjfYjpnitRBnknVDDev/AVcofAzcAHIgGECmeCnPSFanvZAnpjYdbgO0L3jhXnN+wFg+rneg0chCqnKe1ugPcN4qiU76CH1UeTqLDHiaLl7sygLckSN8CMPoiSV5uc4Uof7vMkYSWWjzjrFvuk2UIcviIt/osCwWKu0BkUkoUrREKRoDRmWj3RfOSL//4ufmCB3Lqmm6Pr3lOH1EhjPj+Qml0sJrSTGVHDcNAxmNAkH9XeLOQserC44UHD9jShxFKxsaJ2Qqcq5Cnba5P9+GaZR9U7zbK9CvGsf3+f/VwMvBGjgvPW61UwKHD60Bg25L/9AyngHk7dA4F+ErCFc7j++xXTgu+8lllobgoDZZ+imDU9y7jati3lmj9s6mamA+2hQhwBX/h3tKj2307as0PzPANgENQ1ok+DI/sfT7f5XXNlB+sXClqvBXXdfl5qAaMi7o+bBVE2Umj3TKZWIZ/ETGDOhh+q/bm3Xsi+JIbWNgSn5B+u5QtiRRlsrcpvgfdY54H3HWMuAt39nhEoT5cKghWts4NEJWUh5MDAiNrfVnamW1k94F02HRTFrpbmabk7oAQvFE4tyoymRxBiVMpbrNMj51LC8BL6uomObcOvBVHJwVFvuUOxjxtVpi4ZRQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR12MB2405.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(508600001)(55016003)(7696005)(33656002)(2906002)(7416002)(5660300002)(54906003)(52536014)(110136005)(38070700005)(38100700002)(4744005)(26005)(66446008)(66476007)(122000001)(66556008)(64756008)(76116006)(66946007)(4326008)(316002)(8936002)(8676002)(9686003)(71200400001)(86362001)(6506007)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?rzuy/f2MXUOj46FApyRhQv/lQjK9ynvO2ygn0EcEgR6aETBOv6cQVIAt5TLK?= =?us-ascii?Q?zvjs8DFgmXhDZBPwGuyLCIDeLTE/1KxKsQ+J/7P8cVV10KVnvhxUp2Fl6Rm+?= =?us-ascii?Q?b1Bkxzzohmv5UKvonT8qBz5VeOL7p+222nFmkQSwZHZGliLYfNWnUM1kj5Ig?= =?us-ascii?Q?3N5w1Uvcp6++sgsbxmNLQGgbFW5KEa3ZVObtXn6VLLZDeQfiq+V3T31SAgS2?= =?us-ascii?Q?GqBvVEPmPdhRJ/LE30SpHgzXNMGkWTJiMosIM9h2Nn7g0tg1oQ4ys6ATuG2K?= =?us-ascii?Q?Fmofh5NJA5bAHEao9CDkSu+2GtTe7X/u96LNEl+17vmXtjk3BwQyKaGmSB41?= =?us-ascii?Q?2uTMCgcNVdtdSJ5kQycFBsGssyXEJ6L8fYJMNmBjzOxs7qeD4rWwODkyvmve?= =?us-ascii?Q?0Qr+xs4AwCwZ76CrnPE8a0g4GzX9mqjMemWSsjnQhl0qJFnBgNEHU5EEJ9rR?= =?us-ascii?Q?haZeGpPWJo3c2Aaywf2wTYZaFRhVVz042jc6OI/jFGgHKZ0cIj86vYCrUlLO?= =?us-ascii?Q?N4YS8TEBhlfKilg6vly40G49kdKTASxCcarCnis/mpUjRbb/RoKmGqdhDP30?= =?us-ascii?Q?sWkU73W6ISZWcuKQTacJ5zwrZSaO9eL3sS4Jv9D7Z1k+aiZVwTqQrozqmJKd?= =?us-ascii?Q?+ClS1/Wb49xyWrG61gXjnl0ggaW4bTJ3LA/qo8sWJQ3TnWsGnvsat/5D51cq?= =?us-ascii?Q?zS0vYjOnL0QutfP3ckXOxEMuBVPi1ouSvE+LFl9pyet7GGFYDsyKPGNcmrAv?= =?us-ascii?Q?6FYUttUqm0XUGWzqaHfHrv7IxIHaVptWlP8f/qwLUXVuQJUWVYsr3pGns6IU?= =?us-ascii?Q?N5j7QP2xR1usbQ34wgOwjKLXuRuVqykhq6wdYM8UXCWdOuw1G+ZPtRrwiBY2?= =?us-ascii?Q?i+qOaE1WbX6S36QVht6DGmT0u6b4+Y+6vyYHV8Md9gKHGUETJIO+yA+dI9gH?= =?us-ascii?Q?NOxbrB+l0zPsA1kDBbWSCzu1Ne5eeyEiWlmeQs8FCWXBvVGmpmagq3fJ26tY?= =?us-ascii?Q?FicJBr4FiTIV3ktkluzDCmM9kbtFO5thVZomJWQfL37d3133eDWDiLB/nSFB?= =?us-ascii?Q?NAsIq+mE/KYWUt1YtpSWQFoqF9e7Zm5Ao3rOQmvtNfwHR4/4l1uV1Uwgc76X?= =?us-ascii?Q?KIJOpQWtpL4h/ChW4AIdvgVSZSvBE8I6g57E725GV4sPeNo8w5ZH37cjmAJF?= =?us-ascii?Q?gzmzuhyJZyupPrv/TXAe6Ic/R6H1PUo7kmPle4XvTXQ+ogPw7+i7VC6bZHXE?= =?us-ascii?Q?lL10aRdXJ+ZnUfmM+Q57kQgknDG/SnKjXsB2USc5UrwqMH2LtHyB5aUR3SIh?= =?us-ascii?Q?pUtX2E2DCOUv8qPY1O+EjleC0lFPzhypIWh5PmSJsJWmYZPJVyCQeNovWQnS?= =?us-ascii?Q?aQXv19CY64Ua4olJIHufzalZ9maWEMJbc04ms8gKoOr+JO4PzoMEssNxvBCN?= =?us-ascii?Q?Zs99rM25LficAOATUoSx7BfowDUwSikOOwZzsA5kGQo2sv9y6/KnaXDuFwLY?= =?us-ascii?Q?yHcTuUprNSsv4EmzvK1Mf/dg0EAr/2YSrO4GG2n+jSFpTUL/A4AP/CUdNIL1?= =?us-ascii?Q?7fx3XaJzviRqp2QzATsVUVW+aECC8uA9P7ZFRoSHqj9lystrLLTE+FsN3cDY?= =?us-ascii?Q?jxVH2jBDo9d/2OWxtDWXpMc41RNiD9kNtSOUL2zBJc367WxePT+qWNPqwPRj?= =?us-ascii?Q?vF9ScKB/bWakO57AAsJvsiDO2tLLuR6668FBNTAOuOdcd5HbJG4WBUD/VRsU?= =?us-ascii?Q?bIeqfL8qvA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2405.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3833db4d-379d-40d2-c7ef-08da3d820bc0 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2022 12:36:37.7947 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cYlNd/CtZbgjHHQv5KoLK/vAyYDdq0AEemuErkJQdDmLYnUR7W5KfUMl++lHZLC4UvRxL+71eVx94UPPqSn7Mw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2710 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thur, May 19, 2022 10:55 Dumitrescu, Cristian : > I don't understand the purpose of this proposed API function, can you ple= ase > explain? >=20 > It looks to me that you want to have an alternative way to create a meter > profile, so why not use the existing API function rte_mtr_meter_profile_a= dd() ? > It does the same thing. >=20 > Also, who allocates this opaque array meter_profile_cfg? Assuming it is t= he user > that needs to allocate it, how does the user know its size? The creation of a meter is still done thru the rte_mtr_meter_profile_add() = API. It is responsible for memory allocation and parameters calculation. The rte_mtr_meter_profile_get() API just returns the pointer to the object allocated earlier, based on the Meter ID, saving the lookup time. User still have to manage the lifecycle with add/destroy functions. PMD allocates this opaque pointer and knows its size, user doesn't need to = worry. I hope that my examples in the meeting minutes explain this concept clear e= nough.