From: Asaf Penso <asafp@nvidia.com>
To: Matan Azrad <matan@nvidia.com>, Slava Ovsiienko <viacheslavo@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
NBU-Contact-Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: reduce log level in hlist registration
Date: Mon, 23 Nov 2020 16:01:44 +0000 [thread overview]
Message-ID: <DM5PR12MB240638E851473C0AADFB4EA1CDFC0@DM5PR12MB2406.namprd12.prod.outlook.com> (raw)
In-Reply-To: <1606147002-451248-1-git-send-email-matan@nvidia.com>
Regards,
Asaf Penso
>-----Original Message-----
>From: dev <dev-bounces@dpdk.org> On Behalf Of Matan Azrad
>Sent: Monday, November 23, 2020 5:57 PM
>To: Slava Ovsiienko <viacheslavo@nvidia.com>
>Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon <thomas@monjalon.net>
>Subject: [dpdk-dev] [PATCH] net/mlx5: reduce log level in hlist registration
>
>In mlx5 internal hash list tool, there is a log print when an entry allocation is
>failed: Can't allocate hash list entry.
>
>Some initialization checks triggers hash list registration in order to check some
>capabilities. Here, the failure in registration doesn't lead to failure in the
>initialization flow, that is why the log level can be lower.
>
>Move the entry allocation failure log to debug level.
>
>Signed-off-by: Matan Azrad <matan@nvidia.com>
Reviewed-by: Asaf Penso <asafp@nvidia.com>
>---
> drivers/net/mlx5/mlx5_utils.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/mlx5/mlx5_utils.c b/drivers/net/mlx5/mlx5_utils.c
>index 9889437..848d108 100644
>--- a/drivers/net/mlx5/mlx5_utils.c
>+++ b/drivers/net/mlx5/mlx5_utils.c
>@@ -156,7 +156,7 @@ struct mlx5_hlist_entry*
> entry = h->cb_create(h, key, ctx);
> if (!entry) {
> rte_errno = ENOMEM;
>- DRV_LOG(ERR, "Can't allocate hash list %s entry.", h->name);
>+ DRV_LOG(DEBUG, "Can't allocate hash list %s entry.", h-
>>name);
> goto done;
> }
> entry->key = key;
>--
>1.8.3.1
next prev parent reply other threads:[~2020-11-23 16:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 15:56 Matan Azrad
2020-11-23 16:01 ` Asaf Penso [this message]
2020-11-23 21:47 ` Slava Ovsiienko
2020-11-24 22:29 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR12MB240638E851473C0AADFB4EA1CDFC0@DM5PR12MB2406.namprd12.prod.outlook.com \
--to=asafp@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).