Re: [dpdk-dev] [PATCH] doc: add new tables for rte flow items and actions support

[Asaf Penso <asafp@nvidia.com>]

>-----Original Message-----
>From: Thomas Monjalon <thomas@monjalon.net>
>Sent: Friday, February 5, 2021 12:09 AM
>To: Asaf Penso <asafp@nvidia.com>
>Cc: dev@dpdk.org
>Subject: Re: [dpdk-dev] [PATCH] doc: add new tables for rte flow items and
>actions support
>
>04/02/2021 18:05, Asaf Penso:
>> In http://doc.dpdk.org/guides/nics/overview.html, table 1.1 lists all
>> supported features.
>> It has a single line for "Flow API" that refers to rte_flow support.
>> rte_flow is composed of many items and actions that are not expressed
>> in this single line.
>>
>> The following new tables are suggested:
>> 1. rte_flow items
>> 2. rte_flow actions
>> 3. rte_flow shared actions
>>
>> Signed-off-by: Asaf Penso <asafp@nvidia.com>
>> ---
>>  doc/guides/conf.py                   |  23 +++++---
>>  doc/guides/nics/features/default.ini | 109
>+++++++++++++++++++++++++++++++++++
>>  doc/guides/nics/features/mlx4.ini    |  15 +++++
>>  doc/guides/nics/features/mlx5.ini    |  70 ++++++++++++++++++++++
>>  doc/guides/nics/overview.rst         |  11 ++++
>>  5 files changed, 221 insertions(+), 7 deletions(-)
>
>After running git status I remembered the generated .txt files must be added
>in .gitignore.

Thanks, will update .gitignore file in v2.

>
>[...]
>> +[rte_flow actions]
>> +end                  = Y
>> +void                 = Y
>> +jump                 = Y
>> +mark                 = Y
>> +flag                 = Y
>> +queue                = Y
>> +drop                 = Y
>> +count                = Y
>> +rss                  = Y
>> +port_id              = Y
>> +meter                = Y
>> +of_pop_vlan          = Y
>> +of_push_vlan         = Y
>> +of_set_vlan_vid      = Y
>> +of_set_vlan_pcp      = Y
>> +vxlan_encap          = Y
>> +vxlan_decap          = Y
>> +raw_encap            = Y
>> +raw_decap            = Y
>> +set_ipv4_src         = Y
>> +set_ipv4_dst         = Y
>> +set_ipv6_src         = Y
>> +set_ipv6_dst         = Y
>> +set_tp_src           = Y
>> +set_tp_dst           = Y
>> +dec_ttl              = Y
>> +set_ttl              = Y
>> +set_mac_src          = Y
>> +set_mac_dst          = Y
>> +inc_tcp_seq          = Y
>> +dec_tcp_seq          = Y
>> +inc_tcp_ack          = Y
>> +dec_tcp_ack          = Y
>> +set_tag              = Y
>> +set_meta             = Y
>> +set_ipv4_dscp        = Y
>> +set_ipv6_dscp        = Y
>> +age                  = Y
>> +sample               = Y
>> +shared               = S
>> +modify_field         = Y
>
>I suggest not having "shared" in above table but marking "age" and "rss"
>as shared with "S" in above table.
 
In this case, how would you separate, for example, between support of age and shared age? There are different actions.

>
>> +[rte_flow shared actions]
>> +age                  = Y
>> +rss                  = Y
>
>