From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 095F2A0A02; Thu, 14 Jan 2021 14:27:22 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 88A0A14124F; Thu, 14 Jan 2021 14:27:21 +0100 (CET) Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by mails.dpdk.org (Postfix) with ESMTP id 57E5014124E for ; Thu, 14 Jan 2021 14:27:20 +0100 (CET) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Thu, 14 Jan 2021 05:27:19 -0800 Received: from HQMAIL111.nvidia.com (172.20.187.18) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 14 Jan 2021 13:27:11 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Thu, 14 Jan 2021 13:27:11 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LFt9g2FhpXk2Ycq42+QuE63NUfnL/+rNv2TsShepcQICawbIAmvQpCObu6qHMd2PgCBAd1rhkYn7BxZo5S5SMhioC7LPwFIYfMjmPK27wBRX9iY8FYXm4jGd1pUIkKNygPyK6md4pxhphNIdV7eFT6CxSyalPRAtHgbvlYTES/f7rSXtRQYEMSuZef1ltcK5XdRIVZwFOA/DsWuQvQga510yvcZe6HJuCTqx3K6W1ZPF+HHwWBIcPWs4EQ6ha4iDKHbiKcB9OqpdFtSzBO6rO2rnDOWohHlO5JHJmKcWiwXJe1QHHl1HtZL+HIWALAwemCzHT3Gmked2714yvFgn3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rFg46/FyLTsi2jBwLYUXSwVSqjKI2wxYkzuLuxCg72E=; b=Xf4wcIt3jiBEWbtOnrkzKG+Z3n5BZgnE9+4xEPqPYd8zPbLCOD+3s7u5+zxHg9360YPCSZ/UHfZ9vdTTA0342tEFHqJb6OJDwwyWgdHiWcNkuYEv81vMC71oO0SL7mmV0nJlB9DChqzM7c/36sl8qrZeJzXH/VEHu329Vv4H9Mdq7aMKtK1+Ea4KCVXtjJc75FaOnknM5DBvcK4E+55AeygipMmlnQSQX23JYNWUhCYVv78eTldEatct+dk/WP8qmF0RP2Xi6u72yjNioIb8qZbEbchUjSCSzUlT9L+8HzyAy1LICiLENGA0Aivp5Z0n7ll/tXSnP/lSUutwnJpTzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM5PR12MB2406.namprd12.prod.outlook.com (2603:10b6:4:b7::23) by DM6PR12MB3243.namprd12.prod.outlook.com (2603:10b6:5:185::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.10; Thu, 14 Jan 2021 13:27:09 +0000 Received: from DM5PR12MB2406.namprd12.prod.outlook.com ([fe80::d1e7:9a70:b384:4e56]) by DM5PR12MB2406.namprd12.prod.outlook.com ([fe80::d1e7:9a70:b384:4e56%7]) with mapi id 15.20.3763.011; Thu, 14 Jan 2021 13:27:09 +0000 From: Asaf Penso To: Ferruh Yigit , Gregory Etelson , Ori Kam , "qinx.sun@intel.com" CC: "bugzilla@dpdk.org" , "dev@dpdk.org" , Ajit Khaparde Thread-Topic: [dpdk-dev] [Bug 613] [21.02] rule lost after port stopped Thread-Index: AQHW6kUCSyUGx9BV0kWZYBbrylcEUKomzJ2AgABQaDA= Date: Thu, 14 Jan 2021 13:27:09 +0000 Message-ID: References: <09d81edf-ad10-4dbe-a1a5-63a5a7ef6987@intel.com> In-Reply-To: <09d81edf-ad10-4dbe-a1a5-63a5a7ef6987@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [217.111.27.204] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b897b48d-576a-44e1-4cb0-08d8b890186e x-ms-traffictypediagnostic: DM6PR12MB3243: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:291; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3UGUmK5p9GbrqjKt/5t0P6hpJEGV4TA9PqUvtEI1UANZX/utXSWtex/1zuK1NomrT0FvWgzdB5gSiHGAyiuhTSxKyV9fSUXaEjsznfRJAdnaON4OCO6fNnyua0/cT0AIrp449R0G2Cn8qGEQJQjGL9+xupSANkqCdRS0MZ6LX8Z7bthlM6kW3B+3d12GfpkxRFL7u+5NS+9Ioy42raMEA34L8vJbOeDdjgWP5AD9SFK/5mRcy31cYZzveqXo2EfxY3/GjYpmUvwO+3jmmSXq6Tfwx+N291dIjGgTifRcakdnUQGKUnTiHbW5t1ZGd6G0WD8AE1G4woBnSwNeuY6VDELJLndi06fN8ntTSYNy4w6PfwrvN5vlEf8kZNfOMnVAgWQdSE0Gg2O5Hy6zQT6TOvWIxA1NGxqdlWMEgmwS9mG7j6UN1hX6ukPr0Z1UGa7bf8JKLsfLlDccsjL0aKxAxw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR12MB2406.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(366004)(136003)(396003)(346002)(39860400002)(33656002)(2906002)(8676002)(83380400001)(45080400002)(186003)(86362001)(54906003)(6506007)(4326008)(316002)(5660300002)(55236004)(71200400001)(55016002)(9686003)(7696005)(66476007)(66556008)(8936002)(52536014)(76116006)(64756008)(66446008)(478600001)(66946007)(26005)(110136005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?iso-8859-1?Q?nXHIwdv1fnxG/0GlC/Bq2fVE4oq0CKVONwXnHMzPrRr87u6R1tCYp6xv1l?= =?iso-8859-1?Q?dhplz8NTwsvO/YMsFnoB/inVggQ+NpmLYEzKB2Yaox8rpy/wFYbonW63Ld?= =?iso-8859-1?Q?YTq+wtA2aDQVyVeVPa2pfAocXLC1iNuCHE7Uv5UXkxC5aCMDabHB8nKUvd?= =?iso-8859-1?Q?h0HIuYi4crWrauJP8tx7t4kwNq0uW3W6jq/cNejMV925RATXaVdsvv2hoF?= =?iso-8859-1?Q?RJH0OBCKcYB7u5I3zUytNcLThdGKBjSrU3Y02Esr2i66yUp0lEfl3wwM6F?= =?iso-8859-1?Q?fTeBTC7l23b8HREaLYb2GY/a6sZ2wcBWzL+zLDPt6hvYvgB3wQDjLNbckR?= =?iso-8859-1?Q?RY07asF4+oEiyrlTsjtm9OIzMqdn+H4B6vEtgqiXE14hxX1J9MPFqQqXWs?= =?iso-8859-1?Q?Ioy2MYu5wvpFBFk8m1kK887othjxSdpbYtBkvt4fjrzHeKX3ytcRWatVIB?= =?iso-8859-1?Q?zt1BKoJbAYGaMu2V5m2yCwTSpug/pRvuuojiD5Zacd1Ictpo2g6bagOn/V?= =?iso-8859-1?Q?W4v4MSzh+RSm2NdqGyk7nPHdkqZilXAxyWkPKcJKM+gP0a/C6ulOqyRLav?= =?iso-8859-1?Q?v4AfmuZyOCAJXC3QtwhLr/t07LbdryiCKcHLQgiJCuD6qzc/gegBm0bdo/?= =?iso-8859-1?Q?tpUqWbMntjMoSO00liz1r4k/WV6hdHrrd2rBratPUjHvdwNRbsIjdwkAQD?= =?iso-8859-1?Q?G1TVO/sYjdYbRE3eOI721EN+iT4rLYKADVsXW3hX7uHSTDCB+rlJpoRBwh?= =?iso-8859-1?Q?Yo2rjzwfUr8q1xXJOGnOaxagseIpO/r1o48yVn9QwSvZ/VEMlbeVMWqQyM?= =?iso-8859-1?Q?czlCg1j0TrQAXF2Q95ITf0oLBYj2tCKvf5cwp8L/iijKWURIi/7wE3IkzT?= =?iso-8859-1?Q?ahEcDZ2lIyD9YQ4gi88nYmwTbvSUxyY1Yeu3YqGskEpvkYnyt6YudkpzUW?= =?iso-8859-1?Q?HYQQsIdqXd5Nc4xqRC7/WtvRo05ZNJzv0dZljrpWcw9fQg3X3nwYtZxkG/?= =?iso-8859-1?Q?fyCLLX4WwTlCM6brI=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2406.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b897b48d-576a-44e1-4cb0-08d8b890186e X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jan 2021 13:27:09.7018 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MywOW2xaPdwdpFGe+M4GD4TJwDxJrIHROb+VrFcEwUpFE2QdtzKFAzkm8J3GSMan7qUmM/LREhCbzyaxLk5XYQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3243 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1610630839; bh=rFg46/FyLTsi2jBwLYUXSwVSqjKI2wxYkzuLuxCg72E=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=dex3XSEbSd/yq+L0PciuH6r3tLFsF02/oLcoQEANqcrU/k9is0kdhPbnkMJ02qsVz 6ukkCBzSfPW/SvoYzFb2scDyw4pHV5UoH5X1Z5dRMrG5ESec5MNCqqLGGdl5OQqwoD 1hFGAGbzt6kYni3jGb4ntpHK3n7O62/1oHibwnbORNsk6MwKji1xbgY9wtNe8ioKBO iEGccfjH/jEJL+mdx5eWQzI7CqBSotAERXbw6nneqmHcZlfC4UfG7wuGb8jg/QQie+ k9vyTx1Lbe2vK13F9ry2F8heGyPAxOqshPlVxmqAH7f299aRLKb5JaomY4xpcCu7LM 1eGUcqP45SspQ== Subject: Re: [dpdk-dev] [Bug 613] [21.02] rule lost after port stopped X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >-----Original Message----- >From: dev On Behalf Of Ferruh Yigit >Sent: Thursday, January 14, 2021 10:38 AM >To: Gregory Etelson ; Ori Kam >Cc: bugzilla@dpdk.org; dev@dpdk.org; Ajit Khaparde > >Subject: Re: [dpdk-dev] [Bug 613] [21.02] rule lost after port stopped > >On 1/14/2021 7:15 AM, bugzilla@dpdk.org wrote: >> >https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbugs >> >.dpdk.org%2Fshow_bug.cgi%3Fid%3D613&data=3D04%7C01%7Casafp%40n >vidia. >> >com%7Cfa63af2a7ee048e0ff8c08d8b867c219%7C43083d15727340c1b7db39efd >9ccc >> >17a%7C0%7C0%7C637462103068292531%7CUnknown%7CTWFpbGZsb3d8eyJ >WIjoiMC4wL >> >jAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000& >sdata >> >=3DPMbgS6CGe6etyFwI%2F7wjnNC9Fptp4%2BuMCprcJx9I3Gg%3D&reserv >ed=3D0 >> >> Bug ID: 613 >> Summary: [21.02] rule lost after port stopped >> Product: DPDK >> Version: unspecified >> Hardware: x86 >> OS: Linux >> Status: UNCONFIRMED >> Severity: normal >> Priority: Normal >> Component: testpmd >> Assignee: dev@dpdk.org >> Reporter: qinx.sun@intel.com >> Target Milestone: --- >> >> create a rule in testpmd, stop port and then flow list port find that >> rule lost. >> >> Environment >> >> DPDK version: Use make showversion or for a non-released version: git >> remote -v && git show-ref --heads >> 21.02.0-rc0:0144eeafd1467937a379a7dc005bcb0579b0ae5e >> Other software versions: name/version for QEMU, OVS, etc. Repeat as >required. >> OS: CentOS8.3 >> Compiler: gcc version 8.3.1 20191121 (Red Hat 8.3.1-5) Hardware >> platform:=A0Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz NIC hardware: >> Ethernet Controller E810-C for SFP 1593 NIC firmware:=A02.30 0x80004dcf >> 1.2839.0 NIC driver:=A01.3.0_dirty >> Pkg:=A0ice-comms_1.3.24.0 >> >> [reproduce steps] >> 1. bind to vfio-pci and create 2 vfs >> usertools/dpdk-devbind.py --force --bind=3Dvfio-pci 0000:03:00.0 echo 2 >> > /sys/bus/pci/devices/0000:03:00.0/sriov_numvfs >> >> 2. start testpmd >> x86_64-native-linuxapp-gcc/app/dpdk-testpmd -l 1,2,3,4 -n 4 -a >> 0000:03:01.0,cap=3Ddcf -a 0000:03:01.1 >> --file-prefix=3Ddpdk_1965_20210114114229 >> -- -i >> >> 3. create a rule >> testpmd> flow create 0 ingress pattern eth dst is 68:05:ca:8d:ed:a8 / >> testpmd> ipv4 src >> is 192.168.0.1 dst is 192.168.0.2 tos is 4 ttl is 3 / udp src is 25 >> dst is 23 / end actions vf id 1 / end Flow rule #1 created >> >> 4. list rule >> testpmd> flow list 0 >> ID Group Prio Attr Rule >> 0 0 0 i-- ETH IPV4 UDP =3D> VF >> >> 5.stop port 0 >> testpmd> port stop 0 >> Stopping ports... >> Checking link statuses... >> Done >> >> 6.list rule >> testpmd> flow list 0 >> testpmd> >> >> Actual Result: rule lost after port stopped >> >> Expected Result: The result of rule list is the same as step 4. >> >> Regression >> Is this issue a regression: (Y) >> >> Version the regression was introduced: Specify git id if known. >> >> commit 0f93edbf7c874480e21e365f527fecdb305984b9 >> Author: Gregory Etelson >> Date: Thu Nov 26 18:43:02 2020 +0200 >> >> app/testpmd: release flows left before port stop >> >> According to RTE flow user guide, PMD will not keep flow rules after >> port stop. Application resources that refer to flow rules become >> obsolete after port stop and must not be used. >> Testpmd maintains linked list of active flows for each port. Entries >> in that list are allocated dynamically and must be explicitly released >> to prevent memory leak. >> The patch releases testpmd port flow_list that holds remaining flows >> before port is stopped. >> >> Cc: stable@dpdk.org >> >> Signed-off-by: Gregory Etelson >> Acked-by: Ori Kam >> Acked-by: Ajit Khaparde >> > >cc'ed Gregory & Ori. This is now the expected behavior and the motivation is written in the comm= it message by Gregory.