From: Ankur Dwivedi <adwivedi@marvell.com>
To: "Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Anoob Joseph <anoobj@marvell.com>
Subject: Re: [dpdk-dev] [PATCH v2 3/3] test/event_crypto_adapter: free resources during exit
Date: Tue, 6 Oct 2020 13:00:32 +0000 [thread overview]
Message-ID: <DM5PR1801MB188407C54C30B5DB3A12427EDD0D0@DM5PR1801MB1884.namprd18.prod.outlook.com> (raw)
In-Reply-To: <MWHPR11MB18384D43DAA1762245863238E80D0@MWHPR11MB1838.namprd11.prod.outlook.com>
Hi Abhinandan,
Please see my comments inline.
Thanks
Ankur
>-----Original Message-----
>From: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>
>Sent: Tuesday, October 6, 2020 4:00 PM
>To: Ankur Dwivedi <adwivedi@marvell.com>; dev@dpdk.org
>Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Anoob Joseph
><anoobj@marvell.com>
>Subject: [EXT] RE: [PATCH v2 3/3] test/event_crypto_adapter: free resources
>during exit
>
>External Email
>
>----------------------------------------------------------------------
>
>
>> -----Original Message-----
>> From: Gujjar, Abhinandan S
>> Sent: Tuesday, October 6, 2020 3:52 PM
>> To: 'Ankur Dwivedi' <adwivedi@marvell.com>; dev@dpdk.org
>> Cc: jerinj@marvell.com; anoobj@marvell.com
>> Subject: RE: [PATCH v2 3/3] test/event_crypto_adapter: free resources
>> during exit
>>
>> Hi Ankur,
>>
>> Please see comment below.
>>
>> > -----Original Message-----
>> > From: Ankur Dwivedi <adwivedi@marvell.com>
>> > Sent: Friday, September 25, 2020 12:59 PM
>> > To: dev@dpdk.org
>> > Cc: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>;
>> > jerinj@marvell.com; anoobj@marvell.com; Ankur Dwivedi
>> > <adwivedi@marvell.com>
>> > Subject: [PATCH v2 3/3] test/event_crypto_adapter: free resources
>> > during exit
>> >
>> > The resources held by crypto adapter should be freed when the test
>> > suite exits.
>> >
>> > Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com>
>> > ---
>> > app/test/test_event_crypto_adapter.c | 15 +++++++++++++++
>> > 1 file changed, 15 insertions(+)
>> >
>> > diff --git a/app/test/test_event_crypto_adapter.c
>> > b/app/test/test_event_crypto_adapter.c
>> > index 572ef9c27..4b09ab3b7 100644
>> > --- a/app/test/test_event_crypto_adapter.c
>> > +++ b/app/test/test_event_crypto_adapter.c
>> > @@ -899,6 +899,20 @@ testsuite_setup(void)
>> > return TEST_SUCCESS;
>> > }
>> >
>> > +static void
>> > +crypto_adapter_teardown(void)
>> > +{
>> > + int ret;
>> > +
>
>Below APIs could return error. So, set this flag at the end?
[Ankur] Will make the change in v3.
>> > + crypto_adapter_setup_done = 0;
>
>> Call rte_event_crypto_adapter_stop() here?
[Ankur] Will make the change in v3.
>> > + ret =
>> > rte_event_crypto_adapter_queue_pair_del(TEST_ADAPTER_ID,
>> > + TEST_CDEV_ID, TEST_CDEV_QP_ID);
>> > + if (ret < 0)
>> > + RTE_LOG(ERR, USER1, "Failed to delete queue pair!");
>> > +
>> > + rte_event_crypto_adapter_free(TEST_ADAPTER_ID);
>> > +}
>> > +
>> > static void
>> > crypto_teardown(void)
>> > {
>> > @@ -941,6 +955,7 @@ eventdev_teardown(void) static void
>> > testsuite_teardown(void)
>> > {
>> > + crypto_adapter_teardown();
>> > crypto_teardown();
>> > eventdev_teardown();
>> > }
>> > --
>> > 2.28.0
next prev parent reply other threads:[~2020-10-06 13:00 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 9:15 [dpdk-dev] [PATCH 0/3] Bug fixes in event crypto adapter test application Ankur Dwivedi
2020-09-08 9:15 ` [dpdk-dev] [PATCH 1/3] test/event_crypto_adapter: return error with unsupported mode Ankur Dwivedi
2020-09-11 7:37 ` Gujjar, Abhinandan S
2020-09-18 7:10 ` Gujjar, Abhinandan S
2020-09-18 14:34 ` Ankur Dwivedi
2020-09-18 14:42 ` Gujjar, Abhinandan S
2020-09-18 15:03 ` Ankur Dwivedi
2020-09-23 5:31 ` Ankur Dwivedi
2020-09-23 7:17 ` Gujjar, Abhinandan S
2020-10-08 9:12 ` Jerin Jacob
2020-09-08 9:15 ` [dpdk-dev] [PATCH 2/3] test/event_crypto_adapter: fix function arguments Ankur Dwivedi
2020-09-08 9:15 ` [dpdk-dev] [PATCH 3/3] test/event_crypto_adapter: free resources during exit Ankur Dwivedi
2020-09-25 7:28 ` [dpdk-dev] [PATCH v2 0/3] Bug fixes in event crypto adapter test application Ankur Dwivedi
2020-09-25 7:28 ` [dpdk-dev] [PATCH v2 1/3] test/event_crypto_adapter: return error with unsupported mode Ankur Dwivedi
2020-09-25 7:28 ` [dpdk-dev] [PATCH v2 2/3] test/event_crypto_adapter: fix function arguments Ankur Dwivedi
2020-10-06 10:21 ` Gujjar, Abhinandan S
2020-10-06 12:57 ` Ankur Dwivedi
2020-09-25 7:28 ` [dpdk-dev] [PATCH v2 3/3] test/event_crypto_adapter: free resources during exit Ankur Dwivedi
2020-10-06 10:21 ` Gujjar, Abhinandan S
2020-10-06 10:29 ` Gujjar, Abhinandan S
2020-10-06 13:00 ` Ankur Dwivedi [this message]
2020-10-05 9:43 ` [dpdk-dev] [PATCH v2 0/3] Bug fixes in event crypto adapter test application Jerin Jacob
2020-10-05 9:48 ` Gujjar, Abhinandan S
2020-10-07 5:26 ` [dpdk-dev] [PATCH v3 0/3] Bug fixes in event crypto adapter test Ankur Dwivedi
2020-10-07 5:26 ` [dpdk-dev] [PATCH v3 1/3] test/event_crypto_adapter: return error with unsupported mode Ankur Dwivedi
2020-10-08 7:25 ` Gujjar, Abhinandan S
2020-10-07 5:26 ` [dpdk-dev] [PATCH v3 2/3] test/event_crypto_adapter: fix function arguments Ankur Dwivedi
2020-10-08 7:26 ` Gujjar, Abhinandan S
2020-10-07 5:26 ` [dpdk-dev] [PATCH v3 3/3] test/event_crypto_adapter: free resources during exit Ankur Dwivedi
2020-10-08 7:26 ` Gujjar, Abhinandan S
2020-10-08 12:52 ` [dpdk-dev] [PATCH v4 0/3] Bug fixes in event crypto adapter test Ankur Dwivedi
2020-10-08 12:52 ` [dpdk-dev] [PATCH v4 1/3] test/event_crypto_adapter: return error for unsupported mode Ankur Dwivedi
2020-10-08 12:52 ` [dpdk-dev] [PATCH v4 2/3] test/event_crypto_adapter: fix function arguments Ankur Dwivedi
2020-10-08 12:52 ` [dpdk-dev] [PATCH v4 3/3] test/event_crypto_adapter: free resources during exit Ankur Dwivedi
2020-10-08 15:00 ` [dpdk-dev] [PATCH v4 0/3] Bug fixes in event crypto adapter test Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR1801MB188407C54C30B5DB3A12427EDD0D0@DM5PR1801MB1884.namprd18.prod.outlook.com \
--to=adwivedi@marvell.com \
--cc=abhinandan.gujjar@intel.com \
--cc=anoobj@marvell.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).