From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CC0FAA04BB; Tue, 6 Oct 2020 15:00:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3D08E1B686; Tue, 6 Oct 2020 15:00:39 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 2AB201B679 for ; Tue, 6 Oct 2020 15:00:37 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 096D08XE008158; Tue, 6 Oct 2020 06:00:36 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0220; bh=lRxDLCdefBnQsKMo1B675nrgguIjIT8i+vhCWeOlcJE=; b=fNkBtJH8d+9MGJiGN+8jxlBNtzMra3UweT+QJxkeb6fFu61WVwJ32VmUaCUyUArqabdk XnjAO3fIWjMKNLuXA+t5PE5gXCLThsNNUS0I7TsSFai+2+KTPcqTdxEvXs9mr8AyLlsn 5wFZYI4fT8ETNx3thnm4V8OYNvXBUb9NXPbi+qW67SFbByQZtOd3jzBZm6BJXEujji2w 6nZgnZLD5UPyk1/ahkQrtekFqzobkSQesSLpfRN4os22YzJfIqrqUiGVt5cguoVoA8EO S9+L7q2WqO0XL7l0HpHZswz3a2dZpBj6BUW0e+kCl4VpnvUGOukU8QeQYzf7aRHDDS4b qQ== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 33xpnps068-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 06 Oct 2020 06:00:36 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 6 Oct 2020 06:00:35 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 6 Oct 2020 06:00:34 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Tue, 6 Oct 2020 06:00:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aNCVxpHzfOdL4V1BtjqFxmfNBBstnTSkwfLicFk2lOtnykGAROxfOfVrIvGUHnJCMzw4PONMAOndVGryb3Lek6hJxoxV3oSMkKucEmMsKOTuigOESnAFMNESAozrASaKI+OMTRF+s+63bnL9mqisdVc/I+9dlAf+uYcANYY+DSO0sGN9UDayHZjj8mnWbX3K11mpZgorFuRq1VyLNHjR9Hd4KnT1r/DxCFjoWss6Ef6RxA+/jMhd2hq4nXG9aGQW5VxyOk+gmzaUZZbClGWQfnTkVWVmvZh7OhgXXskj6xT6oHgi8Kmm8GP1UB7P9DgKQwZoO/ZYnLw6Ni1vRBfZrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lRxDLCdefBnQsKMo1B675nrgguIjIT8i+vhCWeOlcJE=; b=fy5aLx2ULnq3mznCA/D0YsyoPPOPOVreTL66oeyP8TnPDTCXutK0LGNzA708yJBexDczIe26HyKwMg1QG7p7AUexb6bhwG40yWSdKsVUiTN5kz50NlmBgHgb+Jt0rJqtiOTxhiAiLGe6Rl/uBpHNSKANwvpsxLFdZ/5dUpYMAs9KyNmcsCeXqDH5rb646t7fIfYPAXgmukbcRz/Ml+p6cyglynIe3NFXBcmwM3utfzUkk/0ZvXn0KeNxX4zVkVr1ik+n9fDXQOH/EZggfIP3aOKo2dfMCtw1D2wDMEWFuq5NiXBTWZWu9TGDhwqzkwbkkvkREJSis8p70tdUMxK7hQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lRxDLCdefBnQsKMo1B675nrgguIjIT8i+vhCWeOlcJE=; b=BWDxX2+LvcstaGNtggkuRDKQtZLCZv4X8Cx+HpxXDCGnmlvq47IXxDpE1khkJx8Vzn0S1HYRXCdxefIeCkJwxmV+pr6VYQ5YUkmutO5uBUM+VBIqdSq8fGhtygekqdJ9xb2+lxfeMKdmUTq0T2dKhFDc+iuAO8HyYE3arfp7Zn0= Received: from DM5PR1801MB1884.namprd18.prod.outlook.com (2603:10b6:4:65::20) by DM6PR18MB3489.namprd18.prod.outlook.com (2603:10b6:5:2ae::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.32; Tue, 6 Oct 2020 13:00:32 +0000 Received: from DM5PR1801MB1884.namprd18.prod.outlook.com ([fe80::4413:c1f2:14ef:33a3]) by DM5PR1801MB1884.namprd18.prod.outlook.com ([fe80::4413:c1f2:14ef:33a3%7]) with mapi id 15.20.3455.021; Tue, 6 Oct 2020 13:00:32 +0000 From: Ankur Dwivedi To: "Gujjar, Abhinandan S" , "dev@dpdk.org" CC: Jerin Jacob Kollanukkaran , Anoob Joseph Thread-Topic: [PATCH v2 3/3] test/event_crypto_adapter: free resources during exit Thread-Index: AQHWkw2bYWO7rwzb8E2f0tJyxgs29KmKbuyAgAACNYCAAClvMA== Date: Tue, 6 Oct 2020 13:00:32 +0000 Message-ID: References: <20200908091534.24305-1-adwivedi@marvell.com> <20200925072841.17578-1-adwivedi@marvell.com> <20200925072841.17578-4-adwivedi@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [47.15.1.112] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 71aeb1a8-b64b-490e-340d-08d869f7cee8 x-ms-traffictypediagnostic: DM6PR18MB3489: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /by2Xonxv+ve7StGMJn9K+H6yPB/vgZL1ILj3sfvnNbR3E72lZ/cvCFLhkriDHNYfd3ElmW06tOQ6nXNCWNzwqDJJ7CTh6MRQ7d6+C9XL6h6JTZNjn3amf/QoEUFZ/02b9N2gvBKe6bgOTJANAn5SqtZWlgo0UxaoNINjs/7tzMGmwlFp6ZN7FdAw7TaoWW2MuBTQLQ+bLpC5ndNpjQUYVWV05tzuVXOLKBPH1d85CdZY+9H5KtOx6KC8JRhW+i7+BTmLQb+54VSmvMqusIWJSkzGLjCXYElIlPm7QgS7VXkI2lbWupCJiNlQQBvgWRS9545q05uB5ejNZrlme4e8w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR1801MB1884.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(39860400002)(346002)(396003)(366004)(136003)(2906002)(86362001)(110136005)(316002)(186003)(4326008)(53546011)(478600001)(7696005)(26005)(33656002)(54906003)(6506007)(8676002)(8936002)(107886003)(9686003)(55016002)(66476007)(64756008)(66556008)(66446008)(71200400001)(66946007)(83380400001)(76116006)(5660300002)(52536014); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: AZ8DKevckhlQwpn/Kue2SubmyII3qXUYNgaAMbGMY29mvyD4DW/7mYTVj7y23T71vg1m+FMhrrsvTQGe5dXFnRxNri00r0F44a6AmOGWNJO9EjD5JpOELQmPlWbZTgDh8fFeVpREAo/pOyAhP/qHLeG+YHBMefRGyjk6+hRiiU8YOHz8plIpD+vpKrcDTxxB8WoOLwwNtdG6FUHXqXYsmtWLWFEsTrwl4EJtzGoL5HCCyhQR5TZ9yaARHea8K6DZ10raVb2UxzuVw9+U9YYkL1pjlh9sd03wlMetppFhqoFenQ3J9y3nSzMGWQ2WolSzFaknCmRJuk4yd52WIngr8DhugyE0A8p57NlWv5bGqaG5IXGpvfwukQrcDOoVg/b0QZq4PourA4Mga4XZ37jBCucMc1y4dRymIsvyJvGc8TR11cS3Kgb2UhVPwlZ9n3RwJYuLqKFHsNiew/8OAWRV8QxWvxb/RaowpoHRaBADorblPQcj69oCGAamLVD9EFY7KSqI+Sd4L2LX/9oubsjXXSRoKv+q3HiOBNehWY8br1Edp8GBUo26b/jn1T/omI2glcAAEPFqu0+qtFFmvp5UeHp/yYk7xJ0rg/z2040XCmZKsJ8Nq2eBgeXXb5zQkckgYDqgeiIoOpAcGhkT3D1Q/A== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR1801MB1884.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 71aeb1a8-b64b-490e-340d-08d869f7cee8 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Oct 2020 13:00:32.0318 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2TNb8wYvbDgax/XFDpKXpsQTxQZXIDzn1yg0gSYn6yUDsL7avf0K6M2ediywionVOekG0344xBjCfoF49CTDEg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB3489 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-10-06_05:2020-10-06, 2020-10-06 signatures=0 Subject: Re: [dpdk-dev] [PATCH v2 3/3] test/event_crypto_adapter: free resources during exit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Abhinandan, Please see my comments inline. Thanks Ankur >-----Original Message----- >From: Gujjar, Abhinandan S >Sent: Tuesday, October 6, 2020 4:00 PM >To: Ankur Dwivedi ; dev@dpdk.org >Cc: Jerin Jacob Kollanukkaran ; Anoob Joseph > >Subject: [EXT] RE: [PATCH v2 3/3] test/event_crypto_adapter: free resource= s >during exit > >External Email > >---------------------------------------------------------------------- > > >> -----Original Message----- >> From: Gujjar, Abhinandan S >> Sent: Tuesday, October 6, 2020 3:52 PM >> To: 'Ankur Dwivedi' ; dev@dpdk.org >> Cc: jerinj@marvell.com; anoobj@marvell.com >> Subject: RE: [PATCH v2 3/3] test/event_crypto_adapter: free resources >> during exit >> >> Hi Ankur, >> >> Please see comment below. >> >> > -----Original Message----- >> > From: Ankur Dwivedi >> > Sent: Friday, September 25, 2020 12:59 PM >> > To: dev@dpdk.org >> > Cc: Gujjar, Abhinandan S ; >> > jerinj@marvell.com; anoobj@marvell.com; Ankur Dwivedi >> > >> > Subject: [PATCH v2 3/3] test/event_crypto_adapter: free resources >> > during exit >> > >> > The resources held by crypto adapter should be freed when the test >> > suite exits. >> > >> > Signed-off-by: Ankur Dwivedi >> > --- >> > app/test/test_event_crypto_adapter.c | 15 +++++++++++++++ >> > 1 file changed, 15 insertions(+) >> > >> > diff --git a/app/test/test_event_crypto_adapter.c >> > b/app/test/test_event_crypto_adapter.c >> > index 572ef9c27..4b09ab3b7 100644 >> > --- a/app/test/test_event_crypto_adapter.c >> > +++ b/app/test/test_event_crypto_adapter.c >> > @@ -899,6 +899,20 @@ testsuite_setup(void) >> > return TEST_SUCCESS; >> > } >> > >> > +static void >> > +crypto_adapter_teardown(void) >> > +{ >> > + int ret; >> > + > >Below APIs could return error. So, set this flag at the end? [Ankur] Will make the change in v3. >> > + crypto_adapter_setup_done =3D 0; > >> Call rte_event_crypto_adapter_stop() here? [Ankur] Will make the change in v3. >> > + ret =3D >> > rte_event_crypto_adapter_queue_pair_del(TEST_ADAPTER_ID, >> > + TEST_CDEV_ID, TEST_CDEV_QP_ID); >> > + if (ret < 0) >> > + RTE_LOG(ERR, USER1, "Failed to delete queue pair!"); >> > + >> > + rte_event_crypto_adapter_free(TEST_ADAPTER_ID); >> > +} >> > + >> > static void >> > crypto_teardown(void) >> > { >> > @@ -941,6 +955,7 @@ eventdev_teardown(void) static void >> > testsuite_teardown(void) >> > { >> > + crypto_adapter_teardown(); >> > crypto_teardown(); >> > eventdev_teardown(); >> > } >> > -- >> > 2.28.0