From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 501E7A04B1; Wed, 23 Sep 2020 07:31:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2FD551D5F3; Wed, 23 Sep 2020 07:31:41 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id C46821D5E0 for ; Wed, 23 Sep 2020 07:31:39 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 08N5QlqS002128; Tue, 22 Sep 2020 22:31:39 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0220; bh=T6SklrJPgeqAPj/CK3VSCD8XL2GSOuk3kUIUquVCLWM=; b=Dy4StH4Hxa0woUlBMoQNPSRzpfnz5q2QW+MGdNWRHzNPWENbUL5gpGDeIzAO6vaI8Zcd pxnTs99rCllX4QlB7kjoVFw1ja9udIexybM+3Ic/YjDcXvquWBjP70hRtyqKV4Wdt2dI RMGveUh5Qvdlt68GzQbmFhKn62uel04ftEoV1OUok6GzcTY/zBe302XYmZ2ncXawT//D GchyvVnx0KW/LyrYbjq8s7dNxyoWidT6fidbTY/HpPdzuSd5LD8TZomS8M7DD0nymLAb xGboMaYbw2CNe5qyu3oGW88KZE28Bh1F5yLCSjRziq0LUUiMO6ECGLP1Jfq8Yv1Y9ek7 7w== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0b-0016f401.pphosted.com with ESMTP id 33nhgndb86-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 22 Sep 2020 22:31:39 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 22 Sep 2020 22:31:37 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 22 Sep 2020 22:31:36 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.173) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Tue, 22 Sep 2020 22:31:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PMdQ0o6D1sYmvhilzt5jcyix8T8yJT4AevU8m9XdgyefrSSazqfPkbGxFK5kSwhl/kU3kuxV6k86dnrKiSSqJ1Hi4yteWf/SeNpGnhFZfQ5kEeAqB5Mf9NBRTXcZq8yTAQjXyKMBdt+fdLImiwpM0eXRmKNUSUQUDNq/Ad266XwJl3e7qBTCTEu4OtKxNeUw1yprc5CSpEkbIcPMRwGR9rNDInPn0Lz6ZltWbsZtGLqMY2xIlkMCFZKiEDQqsSR7MSwlMRU+RHfpsneyemgmFvPYn00NadiE7dSYMRVfQXH3Bj8X62M2Dw/SbCQjClONTV9EalcL8ZKP5Uk5nzcI0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T6SklrJPgeqAPj/CK3VSCD8XL2GSOuk3kUIUquVCLWM=; b=HolL322kpsGG4cBWP5bSpliWgx0ZAOh8pmEyRLxa8MH4Jh6P5aEGWY7YJDotnMVFd2jXAlyLwedtaXdMzRWLL/ghK6XSdNZLcj2oyejWqPgCQV2dA5RAYWaDRt6zVDA9jSaWPQlKmOqz2KxIvDQFI8gWw7++cUI/9lCVHNI9cZr/NBz7/GaX+vyS6PEZZF5JtDbZ9PBFPaZbUP8KAIsIa9rc0X4SYvY1BKllf8tUFlkK+6v0fm8pTMgLoQDRpqE2qMWVPQJU1AD67yr89dRdr8jOhsKHRuz7M6+Eh39bUecpwGWy7pjYdgJgudyWOFcsICobYSdmSJWyBXgqw5SP0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T6SklrJPgeqAPj/CK3VSCD8XL2GSOuk3kUIUquVCLWM=; b=a6JvAoXVQrXx2E2DSM88d98M37ctSXxbzEvKqtBrBdNF2NS56qoKnsB9EGbeD4RVAq2XQDN0NO0mjYi6mBHTxFcvtmP7OMh5AfdNoBwpfIEWUZ4ac0/f2bMbLOeF/bIQdoNEd9ZFOaOSNvAd+awszUFW3nKqqdBeJ8i1vficgKo= Received: from DM5PR1801MB1884.namprd18.prod.outlook.com (2603:10b6:4:65::20) by DM6PR18MB2938.namprd18.prod.outlook.com (2603:10b6:5:172::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.19; Wed, 23 Sep 2020 05:31:35 +0000 Received: from DM5PR1801MB1884.namprd18.prod.outlook.com ([fe80::a57b:7214:a81b:3ed7]) by DM5PR1801MB1884.namprd18.prod.outlook.com ([fe80::a57b:7214:a81b:3ed7%6]) with mapi id 15.20.3391.026; Wed, 23 Sep 2020 05:31:35 +0000 From: Ankur Dwivedi To: "Gujjar, Abhinandan S" , "dev@dpdk.org" CC: Jerin Jacob Kollanukkaran , Anoob Joseph Thread-Topic: [PATCH 1/3] test/event_crypto_adapter: return error with unsupported mode Thread-Index: AQHWhcCt9/oUPrlD5EGZV5j4/IdhRKljETmAgAr44YCAAHdJUIAABweAgAAD6kCABzsV0A== Date: Wed, 23 Sep 2020 05:31:35 +0000 Message-ID: References: <20200908091534.24305-1-adwivedi@marvell.com> <20200908091534.24305-2-adwivedi@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [157.40.9.19] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7b0be91c-8155-4ba8-d524-08d85f81efeb x-ms-traffictypediagnostic: DM6PR18MB2938: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YuMEObHdKZXV4QxFOOrl0938vShsFWE3k7SvLYdNlZL6dEGS726h45ZW/a3Owq1Xo7mOyUFyzj7sZZjdggKD6sB66Sno2VHTYb1F2EsxdOCPBet+VE0tv9zC/8LqDm61uJT4oD1ZEczq9g/UTRwlAB6EEHw4VRGjYbQr6nVpNbL0kcl8uI7mYiZttYKsklMIidpSpxXCbybOcW3TWmAfVsbN9GKySr8JB0HrwVeWCP25aZ5AuKdS4YivDqyVBWHl5zbTBBoTBAUmS6O4Ws6IwpFrlxpuWK1ScLN+awYflTrkGKk49OUTq1V6OnfifDOJzCeG99v8AoiuJzc7exUvbOoaXAYiCl9XS+CGI4i9j8uWL8E+A/t4UO9DYpV0iuEM x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR1801MB1884.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(346002)(136003)(39850400004)(396003)(376002)(4326008)(33656002)(478600001)(6506007)(53546011)(7696005)(55016002)(107886003)(8936002)(2906002)(9686003)(8676002)(26005)(54906003)(316002)(83380400001)(52536014)(5660300002)(66556008)(66446008)(64756008)(66946007)(66476007)(71200400001)(86362001)(76116006)(110136005)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: p4+SQ2iwMZzYPcktR3XD7OJMY0TW/Z/y0xGMqZlmxjyRtS5pjgsFFT9s5QguR+/EhZy/EOEj/Cg+LZuUjoLQERvKCsIXdp2+nixhlXJ3KImtIH7LYsP0NLzmEu1njifgm++2pFzSZti6U9+TPujnpR5NTUS/Kdqk9fkMIyygEloaTANdEAPBT5V5iq15s7wMcPBD8UhWQrzbjh3WDbBlM6bUwz5DE/tIayVcEI0uvmxTlY14Ou59yA5/gia47S6ULXiUi3VGcQJMjUnyLI8pHIFR5T0hUnMijrpw+0Rxkda2jv1YGisH8Aa3MTPt2iwdISJD8ChwI061xyYQ/Kk7yXimIA34R79KGdIyUJDWueKS1sKoL1WJb+GkminRgJAIvtJGuKwXn+RPe4OmFN17mulwkkhhPP3aa72ylvBfJ+Uds7/6gBwlw/hr0dDay9bQAwUOylqo6vLR8ndNNStjaOGTTN33K/S+iQ9MmY/p45R082hZDawIRklYqjjZqrdJxb7dT9AcYXj+3EW3EN/ZjA/NYds+ms1Yx8M2LO4MZ5c9Iuypt+6paxQnXdBKMHWWRPKC1fIYBOBkT0KNEteEcXY9fF1y4/XG7w+LeBNp/lDDtXhyy1IMbHQGO2KtrZFdBwOXlGQ0nfGxfUwlgw0deA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR1801MB1884.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7b0be91c-8155-4ba8-d524-08d85f81efeb X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Sep 2020 05:31:35.2635 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ICKGszWkpqOoJzx2KqYRj3bFKvJ2U+GtiL2gf8GMeqhZSpvPbhoxqg+rEFHV1zZyW+T4tZhqGmaoa3XjbE0biw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB2938 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-09-23_03:2020-09-21, 2020-09-23 signatures=0 Subject: Re: [dpdk-dev] [PATCH 1/3] test/event_crypto_adapter: return error with unsupported mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Abhinandan, Please see my comments inline. Thanks Ankur >-----Original Message----- >From: Ankur Dwivedi >Sent: Friday, September 18, 2020 8:34 PM >To: 'Gujjar, Abhinandan S' ; dev@dpdk.org >Cc: Jerin Jacob Kollanukkaran ; Anoob Joseph > >Subject: RE: [PATCH 1/3] test/event_crypto_adapter: return error with >unsupported mode > >Hi Abhinandan, > >Please see my comments inline. > >Thanks >Ankur > >>-----Original Message----- >>From: Gujjar, Abhinandan S >>Sent: Friday, September 18, 2020 8:13 PM >>To: Ankur Dwivedi ; dev@dpdk.org >>Cc: Jerin Jacob Kollanukkaran ; Anoob Joseph >> >>Subject: [EXT] RE: [PATCH 1/3] test/event_crypto_adapter: return error >>with unsupported mode >> >>External Email >> >>---------------------------------------------------------------------- >>Hi Ankur, >> >>Please see comments inline. >> >>Regards >>Abhinandan >> >>> -----Original Message----- >>> From: Ankur Dwivedi >>> Sent: Friday, September 18, 2020 8:05 PM >>> To: Gujjar, Abhinandan S ; dev@dpdk.org >>> Cc: Jerin Jacob Kollanukkaran ; Anoob Joseph >>> >>> Subject: RE: [PATCH 1/3] test/event_crypto_adapter: return error with >>> unsupported mode >>> >>> Hi Abhinandan, >>> >>> Please see my comments inline. >>> >>> Thanks >>> Ankur >>> >>> >-----Original Message----- >>> >From: Gujjar, Abhinandan S >>> >Sent: Friday, September 18, 2020 12:41 PM >>> >To: Ankur Dwivedi ; dev@dpdk.org >>> >Cc: Jerin Jacob Kollanukkaran ; Anoob Joseph >>> > >>> >Subject: [EXT] RE: [PATCH 1/3] test/event_crypto_adapter: return >>> >error with unsupported mode >>> > >>> >External Email >>> > >>> >-------------------------------------------------------------------- >>> >- >>> >- >>> >Hi Ankur, >>> > >>> >This patch requires minor change. Please find the comment inline. >>> > >>> >> -----Original Message----- >>> >> From: Gujjar, Abhinandan S >>> >> Sent: Friday, September 11, 2020 1:07 PM >>> >> To: Ankur Dwivedi ; dev@dpdk.org >>> >> Cc: jerinj@marvell.com; anoobj@marvell.com >>> >> Subject: RE: [PATCH 1/3] test/event_crypto_adapter: return error >>> >> with unsupported mode >>> >> >>> >> Acked-by: abhinandan.gujjar@intel.com (For series) >>> >> >>> >> > -----Original Message----- >>> >> > From: Ankur Dwivedi >>> >> > Sent: Tuesday, September 8, 2020 2:46 PM >>> >> > To: dev@dpdk.org >>> >> > Cc: Gujjar, Abhinandan S ; >>> >> > jerinj@marvell.com; anoobj@marvell.com; Ankur Dwivedi >>> >> > >>> >> > Subject: [PATCH 1/3] test/event_crypto_adapter: return error >>> >> > with unsupported mode >>> >> > >>> >> > The capability of a event device should be checked before >>> >> > creating a event crypto adapter in a particular mode. The test >>> >> > case returns error if the mode is not supported. >>> >> > >>> >> > Signed-off-by: Ankur Dwivedi >>> >> > --- >>> >> > app/test/test_event_crypto_adapter.c | 30 >>> >> > ++++++++++++++++++---------- >>> >> > 1 file changed, 20 insertions(+), 10 deletions(-) >>> >> > >>> >> > diff --git a/app/test/test_event_crypto_adapter.c >>> >> > b/app/test/test_event_crypto_adapter.c >>> >> > index 8d42462d8..930c2a9bc 100644 >>> >> > --- a/app/test/test_event_crypto_adapter.c >>> >> > +++ b/app/test/test_event_crypto_adapter.c >>> >> > @@ -750,15 +750,23 @@ configure_event_crypto_adapter(enum >>> >> > rte_event_crypto_adapter_mode mode) >>> >> > uint32_t cap; >>> >> > int ret; >>> >> > >>> >> > + ret =3D rte_event_crypto_adapter_caps_get(evdev, >TEST_CDEV_ID, >>> >> > &cap); >>> >> > + TEST_ASSERT_SUCCESS(ret, "Failed to get adapter >>> >> > +capabilities\n"); >>> >> > + >>> >> > + if ((mode =3D=3D RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD) >&& >>> >> > + !(cap & >>> >> > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD)) >>> >> > + return -ENOTSUP; >>> >> > + >>> >> > + if ((mode =3D=3D RTE_EVENT_CRYPTO_ADAPTER_OP_NEW) && >>> >> > + !(cap & >>> >> > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW)) >>> >> > + return -ENOTSUP; >>> >> > + >>> >SW adapter does not have *_INTERNAL_PORT_* caps. Just noticed test >>> >was failing here. >>> >Could you please bypass this check for "event_sw" and repost the patch= ? >>> [Ankur] I was thinking of handling this by reading >>> rte_eventdevs[evdev].data->name. >>> If the name matches event_sw0(which is the default device name), I >>> will bypass if checks. >>> Can the event_sw device name be anything else? >>> Or, if there is a better way of handling this please let me know. >>Yes. You can also use rte_event_dev_info_get(evdev, &info) and check >>info.driver_name for "event_sw". >[Ankur] Thanks for the suggestion. I will try this and make the required >changes in v2. [Ankur] I thought of an alternative to implement the above. If the capabili= ty=20 does not have any *_INTERNAL_PORT_* caps, it will be a SW PMD. Is this corr= ect?=20 In that case capability will be used to skip the if checks instead of the p= md specific name comparison. Please let me know your thoughts on this. >> >>> > >>> >> > /* Create adapter with default port creation callback */ >>> >> > ret =3D rte_event_crypto_adapter_create(TEST_ADAPTER_ID, >>> >> > - TEST_CDEV_ID, >>> >> > + evdev, >>> >> > &conf, mode); >>> >> > TEST_ASSERT_SUCCESS(ret, "Failed to create event crypto >>> >> adapter\n"); >>> >> > >>> >> > - ret =3D rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, >>> >> > evdev, &cap); >>> >> > - TEST_ASSERT_SUCCESS(ret, "Failed to get adapter >capabilities\n"); >>> >> > - >>> >> > if (cap & >>> >> > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_QP_EV_BIND) { >>> >> > ret =3D >>> >> > rte_event_crypto_adapter_queue_pair_add(TEST_ADAPTER_ID, >>> >> > TEST_CDEV_ID, TEST_CDEV_QP_ID, >>> &response_info); @@ -813,6 >>> >> > +821,8 @@ test_crypto_adapter_conf(enum >>> >> > rte_event_crypto_adapter_mode mode) >>> >> > TEST_ASSERT(ret >=3D 0, "Failed to link queue >%d " >>> >> > "port=3D%u\n", qid, >>> >> > > params.crypto_event_port_id); >>> >> > + } else { >>> >> > + return ret; >>> >> > } >>> >> > crypto_adapter_setup_done =3D 1; >>> >> > } >>> >> > @@ -845,24 +855,24 @@ static int >>> >> > test_crypto_adapter_conf_op_forward_mode(void) >>> >> > { >>> >> > enum rte_event_crypto_adapter_mode mode; >>> >> > + int ret; >>> >> > >>> >> > mode =3D RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD; >>> >> > - TEST_ASSERT_SUCCESS(test_crypto_adapter_conf(mode), >>> >> > - "Failed to config crypto adapter"); >>> >> > + ret =3D test_crypto_adapter_conf(mode); >>> >> > >>> >> > - return TEST_SUCCESS; >>> >> > + return ret; >>> >> > } >>> >> > >>> >> > static int >>> >> > test_crypto_adapter_conf_op_new_mode(void) >>> >> > { >>> >> > enum rte_event_crypto_adapter_mode mode; >>> >> > + int ret; >>> >> > >>> >> > mode =3D RTE_EVENT_CRYPTO_ADAPTER_OP_NEW; >>> >> > - TEST_ASSERT_SUCCESS(test_crypto_adapter_conf(mode), >>> >> > - "Failed to config crypto adapter"); >>> >> > + ret =3D test_crypto_adapter_conf(mode); >>> >> > >>> >> > - return TEST_SUCCESS; >>> >> > + return ret; >>> >> > } >>> >> > >>> >> > >>> >> > -- >>> >> > 2.28.0