Re: [dpdk-dev] [PATCH] test/event_crypto_adapter: set cipher operation in transform

[Ankur Dwivedi <adwivedi@marvell.com>]

Hi Abhinandan,

>-----Original Message-----
>From: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>
>Sent: Monday, January 18, 2021 2:42 PM
>To: Ankur Dwivedi <adwivedi@marvell.com>; dev@dpdk.org
>Cc: stable@dpdk.org; akhil.goyal@nxp.com; Anoob Joseph
><anoobj@marvell.com>
>Subject: [EXT] RE: [PATCH] test/event_crypto_adapter: set cipher operation in
>transform
>
>External Email
>
>----------------------------------------------------------------------
>Hi Ankur,
>
>> -----Original Message-----
>> From: Ankur Dwivedi <adwivedi@marvell.com>
>> Sent: Friday, January 8, 2021 2:11 PM
>> To: dev@dpdk.org
>> Cc: stable@dpdk.org; Gujjar, Abhinandan S
>> <abhinandan.gujjar@intel.com>; akhil.goyal@nxp.com;
>> anoobj@marvell.com; Ankur Dwivedi <adwivedi@marvell.com>
>> Subject: [PATCH] test/event_crypto_adapter: set cipher operation in
>> transform
>>
>> The cipher operation in the transform should be set to encrypt.
>>
>> Fixes: 74449375237f ("test/event_crypto_adapter: fix configuration")
>>
>> Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com>
>> ---
>>  app/test/test_event_crypto_adapter.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/app/test/test_event_crypto_adapter.c
>> b/app/test/test_event_crypto_adapter.c
>> index a0169aa6cf..335211cd8c 100644
>> --- a/app/test/test_event_crypto_adapter.c
>> +++ b/app/test/test_event_crypto_adapter.c
>> @@ -183,6 +183,7 @@ test_op_forward_mode(uint8_t session_less)
>>  	cipher_xform.type = RTE_CRYPTO_SYM_XFORM_CIPHER;
>>  	cipher_xform.next = NULL;
>>  	cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_NULL;
>> +	cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT;
>NULL PMD does not refer " RTE_CRYPTO_CIPHER_OP_ENCRYPT ". Is your test
>code failing without this change?
[Ankur] Yes the test is failing, because in octeontx2 crypto pmd, during crypto session configure there is a check for the cipher xform op. If the op does not match either encrypt or decrypt, the session configure fails.
>>
>>  	op = rte_crypto_op_alloc(params.op_mpool,
>>  			RTE_CRYPTO_OP_TYPE_SYMMETRIC);
>> @@ -382,6 +383,7 @@ test_op_new_mode(uint8_t session_less)
>>  	cipher_xform.type = RTE_CRYPTO_SYM_XFORM_CIPHER;
>>  	cipher_xform.next = NULL;
>>  	cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_NULL;
>> +	cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT;
>>
>>  	op = rte_crypto_op_alloc(params.op_mpool,
>>  			RTE_CRYPTO_OP_TYPE_SYMMETRIC);
>> --
>> 2.28.0