From: Ankur Dwivedi <adwivedi@marvell.com>
To: Akhil Goyal <akhil.goyal@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "declan.doherty@intel.com" <declan.doherty@intel.com>,
Anoob Joseph <anoobj@marvell.com>
Subject: Re: [dpdk-dev] [PATCH 7/7] test/crypto: use generic cryptotests for OCTEON TX PMDs
Date: Thu, 2 Jul 2020 13:15:30 +0000 [thread overview]
Message-ID: <DM5PR1801MB1884D3E4F080C06EA8D448A5DD6D0@DM5PR1801MB1884.namprd18.prod.outlook.com> (raw)
In-Reply-To: <VI1PR04MB31685B877D2543CC888167A3E66C0@VI1PR04MB3168.eurprd04.prod.outlook.com>
Hi Akhil,
Please see my response inline.
Thanks
Ankur
>-----Original Message-----
>From: Akhil Goyal <akhil.goyal@nxp.com>
>Sent: Thursday, July 2, 2020 1:53 AM
>To: Ankur Dwivedi <adwivedi@marvell.com>; dev@dpdk.org
>Cc: declan.doherty@intel.com; Anoob Joseph <anoobj@marvell.com>
>Subject: [EXT] RE: [PATCH 7/7] test/crypto: use generic cryptotests for OCTEON
>TX PMDs
>
>External Email
>
>----------------------------------------------------------------------
>Hi Anoob/Ankur,
>> From: Anoob Joseph <anoobj@marvell.com>
>>
>> This patch enables the generic crypto tests for OCTEON TX PMDs.
>> Reomves the PMD specific tests.
>
>Spell check.
[Ankur] Will address this in v2.
>
>>
>> Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com>
>> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
>> ---
>> app/test/test_cryptodev.c | 769
>> +---------------------------------------------
>> 1 file changed, 2 insertions(+), 767 deletions(-)
>>
>
>Please split this patch into two patches. When I try to apply this patch, The
>contents of this patch gets changed. I believe a lot of similar lines of Code
>make git confused and it jumble up the code.
>So probably, you can remove the PMD specific cases in one patch and
>Testsuite in the other one.
[Ankur] Will address this in v2.
>
>Rename the title of the patch as
>test/crypto: use generic testsuite for OCTEON TX/TX2
[Ankur] Will address this in v2.
next prev parent reply other threads:[~2020-07-02 13:15 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 5:38 [dpdk-dev] [PATCH 0/7] test/crypto: use generic crypto auto test framework Ankur Dwivedi
2020-06-11 5:38 ` [dpdk-dev] [PATCH 1/7] common/cpt: fix encryption offset Ankur Dwivedi
2020-07-01 20:24 ` Akhil Goyal
2020-07-02 13:18 ` Ankur Dwivedi
2020-06-11 5:38 ` [dpdk-dev] [PATCH 2/7] crypto/octeontx: remove stats callback Ankur Dwivedi
2020-06-11 5:38 ` [dpdk-dev] [PATCH 3/7] crypto/octeontx: set session private data Ankur Dwivedi
2020-06-11 5:38 ` [dpdk-dev] [PATCH 4/7] crypto/octeontx2: " Ankur Dwivedi
2020-06-11 5:38 ` [dpdk-dev] [PATCH 5/7] crypto/octeontx: remove unsupported feature Ankur Dwivedi
2020-07-01 20:27 ` Akhil Goyal
2020-07-02 13:20 ` Ankur Dwivedi
2020-06-11 5:38 ` [dpdk-dev] [PATCH 6/7] crypto/octeontx2: " Ankur Dwivedi
2020-06-11 5:38 ` [dpdk-dev] [PATCH 7/7] test/crypto: use generic cryptotests for OCTEON TX PMDs Ankur Dwivedi
2020-07-01 20:23 ` Akhil Goyal
2020-07-02 13:15 ` Ankur Dwivedi [this message]
2020-07-03 5:41 ` [dpdk-dev] [PATCH v2 1/8] common/cpt: fix encryption offset Ankur Dwivedi
2020-07-03 5:41 ` [dpdk-dev] [PATCH v2 2/8] crypto/octeontx: remove stats callback Ankur Dwivedi
2020-07-03 5:41 ` [dpdk-dev] [PATCH v2 3/8] crypto/octeontx: set session private data Ankur Dwivedi
2020-07-03 5:41 ` [dpdk-dev] [PATCH v2 4/8] crypto/octeontx2: " Ankur Dwivedi
2020-07-03 5:41 ` [dpdk-dev] [PATCH v2 5/8] crypto/octeontx: revert non-byte aligned data feature Ankur Dwivedi
2020-07-03 5:41 ` [dpdk-dev] [PATCH v2 6/8] crypto/octeontx2: " Ankur Dwivedi
2020-07-03 5:41 ` [dpdk-dev] [PATCH v2 7/8] test/crypto: remove PMD specific tests Ankur Dwivedi
2020-07-03 5:41 ` [dpdk-dev] [PATCH v2 8/8] test/crypto: use generic testsuite for OCTEON TX/TX2 Ankur Dwivedi
2020-07-04 19:57 ` [dpdk-dev] [PATCH v2 1/8] common/cpt: fix encryption offset Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR1801MB1884D3E4F080C06EA8D448A5DD6D0@DM5PR1801MB1884.namprd18.prod.outlook.com \
--to=adwivedi@marvell.com \
--cc=akhil.goyal@nxp.com \
--cc=anoobj@marvell.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).