From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B3A7DA04B5; Fri, 18 Sep 2020 17:03:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 319061D95C; Fri, 18 Sep 2020 17:03:48 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 512981D937 for ; Fri, 18 Sep 2020 17:03:46 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 08IF11Gk006491; Fri, 18 Sep 2020 08:03:45 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0220; bh=3HsNuvVyj6y2k2lzAoFBY54kgLWZJHFSCrle7bPDmVo=; b=TKY2O5boJhurMAwX9Fcj3Zcl4PSt80crZaqMOnmBlK0APE7ucapmLGGx+xME/ERd4oqr ilgMJ5MIg+xTkMpwHOONrRGHrvLDuFDxie5WL6rl9q9a8Ty9mcvnuFOQG8XYdAwnETtY /DtCyWvLBqELK8edwV3ghpgrzJdJimyzSHEePB0iPA3ciunjmE6vtMvySuvqdLZcWjdu T+JhsaNBX2UobRd0UYsLgKM+Sw/nqzHqX/P0yvqQBaHUnyrqmVeRZOgAlN7UliuvlBv6 DSrm7X51YSHevWCU8uj4eFJgZKIwIk5RPVnRhi2mRETeWM9ZaFO4TgpWNhy1g1Q7allL qA== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0a-0016f401.pphosted.com with ESMTP id 33m73mvy9k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Fri, 18 Sep 2020 08:03:45 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 18 Sep 2020 08:03:44 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 18 Sep 2020 08:03:43 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.177) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Fri, 18 Sep 2020 08:03:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gEuQIh+POMHVe65ZLme7G6RRZSKhyf70CRGGj/Agd+GbpwcLun42rNB97X/sxWEat8qvJJ+z76M0w4NNx5P+yE8LBuioRPGdBjc5lrJbIFFeWeio71PQbDVKa/1M3/K0xWK+tcojLSLZ9ND5YqMLAERbi1G5Kk3tvPLr31kAV5rrv5U+7BxDgZcB4uqZRuGnohBAnVAYOqnjFZArwF8+Kvs50+Wj5y1JP5ch5uXvfjgy8kqrvnTL8A2YDzxvZ45mYjm6RFolooYcY6REAuXLNMeLXyvQnLn+rFPLU47ZwUlkIltqplLv+jmdqv3+lekg4RjnHUjNZjJ1Z3z/GjNgKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3HsNuvVyj6y2k2lzAoFBY54kgLWZJHFSCrle7bPDmVo=; b=hoxk1x0u1jia1rP4AfQ14UENey79795A12jMyRU6b1ozIbaEWYBpBCdH4DV0vedNMDcMI5YB8AJ2+Y/8ZE2tqCMbJsdLFu4SiSABryojlHx7IA+djbY/51As+CbtNNRTDF09d/Ef/3Z79tXs+GqB0ccNKdTQ4mNPVH36FTdp9SRNkucaraukrd620l/TUtFcFUKWg6Bdpz+/0qUBd56CGzipkV8X/abnje6pLlDUYdKhg+D+WweLP2yTKdH8vhFRu81cROohTNQuhD5DlFIrckbUUN7NWGXxt1sf3N3OSlyW2QB5UYqhp9v/ioF/orPPpdARacI8poZAc8igDZIAng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3HsNuvVyj6y2k2lzAoFBY54kgLWZJHFSCrle7bPDmVo=; b=N/a7K72WB1lk/iMShDVTDqdqSYkuyHRcPRviH1xNzLw1zf7HtbHUafDs4YJku1nU9b7D6yPvdfU9bLkUmRYZ/OFoFhGRGLI6egm8vjP/ZI71Voa61zC7RmjTsO/Oj4jFWH/kp5Ivog5kGTdGhECkljguu6NXxEHPhLWt2vKmAvo= Received: from DM5PR1801MB1884.namprd18.prod.outlook.com (2603:10b6:4:65::20) by DM5PR18MB0970.namprd18.prod.outlook.com (2603:10b6:3:2e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.11; Fri, 18 Sep 2020 15:03:41 +0000 Received: from DM5PR1801MB1884.namprd18.prod.outlook.com ([fe80::a57b:7214:a81b:3ed7]) by DM5PR1801MB1884.namprd18.prod.outlook.com ([fe80::a57b:7214:a81b:3ed7%6]) with mapi id 15.20.3391.014; Fri, 18 Sep 2020 15:03:41 +0000 From: Ankur Dwivedi To: "Gujjar, Abhinandan S" , "dev@dpdk.org" CC: Jerin Jacob Kollanukkaran , Anoob Joseph Thread-Topic: [PATCH 1/3] test/event_crypto_adapter: return error with unsupported mode Thread-Index: AQHWhcCt9/oUPrlD5EGZV5j4/IdhRKljETmAgAr44YCAAHdJUIAABweAgAAD6kA= Date: Fri, 18 Sep 2020 15:03:40 +0000 Message-ID: References: <20200908091534.24305-1-adwivedi@marvell.com> <20200908091534.24305-2-adwivedi@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [47.15.27.212] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c9467c46-5438-437c-090d-08d85be407a2 x-ms-traffictypediagnostic: DM5PR18MB0970: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Y7sDxlG5o8v95XnoTcV5xfF81E0xwsCv7hQL5zEzwEHPmYNtUw42vve1Y3CSIjQJbNy8Tv6GbDHg8hl+R84eRpQjiMTVfKPVAVGhPHMuS41ak0xlLnHHIw0DkRp8XfGAz7OsVuSAsPWZBDd0EG2NOpc8gnzxyFFCdCqvg2LqceIZSy/bX5G8ygHlUFu9CTrcbDyEapD3Xly6Y+NC2nnlsQAL/z/kUI5GZUQk/C7YenQneaKFmRVq/FQlii9VtgY5CT0gTfk07brn1z75scbpUMwl85MyolYBXKIYUcwtqDZ4hnPjB1Vw7c3iNGPUFokg x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR1801MB1884.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(39860400002)(376002)(366004)(346002)(316002)(9686003)(6506007)(8936002)(53546011)(478600001)(2906002)(33656002)(83380400001)(26005)(186003)(52536014)(86362001)(5660300002)(8676002)(107886003)(4326008)(66946007)(55016002)(66446008)(64756008)(66476007)(66556008)(71200400001)(76116006)(110136005)(54906003)(7696005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: viYooF3ChVBG1z/i6K8/hriSlDS/5t2/no2DS6D1vJXTLQPZhUuwtS2maoyqPzMOV3KSxkhxkkBFxI6ltYHr81PbRpsy2fqz8CH0oOJOei/61wPE8YZW+TsBX+s70e871ozObaN711EU0grPFDxvJFTJMZcd5PXJVyEhrNnWZJcp+n04gNrXxoHdAs1FfpEAfIjdnkCCPRDdXXISs+3JbvV6FMgALdjr43J3xtn2hUBmqsYS1cr1A3251sMxZ9r8+MXMYZ3FYe5ZWL/c3xBuvpAYM34NcdANeyyK7VEtWkFVerznXhqzJgwoaQc+0ODjcAWOeDfV15tInR7NK81txmNdmIpv0HpHYblKDyo/zLGTrYxgnji0L9kaxRWDszo+hcE1V2IvVZSjRXGPb7l9wDTSkfa9I/0WLFvKz9MG07PaHESyx95ZZDL1C/Gi0w3q89QubcMQxDe+QSApaiq2SC1ra04n0COdVl61Urs6Icnf0+7DDdXBzoQeaJ48UqobEj9rPKtcpIqiafgQEBxqswk1cztSdBwkp9XXK1of4FtVEMue417Eol+/K8FyDbQR7GU9cYMWwKnBSLN5VbKaKtO6iBa4JG23et2ghO+UWPCYuUr3/4ZOQRQLJOnA7Tk6KAseoB2eaAW14mV1KM0dmQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR1801MB1884.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c9467c46-5438-437c-090d-08d85be407a2 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Sep 2020 15:03:41.0296 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /t2oOb35JAmway8+iK3gPKO3dve6d0hLpWB+ubon7UxAjTM5/k6mKBBpsAnojKN6zsbInx2JlSweC3XDCZNiYA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR18MB0970 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-09-18_14:2020-09-16, 2020-09-18 signatures=0 Subject: Re: [dpdk-dev] [PATCH 1/3] test/event_crypto_adapter: return error with unsupported mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Abhinandan, Please see my comments inline. Thanks Ankur >-----Original Message----- >From: Gujjar, Abhinandan S >Sent: Friday, September 18, 2020 8:13 PM >To: Ankur Dwivedi ; dev@dpdk.org >Cc: Jerin Jacob Kollanukkaran ; Anoob Joseph > >Subject: [EXT] RE: [PATCH 1/3] test/event_crypto_adapter: return error wit= h >unsupported mode > >External Email > >---------------------------------------------------------------------- >Hi Ankur, > >Please see comments inline. > >Regards >Abhinandan > >> -----Original Message----- >> From: Ankur Dwivedi >> Sent: Friday, September 18, 2020 8:05 PM >> To: Gujjar, Abhinandan S ; dev@dpdk.org >> Cc: Jerin Jacob Kollanukkaran ; Anoob Joseph >> >> Subject: RE: [PATCH 1/3] test/event_crypto_adapter: return error with >> unsupported mode >> >> Hi Abhinandan, >> >> Please see my comments inline. >> >> Thanks >> Ankur >> >> >-----Original Message----- >> >From: Gujjar, Abhinandan S >> >Sent: Friday, September 18, 2020 12:41 PM >> >To: Ankur Dwivedi ; dev@dpdk.org >> >Cc: Jerin Jacob Kollanukkaran ; Anoob Joseph >> > >> >Subject: [EXT] RE: [PATCH 1/3] test/event_crypto_adapter: return >> >error with unsupported mode >> > >> >External Email >> > >> >--------------------------------------------------------------------- >> >- >> >Hi Ankur, >> > >> >This patch requires minor change. Please find the comment inline. >> > >> >> -----Original Message----- >> >> From: Gujjar, Abhinandan S >> >> Sent: Friday, September 11, 2020 1:07 PM >> >> To: Ankur Dwivedi ; dev@dpdk.org >> >> Cc: jerinj@marvell.com; anoobj@marvell.com >> >> Subject: RE: [PATCH 1/3] test/event_crypto_adapter: return error >> >> with unsupported mode >> >> >> >> Acked-by: abhinandan.gujjar@intel.com (For series) >> >> >> >> > -----Original Message----- >> >> > From: Ankur Dwivedi >> >> > Sent: Tuesday, September 8, 2020 2:46 PM >> >> > To: dev@dpdk.org >> >> > Cc: Gujjar, Abhinandan S ; >> >> > jerinj@marvell.com; anoobj@marvell.com; Ankur Dwivedi >> >> > >> >> > Subject: [PATCH 1/3] test/event_crypto_adapter: return error with >> >> > unsupported mode >> >> > >> >> > The capability of a event device should be checked before >> >> > creating a event crypto adapter in a particular mode. The test >> >> > case returns error if the mode is not supported. >> >> > >> >> > Signed-off-by: Ankur Dwivedi >> >> > --- >> >> > app/test/test_event_crypto_adapter.c | 30 >> >> > ++++++++++++++++++---------- >> >> > 1 file changed, 20 insertions(+), 10 deletions(-) >> >> > >> >> > diff --git a/app/test/test_event_crypto_adapter.c >> >> > b/app/test/test_event_crypto_adapter.c >> >> > index 8d42462d8..930c2a9bc 100644 >> >> > --- a/app/test/test_event_crypto_adapter.c >> >> > +++ b/app/test/test_event_crypto_adapter.c >> >> > @@ -750,15 +750,23 @@ configure_event_crypto_adapter(enum >> >> > rte_event_crypto_adapter_mode mode) >> >> > uint32_t cap; >> >> > int ret; >> >> > >> >> > + ret =3D rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID, >> >> > &cap); >> >> > + TEST_ASSERT_SUCCESS(ret, "Failed to get adapter >> >> > +capabilities\n"); >> >> > + >> >> > + if ((mode =3D=3D RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD) && >> >> > + !(cap & >> >> > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD)) >> >> > + return -ENOTSUP; >> >> > + >> >> > + if ((mode =3D=3D RTE_EVENT_CRYPTO_ADAPTER_OP_NEW) && >> >> > + !(cap & >> >> > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW)) >> >> > + return -ENOTSUP; >> >> > + >> >SW adapter does not have *_INTERNAL_PORT_* caps. Just noticed test >> >was failing here. >> >Could you please bypass this check for "event_sw" and repost the patch? >> [Ankur] I was thinking of handling this by reading >> rte_eventdevs[evdev].data->name. >> If the name matches event_sw0(which is the default device name), I >> will bypass if checks. >> Can the event_sw device name be anything else? >> Or, if there is a better way of handling this please let me know. >Yes. You can also use rte_event_dev_info_get(evdev, &info) and check >info.driver_name for "event_sw". [Ankur] Thanks for the suggestion. I will try this and make the required ch= anges in v2. > >> > >> >> > /* Create adapter with default port creation callback */ >> >> > ret =3D rte_event_crypto_adapter_create(TEST_ADAPTER_ID, >> >> > - TEST_CDEV_ID, >> >> > + evdev, >> >> > &conf, mode); >> >> > TEST_ASSERT_SUCCESS(ret, "Failed to create event crypto >> >> adapter\n"); >> >> > >> >> > - ret =3D rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, >> >> > evdev, &cap); >> >> > - TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n"); >> >> > - >> >> > if (cap & >> >> > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_QP_EV_BIND) { >> >> > ret =3D >> >> > rte_event_crypto_adapter_queue_pair_add(TEST_ADAPTER_ID, >> >> > TEST_CDEV_ID, TEST_CDEV_QP_ID, >> &response_info); @@ -813,6 >> >> > +821,8 @@ test_crypto_adapter_conf(enum >> >> > rte_event_crypto_adapter_mode mode) >> >> > TEST_ASSERT(ret >=3D 0, "Failed to link queue %d " >> >> > "port=3D%u\n", qid, >> >> > params.crypto_event_port_id); >> >> > + } else { >> >> > + return ret; >> >> > } >> >> > crypto_adapter_setup_done =3D 1; >> >> > } >> >> > @@ -845,24 +855,24 @@ static int >> >> > test_crypto_adapter_conf_op_forward_mode(void) >> >> > { >> >> > enum rte_event_crypto_adapter_mode mode; >> >> > + int ret; >> >> > >> >> > mode =3D RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD; >> >> > - TEST_ASSERT_SUCCESS(test_crypto_adapter_conf(mode), >> >> > - "Failed to config crypto adapter"); >> >> > + ret =3D test_crypto_adapter_conf(mode); >> >> > >> >> > - return TEST_SUCCESS; >> >> > + return ret; >> >> > } >> >> > >> >> > static int >> >> > test_crypto_adapter_conf_op_new_mode(void) >> >> > { >> >> > enum rte_event_crypto_adapter_mode mode; >> >> > + int ret; >> >> > >> >> > mode =3D RTE_EVENT_CRYPTO_ADAPTER_OP_NEW; >> >> > - TEST_ASSERT_SUCCESS(test_crypto_adapter_conf(mode), >> >> > - "Failed to config crypto adapter"); >> >> > + ret =3D test_crypto_adapter_conf(mode); >> >> > >> >> > - return TEST_SUCCESS; >> >> > + return ret; >> >> > } >> >> > >> >> > >> >> > -- >> >> > 2.28.0